theme-check 1.2.0 → 1.5.1

data/lib/theme_check/printer.rb

@@ -2,14 +2,18 @@
 
 module ThemeCheck
   class Printer
+    def initialize(out_stream = STDOUT)
+      @out = out_stream
+    end
+
     def print(theme, offenses, auto_correct)
       offenses.each do |offense|
         print_offense(offense, auto_correct)
-        puts
+        @out.puts
       end
 
       correctable = offenses.select(&:correctable?)
-      puts "#{theme.all.size} files inspected, #{red(offenses.size.to_s + ' offenses')} detected, \
+      @out.puts "#{theme.all.size} files inspected, #{red(offenses.size.to_s + ' offenses')} detected, \
 #{yellow(correctable.size.to_s + ' offenses')} #{auto_correct ? 'corrected' : 'auto-correctable'}"
     end
 
@@ -26,15 +30,15 @@ module ThemeCheck
         ""
       end
 
-      puts location +
+      @out.puts location +
         colorized_severity(offense.severity) + ": " +
         yellow(offense.check_name) + ": " +
         corrected +
         offense.message + "."
       if offense.source_excerpt
-        puts "\t#{offense.source_excerpt}"
+        @out.puts "\t#{offense.source_excerpt}"
         if offense.markup_start_in_excerpt
-          puts "\t" + (" " * offense.markup_start_in_excerpt) + ("^" * offense.markup.size)
+          @out.puts "\t" + (" " * offense.markup_start_in_excerpt) + ("^" * offense.markup.size)
         end
       end
     end

data/lib/theme_check/regex_helpers.rb

@@ -2,8 +2,11 @@
 
 module ThemeCheck
   module RegexHelpers
-    VARIABLE = /#{Liquid::VariableStart}.*?#{Liquid::VariableEnd}/om
+    LIQUID_TAG = /#{Liquid::TagStart}.*?#{Liquid::TagEnd}/om
+    LIQUID_VARIABLE = /#{Liquid::VariableStart}.*?#{Liquid::VariableEnd}/om
+    LIQUID_TAG_OR_VARIABLE = /#{LIQUID_TAG}|#{LIQUID_VARIABLE}/om
     START_OR_END_QUOTE = /(^['"])|(['"]$)/
+
     def matches(s, re)
       start_at = 0
       matches = []
@@ -16,7 +19,7 @@ module ThemeCheck
 
     def href_to_file_size(href)
       # asset_url (+ optional stylesheet_tag) variables
-      if href =~ /^#{VARIABLE}$/o && href =~ /asset_url/ && href =~ Liquid::QuotedString
+      if href =~ /^#{LIQUID_VARIABLE}$/o && href =~ /asset_url/ && href =~ Liquid::QuotedString
         asset_id = Regexp.last_match(0).gsub(START_OR_END_QUOTE, "")
         asset = @theme.assets.find { |a| a.name.end_with?("/" + asset_id) }
         return if asset.nil?

data/lib/theme_check/theme.rb

@@ -7,6 +7,9 @@ module ThemeCheck
     LIQUID_REGEX = /\.liquid$/i
     JSON_REGEX = /\.json$/i
 
+    attr_reader :storage
+    attr_writer :default_locale_json
+
     def initialize(storage)
       @storage = storage
     end

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "1.2.0"
+  VERSION = "1.5.1"
 end

data/lib/theme_check.rb

@@ -27,6 +27,7 @@ require_relative "theme_check/config"
 require_relative "theme_check/node"
 require_relative "theme_check/offense"
 require_relative "theme_check/printer"
+require_relative "theme_check/json_printer"
 require_relative "theme_check/shopify_liquid"
 require_relative "theme_check/storage"
 require_relative "theme_check/string_helpers"

data/theme-check.gemspec

@@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency('liquid', '>= 5.0.1')
-  spec.add_dependency('nokogumbo')
+  spec.add_dependency('nokogiri', '>= 1.12')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-15 00:00:00.000000000 Z
+date: 2021-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -25,27 +25,25 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 5.0.1
 - !ruby/object:Gem::Dependency
-  name: nokogumbo
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.12'
 description: 
 email:
 - marcandre.cournoyer@shopify.com
 executables:
 - theme-check
 - theme-check-language-server
-- theme-check-language-server.bat
-- theme-check.bat
 extensions: []
 extra_rdoc_files: []
 files:
@@ -62,7 +60,8 @@ files:
 - README.md
 - RELEASING.md
 - Rakefile
-- bin/liquid-server
+- bin/theme-check
+- bin/theme-check-language-server
 - config/default.yml
 - config/nothing.yml
 - config/theme_app_extension.yml
@@ -78,6 +77,7 @@ files:
 - docs/api/json_check.md
 - docs/api/liquid_check.md
 - docs/checks/TEMPLATE.md.erb
+- docs/checks/app_block_valid_tags.md
 - docs/checks/asset_size_app_block_css.md
 - docs/checks/asset_size_app_block_javascript.md
 - docs/checks/asset_size_css.md
@@ -90,6 +90,7 @@ files:
 - docs/checks/deprecate_bgsizes.md
 - docs/checks/deprecate_lazysizes.md
 - docs/checks/deprecated_filter.md
+- docs/checks/deprecated_global_app_block_type.md
 - docs/checks/html_parsing_error.md
 - docs/checks/img_lazy_loading.md
 - docs/checks/img_width_and_height.md
@@ -100,6 +101,7 @@ files:
 - docs/checks/missing_required_template_files.md
 - docs/checks/missing_template.md
 - docs/checks/nested_snippet.md
+- docs/checks/pagination_size.md
 - docs/checks/parser_blocking_javascript.md
 - docs/checks/parser_blocking_script_tag.md
 - docs/checks/remote_asset.md
@@ -116,11 +118,10 @@ files:
 - docs/checks/valid_html_translation.md
 - docs/checks/valid_json.md
 - docs/checks/valid_schema.md
+- docs/flamegraph.svg
 - docs/preview.png
 - exe/theme-check
 - exe/theme-check-language-server
-- exe/theme-check-language-server.bat
-- exe/theme-check.bat
 - lib/theme_check.rb
 - lib/theme_check/analyzer.rb
 - lib/theme_check/asset_file.rb
@@ -128,6 +129,7 @@ files:
 - lib/theme_check/check.rb
 - lib/theme_check/checks.rb
 - lib/theme_check/checks/TEMPLATE.rb.erb
+- lib/theme_check/checks/app_block_valid_tags.rb
 - lib/theme_check/checks/asset_size_app_block_css.rb
 - lib/theme_check/checks/asset_size_app_block_javascript.rb
 - lib/theme_check/checks/asset_size_css.rb
@@ -140,6 +142,7 @@ files:
 - lib/theme_check/checks/deprecate_bgsizes.rb
 - lib/theme_check/checks/deprecate_lazysizes.rb
 - lib/theme_check/checks/deprecated_filter.rb
+- lib/theme_check/checks/deprecated_global_app_block_type.rb
 - lib/theme_check/checks/html_parsing_error.rb
 - lib/theme_check/checks/img_lazy_loading.rb
 - lib/theme_check/checks/img_width_and_height.rb
@@ -150,6 +153,7 @@ files:
 - lib/theme_check/checks/missing_required_template_files.rb
 - lib/theme_check/checks/missing_template.rb
 - lib/theme_check/checks/nested_snippet.rb
+- lib/theme_check/checks/pagination_size.rb
 - lib/theme_check/checks/parser_blocking_javascript.rb
 - lib/theme_check/checks/parser_blocking_script_tag.rb
 - lib/theme_check/checks/remote_asset.rb
@@ -181,6 +185,7 @@ files:
 - lib/theme_check/json_check.rb
 - lib/theme_check/json_file.rb
 - lib/theme_check/json_helpers.rb
+- lib/theme_check/json_printer.rb
 - lib/theme_check/language_server.rb
 - lib/theme_check/language_server/completion_engine.rb
 - lib/theme_check/language_server/completion_helper.rb
@@ -192,10 +197,16 @@ files:
 - lib/theme_check/language_server/constants.rb
 - lib/theme_check/language_server/diagnostics_tracker.rb
 - lib/theme_check/language_server/document_link_engine.rb
+- lib/theme_check/language_server/document_link_provider.rb
+- lib/theme_check/language_server/document_link_providers/asset_document_link_provider.rb
+- lib/theme_check/language_server/document_link_providers/include_document_link_provider.rb
+- lib/theme_check/language_server/document_link_providers/render_document_link_provider.rb
+- lib/theme_check/language_server/document_link_providers/section_document_link_provider.rb
 - lib/theme_check/language_server/handler.rb
 - lib/theme_check/language_server/protocol.rb
 - lib/theme_check/language_server/server.rb
 - lib/theme_check/language_server/tokens.rb
+- lib/theme_check/language_server/uri_helper.rb
 - lib/theme_check/language_server/variable_lookup_finder.rb
 - lib/theme_check/liquid_check.rb
 - lib/theme_check/locale_diff.rb

data/bin/liquid-server

@@ -1,4 +0,0 @@
-#!/usr/bin/env bash
-dev="/opt/dev/bin/dev"
-cd "$($dev project-path theme-check)"
-"$dev" language-server

data/exe/theme-check-language-server.bat

@@ -1,3 +0,0 @@
-@ECHO OFF
-
-ruby "%~dp0\theme-check-language-server" %*

data/exe/theme-check.bat

@@ -1,3 +0,0 @@
-@ECHO OFF
-
-ruby "%~dp0\theme-check" %*