theme-check 1.10.0 → 1.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 542ffd23d66103c0ad13f740b9838c28ed1ef010faed69a9066a6301ed0e9692
-  data.tar.gz: fdaa5345072521c1467ca5dc8c17d3460e5e299fbceed14b242bb27dc2001ca3
+  metadata.gz: c2774c1d3e2e9b8fa7dab0fdd4174dbfd3e625c608af349c30f526f00a6b9123
+  data.tar.gz: 69bdb078be8aa938b2dec75a62206840586ae1a015620ec3c9ce727e49fc2e07
 SHA512:
-  metadata.gz: 4c0897c7d37ada167a220691d892879884fa3ef82539fd9b649e4b8f9ab10d813907bb77420a471ff3545c192a7794378fcf19acdb16a9a866715c49d2a5f03a
-  data.tar.gz: 5543d2dafa855b025a28a3dc83742896d90ad8eba4c3bcb4b2bbea41fbd9c89b1f3a2695354bc35c62af4e8ca460d68ac6d5b3f4fa47032b218fe31eb8b70015
+  metadata.gz: aa83efd1994e95fd12defc06b13567fac6e80fd830fb870f7a50b650424b8ed339848271ac35c608b6bc40a3e884665a3136c1f75e150be937be8b78e74df9fc
+  data.tar.gz: 848e2752ecc6e6bb4b0954663dac298f869a191d0b4b146fd488b8a9a442a5573a1c716c84658b2654431f96db1572309c70991a2e29e37c1bf82bd337c79edd

data/CHANGELOG.md

@@ -1,4 +1,26 @@
 
+v1.10.3 / 2022-06-16
+==================
+
+  * Support app drop in theme app extensions ([#566](https://github.com/shopify/theme-check/issues/566))
+  * Fix requiring custom check when root is specified ([#565](https://github.com/shopify/theme-check/issues/565))
+  * Fix TranslationKeyExists.on_end issue ([#587](https://github.com/shopify/theme-check/issues/587))
+  * Fix bad link on check documentation ([#575](https://github.com/shopify/theme-check/issues/575))
+  * Update TEMPLATE.md.erb to use shopify.dev URL
+  * Fixed broken URL ([#574](https://github.com/shopify/theme-check/issues/574))
+  * Fix unknown configuration issue for UndefinedObject checker ([#568](https://github.com/shopify/theme-check/issues/568))
+
+v1.10.2 / 2022-03-07
+====================
+
+  * Handle nil paths in json_printer's sort_by ([#561](https://github.com/shopify/theme-check/issues/561))
+  * Prevent bad render tags from passing theme-check ([#559](https://github.com/shopify/theme-check/issues/559))
+
+v1.10.1 / 2022-02-24
+====================
+
+  * Revert "Prevent bad render tags from passing theme-check ([#551](https://github.com/shopify/theme-check/issues/551))"
+
 v1.10.0 / 2022-02-24
 ====================
 

data/RELEASING.md

@@ -73,11 +73,11 @@
 
 1. Release `theme-check` on RubyGems by following the steps in the previous section.
 
-2. Update the `theme-check` version in [`shopify-cli`](https://github.com/shopify/shopify-cli)'s `Gemfile.lock` and `shopify-cli.gemspec` files.
+2. Update the `theme-check` version in [`shopify-cli`](https://github.com/shopify/shopify-cli)'s `shopify-cli.gemspec` file.
 
-   Such as in [this PR.](https://github.com/Shopify/shopify-cli/pull/1357/files)
+3. Run `bundle update theme-check` and get an updated `Gemfile.lock`
 
-3. Create a branch + a commit on the [`shopify-cli`](https://github.com/Shopify/shopify-cli) repository.
+4. Create a branch + a commit on the [`shopify-cli`](https://github.com/Shopify/shopify-cli) repository.
 
    ```bash
    VERSION=X.X.X
@@ -87,7 +87,7 @@
    git commit -m "Bump theme-check version to $VERSION"
    ```
 
-4. Create a pull-request for those changes on the [`shopify-cli`](https://github.com/Shopify/shopify-cli) repository.
+5. Create a pull-request for those changes on the [`shopify-cli`](https://github.com/Shopify/shopify-cli) repository.
 
    ```bash
    # shortcut if you have `hub` installed

data/config/default.yml

@@ -101,6 +101,7 @@ UndefinedObject:
   enabled: true
   ignore: []
   exclude_snippets: true
+  config_type: :default
 
 RequiredDirectories:
   enabled: true

data/config/theme_app_extension.yml

@@ -89,6 +89,7 @@ UndefinedObject:
   enabled: true
   ignore: []
   exclude_snippets: true
+  config_type: :theme_app_extension
 
 RequiredDirectories:
   enabled: false

data/data/shopify_liquid/theme_app_extension_objects.yml

@@ -0,0 +1,2 @@
+---
+- app

data/docs/api/check.md

@@ -12,4 +12,4 @@ There are three types of checks currently supported:
 
 - [`LiquidCheck`](/docs/api/liquid_check.md)
 - [`HtmlCheck`](/docs/api/html_check.md)
-- [`JsonCheck`](/docs/api/html_check.md)
+- [`JsonCheck`](/docs/api/json_check.md)

data/docs/checks/TEMPLATE.md.erb

@@ -34,7 +34,7 @@ The following example contains the default configuration for this check:
 | Parameter | Description |
 | --- | --- |
 | enabled | Whether the check is enabled. |
-| severity | The [severity](https://shopify.developers/themes/tools/theme-check/configuration#check-severity) of the check. |
+| severity | The [severity](https://shopify.dev/themes/tools/theme-check/configuration#check-severity) of the check. |
 | other_option | A description of the option. |
 
 ## Disabling this check

data/docs/checks/schema_json_format.md

@@ -59,7 +59,7 @@ SchemaJsonFormat:
 | Parameter | Description |
 | --- | --- |
 | enabled | Whether the check is enabled. |
-| severity | The [severity](https://shopify.developers/themes/tools/theme-check/configuration#check-severity) of the check. |
+| severity | The [severity](https://shopify.dev/themes/tools/theme-check/configuration#check-severity) of the check. |
 | start_level | The indentation level. If you prefer an indented schema, set this to 1. |
 | indent | The character(s) used for indentation levels. |
 

data/lib/theme_check/checks/translation_key_exists.rb

@@ -48,6 +48,7 @@ module ThemeCheck
 
     def key_exists?(key, pointer)
       key.split(".").each do |token|
+        return false unless pointer.is_a?(Hash)
         return false unless pointer.key?(token)
         pointer = pointer[token]
       end

data/lib/theme_check/checks/undefined_object.rb

@@ -55,7 +55,8 @@ module ThemeCheck
       end
     end
 
-    def initialize(exclude_snippets: true)
+    def initialize(config_type: :default, exclude_snippets: true)
+      @config_type = config_type
       @exclude_snippets = exclude_snippets
       @files = {}
     end
@@ -111,6 +112,9 @@ module ThemeCheck
       shopify_plus_objects = ThemeCheck::ShopifyLiquid::Object.plus_labels
       shopify_plus_objects.freeze
 
+      theme_app_extension_objects = ThemeCheck::ShopifyLiquid::Object.theme_app_extension_labels
+      theme_app_extension_objects.freeze
+
       each_template do |(name, info)|
         if 'templates/customers/reset_password' == name
           # NOTE: `email` is exceptionally exposed as a theme object in
@@ -121,6 +125,8 @@ module ThemeCheck
           #       the checkout template
           # https://shopify.dev/docs/themes/theme-templates/checkout-liquid#optional-objects
           check_object(info, all_global_objects + shopify_plus_objects)
+        elsif config_type == :theme_app_extension
+          check_object(info, all_global_objects + theme_app_extension_objects)
         else
           check_object(info, all_global_objects)
         end
@@ -129,6 +135,8 @@ module ThemeCheck
 
     private
 
+    attr_reader :config_type
+
     def ignore?(node)
       @exclude_snippets && node.theme_file.snippet?
     end

data/lib/theme_check/config.rb

@@ -209,7 +209,8 @@ module ThemeCheck
 
     def resolve_requires
       self["require"]&.each do |path|
-        require(File.join(@root, path))
+        file_to_require = @root.join(path).realpath
+        require(file_to_require.to_s)
       end
     end
   end

data/lib/theme_check/json_printer.rb

@@ -25,7 +25,7 @@ module ThemeCheck
             styleCount: path_offenses.count { |offense| offense[:severity] == Check::SEVERITY_VALUES[:style] },
           }
         end
-        .sort_by { |o| o[:path] }
+        .sort_by { |o| o[:path] || Pathname.new('') }
     end
   end
 end

data/lib/theme_check/shopify_liquid/object.rb

@@ -13,6 +13,10 @@ module ThemeCheck
       def plus_labels
         @plus_labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/plus_objects.yml"))
       end
+
+      def theme_app_extension_labels
+        @theme_app_extension_labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/theme_app_extension_objects.yml"))
+      end
     end
   end
 end

data/lib/theme_check/tags.rb

@@ -125,7 +125,23 @@ module ThemeCheck
     end
 
     class Render < Liquid::Tag
-      SYNTAX = /((?:#{Liquid::QuotedString}|\A#{Liquid::VariableSegment})+)(\s+(with|#{Liquid::Render::FOR})\s+(#{Liquid::QuotedFragment}+))?(\s+(?:as)\s+(#{Liquid::VariableSegment}+))?/o
+      SYNTAX = %r{
+        (
+          ## for {% render "snippet" %}
+          #{Liquid::QuotedString}+ |
+          ## for {% render block %}
+          ## We require the variable # segment to be at the beginning of the
+          ## string (with \A). This is to prevent code like {% render !foo! %}
+          ## from parsing
+          \A#{Liquid::VariableSegment}+
+        )
+        ## for {% render "snippet" with product as p %}
+        ## or {% render "snippet" for products p %}
+        (\s+(with|#{Liquid::Render::FOR})\s+(#{Liquid::QuotedFragment}+))?
+        (\s+(?:as)\s+(#{Liquid::VariableSegment}+))?
+        ## variables passed into the tag (e.g. {% render "snippet", var1: value1, var2: value2 %}
+        ## are not matched by this regex and are handled by Liquid::Render.initialize
+      }xo
 
       disable_tags "include"
 

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "1.10.0"
+  VERSION = "1.10.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.10.3
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-24 00:00:00.000000000 Z
+date: 2022-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -84,6 +84,7 @@ files:
 - data/shopify_liquid/objects.yml
 - data/shopify_liquid/plus_objects.yml
 - data/shopify_liquid/tags.yml
+- data/shopify_liquid/theme_app_extension_objects.yml
 - data/shopify_translation_keys.yml
 - dev.yml
 - docs/api/check.md
@@ -300,7 +301,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: A Shopify Theme Linter