theme-check 0.8.1 → 0.10.0

data/lib/theme_check/liquid_check.rb

@@ -6,6 +6,7 @@ module ThemeCheck
     extend ChecksTracking
     include ParsingHelpers
 
+    # TODO: remove this once all regex checks are migrate to HtmlCheck# TODO: remove this once all regex checks are migrate to HtmlCheck
     TAG = /#{Liquid::TagStart}.*?#{Liquid::TagEnd}/om
     VARIABLE = /#{Liquid::VariableStart}.*?#{Liquid::VariableEnd}/om
     START_OR_END_QUOTE = /(^['"])|(['"]$)/
@@ -16,9 +17,5 @@ module ThemeCheck
     ATTR = /[a-z0-9-]+/i
     HTML_ATTRIBUTE = /#{ATTR}(?:=#{QUOTED_LIQUID_ATTRIBUTE})?/omix
     HTML_ATTRIBUTES = /(?:#{HTML_ATTRIBUTE}|\s)*/omix
-
-    def add_offense(message, node: nil, template: node&.template, markup: nil, line_number: nil, &block)
-      offenses << Offense.new(check: self, message: message, template: template, node: node, markup: markup, line_number: line_number, correction: block)
-    end
   end
 end

data/lib/theme_check/offense.rb

@@ -114,6 +114,24 @@ module ThemeCheck
       end
     end
 
+    def whole_theme?
+      check.whole_theme?
+    end
+
+    def single_file?
+      check.single_file?
+    end
+
+    def ==(other)
+      other.is_a?(Offense) &&
+        check == other.check &&
+        message == other.message &&
+        template == other.template &&
+        node == other.node &&
+        markup == other.markup &&
+        line_number == other.line_number
+    end
+
     def to_s
       if template
         "#{message} at #{location}"

data/lib/theme_check/shopify_liquid/tag.rb

@@ -8,6 +8,19 @@ module ThemeCheck
 
       def labels
         @tags ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/tags.yml"))
+          .to_set
+      end
+
+      def tag_regex(tag)
+        return unless labels.include?(tag)
+        @tag_regexes ||= {}
+        @tag_regexes[tag] ||= /\A#{Liquid::TagStart}-?\s*#{tag}/m
+      end
+
+      def liquid_tag_regex(tag)
+        return unless labels.include?(tag)
+        @tag_liquid_regexes ||= {}
+        @tag_liquid_regexes[tag] ||= /^\s*#{tag}/m
       end
     end
   end

data/lib/theme_check/template.rb

@@ -32,6 +32,14 @@ module ThemeCheck
       relative_path.sub_ext('').to_s
     end
 
+    def json?
+      false
+    end
+
+    def liquid?
+      true
+    end
+
     def template?
       name.start_with?('templates')
     end

data/lib/theme_check/theme.rb

@@ -52,8 +52,13 @@ module ThemeCheck
       @all ||= json + liquid + assets
     end
 
-    def [](name)
-      all.find { |t| t.name == name }
+    def [](name_or_relative_path)
+      case name_or_relative_path
+      when Pathname
+        all.find { |t| t.relative_path == name_or_relative_path }
+      else
+        all.find { |t| t.name == name_or_relative_path }
+      end
     end
 
     def templates

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.8.1"
+  VERSION = "0.10.0"
 end

data/lib/theme_check/visitor.rb

@@ -3,14 +3,13 @@ module ThemeCheck
   class Visitor
     attr_reader :checks
 
-    def initialize(checks)
+    def initialize(checks, disabled_checks)
       @checks = checks
+      @disabled_checks = disabled_checks
     end
 
     def visit_template(template)
-      @disabled_checks = DisabledChecks.new
       visit(Node.new(template.root, nil, template))
-      remove_disabled_offenses
     rescue Liquid::Error => exception
       exception.template_name = template.name
       call_checks(:on_error, exception)
@@ -35,13 +34,5 @@ module ThemeCheck
     def call_checks(method, *args)
       checks.call(method, *args)
     end
-
-    def remove_disabled_offenses
-      checks.disableable.each do |check|
-        check.offenses.reject! do |offense|
-          @disabled_checks.disabled?(offense.code_name, offense.start_index)
-        end
-      end
-    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-04-22 00:00:00.000000000 Z
+date: 2021-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -72,9 +72,12 @@ files:
 - docs/checks/CHECK_DOCS_TEMPLATE.md
 - docs/checks/asset_size_css.md
 - docs/checks/asset_size_javascript.md
+- docs/checks/asset_url_filters.md
+- docs/checks/content_for_header_modification.md
 - docs/checks/convert_include_to_render.md
 - docs/checks/default_locale.md
 - docs/checks/deprecated_filter.md
+- docs/checks/img_lazy_loading.md
 - docs/checks/img_width_and_height.md
 - docs/checks/liquid_tag.md
 - docs/checks/matching_schema_translations.md
@@ -84,6 +87,7 @@ files:
 - docs/checks/missing_template.md
 - docs/checks/nested_snippet.md
 - docs/checks/parser_blocking_javascript.md
+- docs/checks/parser_blocking_script_tag.md
 - docs/checks/remote_asset.md
 - docs/checks/required_directories.md
 - docs/checks/required_layout_theme_object.md
@@ -104,13 +108,17 @@ files:
 - lib/theme_check.rb
 - lib/theme_check/analyzer.rb
 - lib/theme_check/asset_file.rb
+- lib/theme_check/bug.rb
 - lib/theme_check/check.rb
 - lib/theme_check/checks.rb
 - lib/theme_check/checks/asset_size_css.rb
 - lib/theme_check/checks/asset_size_javascript.rb
+- lib/theme_check/checks/asset_url_filters.rb
+- lib/theme_check/checks/content_for_header_modification.rb
 - lib/theme_check/checks/convert_include_to_render.rb
 - lib/theme_check/checks/default_locale.rb
 - lib/theme_check/checks/deprecated_filter.rb
+- lib/theme_check/checks/img_lazy_loading.rb
 - lib/theme_check/checks/img_width_and_height.rb
 - lib/theme_check/checks/liquid_tag.rb
 - lib/theme_check/checks/matching_schema_translations.rb
@@ -120,6 +128,7 @@ files:
 - lib/theme_check/checks/missing_template.rb
 - lib/theme_check/checks/nested_snippet.rb
 - lib/theme_check/checks/parser_blocking_javascript.rb
+- lib/theme_check/checks/parser_blocking_script_tag.rb
 - lib/theme_check/checks/remote_asset.rb
 - lib/theme_check/checks/required_directories.rb
 - lib/theme_check/checks/required_layout_theme_object.rb
@@ -142,6 +151,9 @@ files:
 - lib/theme_check/disabled_checks.rb
 - lib/theme_check/exceptions.rb
 - lib/theme_check/file_system_storage.rb
+- lib/theme_check/html_check.rb
+- lib/theme_check/html_node.rb
+- lib/theme_check/html_visitor.rb
 - lib/theme_check/in_memory_storage.rb
 - lib/theme_check/json_check.rb
 - lib/theme_check/json_file.rb
@@ -155,11 +167,13 @@ files:
 - lib/theme_check/language_server/completion_providers/render_snippet_completion_provider.rb
 - lib/theme_check/language_server/completion_providers/tag_completion_provider.rb
 - lib/theme_check/language_server/constants.rb
+- lib/theme_check/language_server/diagnostics_tracker.rb
 - lib/theme_check/language_server/document_link_engine.rb
 - lib/theme_check/language_server/handler.rb
 - lib/theme_check/language_server/protocol.rb
 - lib/theme_check/language_server/server.rb
 - lib/theme_check/language_server/tokens.rb
+- lib/theme_check/language_server/variable_lookup_finder.rb
 - lib/theme_check/liquid_check.rb
 - lib/theme_check/locale_diff.rb
 - lib/theme_check/node.rb
@@ -206,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.17
 signing_key: 
 specification_version: 4
 summary: A Shopify Theme Linter