theme-check 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93631c68de37297060f57799731a0ef4adae05aa9d89f8a019d28b0afe65533a
-  data.tar.gz: 86efb9c580a6206974bec0c876fc1feca80c5dad3c7d500e4528a537f01c9613
+  metadata.gz: c75935127b3ec2257d0e857c46b501a0c5189da619776202a2180234606c84ca
+  data.tar.gz: 3a54ffed715331b78f6ae3949b76466068539cd9fea4275e64f9f7a413ffd22b
 SHA512:
-  metadata.gz: 712d137ecb52bc6af0b83db9ed391252f78d5a0ad2a3b4c3d82d6b1a59e927da167b2bdea40a7f07f45d77cb16c72ca2e49243b78bb6c52296ed84a30c5cd83f
-  data.tar.gz: 3e6505817fc868979c2ead8f99133d9c24754b905b3211774c74e9a1261a9f962fd9660c94aed70838a2c0dcb086e353a7ce5a739d9ada8456f7ba0ff61ee077
+  metadata.gz: 2720180bf217fd64061f6ed4edc5ba01616fbb6ec6b30254638c992924719d179af0f2d72c4a1a1330c7b1e6a0ef9856aec4567aca73161a0cd2b59033fffcf4
+  data.tar.gz: c1d79dad05a55c374d4a2e008484d3c527f4483174e66ffb3c30ce96f65e8a2f03c6295de33130295b70bc63f3d3aed4dce2c7eac14de0347aa73fca599b062e

data/.github/workflows/theme-check.yml

@@ -8,15 +8,22 @@ on:
 
 jobs:
   test:
+    runs-on: macos-latest
 
-    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        version:
+          - 3.0.0
+          - 2.7.1
+
+    name: Ruby ${{ matrix.version }}
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby
+    - name: Set up Ruby ${{ matrix.version }}
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7
+        ruby-version: ${{ matrix.version }}
     - uses: actions/cache@v1
       with:
         path: vendor/bundle

data/CHANGELOG.md

@@ -1,4 +1,12 @@
 
+0.7.0 / 2021-04-08
+==================
+
+  * Add [RemoteAsset Check](/docs/checks/remote_asset.md)
+  * Fixes:
+    * Don't hang on self closing img tags ([#247](https://github.com/shopify/theme-check/issues/247))
+    * Fix document links from different root
+
 0.6.0 / 2021-03-23
 ==================
 

data/Gemfile

@@ -21,8 +21,8 @@ group :development do
   gem 'guard-minitest'
 end
 
-gem 'rubocop', require: false
-gem 'rubocop-performance', require: false
-gem 'rubocop-shopify', require: false
-gem 'rubocop-minitest', require: false
-gem 'rubocop-rake', require: false
+gem 'rubocop', '~> 1.12.0', require: false
+gem 'rubocop-performance', '~> 1.10.2', require: false
+gem 'rubocop-shopify', '~> 1.0.7', require: false
+gem 'rubocop-minitest', '~> 0.11.0', require: false
+gem 'rubocop-rake', '~> 0.5.1', require: false

data/LICENSE.md

@@ -1,6 +1,8 @@
 
 Copyright 2020-present, Shopify Inc.
 
+Contains code from activesupport Copyright (c) 2005-2019 David Heinemeier Hansson
+
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 
 The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

data/README.md

@@ -35,6 +35,7 @@ Theme Check currently checks for the following:
 As well as checks that prevent easy to spot performance problems:
 
 ✅ Use of [parser-blocking](/docs/checks/parser_blocking_javascript.md) JavaScript  
+✅ [Use of non-Shopify domains for assets](/docs/checks/remote_asset.md)  
 ✅ [Missing width and height attributes on `img` tags](/docs/checks/img_width_and_height.md)  
 ✅ [Too much JavaScript](/docs/checks/asset_size_javascript.md)  
 ✅ [Too much CSS](/docs/checks/asset_size_css.md)  

data/RELEASING.md

@@ -2,11 +2,18 @@
 
 1. Check the Semantic Versioning page for info on how to version the new release: http://semver.org
 
-2. Create a PR to update the version in `lib/theme_check/version.rb` and replace the `THEME_CHECK_VERSION` placeholder in the documentation for new rules.
+2. Run the following command to update the version in `lib/theme_check/version.rb` and replace the `THEME_CHECK_VERSION` placeholder in the documentation for new rules:
 
-3. Merge your PR to master
+   ```bash
+   VERSION="X.X.X"
+   rake prerelease[$VERSION]
+   ```
+
+3. Commit your changes and make a PR.
+
+4. Merge your PR to master.
 
-4. On [Shipit](https://shipit.shopify.io/shopify/theme-check/rubygems), deploy your commit.
+5. On [Shipit](https://shipit.shopify.io/shopify/theme-check/rubygems), deploy your commit.
 
 ## Homebrew Release Process
 

data/Rakefile

@@ -46,3 +46,9 @@ end
 
 desc("Builds all distribution packages of the CLI")
 task(package: 'package:all')
+
+desc("Update files in the repo to match new version")
+task :prerelease, [:version] do |_t, args|
+  require 'theme_check/releaser'
+  ThemeCheck::Releaser.new.release(args.version)
+end

data/config/default.yml

@@ -93,3 +93,6 @@ AssetSizeCSS:
 
 ImgWidthAndHeight:
   enabled: true
+
+RemoteAsset:
+  enabled: true

data/docs/checks/remote_asset.md

@@ -0,0 +1,82 @@
+# Discourage use of third party domains for hosting assets (`RemoteAsset`)
+
+Years ago, loading jQuery from a common CDN was good for performance because the browser cache could be reused across website. This is no longer true because browsers now include the domain from which the request was made in the cache key.
+
+Therefore, this technique now makes things worse. Here's why:
+
+* **The benefits of HTTP/2 prioritization are lost.** HTTP/2 prioritization is a mechanism used by servers. If different servers are used to deliver assets, there's no way to prioritize.
+* **A new connection dance (DNS, TCP, TLS) must be done to start downloading the resource.** With HTTPS, this takes 5 round trips to achieve. The farther away the buyer is from that domain, the longer it takes.
+* **The [slow start][slowstart] part of the Internet's TCP congestion control strategy must happen on every connection.** This means that the download "acceleration" we commonly observe must be repeated many times over.
+
+The fix? Deliver as much as you can from a small number of connections. In a Shopify context, this is done by leveraging the `assets/` folder and the [URL filters][url_filters].
+
+## Check Details
+
+This check is aimed at eliminating unnecessary HTTP connections.
+
+:-1: Examples of **incorrect** code for this check:
+
+```liquid
+<!-- Using multiple CDNs -->
+<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.6.0/jquery.min.js" defer></script>
+{{ "https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" | stylesheet_tag }}
+<img src="https://example.com/heart.png" ...>
+
+<!-- Missing img_url filter -->
+<img src="{{ image }}" ...>
+```
+
+In the examples above, multiple connections are competing for resources, are accelerating download independently and are improperly prioritized.
+
+:+1: Examples of **correct** code for this check:
+
+```liquid
+<!-- Good -->
+<script src="{{ 'jquery.min.js' | asset_url }}" defer></script>
+{{ 'bootstrap.min.css' | asset_url | stylesheet_tag }}
+
+<!-- Better -->
+<script src="{{ 'theme.js' | asset_url }}" defer></script>
+{{ 'theme.css' | asset_url | stylesheet_tag }}
+
+<!-- Images -->
+<img src="{{ image | img_url }}" ...>
+```
+
+In the above, the JavaScript, CSS and images are all loading from the same connection. Making it so the browser and CDN can properly prioritize which assets are downloaded first while maintaining a "hot" connection that downloads fast.
+
+This can be done by downloading the files from those CDNs directly into your theme's `assets/` folder.
+
+Use the [`img_url` filter][img_url] for images.
+
+## Check Options
+
+The default configuration for this check is the following:
+
+```yaml
+RemoteAsset:
+  enabled: true
+```
+
+## When Not To Use It
+
+When the remote content is highly dynamic.
+
+## Version
+
+This check has been introduced in Theme Check 0.7.0.
+
+## Resources
+
+- [Announcement by Google][googleprivacy]
+- [HTTP Cache Partioning Explainer](https://github.com/shivanigithub/http-cache-partitioning)
+- [Slow Start][slowstart]
+- [Rule Source][codesource]
+- [Documentation Source][docsource]
+
+[googleprivacy]: https://developers.google.com/web/updates/2020/10/http-cache-partitioning#resources
+[codesource]: /lib/theme_check/checks/remote_asset.rb
+[docsource]: /docs/checks/remote_asset.md
+[slowstart]: https://en.wikipedia.org/wiki/TCP_congestion_control#Slow_start
+[url_filters]: https://shopify.dev/docs/themes/liquid/reference/filters/url-filters
+[img_url]: https://shopify.dev/docs/themes/liquid/reference/filters/url-filters#img_url

data/lib/theme_check.rb

@@ -22,6 +22,7 @@ require_relative "theme_check/offense"
 require_relative "theme_check/printer"
 require_relative "theme_check/shopify_liquid"
 require_relative "theme_check/storage"
+require_relative "theme_check/string_helpers"
 require_relative "theme_check/file_system_storage"
 require_relative "theme_check/in_memory_storage"
 require_relative "theme_check/tags"

data/lib/theme_check/check.rb

@@ -82,7 +82,7 @@ module ThemeCheck
     end
 
     def code_name
-      self.class.name.demodulize
+      StringHelpers.demodulize(self.class.name)
     end
 
     def ignore!

data/lib/theme_check/checks/asset_size_css.rb

@@ -75,7 +75,7 @@ module ThemeCheck
       # asset_url (+ optional stylesheet_tag) variables
       if href =~ /^#{VARIABLE}$/o && href =~ /asset_url/ && href =~ Liquid::QuotedString
         asset_id = Regexp.last_match(0).gsub(START_OR_END_QUOTE, "")
-        asset = @theme.assets.find { |a| a.name.ends_with?("/" + asset_id) }
+        asset = @theme.assets.find { |a| a.name.end_with?("/" + asset_id) }
         return if asset.nil?
         asset.gzipped_size
 

data/lib/theme_check/checks/asset_size_javascript.rb

@@ -56,7 +56,7 @@ module ThemeCheck
       # More complicated liquid statements are not in scope.
       if src =~ /^#{VARIABLE}$/o && src =~ /asset_url/ && src =~ Liquid::QuotedString
         asset_id = Regexp.last_match(0).gsub(START_OR_END_QUOTE, "")
-        asset = @theme.assets.find { |a| a.name.ends_with?("/" + asset_id) }
+        asset = @theme.assets.find { |a| a.name.end_with?("/" + asset_id) }
         return if asset.nil?
         asset.gzipped_size
       elsif src =~ %r{^(https?:)?//}

data/lib/theme_check/checks/img_width_and_height.rb

@@ -8,7 +8,7 @@ module ThemeCheck
     doc docs_url(__FILE__)
 
     # Not implemented with lookbehinds and lookaheads because performance was shit!
-    IMG_TAG = /<img#{HTML_ATTRIBUTES}>/oxim
+    IMG_TAG = %r{<img#{HTML_ATTRIBUTES}/?>}oxim
     SRC_ATTRIBUTE = /\s(src)=(#{QUOTED_LIQUID_ATTRIBUTE})/oxim
     WIDTH_ATTRIBUTE = /\s(width)=(#{QUOTED_LIQUID_ATTRIBUTE})/oxim
     HEIGHT_ATTRIBUTE = /\s(height)=(#{QUOTED_LIQUID_ATTRIBUTE})/oxim
@@ -35,7 +35,7 @@ module ThemeCheck
     def record_missing_field_offenses(img_match)
       width = WIDTH_ATTRIBUTE.match(img_match[0])
       height = HEIGHT_ATTRIBUTE.match(img_match[0])
-      return if width.present? && height.present?
+      return if width && height
       missing_width = width.nil?
       missing_height = height.nil?
       error_message = if missing_width && missing_height

data/lib/theme_check/checks/matching_translations.rb

@@ -11,7 +11,7 @@ module ThemeCheck
     end
 
     def on_file(file)
-      return unless file.name.starts_with?("locales/")
+      return unless file.name.start_with?("locales/")
       return unless file.content.is_a?(Hash)
       return if file.name == @theme.default_locale_json&.name
 

data/lib/theme_check/checks/parser_blocking_javascript.rb

@@ -11,7 +11,7 @@ module ThemeCheck
       <script                                    # Find the start of a script tag
       (?=[^>]+?src=)                             # Make sure src= is in the script with a lookahead
       (?:(?!defer|async|type=["']module['"]).)*? # Find tags that don't have defer|async|type="module"
-      >
+      /?>
     }xim
     SCRIPT_TAG_FILTER = /\{\{[^}]+script_tag\s+\}\}/
 

data/lib/theme_check/checks/remote_asset.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+module ThemeCheck
+  class RemoteAsset < LiquidCheck
+    include RegexHelpers
+    severity :suggestion
+    categories :liquid, :performance
+    doc docs_url(__FILE__)
+
+    OFFENSE_MESSAGE = "Asset should be served by the Shopify CDN for better performance."
+
+    HTML_FILTERS = [
+      'stylesheet_tag',
+      'script_tag',
+      'img_tag',
+    ]
+    ASSET_URL_FILTERS = [
+      'asset_url',
+      'asset_img_url',
+      'file_img_url',
+      'file_url',
+      'global_asset_url',
+      'img_url',
+      'payment_type_img_url',
+      'shopify_asset_url',
+    ]
+
+    RESOURCE_TAG = /<(?<tag_name>img|script|link|source)#{HTML_ATTRIBUTES}>/oim
+    RESOURCE_URL = /\s(?:src|href)=(?<resource_url>#{QUOTED_LIQUID_ATTRIBUTE})/oim
+    ASSET_URL_FILTER = /[\|\s]*(#{ASSET_URL_FILTERS.join('|')})/omi
+    PROTOCOL = %r{(https?:)?//}
+    ABSOLUTE_PATH = %r{\A/[^/]}im
+    RELATIVE_PATH = %r{\A(?!#{PROTOCOL})[^/\{]}oim
+    REL = /\srel=(?<rel>#{QUOTED_LIQUID_ATTRIBUTE})/oim
+
+    def on_variable(node)
+      record_variable_offense(node)
+    end
+
+    def on_document(node)
+      source = node.template.source
+      record_html_offenses(node, source)
+    end
+
+    private
+
+    def record_variable_offense(variable_node)
+      # We flag HTML tags with URLs not hosted by Shopify
+      return if !html_resource_drop?(variable_node) || variable_hosted_by_shopify?(variable_node)
+      add_offense(OFFENSE_MESSAGE, node: variable_node)
+    end
+
+    def html_resource_drop?(variable_node)
+      variable_node.value.filters
+        .any? { |(filter_name, *_filter_args)| HTML_FILTERS.include?(filter_name) }
+    end
+
+    def variable_hosted_by_shopify?(variable_node)
+      variable_node.value.filters
+        .any? { |(filter_name, *_filter_args)| ASSET_URL_FILTERS.include?(filter_name) }
+    end
+
+    # This part is slightly more complicated because we don't have an
+    # HTML AST. We have to resort to looking at the HTML with regexes
+    # to figure out if we have a resource (stylesheet, script, or media)
+    # that points to a remote domain.
+    def record_html_offenses(node, source)
+      matches(source, RESOURCE_TAG).each do |match|
+        tag = match[0]
+
+        # We don't flag stuff without URLs
+        next unless tag =~ RESOURCE_URL
+        resource_match = Regexp.last_match
+        resource_url = resource_match[:resource_url].gsub(START_OR_END_QUOTE, '')
+
+        next if non_stylesheet_link?(tag)
+        next if url_hosted_by_shopify?(resource_url)
+        next if resource_url =~ ABSOLUTE_PATH
+        next if resource_url =~ RELATIVE_PATH
+
+        start = match.begin(0) + resource_match.begin(:resource_url)
+        add_offense(
+          OFFENSE_MESSAGE,
+          node: node,
+          markup: resource_url,
+          line_number: source[0...start].count("\n") + 1,
+        )
+      end
+    end
+
+    def non_stylesheet_link?(tag)
+      tag =~ REL && !(Regexp.last_match[:rel] =~ /\A['"]stylesheet['"]\Z/)
+    end
+
+    def url_hosted_by_shopify?(url)
+      url =~ /\A#{VARIABLE}\Z/oim && url =~ ASSET_URL_FILTER
+    end
+  end
+end

data/lib/theme_check/checks/translation_key_exists.rb

@@ -4,10 +4,7 @@ module ThemeCheck
     extend self
 
     def translations
-      @translations ||= begin
-        # loaded as a Set because the include? lookup will be much faster.
-        YAML.load(File.read("#{__dir__}/../../../data/shopify_translation_keys.yml")).to_set
-      end
+      @translations ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_translation_keys.yml")).to_set
     end
 
     def include?(key)

data/lib/theme_check/checks/undefined_object.rb

@@ -135,7 +135,7 @@ module ThemeCheck
 
     def each_template
       @files.each do |(name, info)|
-        next if name.starts_with?('snippets/')
+        next if name.start_with?('snippets/')
         yield [name, info]
       end
     end

data/lib/theme_check/checks/valid_html_translation.rb

@@ -8,7 +8,7 @@ module ThemeCheck
     doc docs_url(__FILE__)
 
     def on_file(file)
-      return unless file.name.starts_with?("locales/")
+      return unless file.name.start_with?("locales/")
       return unless file.content.is_a?(Hash)
 
       visit_nested(file.content)

data/lib/theme_check/cli.rb

@@ -6,14 +6,17 @@ module ThemeCheck
     USAGE = <<~END
       Usage: theme-check [options] /path/to/your/theme
 
-      Options:
-        --init                               Generate a .theme-check.yml file in the current directory
+      Basic Options:
         -C, --config <path>                  Use the config provided, overriding .theme-check.yml if present
         -c, --category <category>            Only run this category of checks
         -x, --exclude-category  <category>   Exclude this category of checks
-        -l, --list                           List enabled checks
         -a, --auto-correct                   Automatically fix offenses
+
+      Miscellaneous:
+        --init                               Generate a .theme-check.yml file
+        --print-config                       Output active config to STDOUT
         -h, --help                           Show this. Hi!
+        -l, --list                           List enabled checks
         -v, --version                        Print Theme Check version
 
       Description:
@@ -51,13 +54,15 @@ module ThemeCheck
           auto_correct = true
         when "--init"
           command = :init
+        when "--print"
+          command = :print
         else
           @path = arg
         end
       end
 
       unless [:version, :init].include?(command)
-        @config = if config_path.present?
+        @config = if config_path
           ThemeCheck::Config.new(
             root: @path,
             configuration: ThemeCheck::Config.load_file(config_path)
@@ -102,6 +107,10 @@ module ThemeCheck
       end
     end
 
+    def print
+      puts YAML.dump(@config.to_h)
+    end
+
     def check
       puts "Checking #{@config.root} ..."
       storage = ThemeCheck::FileSystemStorage.new(@config.root, ignored_patterns: @config.ignored_patterns)

data/lib/theme_check/disabled_checks.rb

@@ -61,11 +61,11 @@ module ThemeCheck
     end
 
     def start_disabling?(text)
-      text.strip.starts_with?(DISABLE_START)
+      text.strip.start_with?(DISABLE_START)
     end
 
     def stop_disabling?(text)
-      text.strip.starts_with?(DISABLE_END)
+      text.strip.start_with?(DISABLE_END)
     end
 
     # Return a list of checks from a theme-check-disable comment

data/lib/theme_check/in_memory_storage.rb

@@ -6,32 +6,25 @@
 # as a big hash already, leave it like that and save yourself some IO.
 module ThemeCheck
   class InMemoryStorage < Storage
-    def initialize(files = {}, root = nil)
+    def initialize(files = {}, root = "/dev/null")
       @files = files
-      @root = root
+      @root = Pathname.new(root)
     end
 
-    def path(name)
-      return File.join(@root, name) unless @root.nil?
-      name
+    def path(relative_path)
+      @root.join(relative_path)
     end
 
-    def relative_path(name)
-      path = Pathname.new(name)
-      return path.relative_path_from(@root).to_s unless path.relative? || @root.nil?
-      name
+    def read(relative_path)
+      @files[relative_path]
     end
 
-    def read(name)
-      @files[relative_path(name)]
-    end
-
-    def write(name, content)
-      @files[relative_path(name)] = content
+    def write(relative_path, content)
+      @files[relative_path] = content
     end
 
     def files
-      @values ||= @files.keys
+      @files.keys
     end
 
     def directories
@@ -41,5 +34,9 @@ module ThemeCheck
         .map(&:to_s)
         .uniq
     end
+
+    def relative_path(absolute_path)
+      Pathname.new(absolute_path).relative_path_from(@root).to_s
+    end
   end
 end

data/lib/theme_check/language_server/completion_engine.rb

@@ -10,8 +10,8 @@ module ThemeCheck
         @providers = CompletionProvider.all.map { |x| x.new(storage) }
       end
 
-      def completions(name, line, col)
-        buffer = @storage.read(name)
+      def completions(relative_path, line, col)
+        buffer = @storage.read(relative_path)
         cursor = from_line_column_to_index(buffer, line, col)
         token = find_token(buffer, cursor)
         return [] if token.nil?

data/lib/theme_check/language_server/completion_providers/filter_completion_provider.rb

@@ -8,7 +8,7 @@ module ThemeCheck
       def completions(content, cursor)
         return [] unless can_complete?(content, cursor)
         available_labels
-          .select { |w| w.starts_with?(partial(content, cursor)) }
+          .select { |w| w.start_with?(partial(content, cursor)) }
           .map { |filter| filter_to_completion(filter) }
       end
 

data/lib/theme_check/language_server/completion_providers/object_completion_provider.rb

@@ -7,7 +7,7 @@ module ThemeCheck
         return [] unless can_complete?(content, cursor)
         partial = first_word(content) || ''
         ShopifyLiquid::Object.labels
-          .select { |w| w.starts_with?(partial) }
+          .select { |w| w.start_with?(partial) }
           .map { |object| object_to_completion(object) }
       end
 

data/lib/theme_check/language_server/completion_providers/render_snippet_completion_provider.rb

@@ -7,7 +7,7 @@ module ThemeCheck
         return [] unless cursor_on_quoted_argument?(content, cursor)
         partial = snippet(content) || ''
         snippets
-          .select { |x| x.starts_with?(partial) }
+          .select { |x| x.start_with?(partial) }
           .map { |x| snippet_to_completion(x) }
       end
 

data/lib/theme_check/language_server/completion_providers/tag_completion_provider.rb

@@ -7,12 +7,12 @@ module ThemeCheck
         return [] unless can_complete?(content, cursor)
         partial = first_word(content) || ''
         ShopifyLiquid::Tag.labels
-          .select { |w| w.starts_with?(partial) }
+          .select { |w| w.start_with?(partial) }
           .map { |tag| tag_to_completion(tag) }
       end
 
       def can_complete?(content, cursor)
-        content.starts_with?(Liquid::TagStart) && (
+        content.start_with?(Liquid::TagStart) && (
           cursor_on_first_word?(content, cursor) ||
           cursor_on_start_content?(content, cursor, Liquid::TagStart)
         )

data/lib/theme_check/language_server/document_link_engine.rb

@@ -10,8 +10,9 @@ module ThemeCheck
         @storage = storage
       end
 
-      def document_links(uri)
-        buffer = @storage.read(uri)
+      def document_links(relative_path)
+        buffer = @storage.read(relative_path)
+        return [] unless buffer
         matches(buffer, PARTIAL_RENDER).map do |match|
           start_line, start_character = from_index_to_line_column(
             buffer,
@@ -40,7 +41,7 @@ module ThemeCheck
       end
 
       def link(partial)
-        'file://' + @storage.path('snippets/' + partial + '.liquid')
+        "file://#{@storage.path('snippets/' + partial + '.liquid')}"
       end
     end
   end

data/lib/theme_check/language_server/handler.rb

@@ -42,19 +42,19 @@ module ThemeCheck
       alias_method :on_shutdown, :on_exit
 
       def on_text_document_did_change(_id, params)
-        uri = text_document_uri(params)
-        @storage.write(uri, content_changes_text(params))
+        relative_path = relative_path_from_text_document_uri(params)
+        @storage.write(relative_path, content_changes_text(params))
       end
 
       def on_text_document_did_close(_id, params)
-        uri = text_document_uri(params)
-        @storage.write(uri, nil)
+        relative_path = relative_path_from_text_document_uri(params)
+        @storage.write(relative_path, "")
       end
 
       def on_text_document_did_open(_id, params)
-        uri = text_document_uri(params)
-        @storage.write(uri, text_document_text(params))
-        analyze_and_send_offenses(uri)
+        relative_path = relative_path_from_text_document_uri(params)
+        @storage.write(relative_path, text_document_text(params))
+        analyze_and_send_offenses(text_document_uri(params))
       end
 
       def on_text_document_did_save(_id, params)
@@ -62,27 +62,27 @@ module ThemeCheck
       end
 
       def on_text_document_document_link(id, params)
-        uri = text_document_uri(params)
+        relative_path = relative_path_from_text_document_uri(params)
         send_response(
           id: id,
-          result: document_links(uri)
+          result: document_links(relative_path)
         )
       end
 
       def on_text_document_completion(id, params)
-        uri = text_document_uri(params)
+        relative_path = relative_path_from_text_document_uri(params)
         line = params.dig('position', 'line')
         col = params.dig('position', 'character')
         send_response(
           id: id,
-          result: completions(uri, line, col)
+          result: completions(relative_path, line, col)
         )
       end
 
       private
 
       def in_memory_storage(root)
-        config = ThemeCheck::Config.from_path(root)
+        config = config_for_path(root)
 
         # Make a real FS to get the files from the snippets folder
         fs = ThemeCheck::FileSystemStorage.new(
@@ -95,13 +95,17 @@ module ThemeCheck
           .map { |fn| [fn, ""] }
           .to_h
 
-        InMemoryStorage.new(files, root)
+        InMemoryStorage.new(files, config.root)
       end
 
       def text_document_uri(params)
         params.dig('textDocument', 'uri').sub('file://', '')
       end
 
+      def relative_path_from_text_document_uri(params)
+        @storage.relative_path(text_document_uri(params))
+      end
+
       def text_document_text(params)
         params.dig('textDocument', 'text')
       end
@@ -110,9 +114,13 @@ module ThemeCheck
         params.dig('contentChanges', 0, 'text')
       end
 
-      def analyze_and_send_offenses(file_path)
-        root = ThemeCheck::Config.find(file_path) || @root_path
-        config = ThemeCheck::Config.from_path(root)
+      def config_for_path(path)
+        root = ThemeCheck::Config.find(path) || @root_path
+        ThemeCheck::Config.from_path(root)
+      end
+
+      def analyze_and_send_offenses(absolute_path)
+        config = config_for_path(absolute_path)
         storage = ThemeCheck::FileSystemStorage.new(
           config.root,
           ignored_patterns: config.ignored_patterns
@@ -131,12 +139,12 @@ module ThemeCheck
         analyzer.offenses
       end
 
-      def completions(uri, line, col)
-        @completion_engine.completions(uri, line, col)
+      def completions(relative_path, line, col)
+        @completion_engine.completions(relative_path, line, col)
       end
 
-      def document_links(uri)
-        @document_link_engine.document_links(uri)
+      def document_links(relative_path)
+        @document_link_engine.document_links(relative_path)
       end
 
       def send_diagnostics(offenses)
@@ -162,7 +170,7 @@ module ThemeCheck
         send_response(
           method: 'textDocument/publishDiagnostics',
           params: {
-            uri: "file:#{path}",
+            uri: "file://#{path}",
             diagnostics: offenses.map { |offense| offense_to_diagnostic(offense) },
           },
         )

data/lib/theme_check/language_server/server.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 require 'json'
 require 'stringio'
-require 'active_support/core_ext/string/inflections'
 
 module ThemeCheck
   module LanguageServer
@@ -99,7 +98,7 @@ module ThemeCheck
       end
 
       def to_snake_case(method_name)
-        method_name.gsub(/[^\w]/, '_').underscore
+        StringHelpers.underscore(method_name.gsub(/[^\w]/, '_'))
       end
 
       def initial_line

data/lib/theme_check/node.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require 'active_support/core_ext/string/inflections'
 
 module ThemeCheck
   # A node from the Liquid AST, the result of parsing a template.
@@ -101,7 +100,7 @@ module ThemeCheck
     # The `:under_score_name` of this type of node. Used to dispatch to the `on_<type_name>`
     # and `after_<type_name>` check methods.
     def type_name
-      @type_name ||= @value.class.name.demodulize.underscore.to_sym
+      @type_name ||= StringHelpers.underscore(StringHelpers.demodulize(@value.class.name)).to_sym
     end
 
     # Is this node inside a `{% liquid ... %}` block?

data/lib/theme_check/offense.rb

@@ -83,7 +83,7 @@ module ThemeCheck
     end
 
     def check_name
-      check.class.name.demodulize
+      StringHelpers.demodulize(check.class.name)
     end
 
     def doc

data/lib/theme_check/releaser.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+require 'theme_check/version'
+
+module ThemeCheck
+  class Releaser
+    ROOT = File.expand_path('../../..', __FILE__)
+    LIB = File.join(ROOT, 'lib')
+
+    class VersionError < StandardError; end
+
+    def release(version)
+      raise VersionError, "Missing version argument." if version.nil?
+      raise VersionError, "Version should be a string." unless version.is_a?(String)
+      raise VersionError, "Version should be a valid semver version." unless version =~ /^\d+\.\d+.\d+$/
+      update_docs(version)
+      update_version(version)
+    end
+
+    def update_version(version)
+      version_file_path = File.join(LIB, 'theme_check/version.rb')
+      version_file = File.read(version_file_path)
+      updated_version_file = version_file.gsub(ThemeCheck::VERSION, version)
+
+      return if updated_version_file == version_file
+      puts "Updating version to #{version} in #{version_file_path}."
+      File.write(version_file_path, updated_version_file)
+    end
+
+    def update_docs(version)
+      Dir[ROOT + '/docs/checks/*.md'].each do |filename|
+        doc_content = File.read(filename)
+        updated_doc_content = doc_content.gsub('THEME_CHECK_VERSION', version)
+        next if updated_doc_content == doc_content
+        puts "Replacing `THEME_CHECK_VERSION` with #{version} in #{Pathname.new(filename).relative_path_from(ROOT)}"
+        File.write(filename, updated_doc_content)
+      end
+    end
+  end
+end

data/lib/theme_check/shopify_liquid/deprecated_filter.rb

@@ -17,14 +17,12 @@ module ThemeCheck
       private
 
       def all
-        @all ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/deprecated_filters.yml"))
-            .values
-            .each_with_object({}) do |filters, acc|
-              filters.each do |(filter, alternatives)|
-                acc[filter] = alternatives
-              end
-            end
+        @all ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/deprecated_filters.yml"))
+          .values
+          .each_with_object({}) do |filters, acc|
+          filters.each do |(filter, alternatives)|
+            acc[filter] = alternatives
+          end
         end
       end
     end

data/lib/theme_check/shopify_liquid/filter.rb

@@ -7,11 +7,9 @@ module ThemeCheck
       extend self
 
       def labels
-        @labels ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/filters.yml"))
-            .values
-            .flatten
-        end
+        @labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/filters.yml"))
+          .values
+          .flatten
       end
     end
   end

data/lib/theme_check/shopify_liquid/object.rb

@@ -7,15 +7,11 @@ module ThemeCheck
       extend self
 
       def labels
-        @labels ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/objects.yml"))
-        end
+        @labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/objects.yml"))
       end
 
       def plus_labels
-        @plus_labels ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/plus_objects.yml"))
-        end
+        @plus_labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/plus_objects.yml"))
       end
     end
   end

data/lib/theme_check/shopify_liquid/tag.rb

@@ -7,9 +7,7 @@ module ThemeCheck
       extend self
 
       def labels
-        @tags ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/tags.yml"))
-        end
+        @tags ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/tags.yml"))
       end
     end
   end

data/lib/theme_check/storage.rb

@@ -2,15 +2,15 @@
 
 module ThemeCheck
   class Storage
-    def read(relative_path)
+    def path(relative_path)
       raise NotImplementedError
     end
 
-    def write(relative_path, content)
+    def read(relative_path)
       raise NotImplementedError
     end
 
-    def path(relative_path)
+    def write(relative_path, content)
       raise NotImplementedError
     end
 

data/lib/theme_check/string_helpers.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module ThemeCheck
+  module StringHelpers
+    extend self
+
+    # Removes the module part from the expression in the string.
+    # Ported from ActiveSupport
+    #
+    #   demodulize('ActiveSupport::Inflector::Inflections') # => "Inflections"
+    #   demodulize('Inflections')                           # => "Inflections"
+    #   demodulize('::Inflections')                         # => "Inflections"
+    #   demodulize('')                                      # => ""
+    #
+    # See also #deconstantize.
+    def demodulize(path)
+      path = path.to_s
+      if (i = path.rindex("::"))
+        path[(i + 2)..-1]
+      else
+        path
+      end
+    end
+
+    # Makes an underscored, lowercase form from the expression in the string.
+    # Base on ActiveSupport's
+    #
+    # Changes '::' to '/' to convert namespaces to paths.
+    #
+    #   underscore('ActiveModel')         # => "active_model"
+    #   underscore('ActiveModel::Errors') # => "active_model/errors"
+    #
+    # As a rule of thumb you can think of +underscore+ as the inverse of
+    # #camelize, though there are cases where that does not hold:
+    #
+    #   camelize(underscore('SSLError'))  # => "SslError"
+    def underscore(camel_cased_word)
+      return camel_cased_word unless /[A-Z-]|::/.match?(camel_cased_word)
+      word = camel_cased_word.to_s.gsub("::", "/")
+      word.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
+      word.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
+      word.tr!("-", "_")
+      word.downcase!
+      word
+    end
+  end
+end

data/lib/theme_check/tags.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require "active_support/core_ext/string/starts_ends_with"
 
 module ThemeCheck
   module Tags
@@ -19,7 +18,7 @@ module ThemeCheck
           "Error in tag 'section' - Valid syntax: section '[type]'",
         ) unless match
         @section_name = match[:section_name].tr(%('"), '')
-        @section_name.chomp!(".liquid") if @section_name.ends_with?(".liquid")
+        @section_name.chomp!(".liquid") if @section_name.end_with?(".liquid")
       end
     end
 

data/lib/theme_check/theme.rb

@@ -13,7 +13,7 @@ module ThemeCheck
 
     def assets
       @assets ||= @storage.files
-        .select { |path| path.starts_with?("assets/") }
+        .select { |path| path.start_with?("assets/") }
         .map { |path| AssetFile.new(path, @storage) }
     end
 

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/theme-check.gemspec

@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency('liquid', '>= 5')
-  spec.add_dependency('activesupport')
+  spec.add_dependency('liquid', '>= 5.0.1')
   spec.add_dependency('nokogumbo')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-03-23 00:00:00.000000000 Z
+date: 2021-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -16,28 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
+        version: 5.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: 5.0.1
 - !ruby/object:Gem::Dependency
   name: nokogumbo
   requirement: !ruby/object:Gem::Requirement
@@ -98,6 +84,7 @@ files:
 - docs/checks/missing_template.md
 - docs/checks/nested_snippet.md
 - docs/checks/parser_blocking_javascript.md
+- docs/checks/remote_asset.md
 - docs/checks/required_directories.md
 - docs/checks/required_layout_theme_object.md
 - docs/checks/space_inside_braces.md
@@ -133,6 +120,7 @@ files:
 - lib/theme_check/checks/missing_template.rb
 - lib/theme_check/checks/nested_snippet.rb
 - lib/theme_check/checks/parser_blocking_javascript.rb
+- lib/theme_check/checks/remote_asset.rb
 - lib/theme_check/checks/required_directories.rb
 - lib/theme_check/checks/required_layout_theme_object.rb
 - lib/theme_check/checks/space_inside_braces.rb
@@ -179,6 +167,7 @@ files:
 - lib/theme_check/parsing_helpers.rb
 - lib/theme_check/printer.rb
 - lib/theme_check/regex_helpers.rb
+- lib/theme_check/releaser.rb
 - lib/theme_check/remote_asset_file.rb
 - lib/theme_check/shopify_liquid.rb
 - lib/theme_check/shopify_liquid/deprecated_filter.rb
@@ -186,6 +175,7 @@ files:
 - lib/theme_check/shopify_liquid/object.rb
 - lib/theme_check/shopify_liquid/tag.rb
 - lib/theme_check/storage.rb
+- lib/theme_check/string_helpers.rb
 - lib/theme_check/tags.rb
 - lib/theme_check/template.rb
 - lib/theme_check/theme.rb