theme-check 0.4.0 → 0.7.2

data/lib/theme_check/shopify_liquid/deprecated_filter.rb

@@ -10,17 +10,19 @@ module ThemeCheck
         all.fetch(filter, nil)
       end
 
+      def labels
+        @labels ||= all.keys
+      end
+
       private
 
       def all
-        @all ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/deprecated_filters.yml"))
-            .values
-            .each_with_object({}) do |filters, acc|
-              filters.each do |(filter, alternatives)|
-                acc[filter] = alternatives
-              end
-            end
+        @all ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/deprecated_filters.yml"))
+          .values
+          .each_with_object({}) do |filters, acc|
+          filters.each do |(filter, alternatives)|
+            acc[filter] = alternatives
+          end
         end
       end
     end

data/lib/theme_check/shopify_liquid/filter.rb

@@ -7,11 +7,9 @@ module ThemeCheck
       extend self
 
       def labels
-        @labels ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/filters.yml"))
-            .values
-            .flatten
-        end
+        @labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/filters.yml"))
+          .values
+          .flatten
       end
     end
   end

data/lib/theme_check/shopify_liquid/object.rb

@@ -7,15 +7,11 @@ module ThemeCheck
       extend self
 
       def labels
-        @labels ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/objects.yml"))
-        end
+        @labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/objects.yml"))
       end
 
       def plus_labels
-        @plus_labels ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/plus_objects.yml"))
-        end
+        @plus_labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/plus_objects.yml"))
       end
     end
   end

data/lib/theme_check/shopify_liquid/tag.rb

@@ -7,9 +7,7 @@ module ThemeCheck
       extend self
 
       def labels
-        @tags ||= begin
-          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/tags.yml"))
-        end
+        @tags ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/tags.yml"))
       end
     end
   end

data/lib/theme_check/storage.rb

@@ -2,15 +2,15 @@
 
 module ThemeCheck
   class Storage
-    def read(relative_path)
+    def path(relative_path)
       raise NotImplementedError
     end
 
-    def write(relative_path, content)
+    def read(relative_path)
       raise NotImplementedError
     end
 
-    def path(relative_path)
+    def write(relative_path, content)
       raise NotImplementedError
     end
 

data/lib/theme_check/string_helpers.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module ThemeCheck
+  module StringHelpers
+    extend self
+
+    # Removes the module part from the expression in the string.
+    # Ported from ActiveSupport
+    #
+    #   demodulize('ActiveSupport::Inflector::Inflections') # => "Inflections"
+    #   demodulize('Inflections')                           # => "Inflections"
+    #   demodulize('::Inflections')                         # => "Inflections"
+    #   demodulize('')                                      # => ""
+    #
+    # See also #deconstantize.
+    def demodulize(path)
+      path = path.to_s
+      if (i = path.rindex("::"))
+        path[(i + 2)..-1]
+      else
+        path
+      end
+    end
+
+    # Makes an underscored, lowercase form from the expression in the string.
+    # Base on ActiveSupport's
+    #
+    # Changes '::' to '/' to convert namespaces to paths.
+    #
+    #   underscore('ActiveModel')         # => "active_model"
+    #   underscore('ActiveModel::Errors') # => "active_model/errors"
+    #
+    # As a rule of thumb you can think of +underscore+ as the inverse of
+    # #camelize, though there are cases where that does not hold:
+    #
+    #   camelize(underscore('SSLError'))  # => "SslError"
+    def underscore(camel_cased_word)
+      return camel_cased_word unless /[A-Z-]|::/.match?(camel_cased_word)
+      word = camel_cased_word.to_s.gsub("::", "/")
+      word.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
+      word.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
+      word.tr!("-", "_")
+      word.downcase!
+      word
+    end
+  end
+end

data/lib/theme_check/tags.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require "active_support/core_ext/string/starts_ends_with"
 
 module ThemeCheck
   module Tags
@@ -19,7 +18,7 @@ module ThemeCheck
           "Error in tag 'section' - Valid syntax: section '[type]'",
         ) unless match
         @section_name = match[:section_name].tr(%('"), '')
-        @section_name.chomp!(".liquid") if @section_name.ends_with?(".liquid")
+        @section_name.chomp!(".liquid") if @section_name.end_with?(".liquid")
       end
     end
 

data/lib/theme_check/theme.rb

@@ -11,6 +11,12 @@ module ThemeCheck
       @storage = storage
     end
 
+    def assets
+      @assets ||= @storage.files
+        .select { |path| path.start_with?("assets/") }
+        .map { |path| AssetFile.new(path, @storage) }
+    end
+
     def liquid
       @liquid ||= @storage.files
         .select { |path| LIQUID_REGEX.match?(path) }
@@ -43,7 +49,7 @@ module ThemeCheck
     end
 
     def all
-      @all ||= json + liquid
+      @all ||= json + liquid + assets
     end
 
     def [](name)

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.4.0"
+  VERSION = "0.7.2"
 end

data/packaging/homebrew/theme_check.base.rb

@@ -13,7 +13,7 @@ class ThemeCheck < Formula
   class RubyGemsDownloadStrategy < AbstractDownloadStrategy
     include RubyBin
 
-    def fetch
+    def fetch(_timeout: nil, **_options)
       ohai("Fetching theme-check from gem source")
       cache.cd do
         ENV['GEM_SPEC_CACHE'] = "#{cache}/gem_spec_cache"

data/theme-check.gemspec

@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency('liquid', '>= 5')
-  spec.add_dependency('activesupport')
+  spec.add_dependency('liquid', '>= 5.0.1')
   spec.add_dependency('nokogumbo')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.7.2
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-25 00:00:00.000000000 Z
+date: 2021-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -16,28 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
+        version: 5.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: 5.0.1
 - !ruby/object:Gem::Dependency
   name: nokogumbo
   requirement: !ruby/object:Gem::Requirement
@@ -81,17 +67,51 @@ files:
 - data/shopify_liquid/objects.yml
 - data/shopify_liquid/plus_objects.yml
 - data/shopify_liquid/tags.yml
+- data/shopify_translation_keys.yml
 - dev.yml
+- docs/checks/CHECK_DOCS_TEMPLATE.md
+- docs/checks/asset_size_css.md
+- docs/checks/asset_size_javascript.md
+- docs/checks/convert_include_to_render.md
+- docs/checks/default_locale.md
+- docs/checks/deprecated_filter.md
+- docs/checks/img_width_and_height.md
+- docs/checks/liquid_tag.md
+- docs/checks/matching_schema_translations.md
+- docs/checks/matching_translations.md
+- docs/checks/missing_enable_comment.md
+- docs/checks/missing_required_template_files.md
+- docs/checks/missing_template.md
+- docs/checks/nested_snippet.md
+- docs/checks/parser_blocking_javascript.md
+- docs/checks/remote_asset.md
+- docs/checks/required_directories.md
+- docs/checks/required_layout_theme_object.md
+- docs/checks/space_inside_braces.md
+- docs/checks/syntax_error.md
+- docs/checks/template_length.md
+- docs/checks/translation_key_exists.md
+- docs/checks/undefined_object.md
+- docs/checks/unknown_filter.md
+- docs/checks/unused_assign.md
+- docs/checks/unused_snippet.md
+- docs/checks/valid_html_translation.md
+- docs/checks/valid_json.md
+- docs/checks/valid_schema.md
 - docs/preview.png
 - exe/theme-check
 - exe/theme-check-language-server
 - lib/theme_check.rb
 - lib/theme_check/analyzer.rb
+- lib/theme_check/asset_file.rb
 - lib/theme_check/check.rb
 - lib/theme_check/checks.rb
+- lib/theme_check/checks/asset_size_css.rb
+- lib/theme_check/checks/asset_size_javascript.rb
 - lib/theme_check/checks/convert_include_to_render.rb
 - lib/theme_check/checks/default_locale.rb
 - lib/theme_check/checks/deprecated_filter.rb
+- lib/theme_check/checks/img_width_and_height.rb
 - lib/theme_check/checks/liquid_tag.rb
 - lib/theme_check/checks/matching_schema_translations.rb
 - lib/theme_check/checks/matching_translations.rb
@@ -100,6 +120,7 @@ files:
 - lib/theme_check/checks/missing_template.rb
 - lib/theme_check/checks/nested_snippet.rb
 - lib/theme_check/checks/parser_blocking_javascript.rb
+- lib/theme_check/checks/remote_asset.rb
 - lib/theme_check/checks/required_directories.rb
 - lib/theme_check/checks/required_layout_theme_object.rb
 - lib/theme_check/checks/space_inside_braces.rb
@@ -129,7 +150,10 @@ files:
 - lib/theme_check/language_server/completion_provider.rb
 - lib/theme_check/language_server/completion_providers/filter_completion_provider.rb
 - lib/theme_check/language_server/completion_providers/object_completion_provider.rb
+- lib/theme_check/language_server/completion_providers/render_snippet_completion_provider.rb
 - lib/theme_check/language_server/completion_providers/tag_completion_provider.rb
+- lib/theme_check/language_server/constants.rb
+- lib/theme_check/language_server/document_link_engine.rb
 - lib/theme_check/language_server/handler.rb
 - lib/theme_check/language_server/position_helper.rb
 - lib/theme_check/language_server/protocol.rb
@@ -142,12 +166,16 @@ files:
 - lib/theme_check/packager.rb
 - lib/theme_check/parsing_helpers.rb
 - lib/theme_check/printer.rb
+- lib/theme_check/regex_helpers.rb
+- lib/theme_check/releaser.rb
+- lib/theme_check/remote_asset_file.rb
 - lib/theme_check/shopify_liquid.rb
 - lib/theme_check/shopify_liquid/deprecated_filter.rb
 - lib/theme_check/shopify_liquid/filter.rb
 - lib/theme_check/shopify_liquid/object.rb
 - lib/theme_check/shopify_liquid/tag.rb
 - lib/theme_check/storage.rb
+- lib/theme_check/string_helpers.rb
 - lib/theme_check/tags.rb
 - lib/theme_check/template.rb
 - lib/theme_check/theme.rb