theme-check 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: babce309fcdbc1bb5121d93b5d7bc443aa5c2fc88481169be0efee6c141449e6
-  data.tar.gz: df49e8b26223efd29341163b2a7125127f961647e9553655102ed772a9792b65
+  metadata.gz: 31af33605da4e88e134907242224b4266afc76fede068c70a1ba6b8d84eb98cd
+  data.tar.gz: 80c7427113fd20c02c02d87d8f598d49182d460a8691e06dbaa954872c4f83c2
 SHA512:
-  metadata.gz: e703cfd5f85e5fb530532eafd3f47d403f3a45463da8e6a8682b605cc31d7e4a942db4e23da1f88354bc8c8e44c0fd903b83536c5db431f4ff68e3116666369f
-  data.tar.gz: 74b032108d464ce48d931ded5147cb5613cb4db0e480904ac740b404f49969381aafb3b8debd657d6c660cc4549d99e977b9568c0c97ea8416b8b022034a3bd3
+  metadata.gz: 486f6280ef9521a7d35a8c4dce9e146b652514cb16def7b70845e2b93993710f2b61bd22dd448954ab1e44adc62b10c84b8e93ac3895dd92c4c1c42911341c83
+  data.tar.gz: '0171786d1c8bea48ba90a755cda22aea62da383b740b2cccc402dba210cc6d361a86704fe43617be2e489747bbb67a6614e4ab975d5fe2128e2f89da724a8ca3'

data/.rubocop.yml

@@ -7,6 +7,7 @@ AllCops:
   TargetRubyVersion: 2.7
   Exclude:
     - 'vendor/bundle/**/*'
+    - 'packaging/builds/**/*'
 
 Metrics/MethodLength:
   Enabled: false

data/CHANGELOG.md

@@ -0,0 +1,27 @@
+
+v0.3.2 / 2021-02-17
+==================
+
+  * Ignore snippets in UndefinedObject check
+
+v0.3.1 / 2021-02-16
+===================
+
+  * Fixup version flag
+
+v0.3.0 / 2021-02-16
+===================
+
+  * Add ParserBlockingJavaScript Check ([#78](https://github.com/Shopify/theme-check/issues/78), [#146](https://github.com/Shopify/theme-check/issues/146))
+  * Internal refactor to enable running theme-check in servers ([#145](https://github.com/Shopify/theme-check/issues/145), [#148](https://github.com/Shopify/theme-check/issues/148))
+  * Add -v, --version flag ([#126](https://github.com/Shopify/theme-check/issues/126))
+  * Exclude content of {% schema %} in line count for TemplateLength ([#140](https://github.com/Shopify/theme-check/issues/140))
+  * Fix Language Server removed files bug ([#136](https://github.com/Shopify/theme-check/issues/136))
+  * Add ignore config ([#147](https://github.com/Shopify/theme-check/issues/147))
+  * Add ability to disable checks with comments ([#79](https://github.com/Shopify/theme-check/issues/79))
+  * Adding checks for shopify plus objects in checkout ([#121](https://github.com/Shopify/theme-check/issues/121))
+
+v0.2.2 / 2021-01-22
+===================
+
+  * [Language Server] Send empty dianogstics to flush errors

data/RELEASING.md

@@ -22,7 +22,7 @@
 
    ```bash
    VERSION=X.X.X
-   cp packaging/builds/$VERSION/theme-check ../homebrew-shopify
+   cp packaging/builds/$VERSION/theme-check.rb ../homebrew-shopify
    ```
 
 4. Create a branch + a commit on the [`homebrew-shopify`](https://github.com/Shopify/homebrew-shopify) repository.

data/config/default.yml

@@ -67,6 +67,7 @@ MissingRequiredTemplateFiles:
 
 UndefinedObject:
   enabled: true
+  exclude_snippets: true
 
 RequiredDirectories:
   enabled: true

data/lib/theme_check/checks/undefined_object.rb

@@ -49,23 +49,28 @@ module ThemeCheck
       end
     end
 
-    def initialize
+    def initialize(exclude_snippets: false)
+      @exclude_snippets = exclude_snippets
       @files = {}
     end
 
     def on_document(node)
+      return if ignore?(node)
       @files[node.template.name] = TemplateInfo.new
     end
 
     def on_assign(node)
+      return if ignore?(node)
       @files[node.template.name].all_assigns[node.value.to] = node
     end
 
     def on_capture(node)
+      return if ignore?(node)
       @files[node.template.name].all_captures[node.value.instance_variable_get('@to')] = node
     end
 
     def on_for(node)
+      return if ignore?(node)
       @files[node.template.name].all_forloops[node.value.variable_name] = node
     end
 
@@ -75,6 +80,7 @@ module ThemeCheck
     end
 
     def on_render(node)
+      return if ignore?(node)
       return unless node.value.template_name_expr.is_a?(String)
 
       snippet_name = "snippets/#{node.value.template_name_expr}"
@@ -85,6 +91,7 @@ module ThemeCheck
     end
 
     def on_variable_lookup(node)
+      return if ignore?(node)
       @files[node.template.name].add_variable_lookup(
         name: node.value.name,
         node: node,
@@ -114,13 +121,18 @@ module ThemeCheck
       end
     end
 
+    private
+
+    def ignore?(node)
+      @exclude_snippets && node.template.snippet?
+    end
+
     def each_template
       @files.each do |(name, info)|
         next if name.starts_with?('snippets/')
         yield [name, info]
       end
     end
-    private :each_template
 
     def check_object(info, all_global_objects, render_node = nil)
       check_undefined(info, all_global_objects, render_node)
@@ -134,7 +146,6 @@ module ThemeCheck
         check_object(snippet_info, all_global_objects + snippet_variables, node)
       end
     end
-    private :check_object
 
     def check_undefined(info, all_global_objects, render_node)
       all_variables = info.all_variables
@@ -154,6 +165,5 @@ module ThemeCheck
         end
       end
     end
-    private :check_undefined
   end
 end

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-16 00:00:00.000000000 Z
+date: 2021-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -65,6 +65,7 @@ files:
 - ".github/workflows/theme-check.yml"
 - ".gitignore"
 - ".rubocop.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile