theme-check 0.3.0 → 0.5.0

data/lib/theme_check/offense.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 module ThemeCheck
+  Position = Struct.new(:line, :column)
+
   class Offense
     MAX_SOURCE_EXCERPT_SIZE = 120
 
@@ -35,6 +37,9 @@ module ThemeCheck
       elsif @node
         @node.line_number
       end
+
+      @start_position = nil
+      @end_position = nil
     end
 
     def source_excerpt
@@ -50,27 +55,19 @@ module ThemeCheck
     end
 
     def start_line
-      return 0 unless line_number
-      line_number - 1
+      start_position.line
     end
 
-    def end_line
-      if markup
-        start_line + markup.count("\n")
-      else
-        start_line
-      end
+    def start_column
+      start_position.column
     end
 
-    def start_column
-      return 0 unless line_number && markup
-      template.full_line(start_line + 1).index(markup.split("\n", 2).first)
+    def end_line
+      end_position.line
     end
 
     def end_column
-      return 0 unless line_number && markup
-      markup_end = markup.split("\n").last
-      template.full_line(end_line + 1).index(markup_end) + markup_end.size
+      end_position.column
     end
 
     def code_name
@@ -116,5 +113,45 @@ module ThemeCheck
         message
       end
     end
+
+    private
+
+    def full_line(line)
+      # Liquid::Template is 1-indexed.
+      template.full_line(line + 1)
+    end
+
+    def lines_of_content
+      @lines ||= markup.lines.map { |x| x.sub(/\n$/, '') }
+    end
+
+    # 0-indexed, inclusive
+    def start_position
+      return @start_position if @start_position
+      return @start_position = Position.new(0, 0) unless line_number && markup
+
+      position = Position.new
+      position.line = line_number - 1
+      position.column = full_line(position.line).index(lines_of_content.first) || 0
+
+      @start_position = position
+    end
+
+    # 0-indexed, exclusive. It's the line + col that are exclusive.
+    # This is why it doesn't make sense to calculate them separately.
+    def end_position
+      return @end_position if @end_position
+      return @end_position = Position.new(0, 0) unless line_number && markup
+
+      position = Position.new
+      position.line = start_line + lines_of_content.size - 1
+      position.column = if start_line == position.line
+        start_column + markup.size
+      else
+        lines_of_content.last.size
+      end
+
+      @end_position = position
+    end
   end
 end

data/lib/theme_check/regex_helpers.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module ThemeCheck
+  module RegexHelpers
+    def matches(s, re)
+      start_at = 0
+      matches = []
+      while (m = s.match(re, start_at))
+        matches.push(m)
+        start_at = m.end(0)
+      end
+      matches
+    end
+  end
+end

data/lib/theme_check/remote_asset_file.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+require "net/http"
+require "pathname"
+
+module ThemeCheck
+  class RemoteAssetFile
+    class << self
+      def cache
+        @cache ||= {}
+      end
+
+      def from_src(src)
+        key = uri(src).to_s
+        cache[key] = RemoteAssetFile.new(src) unless cache.key?(key)
+        cache[key]
+      end
+
+      def uri(src)
+        URI.parse(src.sub(%r{^//}, "https://"))
+      end
+    end
+
+    def initialize(src)
+      @uri = RemoteAssetFile.uri(src)
+      @content = nil
+    end
+
+    def content
+      return @content unless @content.nil?
+
+      res = Net::HTTP.start(@uri.hostname, @uri.port, use_ssl: @uri.scheme == 'https') do |http|
+        req = Net::HTTP::Get.new(@uri)
+        req['Accept-Encoding'] = 'gzip, deflate, br'
+        http.request(req)
+      end
+
+      @content = res.body
+    end
+
+    def gzipped_size
+      @gzipped_size ||= @content.bytesize
+    end
+  end
+end

data/lib/theme_check/shopify_liquid.rb

@@ -2,3 +2,4 @@
 require_relative 'shopify_liquid/deprecated_filter'
 require_relative 'shopify_liquid/filter'
 require_relative 'shopify_liquid/object'
+require_relative 'shopify_liquid/tag'

data/lib/theme_check/shopify_liquid/tag.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+require 'yaml'
+
+module ThemeCheck
+  module ShopifyLiquid
+    module Tag
+      extend self
+
+      def labels
+        @tags ||= begin
+          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/tags.yml"))
+        end
+      end
+    end
+  end
+end

data/lib/theme_check/theme.rb

@@ -11,6 +11,12 @@ module ThemeCheck
       @storage = storage
     end
 
+    def assets
+      @assets ||= @storage.files
+        .select { |path| path.starts_with?("assets/") }
+        .map { |path| AssetFile.new(path, @storage) }
+    end
+
     def liquid
       @liquid ||= @storage.files
         .select { |path| LIQUID_REGEX.match?(path) }
@@ -43,7 +49,7 @@ module ThemeCheck
     end
 
     def all
-      @all ||= json + liquid
+      @all ||= json + liquid + assets
     end
 
     def [](name)

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.3.0"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-16 00:00:00.000000000 Z
+date: 2021-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -65,6 +65,7 @@ files:
 - ".github/workflows/theme-check.yml"
 - ".gitignore"
 - ".rubocop.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
@@ -79,14 +80,43 @@ files:
 - data/shopify_liquid/filters.yml
 - data/shopify_liquid/objects.yml
 - data/shopify_liquid/plus_objects.yml
+- data/shopify_liquid/tags.yml
 - dev.yml
+- docs/checks/CHECK_DOCS_TEMPLATE.md
+- docs/checks/asset_size_javascript.md
+- docs/checks/convert_include_to_render.md
+- docs/checks/default_locale.md
+- docs/checks/deprecated_filter.md
+- docs/checks/liquid_tag.md
+- docs/checks/matching_schema_translations.md
+- docs/checks/matching_translations.md
+- docs/checks/missing_enable_comment.md
+- docs/checks/missing_required_template_files.md
+- docs/checks/missing_template.md
+- docs/checks/nested_snippet.md
+- docs/checks/parser_blocking_javascript.md
+- docs/checks/required_directories.md
+- docs/checks/required_layout_theme_object.md
+- docs/checks/space_inside_braces.md
+- docs/checks/syntax_error.md
+- docs/checks/template_length.md
+- docs/checks/translation_key_exists.md
+- docs/checks/undefined_object.md
+- docs/checks/unknown_filter.md
+- docs/checks/unused_assign.md
+- docs/checks/unused_snippet.md
+- docs/checks/valid_html_translation.md
+- docs/checks/valid_json.md
+- docs/checks/valid_schema.md
 - docs/preview.png
 - exe/theme-check
 - exe/theme-check-language-server
 - lib/theme_check.rb
 - lib/theme_check/analyzer.rb
+- lib/theme_check/asset_file.rb
 - lib/theme_check/check.rb
 - lib/theme_check/checks.rb
+- lib/theme_check/checks/asset_size_javascript.rb
 - lib/theme_check/checks/convert_include_to_render.rb
 - lib/theme_check/checks/default_locale.rb
 - lib/theme_check/checks/deprecated_filter.rb
@@ -122,8 +152,17 @@ files:
 - lib/theme_check/json_file.rb
 - lib/theme_check/json_helpers.rb
 - lib/theme_check/language_server.rb
+- lib/theme_check/language_server/completion_engine.rb
+- lib/theme_check/language_server/completion_helper.rb
+- lib/theme_check/language_server/completion_provider.rb
+- lib/theme_check/language_server/completion_providers/filter_completion_provider.rb
+- lib/theme_check/language_server/completion_providers/object_completion_provider.rb
+- lib/theme_check/language_server/completion_providers/tag_completion_provider.rb
 - lib/theme_check/language_server/handler.rb
+- lib/theme_check/language_server/position_helper.rb
+- lib/theme_check/language_server/protocol.rb
 - lib/theme_check/language_server/server.rb
+- lib/theme_check/language_server/tokens.rb
 - lib/theme_check/liquid_check.rb
 - lib/theme_check/locale_diff.rb
 - lib/theme_check/node.rb
@@ -131,10 +170,13 @@ files:
 - lib/theme_check/packager.rb
 - lib/theme_check/parsing_helpers.rb
 - lib/theme_check/printer.rb
+- lib/theme_check/regex_helpers.rb
+- lib/theme_check/remote_asset_file.rb
 - lib/theme_check/shopify_liquid.rb
 - lib/theme_check/shopify_liquid/deprecated_filter.rb
 - lib/theme_check/shopify_liquid/filter.rb
 - lib/theme_check/shopify_liquid/object.rb
+- lib/theme_check/shopify_liquid/tag.rb
 - lib/theme_check/storage.rb
 - lib/theme_check/tags.rb
 - lib/theme_check/template.rb