theme-check 0.10.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc5f5b1f71dce3de919836a4b8cd55e2ae3994e12c8118a69050840fac21b0e6
-  data.tar.gz: bc190dcdae4c5ec62b8d3e9a6d0a3d1c9ea6fc9b052e843455faf1ed1fc0d92d
+  metadata.gz: 94b918e53777cfb70c65dacd9d9bfbdb6f4463597c8f9c81969e1baef89df7a1
+  data.tar.gz: 7e45af9a3dfeab1eafdff5533df68a9e0d67007d94661a2c974c0c2fece61095
 SHA512:
-  metadata.gz: 24724968d6b6f792e522289b3a62e200d5a2dc568286f8b5044a4b72253bfeb54aafae140dff38d2bfa9e5cb871d1f65c5c575661bb5b5132f73c36919e1b4f1
-  data.tar.gz: aaf053c7dbe25615daadaef936f58435e84180664b03b9f77edf7eee247581ef6b3ddadcf04816922e738db047693e1ca75a6e5bcfec139d42d2d3c0595fe49c
+  metadata.gz: ea1b75ca11a66aefe5eef421f577d53716cb180799863185d36fad21a9033b5cf52579df3e593e41867513da410adc7d16de723f35b3a5435e50098b7af2a348
+  data.tar.gz: ceab091f6bf7317d899cb5459601b7dfb5294e6e4be962a421b33bad33c74fd730001dea90687f81f754d57e5cdedc5b39d0efb5d95d6c016ed965f7e4e86a9f

data/CHANGELOG.md

@@ -1,4 +1,18 @@
 
+v1.0.0 / 2021-06-28
+==================
+
+  * Convert `AssetSizeCSS` to `HtmlCheck`
+  * Add `DeprecateLazysizes` & `DeprecateBgsizes` checks
+  * Allow hardcoded CDN urls in `RemoteAsset`
+  * Bump `LiquidTag` `min_consecutive_statements` default to 5
+  * Exclude {% javascript %} and {% stylesheet %} from line counts in `TemplateLength`
+  * Bump `TemplateLength` `max_length` default to 500
+  * Fix `StringScanner#skip(String)` not being supported on some Rubies
+  * Fix `ParsingHelpers#outside_of_strings` handling of empty strings
+  * Update to support new `{% render %}` syntax
+  * Converted `AssetSizeJavaScript` to `HtmlCheck`
+
 v0.10.2 / 2021-06-18
 ==================
 

data/config/default.yml

@@ -12,7 +12,7 @@ ConvertIncludeToRender:
 LiquidTag:
   enabled: true
   ignore: []
-  min_consecutive_statements: 4
+  min_consecutive_statements: 5
 
 MissingTemplate:
   enabled: true
@@ -38,9 +38,13 @@ SyntaxError:
 TemplateLength:
   enabled: true
   ignore: []
-  max_length: 200
+  max_length: 500
   # Exclude content of {% schema %} in line count
   exclude_schema: true
+  # Exclude content of {% stylesheet %} in line count
+  exclude_stylesheet: true
+  # Exclude content of {% javascript %} in line count
+  exclude_javascript: true
 
 UnknownFilter:
   enabled: true
@@ -99,6 +103,14 @@ DeprecatedFilter:
   enabled: true
   ignore: []
 
+DeprecateLazysizes:
+  enabled: true
+  ignore: []
+
+DeprecateBgsizes:
+  enabled: true
+  ignore: []
+
 MissingEnableComment:
   enabled: true
   ignore: []
@@ -109,16 +121,20 @@ ParserBlockingJavaScript:
 
 ParserBlockingScriptTag:
   enabled: true
+  ignore: []
 
 AssetSizeJavaScript:
   enabled: false
-  ignore: []
   threshold_in_bytes: 10_000
   ignore: []
 
 AssetSizeCSS:
   enabled: false
+  threshold_in_bytes: 100_000
   ignore: []
+
+AssetSizeCSSStylesheetTag:
+  enabled: false
   threshold_in_bytes: 100_000
   ignore: []
 

data/data/shopify_liquid/objects.yml

@@ -40,6 +40,7 @@
 - linklist
 - linklists
 - location
+- localization
 - metafield
 - model
 - model_source
@@ -55,6 +56,7 @@
 - powered_by_link
 - product
 - product_option
+- product_variant
 - recommendations
 - request
 - routes

data/docs/checks/asset_size_css_stylesheet_tag.md

@@ -0,0 +1,50 @@
+# Check Title (`AssetSizeCSSStylesheetTag`)
+
+The `stylesheet_tag` filter generates a link tag that points to a given stylesheet. This rule exists to prevent large CSS bundles (for speed).
+
+## Check Details
+
+This rule disallows the use of too much CSS in themes, as configured by `threshold_in_bytes`.
+
+:-1: Examples of **incorrect** code for this check:
+```liquid
+<!-- Here, assets/theme.css is **greater** than `threshold_in_bytes` compressed. -->
+{{ 'theme.css' | asset_url | stylesheet_tag }}
+```
+
+:+1: Example of **correct** code for this check:
+```liquid
+<!-- Here, assets/theme.css is **less** than `threshold_in_bytes` compressed. -->
+{{ 'theme.css' | asset_url | stylesheet_tag }}
+```
+
+## Check Options
+
+The default configuration for this check is the following:
+
+```yaml
+AssetSizeCSSStylesheetTag:
+  enabled: false
+  threshold_in_bytes: 100_000
+```
+
+### `threshold_in_bytes`
+
+The `threshold_in_bytes` option (default: `100_000`) determines the maximum allowed compressed size in bytes that a single CSS file can take.
+
+## When Not To Use It
+
+This rule is safe to disable.
+
+## Version
+
+This check has been introduced in Theme Check 1.0.0
+
+## Resources
+
+- [The Performance Inequality Gap](https://infrequently.org/2021/03/the-performance-inequality-gap/)
+- [Rule Source][codesource]
+- [Documentation Source][docsource]
+
+[codesource]: /lib/theme_check/checks/asset_size_css_stylesheet_tag.rb
+[docsource]: /docs/checks/asset_size_css_stylesheet_tag.md

data/docs/checks/deprecate_bgsizes.md

@@ -0,0 +1,66 @@
+# Deprecate Bgsizes (`DeprecateBgsizes`)
+
+The lazySizes bgset extension allows you to define multiple background images with a width descriptor. The extension will then load the best image size for the current viewport and device (https://github.com/aFarkas/lazysizes/tree/gh-pages/plugins/bgset)
+
+
+## Check Details
+
+This check is aimed at discouraging the use of the lazySizes bgset plugin 
+
+:-1: Examples of **incorrect** code for this check:
+
+```liquid
+
+<!-- Reports use of "lazyload" class and "data-bgset" attribute -->
+
+<script src="ls.bgset.min.js"></script>
+<script src="lazysizes.min.js"></script>
+<div class="lazyload" data-bgset="image-200.jpg 200w, image-300.jpg 300w, image-400.jpg 400w" data-sizes="auto">
+</div>
+
+```
+
+:+1: Examples of **correct** code for this check:
+
+```liquid
+
+<!-- Uses the CSS image-set() attribute instead of "data-bgset" -->
+<!-- CSS Stylesheet -->
+.box {
+  background-image: -webkit-image-set(
+    url("small-balloons.jpg") 1x,
+    url("large-balloons.jpg") 2x);
+  background-image: image-set(
+    url("small-balloons.jpg") 1x,
+    url("large-balloons.jpg") 2x);
+}
+
+<!-- HTML -->
+<div class="box"></div>
+
+```
+
+## Check Options
+
+The default configuration for this check is the following:
+
+```yaml
+DeprecateBgsizes:
+  enabled: true
+```
+
+## When Not To Use It
+
+You should disable this rule in older browsers that don't support the CSS image-set attribute.
+
+## Version
+
+This check has been introduced in Theme Check 1.0.0.
+
+## Resources
+
+- [Rule Source][codesource]
+- [Documentation Source][docsource]
+
+[codesource]: /lib/theme_check/checks/deprecate_bgsizes.rb
+[docsource]: /docs/checks/deprecate_bgsizes.md

data/docs/checks/deprecate_lazysizes.md

@@ -0,0 +1,61 @@
+# Deprecate lazySizes (`DeprecateLazysizes`)
+
+[lazysizes](https://github.com/aFarkas/lazysizes) is a common JavaScript library used to lazy load images, iframes and scripts.
+
+## Check Details
+
+This check is aimed at discouraging the use of the lazysizes JavaScript library
+
+:-1: Examples of **incorrect** code for this check:
+
+```liquid
+
+<!-- Reports use of "lazyload" class -->
+<img src="a.jpg" class="lazyload">
+
+<!-- Reports use of "data-srcset" and "data-sizes" attribute. Reports data-sizes="auto" -->
+<img
+  alt="House by the lake"
+  data-sizes="auto"
+  data-srcset="small.jpg 500w,
+  medium.jpg 640w,
+  big.jpg 1024w"
+  data-src="medium.jpg"
+  class="lazyload"
+/>
+
+```
+
+:+1: Examples of **correct** code for this check:
+
+```liquid
+
+<!-- Does not use lazySizes library. Instead uses native "loading" attribute -->
+<img src="a.jpg" loading="lazy">
+
+```
+
+## Check Options
+
+The default configuration for this check is the following:
+
+```yaml
+DeprecateLazysizes:
+  enabled: true
+```
+
+## When Not To Use It
+
+You should disable this rule if you want to support lazy loading of images in older browser that don't support the loading="lazy" attribute yet.
+
+## Version
+
+This check has been introduced in Theme Check 1.0.0.
+
+## Resources
+
+- [Rule Source][codesource]
+- [Documentation Source][docsource]
+
+[codesource]: /lib/theme_check/checks/deprecate_lazysizes.rb
+[docsource]: /docs/checks/deprecate_lazysizes.md

data/docs/checks/liquid_tag.md

@@ -39,12 +39,12 @@ The default configuration for this check is the following:
 ```yaml
 LiquidTag:
   enabled: true
-  min_consecutive_statements: 4
+  min_consecutive_statements: 5
 ```
 
 ### `min_consecutive_statements`
 
-The `min_consecutive_statements` option (Default: `4`) determines the maximum (inclusive) number of consecutive statements before the check recommends a refactor.
+The `min_consecutive_statements` option (Default: `5`) determines the maximum (inclusive) number of consecutive statements before the check recommends a refactor.
 
 ## When Not To Use It
 

data/docs/checks/template_length.md

@@ -21,8 +21,10 @@ The default configuration for this check is the following:
 ```yaml
 TemplateLength:
   enabled: true
-  max_length: 200
+  max_length: 500
   exclude_schema: true
+  exclude_stylesheet: true
+  exclude_javascript: true
 ```
 
 ### `max_length`
@@ -31,7 +33,15 @@ The `max_length` (Default: `200`) option determines the maximum number of lines
 
 ### `exclude_schema`
 
-The `exclude_schema` (Default: `true`) option determines if the schema lines from a template should be excluded from the line count.
+The `exclude_schema` (Default: `true`) option determines if the lines inside `{% schema %}` blocks from a template should be excluded from the line count.
+
+### `exclude_stylesheet`
+
+The `exclude_stylesheet` (Default: `true`) option determines if the lines inside `{% stylesheet %}` blocks from a template should be excluded from the line count.
+
+### `exclude_javascript`
+
+The `exclude_javascript` (Default: `true`) option determines if the lines inside `{% javascript %}` blocks from a template should be excluded from the line count.
 
 ## When Not To Use It
 

data/lib/theme_check/checks/asset_size_css.rb

@@ -1,89 +1,26 @@
 # frozen_string_literal: true
 module ThemeCheck
-  class AssetSizeCSS < LiquidCheck
+  class AssetSizeCSS < HtmlCheck
     include RegexHelpers
     severity :error
-    category :performance
+    category :html, :performance
     doc docs_url(__FILE__)
 
-    Link = Struct.new(:href, :index)
-
-    LINK_TAG_HREF = %r{
-      <link
-        (?=[^>]+?rel=['"]?stylesheet['"]?)    # Make sure rel=stylesheet is in the link with lookahead
-        [^>]+                                 # any non closing tag character
-        href=                                 # href attribute start
-        (?<href>#{QUOTED_LIQUID_ATTRIBUTE})   # href attribute value (may contain liquid)
-        [^>]*                                 # any non closing character till the end
-      >
-    }omix
-    STYLESHEET_TAG = %r{
-      #{Liquid::VariableStart}          # VariableStart
-      (?:(?!#{Liquid::VariableEnd}).)*? # anything that isn't followed by a VariableEnd
-      \|\s*asset_url\s*                 # | asset_url
-      \|\s*stylesheet_tag\s*            # | stylesheet_tag
-      #{Liquid::VariableEnd}            # VariableEnd
-    }omix
-
     attr_reader :threshold_in_bytes
 
     def initialize(threshold_in_bytes: 100_000)
       @threshold_in_bytes = threshold_in_bytes
     end
 
-    def on_document(node)
-      @node = node
-      @source = node.template.source
-      record_offenses
-    end
-
-    def record_offenses
-      stylesheets(@source).each do |stylesheet|
-        file_size = href_to_file_size(stylesheet.href)
-        next if file_size.nil?
-        next if file_size <= threshold_in_bytes
-        add_offense(
-          "CSS on every page load exceding compressed size threshold (#{threshold_in_bytes} Bytes).",
-          node: @node,
-          markup: stylesheet.href,
-          line_number: @source[0...stylesheet.index].count("\n") + 1
-        )
-      end
-    end
-
-    def stylesheets(source)
-      stylesheet_links = matches(source, LINK_TAG_HREF)
-        .map do |m|
-          Link.new(
-            m[:href].gsub(START_OR_END_QUOTE, ""),
-            m.begin(:href),
-          )
-        end
-
-      stylesheet_tags = matches(source, STYLESHEET_TAG)
-        .map do |m|
-          Link.new(
-            m[0],
-            m.begin(0),
-          )
-        end
-
-      stylesheet_links + stylesheet_tags
-    end
-
-    def href_to_file_size(href)
-      # asset_url (+ optional stylesheet_tag) variables
-      if href =~ /^#{VARIABLE}$/o && href =~ /asset_url/ && href =~ Liquid::QuotedString
-        asset_id = Regexp.last_match(0).gsub(START_OR_END_QUOTE, "")
-        asset = @theme.assets.find { |a| a.name.end_with?("/" + asset_id) }
-        return if asset.nil?
-        asset.gzipped_size
-
-      # remote URLs
-      elsif href =~ %r{^(https?:)?//}
-        asset = RemoteAssetFile.from_src(href)
-        asset.gzipped_size
-      end
+    def on_link(node)
+      return if node.attributes['rel']&.value != "stylesheet"
+      file_size = href_to_file_size(node.attributes['href']&.value)
+      return if file_size.nil?
+      return if file_size <= threshold_in_bytes
+      add_offense(
+        "CSS on every page load exceeding compressed size threshold (#{threshold_in_bytes} Bytes).",
+        node: node
+      )
     end
   end
 end

data/lib/theme_check/checks/asset_size_css_stylesheet_tag.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+module ThemeCheck
+  class AssetSizeCSSStylesheetTag < LiquidCheck
+    include RegexHelpers
+    severity :error
+    category :liquid, :performance
+    doc docs_url(__FILE__)
+
+    def initialize(threshold_in_bytes: 100_000)
+      @threshold_in_bytes = threshold_in_bytes
+    end
+
+    def on_variable(node)
+      used_filters = node.value.filters.map { |name, *_rest| name }
+      return unless used_filters.include?("stylesheet_tag")
+      file_size = href_to_file_size('{{' + node.markup + '}}')
+      return if file_size <= @threshold_in_bytes
+      add_offense(
+        "CSS on every page load exceeding compressed size threshold (#{@threshold_in_bytes} Bytes).",
+        node: node
+      )
+    end
+  end
+end

data/lib/theme_check/checks/asset_size_javascript.rb

@@ -3,52 +3,26 @@ module ThemeCheck
   # Reports errors when trying to use too much JavaScript on page load
   # Encourages the use of the Import on Interaction pattern [1].
   # [1]: https://addyosmani.com/blog/import-on-interaction/
-  class AssetSizeJavaScript < LiquidCheck
+  class AssetSizeJavaScript < HtmlCheck
     include RegexHelpers
     severity :error
-    category :performance
+    category :html, :performance
     doc docs_url(__FILE__)
 
-    Script = Struct.new(:src, :match)
-
-    SCRIPT_TAG_SRC = %r{
-      <script
-        [^>]+                              # any non closing tag character
-        src=                               # src attribute start
-        (?<src>#{QUOTED_LIQUID_ATTRIBUTE}) # src attribute value (may contain liquid)
-        [^>]*                              # any non closing character till the end
-      >
-    }omix
-
     attr_reader :threshold_in_bytes
 
     def initialize(threshold_in_bytes: 10000)
       @threshold_in_bytes = threshold_in_bytes
     end
 
-    def on_document(node)
-      @node = node
-      @source = node.template.source
-      record_offenses
-    end
-
-    def record_offenses
-      scripts(@source).each do |script|
-        file_size = src_to_file_size(script.src)
-        next if file_size.nil?
-        next if file_size <= threshold_in_bytes
-        add_offense(
-          "JavaScript on every page load exceding compressed size threshold (#{threshold_in_bytes} Bytes), consider using the import on interaction pattern.",
-          node: @node,
-          markup: script.src,
-          line_number: @source[0...script.match.begin(:src)].count("\n") + 1
-        )
-      end
-    end
-
-    def scripts(source)
-      matches(source, SCRIPT_TAG_SRC)
-        .map { |m| Script.new(m[:src].gsub(START_OR_END_QUOTE, ""), m) }
+    def on_script(node)
+      file_size = src_to_file_size(node.attributes['src']&.value)
+      return if file_size.nil?
+      return if file_size <= threshold_in_bytes
+      add_offense(
+        "JavaScript on every page load exceeds compressed size threshold (#{threshold_in_bytes} Bytes), consider using the import on interaction pattern.",
+        node: node
+      )
     end
 
     def src_to_file_size(src)

data/lib/theme_check/checks/deprecate_bgsizes.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+module ThemeCheck
+  class DeprecateBgsizes < HtmlCheck
+    severity :suggestion
+    category :html, :performance
+    doc docs_url(__FILE__)
+
+    def on_div(node)
+      class_list = node.attributes["class"]&.value&.split(" ")
+      add_offense("Use the native loading=\"lazy\" attribute instead of lazysizes", node: node) if class_list&.include?("lazyload")
+      add_offense("Use the CSS imageset attribute instead of data-bgset", node: node) if node.attributes["data-bgset"]
+    end
+  end
+end

data/lib/theme_check/checks/deprecate_lazysizes.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+module ThemeCheck
+  class DeprecateLazysizes < HtmlCheck
+    severity :suggestion
+    category :html, :performance
+    doc docs_url(__FILE__)
+
+    def on_img(node)
+      class_list = node.attributes["class"]&.value&.split(" ")
+      add_offense("Use the native loading=\"lazy\" attribute instead of lazysizes", node: node) if class_list&.include?("lazyload")
+      add_offense("Use the native srcset attribute instead of data-srcset", node: node) if node.attributes["data-srcset"]
+      add_offense("Use the native sizes attribute instead of data-sizes", node: node) if node.attributes["data-sizes"]
+      add_offense("Do not set the data-sizes attribute to auto", node: node) if node.attributes["data-sizes"]&.value == "auto"
+    end
+  end
+end

data/lib/theme_check/checks/img_lazy_loading.rb

@@ -10,12 +10,7 @@ module ThemeCheck
     def on_img(node)
       loading = node.attributes["loading"]&.value&.downcase
       return if ACCEPTED_LOADING_VALUES.include?(loading)
-
-      class_list = node.attributes["class"]&.value&.split(" ")
-
-      if class_list&.include?("lazyload")
-        add_offense("Use the native loading=\"lazy\" attribute instead of lazysizes", node: node)
-      elsif loading == "auto"
+      if loading == "auto"
         add_offense("Prefer loading=\"lazy\" to defer loading of images", node: node)
       else
         add_offense("Add a loading=\"lazy\" attribute to defer loading of images", node: node)

data/lib/theme_check/checks/liquid_tag.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 module ThemeCheck
-  # Recommends using {% liquid ... %} if 4 or more consecutive {% ... %} are found.
+  # Recommends using {% liquid ... %} if 5 or more consecutive {% ... %} are found.
   class LiquidTag < LiquidCheck
     severity :suggestion
     category :liquid
     doc docs_url(__FILE__)
 
-    def initialize(min_consecutive_statements: 4)
+    def initialize(min_consecutive_statements: 5)
       @first_statement = nil
       @consecutive_statements = 0
       @min_consecutive_statements = min_consecutive_statements

data/lib/theme_check/checks/remote_asset.rb

@@ -9,6 +9,7 @@ module ThemeCheck
     PROTOCOL = %r{(https?:)?//}
     ABSOLUTE_PATH = %r{\A/[^/]}im
     RELATIVE_PATH = %r{\A(?!#{PROTOCOL})[^/\{]}oim
+    CDN_ROOT = "https://cdn.shopify.com/"
 
     def on_element(node)
       return unless TAGS.include?(node.name)
@@ -17,6 +18,7 @@ module ThemeCheck
       return if resource_url.nil? || resource_url.empty?
 
       # Ignore if URL is Liquid, taken care of by AssetUrlFilters check
+      return if resource_url.start_with?(CDN_ROOT)
       return if resource_url =~ ABSOLUTE_PATH
       return if resource_url =~ RELATIVE_PATH
       return if url_hosted_by_shopify?(resource_url)

data/lib/theme_check/checks/template_length.rb

@@ -5,9 +5,11 @@ module ThemeCheck
     category :liquid
     doc docs_url(__FILE__)
 
-    def initialize(max_length: 200, exclude_schema: true)
+    def initialize(max_length: 500, exclude_schema: true, exclude_stylesheet: true, exclude_javascript: true)
       @max_length = max_length
       @exclude_schema = exclude_schema
+      @exclude_stylesheet = exclude_stylesheet
+      @exclude_javascript = exclude_javascript
     end
 
     def on_document(_node)
@@ -15,9 +17,15 @@ module ThemeCheck
     end
 
     def on_schema(node)
-      if @exclude_schema
-        @excluded_lines += node.value.nodelist.join.count("\n")
-      end
+      exclude_node_lines(node) if @exclude_schema
+    end
+
+    def on_stylesheet(node)
+      exclude_node_lines(node) if @exclude_stylesheet
+    end
+
+    def on_javascript(node)
+      exclude_node_lines(node) if @exclude_javascript
     end
 
     def after_document(node)
@@ -26,5 +34,11 @@ module ThemeCheck
         add_offense("Template has too many lines [#{lines}/#{@max_length}]", template: node.template)
       end
     end
+
+    private
+
+    def exclude_node_lines(node)
+      @excluded_lines += node.value.nodelist.join.count("\n")
+    end
   end
 end

data/lib/theme_check/html_check.rb

@@ -3,5 +3,7 @@
 module ThemeCheck
   class HtmlCheck < Check
     extend ChecksTracking
+    VARIABLE = /#{Liquid::VariableStart}.*?#{Liquid::VariableEnd}/om
+    START_OR_END_QUOTE = /(^['"])|(['"]$)/
   end
 end

data/lib/theme_check/liquid_check.rb

@@ -5,17 +5,5 @@ module ThemeCheck
   class LiquidCheck < Check
     extend ChecksTracking
     include ParsingHelpers
-
-    # TODO: remove this once all regex checks are migrate to HtmlCheck# TODO: remove this once all regex checks are migrate to HtmlCheck
-    TAG = /#{Liquid::TagStart}.*?#{Liquid::TagEnd}/om
-    VARIABLE = /#{Liquid::VariableStart}.*?#{Liquid::VariableEnd}/om
-    START_OR_END_QUOTE = /(^['"])|(['"]$)/
-    QUOTED_LIQUID_ATTRIBUTE = %r{
-      '(?:#{TAG}|#{VARIABLE}|[^'])*'| # any combination of tag/variable or non straight quote inside straight quotes
-      "(?:#{TAG}|#{VARIABLE}|[^"])*"  # any combination of tag/variable or non double quotes inside double quotes
-    }omix
-    ATTR = /[a-z0-9-]+/i
-    HTML_ATTRIBUTE = /#{ATTR}(?:=#{QUOTED_LIQUID_ATTRIBUTE})?/omix
-    HTML_ATTRIBUTES = /(?:#{HTML_ATTRIBUTE}|\s)*/omix
   end
 end

data/lib/theme_check/parsing_helpers.rb

@@ -7,8 +7,10 @@ module ThemeCheck
 
       while scanner.scan(/.*?("|')/)
         yield scanner.matched[0..-2]
+        quote = scanner.matched[-1] == "'" ? "'" : "\""
         # Skip to the end of the string
-        scanner.skip_until(scanner.matched[-1] == "'" ? /[^\\]'/ : /[^\\]"/)
+        # Check for empty string first, since follow regexp uses lookahead
+        scanner.skip(/#{quote}/) || scanner.skip_until(/[^\\]#{quote}/)
       end
 
       yield scanner.rest if scanner.rest?

data/lib/theme_check/regex_helpers.rb

@@ -2,6 +2,8 @@
 
 module ThemeCheck
   module RegexHelpers
+    VARIABLE = /#{Liquid::VariableStart}.*?#{Liquid::VariableEnd}/om
+    START_OR_END_QUOTE = /(^['"])|(['"]$)/
     def matches(s, re)
       start_at = 0
       matches = []
@@ -11,5 +13,20 @@ module ThemeCheck
       end
       matches
     end
+
+    def href_to_file_size(href)
+      # asset_url (+ optional stylesheet_tag) variables
+      if href =~ /^#{VARIABLE}$/o && href =~ /asset_url/ && href =~ Liquid::QuotedString
+        asset_id = Regexp.last_match(0).gsub(START_OR_END_QUOTE, "")
+        asset = @theme.assets.find { |a| a.name.end_with?("/" + asset_id) }
+        return if asset.nil?
+        asset.gzipped_size
+
+      # remote URLs
+      elsif href =~ %r{^(https?:)?//}
+        asset = RemoteAssetFile.from_src(href)
+        asset.gzipped_size
+      end
+    end
   end
 end

data/lib/theme_check/tags.rb

@@ -125,6 +125,42 @@ module ThemeCheck
       end
     end
 
+    class Render < Liquid::Tag
+      SYNTAX = /((?:#{Liquid::QuotedString}|#{Liquid::VariableSegment})+)(\s+(with|#{Liquid::Render::FOR})\s+(#{Liquid::QuotedFragment}+))?(\s+(?:as)\s+(#{Liquid::VariableSegment}+))?/o
+
+      disable_tags "include"
+
+      attr_reader :template_name_expr, :attributes
+
+      def initialize(tag_name, markup, options)
+        super
+
+        raise SyntaxError, options[:locale].t("errors.syntax.render") unless markup =~ SYNTAX
+
+        template_name = Regexp.last_match(1)
+        with_or_for = Regexp.last_match(3)
+        variable_name = Regexp.last_match(4)
+
+        @alias_name = Regexp.last_match(6)
+        @variable_name_expr = variable_name ? parse_expression(variable_name) : nil
+        @template_name_expr = parse_expression(template_name)
+        @for = (with_or_for == Liquid::Render::FOR)
+
+        @attributes = {}
+        markup.scan(Liquid::TagAttributes) do |key, value|
+          @attributes[key] = parse_expression(value)
+        end
+      end
+
+      class ParseTreeVisitor < Liquid::ParseTreeVisitor
+        def children
+          [
+            @node.template_name_expr,
+          ] + @node.attributes.values
+        end
+      end
+    end
+
     class Style < Liquid::Block; end
 
     class Schema < Liquid::Raw; end
@@ -135,6 +171,7 @@ module ThemeCheck
 
     Liquid::Template.register_tag('form', Form)
     Liquid::Template.register_tag('layout', Layout)
+    Liquid::Template.register_tag('render', Render)
     Liquid::Template.register_tag('paginate', Paginate)
     Liquid::Template.register_tag('section', Section)
     Liquid::Template.register_tag('style', Style)

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.10.2"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-06-18 00:00:00.000000000 Z
+date: 2021-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -75,11 +75,14 @@ files:
 - docs/api/liquid_check.md
 - docs/checks/TEMPLATE.md.erb
 - docs/checks/asset_size_css.md
+- docs/checks/asset_size_css_stylesheet_tag.md
 - docs/checks/asset_size_javascript.md
 - docs/checks/asset_url_filters.md
 - docs/checks/content_for_header_modification.md
 - docs/checks/convert_include_to_render.md
 - docs/checks/default_locale.md
+- docs/checks/deprecate_bgsizes.md
+- docs/checks/deprecate_lazysizes.md
 - docs/checks/deprecated_filter.md
 - docs/checks/html_parsing_error.md
 - docs/checks/img_lazy_loading.md
@@ -118,11 +121,14 @@ files:
 - lib/theme_check/checks.rb
 - lib/theme_check/checks/TEMPLATE.rb.erb
 - lib/theme_check/checks/asset_size_css.rb
+- lib/theme_check/checks/asset_size_css_stylesheet_tag.rb
 - lib/theme_check/checks/asset_size_javascript.rb
 - lib/theme_check/checks/asset_url_filters.rb
 - lib/theme_check/checks/content_for_header_modification.rb
 - lib/theme_check/checks/convert_include_to_render.rb
 - lib/theme_check/checks/default_locale.rb
+- lib/theme_check/checks/deprecate_bgsizes.rb
+- lib/theme_check/checks/deprecate_lazysizes.rb
 - lib/theme_check/checks/deprecated_filter.rb
 - lib/theme_check/checks/html_parsing_error.rb
 - lib/theme_check/checks/img_lazy_loading.rb
@@ -227,7 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.17
+rubygems_version: 3.2.20
 signing_key: 
 specification_version: 4
 summary: A Shopify Theme Linter