theme-check 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e51f58be8347c6d602ef2f5f6385117f1c8ad5d07a66c111c8c8bf623008f3b1
-  data.tar.gz: 88eb1fbc392ff70251255f5aa681e6e7bf37fbc1c0a65bc1651e291c13baf5d9
+  metadata.gz: 4001e286b9a0c851493de76250770565088d1d8f646a6e592ee3f2c142b47c3c
+  data.tar.gz: 3c3cd833684e0020211365eec091b70be3a064ae72f4c1d7337908fbfdbdacd8
 SHA512:
-  metadata.gz: 0c7865cb5cb44da5811b78429d34c3309264ba21f55954a83b97784e15375798794461c0d19edfe620e8cbed45b6b8a80d63755b258505acb4c2b61bbae77e4a
-  data.tar.gz: 625963de20e85bc5b27989fba14a9a8243aafffc21aba5f4ea54b8e937fba05f73df99549a6b6b575dd29b7df48319c054aa2089e98c31e1e8212b1521c73c04
+  metadata.gz: 35855ff5a3e10f8a8dc60cc40d619fe713f013eb8ee64f92c565c34e3a3b58b9646ca1b707535f777e53cabae1dd58facc2adc4722e5c704b11ff70d9407e959
+  data.tar.gz: fb9f94add954ec84a0fb8ca6616e8d91981701ff0d62f5dc89692dcd4ddf7715073db531dc81ec7dd1c8a4fc8df93360adbc32ee02254d8538a027236995cbdf

data/.gitignore

@@ -11,3 +11,4 @@
 Gemfile.lock
 
 .rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml
+packaging/builds

data/README.md

@@ -4,7 +4,7 @@ Think RuboCop, or eslint, but for Shopify themes.
 
 Theme Check is a command line tool that helps you follow Shopify Themes & Liquid best practices by analyzing the Liquid & JSON inside your theme.
 
-Theme Check is also available [inside some code editors](https://github.com/Shopify/theme-check/wiki).
+Code editor support coming soon!
 
 ![](docs/preview.png)
 
@@ -31,12 +31,30 @@ Theme Check currently checks for the following:
 ✅ Using unknown translation keys in `{{ 'missing_key' | t }}`  
 ✅ Using several `{% ... %}` instead of `{% liquid ... %}`  
 ✅ Undefined [objects](https://shopify.dev/docs/themes/liquid/reference/objects)
+✅ Deprecated filters  
 
 And many more to come! Suggestions welcome ([create an issue](https://github.com/Shopify/theme-check/issues)).
 
+## Requirements
+
+- Ruby 2.7+
+
 ## Installation
 
+Theme Check is available through Homebrew _or_ RubyGems.
+
+**Homebrew**
+
+You’ll need to run `brew tap` first to add Shopify’s third-party repositories to Homebrew.
+
+```sh
+brew tap shopify/shopify
+brew install theme-check
 ```
+
+**RubyGems**
+
+```sh
 gem install theme-check
 ```
 

data/Rakefile

@@ -12,3 +12,17 @@ end
 RuboCop::RakeTask.new
 
 task default: [:test, :rubocop]
+
+namespace :package do
+  require 'theme_check/packager'
+
+  task all: [:homebrew]
+
+  desc("Builds a Homebrew package of the CLI")
+  task :homebrew do
+    ThemeCheck::Packager.new.build_homebrew
+  end
+end
+
+desc("Builds all distribution packages of the CLI")
+task(package: 'package:all')

data/config/default.yml

@@ -57,7 +57,10 @@ MissingRequiredTemplateFiles:
   enabled: true
 
 UndefinedObject:
-  enabled: false
+  enabled: true
 
 RequiredDirectories:
   enabled: true
+
+DeprecatedFilter:
+  enabled: true

data/data/shopify_liquid/deprecated_filters.yml

@@ -0,0 +1,10 @@
+---
+Liquid::ColorFilter:
+  hex_to_rgba:
+    - color_to_rgb
+    - color_modify
+Liquid::UrlFilter:
+  collection_img_url:
+    - img_url
+  product_img_url:
+    - img_url

data/lib/theme_check.rb

@@ -21,5 +21,6 @@ require_relative "theme_check/tags"
 require_relative "theme_check/template"
 require_relative "theme_check/theme"
 require_relative "theme_check/visitor"
+require_relative "theme_check/corrector"
 
 Dir[__dir__ + "/theme_check/checks/*.rb"].each { |file| require file }

data/lib/theme_check/analyzer.rb

@@ -3,9 +3,10 @@ module ThemeCheck
   class Analyzer
     attr_reader :offenses
 
-    def initialize(theme, checks = Check.all.map(&:new))
+    def initialize(theme, checks = Check.all.map(&:new), auto_correct = false)
       @theme = theme
       @offenses = []
+      @auto_correct = auto_correct
 
       @liquid_checks = Checks.new
       @json_checks = Checks.new
@@ -39,5 +40,20 @@ module ThemeCheck
       analyze_theme
       @offenses.reject! { |offense| offense.template.path != path }
     end
+
+    def uncorrectable_offenses
+      unless @auto_correct
+        return @offenses
+      end
+
+      @offenses.select { |offense| !offense.correctable? }
+    end
+
+    def correct_offenses
+      if @auto_correct
+        @offenses.each(&:correct)
+        @theme.liquid.each(&:write)
+      end
+    end
   end
 end

data/lib/theme_check/checks/deprecated_filter.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+module ThemeCheck
+  class DeprecatedFilter < LiquidCheck
+    doc "https://shopify.dev/docs/themes/liquid/reference/filters/deprecated-filters"
+    category :liquid
+    severity :suggestion
+
+    def on_variable(node)
+      used_filters = node.value.filters.map { |name, *_rest| name }
+      used_filters.each do |filter|
+        alternatives = ShopifyLiquid::DeprecatedFilter.alternatives(filter)
+        next unless alternatives
+
+        alternatives = alternatives.map { |alt| "`#{alt}`" }
+        add_offense(
+          "Deprecated filter `#{filter}`, consider using an alternative: #{alternatives.join(', ')}",
+          node: node,
+        )
+      end
+    end
+  end
+end

data/lib/theme_check/checks/space_inside_braces.rb

@@ -45,13 +45,24 @@ module ThemeCheck
     def on_variable(node)
       return if @ignore
       if node.markup[0] != " "
-        add_offense("Space missing after '{{'", node: node)
-      elsif node.markup[-1] != " "
-        add_offense("Space missing before '}}'", node: node)
-      elsif node.markup[1] == " "
-        add_offense("Too many spaces after '{{'", node: node)
-      elsif node.markup[-2] == " "
-        add_offense("Too many spaces before '}}'", node: node)
+        add_offense("Space missing after '{{'", node: node) do |corrector|
+          corrector.insert_before(node, " ")
+        end
+      end
+      if node.markup[-1] != " "
+        add_offense("Space missing before '}}'", node: node) do |corrector|
+          corrector.insert_after(node, " ")
+        end
+      end
+      if node.markup[0] == " " && node.markup[1] == " "
+        add_offense("Too many spaces after '{{'", node: node) do |corrector|
+          corrector.replace(node, " #{node.markup.lstrip}")
+        end
+      end
+      if node.markup[-1] == " " && node.markup[-2] == " "
+        add_offense("Too many spaces before '}}'", node: node) do |corrector|
+          corrector.replace(node, "#{node.markup.rstrip} ")
+        end
       end
     end
   end

data/lib/theme_check/checks/undefined_object.rb

@@ -11,76 +11,141 @@ module ThemeCheck
         @all_assigns = {}
         @all_captures = {}
         @all_forloops = {}
+        @all_renders = {}
       end
 
-      attr_reader :all_variable_lookups, :all_assigns, :all_captures, :all_forloops
-      def all
+      attr_reader :all_assigns, :all_captures, :all_forloops
+
+      def add_render(name:, node:)
+        @all_renders[name] = node
+      end
+
+      def add_variable_lookup(name:, node:)
+        line_number = node.parent.line_number
+        key = [name, line_number]
+        @all_variable_lookups[key] = node
+      end
+
+      def all_variables
         all_assigns.keys + all_captures.keys + all_forloops.keys
       end
+
+      def each_snippet
+        @all_renders.each do |(name, info)|
+          yield [name, info]
+        end
+      end
+
+      def each_variable_lookup(unique_keys = false)
+        seen = Set.new
+        @all_variable_lookups.each do |(key, info)|
+          name, _line_number = key
+
+          next if unique_keys && seen.include?(name)
+          seen << name
+
+          yield [key, info]
+        end
+      end
     end
 
     def initialize
-      @templates = {}
-      @used_snippets = {}
+      @files = {}
     end
 
     def on_document(node)
-      @templates[node.template.name] = TemplateInfo.new
+      @files[node.template.name] = TemplateInfo.new
     end
 
     def on_assign(node)
-      @templates[node.template.name].all_assigns[node.value.to] = node
+      @files[node.template.name].all_assigns[node.value.to] = node
     end
 
     def on_capture(node)
-      @templates[node.template.name].all_captures[node.value.instance_variable_get('@to')] = node
+      @files[node.template.name].all_captures[node.value.instance_variable_get('@to')] = node
     end
 
     def on_for(node)
-      @templates[node.template.name].all_forloops[node.value.variable_name] = node
+      @files[node.template.name].all_forloops[node.value.variable_name] = node
+    end
+
+    def on_include(_node)
+      # NOOP: we purposely do nothing on `include` since it is deprecated
+      #   https://shopify.dev/docs/themes/liquid/reference/tags/deprecated-tags#include
     end
 
-    def on_include(node)
+    def on_render(node)
       return unless node.value.template_name_expr.is_a?(String)
-      name = "snippets/#{node.value.template_name_expr}"
-      @used_snippets[name] ||= Set.new
-      @used_snippets[name] << node.template.name
+
+      snippet_name = "snippets/#{node.value.template_name_expr}"
+      @files[node.template.name].add_render(
+        name: snippet_name,
+        node: node,
+      )
     end
 
     def on_variable_lookup(node)
-      @templates[node.template.name].all_variable_lookups[node.value.name] = node
+      @files[node.template.name].add_variable_lookup(
+        name: node.value.name,
+        node: node,
+      )
     end
 
     def on_end
-      foster_snippets = theme.snippets
-        .reject { |t| @used_snippets.include?(t.name) }
-        .map(&:name)
-
-      @templates.each do |(template_name, info)|
-        next if foster_snippets.include?(template_name)
-        if (all_including_templates = @used_snippets[template_name])
-          all_including_templates.each do |including_template|
-            including_template_info = @templates[including_template]
-            check_object(info.all_variable_lookups, including_template_info.all)
-          end
+      all_global_objects = ThemeCheck::ShopifyLiquid::Object.labels
+      all_global_objects.freeze
+
+      each_template do |(name, info)|
+        if 'templates/customers/reset_password' == name
+          # NOTE: `email` is exceptionally exposed as a theme object in
+          #       the customers' reset password template
+          check_object(info, all_global_objects + ['email'])
         else
-          all = info.all
-          all += ['email'] if 'templates/customers/reset_password' == template_name
-          check_object(info.all_variable_lookups, all)
+          check_object(info, all_global_objects)
         end
       end
     end
 
-    def check_object(variable_lookups, all)
-      variable_lookups.each do |(name, node)|
-        next if all.include?(name)
-        next if ThemeCheck::ShopifyLiquid::Object.labels.include?(name)
+    def each_template
+      @files.each do |(name, info)|
+        next if name.starts_with?('snippets/')
+        yield [name, info]
+      end
+    end
+    private :each_template
 
-        parent = node.parent
-        parent = parent.parent if :variable_lookup == parent.type_name
-        add_offense("Undefined object `#{name}`", node: parent)
+    def check_object(info, all_global_objects, render_node = nil)
+      check_undefined(info, all_global_objects, render_node)
+
+      info.each_snippet do |(snippet_name, node)|
+        snippet_info = @files[snippet_name]
+        next unless snippet_info # NOTE: undefined snippet
+
+        snippet_variables = node.value.attributes.keys +
+          Array[node.value.instance_variable_get("@alias_name")]
+        check_object(snippet_info, all_global_objects + snippet_variables, node)
       end
     end
     private :check_object
+
+    def check_undefined(info, all_global_objects, render_node)
+      all_variables = info.all_variables
+
+      info.each_variable_lookup(!!render_node) do |(key, node)|
+        name, _line_number = key
+        next if all_variables.include?(name)
+        next if all_global_objects.include?(name)
+
+        node = node.parent
+        node = node.parent if %i(condition variable_lookup).include?(node.type_name)
+
+        if render_node
+          add_offense("Missing argument `#{name}`", node: render_node)
+        else
+          add_offense("Undefined object `#{name}`", node: node)
+        end
+      end
+    end
+    private :check_undefined
   end
 end

data/lib/theme_check/cli.rb

@@ -10,6 +10,7 @@ module ThemeCheck
         -c, [--category]          # Only run this category of checks
         -x, [--exclude-category]  # Exclude this category of checks
         -l, [--list]              # List enabled checks
+        -a, [--auto-correct]      # Automatically fix offenses
         -h, [--help]              # Show this. Hi!
 
       Description:
@@ -25,6 +26,7 @@ module ThemeCheck
       command = :check
       only_categories = []
       exclude_categories = []
+      auto_correct = false
 
       args = argv.dup
       while (arg = args.shift)
@@ -37,6 +39,8 @@ module ThemeCheck
           exclude_categories << args.shift.to_sym
         when "--list", "-l"
           command = :list
+        when "--auto-correct", "-a"
+          auto_correct = true
         else
           path = arg
         end
@@ -45,6 +49,7 @@ module ThemeCheck
       @config = ThemeCheck::Config.from_path(path)
       @config.only_categories = only_categories
       @config.exclude_categories = exclude_categories
+      @config.auto_correct = auto_correct
 
       send(command)
     end
@@ -69,10 +74,11 @@ module ThemeCheck
       if theme.all.empty?
         raise Abort, "No templates found.\n#{USAGE}"
       end
-      analyzer = ThemeCheck::Analyzer.new(theme, @config.enabled_checks)
+      analyzer = ThemeCheck::Analyzer.new(theme, @config.enabled_checks, @config.auto_correct)
       analyzer.analyze_theme
-      ThemeCheck::Printer.new.print(theme, analyzer.offenses)
-      raise Abort, "" if analyzer.offenses.any?
+      analyzer.correct_offenses
+      ThemeCheck::Printer.new.print(theme, analyzer.offenses, @config.auto_correct)
+      raise Abort, "" if analyzer.uncorrectable_offenses.any?
     end
   end
 end

data/lib/theme_check/config.rb

@@ -6,7 +6,7 @@ module ThemeCheck
     DEFAULT_CONFIG = "#{__dir__}/../../config/default.yml"
 
     attr_reader :root
-    attr_accessor :only_categories, :exclude_categories
+    attr_accessor :only_categories, :exclude_categories, :auto_correct
 
     class << self
       def from_path(path)
@@ -40,6 +40,7 @@ module ThemeCheck
       end
       @only_categories = []
       @exclude_categories = []
+      @auto_correct = false
       resolve_requires
     end
 

data/lib/theme_check/corrector.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module ThemeCheck
+  class Corrector
+    def initialize(template:)
+      @template = template
+    end
+
+    def insert_after(node, content)
+      line = @template.full_line(node.line_number)
+      line.insert(node.range[1] + 1, content)
+      @template.update!
+    end
+
+    def insert_before(node, content)
+      line = @template.full_line(node.line_number)
+      line.insert(node.range[0], content)
+      @template.update!
+    end
+
+    def replace(node, content)
+      line = @template.full_line(node.line_number)
+      line[node.range[0]..node.range[1]] = content
+      node.markup = content
+      @template.update!
+    end
+
+    def wrap(node, insert_before, insert_after)
+      line = @template.full_line(node.line_number)
+      line.insert(node.range[0], insert_before)
+      line.insert(node.range[1] + 1 + insert_before.length, insert_after)
+      @template.update!
+    end
+  end
+end

data/lib/theme_check/liquid_check.rb

@@ -6,8 +6,8 @@ module ThemeCheck
     extend ChecksTracking
     include ParsingHelpers
 
-    def add_offense(message, node: nil, template: node&.template, markup: nil, line_number: nil)
-      offenses << Offense.new(check: self, message: message, template: template, node: node, markup: markup, line_number: line_number)
+    def add_offense(message, node: nil, template: node&.template, markup: nil, line_number: nil, &block)
+      offenses << Offense.new(check: self, message: message, template: template, node: node, markup: markup, line_number: line_number, correction: block)
     end
   end
 end

data/lib/theme_check/node.rb

@@ -22,6 +22,14 @@ module ThemeCheck
       end
     end
 
+    def markup=(markup)
+      if tag?
+        @value.raw = markup
+      elsif @value.instance_variable_defined?(:@markup)
+        @value.instance_variable_set(:@markup, markup)
+      end
+    end
+
     # Array of children nodes.
     def children
       @children ||= begin
@@ -113,5 +121,10 @@ module ThemeCheck
         false
       end
     end
+
+    def range
+      start = template.full_line(line_number).index(markup)
+      [start, start + markup.length - 1]
+    end
   end
 end

data/lib/theme_check/offense.rb

@@ -3,10 +3,11 @@ module ThemeCheck
   class Offense
     MAX_SOURCE_EXCERPT_SIZE = 120
 
-    attr_reader :check, :message, :template, :node, :markup, :line_number
+    attr_reader :check, :message, :template, :node, :markup, :line_number, :correction
 
-    def initialize(check:, message: nil, template: nil, node: nil, markup: nil, line_number: nil)
+    def initialize(check:, message: nil, template: nil, node: nil, markup: nil, line_number: nil, correction: nil)
       @check = check
+      @correction = correction
 
       if message
         @message = message
@@ -39,7 +40,7 @@ module ThemeCheck
     def source_excerpt
       return unless line_number
       @source_excerpt ||= begin
-        excerpt = template.excerpt(line_number)
+        excerpt = template.source_excerpt(line_number)
         if excerpt.size > MAX_SOURCE_EXCERPT_SIZE
           excerpt[0, MAX_SOURCE_EXCERPT_SIZE - 3] + '...'
         else
@@ -54,18 +55,22 @@ module ThemeCheck
     end
 
     def end_line
-      return 0 unless line_number
-      line_number - 1
+      if markup
+        start_line + markup.count("\n")
+      else
+        start_line
+      end
     end
 
     def start_column
-      return 0 unless line_number
-      template.full_line(line_number).index(markup)
+      return 0 unless line_number && markup
+      template.full_line(start_line + 1).index(markup.split("\n", 2).first)
     end
 
     def end_column
-      return 0 unless line_number
-      template.full_line(line_number).index(markup) + markup.size
+      return 0 unless line_number && markup
+      markup_end = markup.split("\n").last
+      template.full_line(end_line + 1).index(markup_end) + markup_end.size
     end
 
     def code_name
@@ -93,6 +98,17 @@ module ThemeCheck
       tokens.join(":") if tokens.any?
     end
 
+    def correctable?
+      line_number && correction
+    end
+
+    def correct
+      if correctable?
+        corrector = Corrector.new(template: template)
+        correction.call(corrector)
+      end
+    end
+
     def to_s
       if template
         "#{message} at #{location}"

data/lib/theme_check/packager.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+module ThemeCheck
+  class Packager
+    ROOT = File.expand_path('../../..', __FILE__)
+    PACKAGING_DIR = File.join(ROOT, 'packaging')
+    BUILDS_DIR = File.join(PACKAGING_DIR, 'builds', ThemeCheck::VERSION)
+
+    def initialize
+      FileUtils.mkdir_p(BUILDS_DIR)
+    end
+
+    def build_homebrew
+      root_dir = File.join(PACKAGING_DIR, 'homebrew')
+
+      build_path = File.join(BUILDS_DIR, "theme-check.rb")
+      puts "\nBuilding Homebrew package"
+
+      puts "Generating formula..."
+      File.delete(build_path) if File.exist?(build_path)
+
+      spec_contents = File.read(File.join(root_dir, 'theme_check.base.rb'))
+      spec_contents = spec_contents.gsub('THEME_CHECK_VERSION', ThemeCheck::VERSION)
+
+      puts "Grabbing sha256 checksum from Rubygems.org"
+      require 'digest/sha2'
+      require 'open-uri'
+      gem_checksum = open("https://rubygems.org/downloads/theme-check-#{ThemeCheck::VERSION}.gem") do |io|
+        Digest::SHA256.new.hexdigest(io.read)
+      end
+
+      puts "Got sha256 checksum for gem: #{gem_checksum}"
+      spec_contents = spec_contents.gsub('THEME_CHECK_GEM_CHECKSUM', gem_checksum)
+
+      puts "Writing generated formula\n  To: #{build_path}\n\n"
+      File.write(build_path, spec_contents)
+    end
+
+    private
+
+    def ensure_program_installed(program, installation_cmd)
+      unless system(program, '--version', out: File::NULL, err: File::NULL)
+        raise <<~MESSAGE
+
+          Could not find program #{program} which is required to build the package.
+          You can install it by running `#{installation_cmd}`.
+
+        MESSAGE
+      end
+    end
+  end
+end

data/lib/theme_check/printer.rb

@@ -2,25 +2,34 @@
 
 module ThemeCheck
   class Printer
-    def print(theme, offenses)
+    def print(theme, offenses, auto_correct)
       offenses.each do |offense|
-        print_offense(offense)
+        print_offense(offense, auto_correct)
         puts
       end
 
-      puts "#{theme.all.size} files inspected, #{red(offenses.size.to_s + ' offenses')} detected"
+      correctable = offenses.select(&:correctable?)
+      puts "#{theme.all.size} files inspected, #{red(offenses.size.to_s + ' offenses')} detected, \
+#{yellow(correctable.size.to_s + ' offenses')} #{auto_correct ? 'corrected' : 'auto-correctable'}"
     end
 
-    def print_offense(offense)
+    def print_offense(offense, auto_correct)
       location = if offense.location
         blue(offense.location) + ": "
       else
         ""
       end
 
+      corrected = if auto_correct && offense.correctable?
+        green("[Corrected] ")
+      else
+        ""
+      end
+
       puts location +
         colorized_severity(offense.severity) + ": " +
         yellow(offense.check_name) + ": " +
+        corrected +
         offense.message + "."
       if offense.source_excerpt
         puts "\t#{offense.source_excerpt}"

data/lib/theme_check/shopify_liquid.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+require_relative 'shopify_liquid/deprecated_filter'
 require_relative 'shopify_liquid/filter'
 require_relative 'shopify_liquid/object'

data/lib/theme_check/shopify_liquid/deprecated_filter.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+require 'yaml'
+
+module ThemeCheck
+  module ShopifyLiquid
+    module DeprecatedFilter
+      extend self
+
+      def alternatives(filter)
+        all.fetch(filter, nil)
+      end
+
+      private
+
+      def all
+        @all ||= begin
+          YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/deprecated_filters.yml"))
+            .values
+            .each_with_object({}) do |filters, acc|
+              filters.each do |(filter, alternatives)|
+                acc[filter] = alternatives
+              end
+            end
+        end
+      end
+    end
+  end
+end

data/lib/theme_check/template.rb

@@ -8,6 +8,7 @@ module ThemeCheck
     def initialize(path, root)
       @path = Pathname(path)
       @root = Pathname(root)
+      @updated = false
     end
 
     def relative_path
@@ -35,13 +36,19 @@ module ThemeCheck
     end
 
     def lines
-      @lines ||= source.split("\n")
+      # Retain trailing newline character
+      @lines ||= source.split("\n", -1)
     end
 
     def excerpt(line)
       lines[line - 1].strip
     end
 
+    def source_excerpt(line)
+      original_lines = source.split("\n")
+      original_lines[line - 1].strip
+    end
+
     def full_line(line)
       lines[line - 1]
     end
@@ -58,6 +65,16 @@ module ThemeCheck
       parse.root
     end
 
+    def update!
+      @updated = true
+    end
+
+    def write
+      if @updated
+        @path.write(lines.join("\n"))
+      end
+    end
+
     def ==(other)
       other.is_a?(Template) && @path == other.path
     end

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/packaging/homebrew/theme_check.base.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require 'formula'
+require 'fileutils'
+
+class ThemeCheck < Formula
+  module RubyBin
+    def ruby_bin
+      Formula["ruby"].opt_bin
+    end
+  end
+
+  class RubyGemsDownloadStrategy < AbstractDownloadStrategy
+    include RubyBin
+
+    def fetch
+      ohai("Fetching theme-check from gem source")
+      cache.cd do
+        ENV['GEM_SPEC_CACHE'] = "#{cache}/gem_spec_cache"
+        system("#{ruby_bin}/gem", "fetch", "theme-check", "--version", gem_version)
+      end
+    end
+
+    def cached_location
+      Pathname.new("#{cache}/theme-check-#{gem_version}.gem")
+    end
+
+    def cache
+      @cache ||= HOMEBREW_CACHE
+    end
+
+    def gem_version
+      return @version if defined?(@version) && @version
+      @version = @resource.version if defined?(@resource)
+      raise "Unable to determine version; did Homebrew change?" unless @version
+      @version
+    end
+
+    def clear_cache
+      cached_location.unlink if cached_location.exist?
+    end
+  end
+
+  include RubyBin
+
+  url "theme-check", using: RubyGemsDownloadStrategy
+  version "THEME_CHECK_VERSION"
+  sha256 'THEME_CHECK_GEM_CHECKSUM'
+  depends_on "ruby"
+
+  def install
+    # set GEM_HOME and GEM_PATH to make sure we package all the dependent gems
+    # together without accidently picking up other gems on the gem path since
+    # they might not be there if, say, we change to a different rvm gemset
+    ENV['GEM_HOME'] = prefix.to_s
+    ENV['GEM_PATH'] = prefix.to_s
+
+    # Use /usr/local/bin at the front of the path instead of Homebrew shims,
+    # which mess with Ruby's own compiler config when building native extensions
+    if defined?(HOMEBREW_SHIMS_PATH)
+      ENV['PATH'] = ENV['PATH'].sub(HOMEBREW_SHIMS_PATH.to_s, '/usr/local/bin')
+    end
+
+    system("#{ruby_bin}/gem", "install", cached_download,
+             "--no-document",
+             "--no-wrapper",
+             "--no-user-install",
+             "--install-dir", prefix,
+             "--bindir", bin)
+
+    raise "gem install 'theme-check' failed with status #{$CHILD_STATUS.exitstatus}" unless $CHILD_STATUS.success?
+
+    bin.rmtree if bin.exist?
+    bin.mkpath
+
+    brew_gem_prefix = "#{prefix}/gems/theme-check-#{version}"
+
+    gemspec = Gem::Specification.load("#{prefix}/specifications/theme-check-#{version}.gemspec")
+    ruby_libs = Dir.glob("#{prefix}/gems/*/lib")
+    gemspec.executables.each do |exe|
+      file = Pathname.new("#{brew_gem_prefix}/#{gemspec.bindir}/#{exe}")
+      (bin + file.basename).open('w') do |f|
+        f << <<~RUBY
+          #!#{ruby_bin}/ruby --disable-gems
+          ENV['GEM_HOME']="#{prefix}"
+          ENV['GEM_PATH']="#{prefix}"
+          require 'rubygems'
+          $:.unshift(#{ruby_libs.map(&:inspect).join(',')})
+          load "#{file}"
+        RUBY
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-06 00:00:00.000000000 Z
+date: 2021-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -74,6 +74,7 @@ files:
 - Rakefile
 - bin/liquid-server
 - config/default.yml
+- data/shopify_liquid/deprecated_filters.yml
 - data/shopify_liquid/filters.yml
 - data/shopify_liquid/objects.yml
 - dev.yml
@@ -86,6 +87,7 @@ files:
 - lib/theme_check/checks.rb
 - lib/theme_check/checks/convert_include_to_render.rb
 - lib/theme_check/checks/default_locale.rb
+- lib/theme_check/checks/deprecated_filter.rb
 - lib/theme_check/checks/liquid_tag.rb
 - lib/theme_check/checks/matching_schema_translations.rb
 - lib/theme_check/checks/matching_translations.rb
@@ -108,6 +110,7 @@ files:
 - lib/theme_check/checks_tracking.rb
 - lib/theme_check/cli.rb
 - lib/theme_check/config.rb
+- lib/theme_check/corrector.rb
 - lib/theme_check/json_check.rb
 - lib/theme_check/json_file.rb
 - lib/theme_check/json_helpers.rb
@@ -118,9 +121,11 @@ files:
 - lib/theme_check/locale_diff.rb
 - lib/theme_check/node.rb
 - lib/theme_check/offense.rb
+- lib/theme_check/packager.rb
 - lib/theme_check/parsing_helpers.rb
 - lib/theme_check/printer.rb
 - lib/theme_check/shopify_liquid.rb
+- lib/theme_check/shopify_liquid/deprecated_filter.rb
 - lib/theme_check/shopify_liquid/filter.rb
 - lib/theme_check/shopify_liquid/object.rb
 - lib/theme_check/tags.rb
@@ -128,6 +133,7 @@ files:
 - lib/theme_check/theme.rb
 - lib/theme_check/version.rb
 - lib/theme_check/visitor.rb
+- packaging/homebrew/theme_check.base.rb
 - theme-check.gemspec
 homepage: https://github.com/Shopify/theme-check
 licenses: