thegarage-gitx 2.2.3.pre1 → 2.2.3.pre2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0b14ee5697a2883977afed2c228ab55bffb1465
-  data.tar.gz: aef6ef947211f421c07b0e3aef71da696c2e9c31
+  metadata.gz: 828adabb95945ff82ba93923950a6af74dcff5e4
+  data.tar.gz: a153b52c49a3dea67cff353aaf43f63ac50e7a87
 SHA512:
-  metadata.gz: 0dad8dba2b0b25ef97c4cd0a1628ba88227270ed2ce68de7cc53777206e762c90ce3e6833bd7ea509b0f8ef8f227d33364b8cb38c94fb364bf7e9baad63ada2f
-  data.tar.gz: 4ddd4bd7aa598289b85962a2d6065ce40a242090fdb8084382bea447c9e20041e19299d39781453bdf9b5010b51a83fefbbc86ca083fcb7b464b5473940239a4
+  metadata.gz: a543bcecabda7e3945377d1fbda43b7d4b1d2222c44d09cfcb13f1e26a9f2f3adb2ce827183dbc980f6720440f73e86210dda80a851717dc81554c4a9e403877
+  data.tar.gz: 1e56171b3055a4c14620277d7d77c77ad2170ea7d1c626d7256a5a3bf4b270071b3f0d19339f3ff85b82bab1705122c5a97b0465be3de470e739a33c7612ad9a

data/lib/thegarage/gitx/cli/review_command.rb

@@ -153,30 +153,9 @@ module Thegarage
           description_template << changelog
           description_template << PULL_REQUEST_FOOTER
 
-          body = input_from_editor(description_template.join("\n"))
+          body = ask_editor(description_template.join("\n"))
           body.gsub(PULL_REQUEST_FOOTER, '').chomp.strip
         end
-
-        # launch configured editor to retreive message/string
-        def input_from_editor(initial_text = '')
-          Tempfile.open('reviewrequest.md') do |f|
-            f << initial_text
-            f.flush
-
-            editor = repo.config['core.editor'] || ENV['EDITOR'] || 'vi'
-            flags = case editor
-            when 'mate', 'emacs', 'subl'
-              '-w'
-            when 'mvim'
-              '-f'
-            else
-              ''
-            end
-            pid = fork { exec([editor, flags, f.path].join(' ')) }
-            Process.waitpid(pid)
-            File.read(f.path)
-          end
-        end
       end
     end
   end

data/lib/thegarage/gitx/string_extensions.rb

@@ -5,10 +5,6 @@ class String
   end
   alias :dedent :undent
 
-  def starts_with?(characters)
-    !!self.match(/^#{characters}/)
-  end
-
   def blank?
     self.to_s == ''
   end

data/lib/thegarage/gitx/thor_extensions.rb

@@ -0,0 +1,27 @@
+class Thor
+  module Actions
+    # launch configured editor to retreive message/string
+    # see http://osdir.com/ml/ruby-talk/2010-06/msg01424.html
+    # see https://gist.github.com/rkumar/456809
+    # see http://rdoc.info/github/visionmedia/commander/master/Commander/UI.ask_editor
+    def ask_editor(initial_text = '')
+      Tempfile.open('reviewrequest.md') do |f|
+        f << initial_text
+        f.flush
+
+        editor = repo.config['core.editor'] || ENV['EDITOR'] || 'vi'
+        flags = case editor
+        when 'mate', 'emacs', 'subl'
+          '-w'
+        when 'mvim'
+          '-f'
+        else
+          ''
+        end
+        pid = fork { exec([editor, flags, f.path].join(' ')) }
+        Process.waitpid(pid)
+        File.read(f.path)
+      end
+    end
+  end
+end

data/lib/thegarage/gitx/version.rb

@@ -1,5 +1,5 @@
 module Thegarage
   module Gitx
-    VERSION = '2.2.3.pre1'
+    VERSION = '2.2.3.pre2'
   end
 end

data/lib/thegarage/gitx.rb

@@ -1,5 +1,6 @@
 require 'thegarage/gitx/version'
 require 'thegarage/gitx/string_extensions'
+require 'thegarage/gitx/thor_extensions'
 
 module Thegarage
   module Gitx

data/spec/thegarage/gitx/cli/review_command_spec.rb

@@ -21,7 +21,7 @@ describe Thegarage::Gitx::Cli::ReviewCommand do
   before do
     allow(cli).to receive(:repo).and_return(repo)
     allow(cli).to receive(:current_branch).and_return(branch)
-    allow(cli).to receive(:input_from_editor).and_return('description')
+    allow(cli).to receive(:ask_editor).and_return('description')
   end
 
   describe '#review' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thegarage-gitx
 version: !ruby/object:Gem::Version
-  version: 2.2.3.pre1
+  version: 2.2.3.pre2
 platform: ruby
 authors:
 - Ryan Sonnek
@@ -244,6 +244,7 @@ files:
 - lib/thegarage/gitx/cli/track_command.rb
 - lib/thegarage/gitx/cli/update_command.rb
 - lib/thegarage/gitx/string_extensions.rb
+- lib/thegarage/gitx/thor_extensions.rb
 - lib/thegarage/gitx/version.rb
 - spec/fixtures/vcr_cassettes/pull_request_does_exist.yml
 - spec/fixtures/vcr_cassettes/pull_request_does_not_exist.yml