thegamesdb 1.1.2 → 2.1.0

data/test/platform_test.rb

@@ -1,113 +1,147 @@
+# frozen_string_literal: true
+
 require_relative './test_helper'
 
 describe 'GamesDB - platforms', :vcr do
+  let(:client) { Gamesdb::Client.new(ENV['GAMESDB_API_KEY']) }
+
   describe 'platforms' do
     before do
-      @platforms = Gamesdb.platforms
+      @platforms = client.platforms
     end
 
     it 'should get gaming platforms' do
-      @platforms.count.wont_be :<, 0
-      @platforms.count.must_equal 110
+      expect(@platforms.count).wont_be :<, 0
+      expect(@platforms.count).must_equal 147
     end
 
     it 'should have a valid name' do
-      @platforms[0][:name].must_be_kind_of String
+      expect(@platforms[0][:name]).must_be_kind_of String
     end
 
     it 'should have a valid id' do
-      @platforms[0][:id].must_be_kind_of Integer
+      expect(@platforms[0][:id]).must_be_kind_of Integer
     end
 
     it 'should have a valid alias' do
-      @platforms[0][:alias].must_be_kind_of String
+      expect(@platforms[0][:alias]).must_be_kind_of String
     end
 
     it 'should have valid fields for other stuff' do
       nes = @platforms.select { |p| p[:id] == 7 }.first
-      nes[:icon].must_be_kind_of String
-      nes[:console].must_be_kind_of String
-      nes[:controller].must_be_kind_of String
-      nes[:developer].must_be_kind_of String
-      nes[:manufacturer].must_be_kind_of String
-      nes[:maxcontrollers].must_be_kind_of String
-      nes[:cpu].must_be_kind_of String
-      nes[:memory].must_be_kind_of String
-      nes[:sound].must_be_kind_of String
-      nes[:display].must_be_kind_of String
-      nes[:overview].must_be_kind_of String
+      expect(nes[:icon]).must_be_kind_of String
+      expect(nes[:console]).must_be_kind_of String
+      expect(nes[:controller]).must_be_kind_of String
+      expect(nes[:developer]).must_be_kind_of String
+      expect(nes[:manufacturer]).must_be_kind_of String
+      expect(nes[:maxcontrollers]).must_be_kind_of String
+      expect(nes[:cpu]).must_be_kind_of String
+      expect(nes[:memory]).must_be_kind_of String
+      expect(nes[:sound]).must_be_kind_of String
+      expect(nes[:display]).must_be_kind_of String
+      expect(nes[:overview]).must_be_kind_of String
     end
   end
 
   describe 'games by platform' do
     before do
-      platforms = Gamesdb.platforms
-      @first_page = Gamesdb.games_by_platform_id(platforms[0][:id])
-      @second_page = Gamesdb.games_by_platform_id(platforms[0][:id], 2)
+      platforms = client.platforms
+      @first_page = client.games_by_platform_id(platforms[0][:id])
+      @second_page = client.games_by_platform_id(platforms[0][:id], 2)
     end
 
     it 'should return games in platform by id' do
-      @first_page.count.wont_be :<, 0
-      @first_page.count.must_equal 20
+      expect(@first_page.count).wont_be :<, 0
+      expect(@first_page.count).must_equal 20
     end
 
     it 'should return games in the platform for the second page' do
-      @second_page.count.wont_be :<, 0
-      @second_page.count.must_equal 20
-      (@first_page & @second_page).must_equal []
+      expect(@second_page.count).wont_be :<, 0
+      expect(@second_page.count).must_equal 20
+      expect(@first_page & @second_page).must_equal []
     end
   end
 
   describe 'games by platform parameters' do
     before do
-      @games1 = Gamesdb.games_by_platform_id(4950)
-      @games2 = Gamesdb.games_by_platform_id(4948)
-      @games3 = Gamesdb.games_by_platform_id("4950,4948")
+      @games1 = client.games_by_platform_id(4950)
+      @games2 = client.games_by_platform_id(4948)
+      @games3 = client.games_by_platform_id('4950,4948')
     end
 
     it 'supports comma separated list' do
-      @games1.count.must_equal 20
-      @games2.count.must_equal 1
-      @games3.count.must_equal 20
+      expect(@games1.count).must_equal 20
+      expect(@games2.count).must_equal 20
+      expect(@games3.count).must_equal 20
 
-      (@games3 - @games1).must_equal @games2
+      expect(@games3 - @games1).must_equal @games2
     end
-
   end
 
   describe 'platform' do
     describe 'assigning basic info' do
       before do
-        @platform = Gamesdb.platform_by_id(6)
+        @platform = client.platforms_by_id(6)
       end
 
       it 'should return valid platform info' do
-        @platform[:name].must_equal 'Super Nintendo (SNES)'
-        @platform[:overview].must_be_kind_of String
-        @platform[:developer].must_be_kind_of String
-        @platform[:manufacturer].must_equal 'Nintendo'
-        @platform[:cpu].must_be_kind_of String
-        @platform[:memory].must_be_kind_of String
-        @platform[:sound].must_be_kind_of String
-        @platform[:display].must_be_kind_of String
+        expect(@platform[:name]).must_equal 'Super Nintendo (SNES)'
+        expect(@platform[:overview]).must_be_kind_of String
+        expect(@platform[:developer]).must_be_kind_of String
+        expect(@platform[:manufacturer]).must_equal 'Nintendo'
+        expect(@platform[:cpu]).must_be_kind_of String
+        expect(@platform[:memory]).must_be_kind_of String
+        expect(@platform[:sound]).must_be_kind_of String
+        expect(@platform[:display]).must_be_kind_of String
       end
     end
 
     describe 'without hardware or images' do
       before do
-        @platform = Gamesdb.platform_by_id 4916
+        @platform = client.platforms_by_id(4916)
       end
 
       it 'should return valid platform info' do
-        @platform[:name].must_equal 'Android'
-        @platform[:overview].must_be_kind_of String
-        @platform[:developer].must_be_kind_of String
-        @platform[:manufacturer].must_be_nil
-        @platform[:cpu].must_be_nil
-        @platform[:memory].must_be_nil
-        @platform[:sound].must_be_nil
-        @platform[:display].must_be_nil
+        expect(@platform[:name]).must_equal 'Android'
+        expect(@platform[:overview]).must_be_kind_of String
+        expect(@platform[:developer]).must_be_kind_of String
+        expect(@platform[:manufacturer]).must_be_nil
+        expect(@platform[:cpu]).must_be_nil
+        expect(@platform[:memory]).must_be_nil
+        expect(@platform[:sound]).must_be_nil
+        expect(@platform[:display]).must_be_nil
       end
     end
   end
+
+  describe 'platforms by name' do
+    it 'should return platforms' do
+      @platforms = client.platforms_by_name('Nintendo')
+
+      expect(@platforms.count).must_equal 14
+      names = @platforms.sort_by { |p| p[:name] }.map { |p| p[:name] }
+      expect(names).must_equal [
+        'Nintendo 3DS', 'Nintendo 64', 'Nintendo DS', 'Nintendo Entertainment System (NES)',
+        'Nintendo Game Boy', 'Nintendo Game Boy Advance', 'Nintendo Game Boy Color', 'Nintendo GameCube',
+        'Nintendo Pokémon Mini', 'Nintendo Switch', 'Nintendo Virtual Boy', 'Nintendo Wii', 'Nintendo Wii U',
+        'Super Nintendo (SNES)'
+      ]
+    end
+  end
+
+  describe 'platform images' do
+    it 'should return all images for a platform' do
+      @images = client.platform_images(7)
+
+      expect(@images.count).must_equal(10)
+      expect(@images.first.keys).must_equal(['id', 'type', 'filename'])
+    end
+
+    it 'should filter image type for a platform' do
+      @images = client.platform_images(7, type: 'boxart')
+
+      expect(@images.count).must_equal(1)
+      expect(@images.first).must_equal({ 'id' => 222, 'type' => 'boxart', 'filename' => 'platform/boxart/7-2.jpg' })
+    end
+  end
 end

data/test/publishers_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require_relative './test_helper'
+
+describe 'GamesDB - Publishers', :vcr do
+  let(:client) { Gamesdb::Client.new(ENV['GAMESDB_API_KEY']) }
+
+  describe 'publishers' do
+    it 'should return publishers' do
+      publishers = client.publishers
+
+      expect(publishers.count.positive?)
+      expect(publishers.first.keys).must_equal(['id', 'name'])
+    end
+  end
+end

data/test/test_helper.rb

@@ -1,10 +1,11 @@
-require 'simplecov'
-SimpleCov.start
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require 'minitest/reporters'
 require 'minitest/spec'
 require 'vcr'
 require 'minitest-vcr'
+
 Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new
 MinitestVcr::Spec.configure!
 

data/thegamesdb.gemspec

@@ -1,8 +1,11 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'thegamesdb/version'
 
+# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |spec|
   spec.name          = 'thegamesdb'
   spec.version       = Gamesdb::VERSION
@@ -13,23 +16,25 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'http://github.com/picandocodigo/gamesdb'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
+  spec.required_ruby_version = '> 2.7.0'
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'byebug' unless defined?(JRUBY_VERSION)
   spec.add_development_dependency 'minitest-reporters'
   spec.add_development_dependency 'minitest-vcr'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'vcr', '~> 4'
   spec.add_development_dependency 'webmock'
-  spec.metadata      = {
-    "bug_tracker_uri"   => "https://github.com/picandocodigo/gamesdb/issues",
-    "changelog_uri"     => "https://github.com/picandocodigo/gamesdb/blob/master/CHANGELOG.md",
-    "documentation_uri" => "https://github.com/picandocodigo/gamesdb/blob/master/README.md#gamesdb",
-    "homepage_uri"      => "https://github.com/picandocodigo/gamesdb",
-    "source_code_uri"   => "https://github.com/picandocodigo/gamesdb",
+  spec.metadata = {
+    'bug_tracker_uri' => 'https://github.com/picandocodigo/gamesdb/issues',
+    'changelog_uri' => 'https://github.com/picandocodigo/gamesdb/blob/master/CHANGELOG.md',
+    'documentation_uri' => 'https://github.com/picandocodigo/gamesdb/blob/master/README.md#gamesdb',
+    'homepage_uri' => 'https://github.com/picandocodigo/gamesdb',
+    'source_code_uri' => 'https://github.com/picandocodigo/gamesdb'
   }
 end
+# rubocop:enable Metrics/BlockLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thegamesdb
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Fernando Briano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-16 00:00:00.000000000 Z
+date: 2023-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -129,18 +129,31 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
+- ".github/workflows/rubocop.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/thegamesdb.rb
-- lib/thegamesdb/config.rb
+- lib/thegamesdb/developers.rb
+- lib/thegamesdb/error.rb
+- lib/thegamesdb/games.rb
+- lib/thegamesdb/genres.rb
+- lib/thegamesdb/images.rb
+- lib/thegamesdb/platforms.rb
+- lib/thegamesdb/publishers.rb
+- lib/thegamesdb/utils.rb
 - lib/thegamesdb/version.rb
+- test/client_test.rb
+- test/developers_test.rb
 - test/games_test.rb
+- test/genres_test.rb
 - test/platform_test.rb
+- test/publishers_test.rb
 - test/test_helper.rb
 - thegamesdb.gemspec
 homepage: http://github.com/picandocodigo/gamesdb
@@ -158,20 +171,24 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Client for TheGamesDB API (thegamesdb.net).
 test_files:
+- test/client_test.rb
+- test/developers_test.rb
 - test/games_test.rb
+- test/genres_test.rb
 - test/platform_test.rb
+- test/publishers_test.rb
 - test/test_helper.rb

data/.travis.yml

@@ -1,24 +0,0 @@
-env:
-  global:
-    - CC_TEST_REPORTER_ID=3ca09808c18a3fb0a12a7b113aeca064acf88831f8a36ee2e9fda89ca37b0650
-language: ruby
-rvm:
-  - 2.3.8
-  - 2.4.9
-  - 2.5.7
-  - 2.6.5
-  - 2.7.0
-  - truffleruby
-  - ruby-head
-install: bundle install
-before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-script:
-  - bundle exec rake test
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-allow_failures:
-  - rvm: ruby-head
-  - rvm: truffleruby

data/lib/thegamesdb/config.rb

@@ -1,9 +0,0 @@
-module Gamesdb
-  class Config
-    attr_accessor :api_key
-
-    def initialize
-      @api_key = ENV['GAMESDB_API_KEY'] || nil
-    end
-  end
-end