theforeman-rubocop 0.1.0.pre.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 303949ac39cb6a1dc5269b09c318beb190888c6e1ae5e639dc337670741dbeaf
-  data.tar.gz: 81383fa08b725ba13fe5250cac9362a72bc4f79b021efb63ce7742921d784f25
+  metadata.gz: f933f45fd6966bc09f46ba494268c9e93a26b1817ee530cf9967098f5ebaed4a
+  data.tar.gz: e6743de32b593b8c307908395e5b86dd6367f0265a4249f1f435a79d29b94663
 SHA512:
-  metadata.gz: 95f106807f8b3f33bd993cd51dd9693270363ef1c4c05e1f2913ee87399615d67504f8d8ce1b9089d56d5a26cddf1cbd1156e8025b676a90105d8201ea825fc6
-  data.tar.gz: 1025ce9baee07dd289407d0bccc914f0ae1ec83d732350a031fdb121ebc31aa31da29bfc8f0b63023b04a2cfa854afc7fc43255769b2f262521c83637efee61c
+  metadata.gz: 1fefc5ca7d7899ec5882cc2d204c2b37892614746781e3762ecaecd370e5348c2d4320157ac19d3b15d0c759f8662ce8489226b77468566d0f6045f516673836
+  data.tar.gz: d402190a05d300b66a913af3bc7bb263442e90643dae4c45dbc961f95f99e925a6da0f67e12b755f7fbdb7d5d310cfef12ae1cab4b03132f23003f3feaaaf451

data/.github/workflows/gem-push.yml

@@ -1,8 +1,9 @@
 name: Publish RubyGem
 
 on:
-  tags:
-    - v*
+  create:
+      tags:
+      - v*
 
 jobs:
   publish_ghp:

data/README.md

@@ -14,6 +14,8 @@ Instead of defining the rules for plugin per plugin, plugins can include default
 
 ## Usage
 
+There is also a [guide how to run this in GH action](docs/github_action.md)
+
 ```ruby
 # Gemfile
 gem 'theforeman-rubocop', '~> 0.0.4'

data/docs/github_action.md

@@ -0,0 +1,51 @@
+# How to run RuboCop in GH action
+
+## Foreman plugin
+
+We will cover how to do use this in Foreman plugin. It should work for any rubygem the same tho.
+
+Rubocop doesn't benefit from running in the full Foreman environment so it is actually better to have own dependency in Gemfile on it.
+We are then able to run the rubocop directly in the plugin folder, which is much faster as we install only the plugin dependencies, not the full foreman dependencies.
+
+In theory, you can just `gem install theforeman-foreman` in the action, but it is discouraged as it is then hard to synchronize what version you use in the CI.
+
+### Plugin `Gemfile`
+
+```ruby
+  source 'https://rubygems.org'
+gemspec
+
+# We use special group rubocop so we can opt out from all dependencies but rubocop.
+gem 'theforeman-rubocop', '~> 0.1.0', groups: %i[development rubocop]
+```
+
+### GH action
+
+Following GH action will run
+
+```yaml
+name: Ruby Testing
+on:
+  pull_request:
+  push:
+    branches:
+    - master
+jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+    env:
+      BUNDLE_WITHOUT: development:test
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7 # Currently supported ruby verion
+          bundler-cache: true
+      - name: Run rubocop
+        run: bundle exec rubocop -P --format github
+  view_specs:
+    runs-on: ubuntu-latest
+    needs: rubocop
+    # .... Whatever you run as tests if you run them in GH actions
+```

data/lib/theforeman/rubocop/version.rb

@@ -1,5 +1,5 @@
 module Theforeman
   module Rubocop
-    VERSION = '0.1.0.pre.1'.freeze
+    VERSION = '0.1.0'.freeze
   end
 end

data/theforeman-rubocop.gemspec

@@ -20,12 +20,13 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.5'
+  spec.add_dependency 'rubocop', '~> 1.23.0'
   spec.add_dependency 'rubocop-checkstyle_formatter', '~> 0.4.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.0'
-  spec.add_dependency 'rubocop-minitest', '~> 0.10.1'
+  spec.add_dependency 'rubocop-minitest', '~> 0.17.0'
   spec.add_dependency 'rubocop-performance', '~> 1.8.1'
-  spec.add_dependency 'rubocop-rails', '~> 2.8.1'
+  spec.add_dependency 'rubocop-rails', '~> 2.12.4'
+  spec.add_dependency 'rubocop-graphql', '~> 0.11.2'
   spec.add_development_dependency 'bundler', '~> 2.1'
   spec.add_development_dependency 'rake', '~> 13.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theforeman-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.1.0.pre.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Ondřej Ezr
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-12-02 00:00:00.000000000 Z
+date: 2021-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: 1.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: 1.23.0
 - !ruby/object:Gem::Dependency
   name: rubocop-checkstyle_formatter
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.17.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.17.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.12.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.12.4
+- !ruby/object:Gem::Dependency
+  name: rubocop-graphql
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.11.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.11.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +136,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
-description: 
+description:
 email:
 - foreman-dev@googlegroups.com
 executables: []
@@ -133,6 +147,7 @@ files:
 - AUTHORS
 - README.md
 - default.yml
+- docs/github_action.md
 - lenient.yml
 - lib/theforeman/rubocop/version.rb
 - minitest.yml
@@ -150,7 +165,7 @@ files:
 homepage: https://github.com/theforeman/theforeman-rubocop
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -161,12 +176,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Shared Rubocop configuration for theforeman.org family of projects.
 test_files: []