tftpplus 0.3 → 0.4

data/ChangeLog

@@ -1,3 +1,31 @@
+2007-05-31 01:45  msoulier
+
+	* lib/net/tftp+.rb: Fixed download problem on windows
+
+2007-04-29 13:24  msoulier
+
+	* bin/tftp_client.rb: Fixed client error not going to the logger
+
+2007-03-31 01:17  msoulier
+
+	* Rakefile: Updated the gemspec.
+
+2007-03-31 00:53  msoulier
+
+	* Rakefile: Updated description.
+
+2007-03-20 01:39  msoulier
+
+	* Rakefile: Rolling version ahead.
+
+2007-03-20 01:27  msoulier
+
+	* ChangeLog: Updated ChangeLog for version 0.3.
+
+2007-03-20 01:26  msoulier
+
+	* README: Updated README.
+
 2007-03-15 00:00  msoulier
 
 	* ChangeLog: Updated ChangeLog

data/README

@@ -7,18 +7,20 @@ A new tftp library for clients and servers that supports RFCs 1350, 2347 and
 Release Notes:
 ==============
 
+About version 0.4:
+------------------
+- Fixed a download problem on windows.
+
 About version 0.3:
 ------------------
 - First working server class.
 
 About version 0.2:
 ------------------
-
 - Fixed handling of remote TID.
 
 About version 0.1:
 ------------------
-
 - Added timeouts on recvfrom
 - Updated debugging output
 - Moved client code into its own sample client.

data/bin/tftp_client.rb

@@ -104,8 +104,8 @@ def main
             $log.debug('client') { "Downloaded #{size} bytes" }
         end
     rescue TftpError => details
-        $stderr.puts "Fatal exception in transfer"
-        $stderr.puts details
+        $log.error "Fatal exception in transfer"
+        $log.error details
     end
 
     finish = Time.now

data/lib/net/tftp+.rb

@@ -953,7 +953,7 @@ class TftpServerHandler < TftpSession
         path = @root + '/' + @filename
         if File.exists?(path)
             debug "Opening file #{path} for reading"
-            @file = File.new(path, "r")
+            @file = File.new(path, "rb")
             debug "File open: #{@file.inspect}"
             send_dat()
         else
@@ -978,10 +978,10 @@ class TftpServerHandler < TftpSession
         unless opts.key?(:resend) and opts[:resend]
             blksize = @options[:blksize].to_i
             debug "Reading #{blksize} bytes from file #{@filename}"
-            rv = @file.read(blksize, @buffer)
+            @buffer = @file.read(blksize)
             debug "@buffer is now #{@buffer.class}"
             debug "Read #{@buffer.length} bytes into buffer"
-            unless rv
+            if @file.eof
                 info "End of file #{@filename} detected."
                 @file.close
                 @state = :fin

metadata

@@ -3,19 +3,19 @@ rubygems_version: 0.9.2
 specification_version: 1
 name: tftpplus
 version: !ruby/object:Gem::Version 
-  version: "0.3"
-date: 2007-03-19 00:00:00 -04:00
-summary: A pure tftp implementation with support for variable block sizes
+  version: "0.4"
+date: 2007-05-30 00:00:00 -04:00
+summary: A pure Ruby TFTP implementation with support for variable block sizes (RFCs 1350, 2347 and 2348).
 require_paths: 
 - lib
 email: msoulier@digitaltorque.ca
 homepage: http://tftpplus.rubyforge.org
 rubyforge_project: 
-description: A new tftp library for clients and servers that supports RFCs 1350, 2347 and 2348 (ie. variable block sizes). It includes a sample client implementation, and will eventually include a multi-threaded server as well.
+description: A new tftp library for clients and servers that supports RFCs 1350, 2347 and 2348 (ie. variable block sizes). It includes a sample client implementation, and a sample server implementation. The server is single-threaded and supports multiple simultaneous downloads.
 autorequire: 
 default_executable: 
 bindir: bin
-has_rdoc: false
+has_rdoc: true
 required_ruby_version: !ruby/object:Gem::Version::Requirement 
   requirements: 
   - - ">"
@@ -37,8 +37,8 @@ test_files:
 - test/test.rb
 rdoc_options: []
 
-extra_rdoc_files: []
-
+extra_rdoc_files: 
+- README
 executables: 
 - tftp_client.rb
 extensions: []