textrepo 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7415dcbc8ec9483a33c0027432a60473fd0b77ad67369b25b88fb0f399edd788
-  data.tar.gz: 9467336f5d93ec578d5693005a4737f4eef55aeb11e4c0a4ec12f197e81de240
+  metadata.gz: 24594803cdcc722b7a9ca01648a9d8955cb9637669ab1c459e653c2eb2d2c199
+  data.tar.gz: bc5802a9a1df190d2278163b25d5ff1d2d107223acec17a3e713d1daf30a2218
 SHA512:
-  metadata.gz: f989032a0f1db66aeb1392cf9b05fd89306152d1b76907953c90ec14839d7a34465a017a2be8017536270b9a071cd3027497305978fdf59681d3547c8a68a5e5
-  data.tar.gz: cfb126c03ce9720dd2f2e90453a5d2baf33160c7786a8a1d9b5ef02b2c4a4e2531de5744d255efd7979a39e87c9e93287de3397533404143b51be1eb8bb23a58
+  metadata.gz: 21ef95e13e30d816b671be203b7beffa1ab022aec94bfc9540a7712f548cbf5749a8f5dc8f13e1f22067f53f52ac63dd2ac75ffa32719d72deb49b6b410c05a3
+  data.tar.gz: bef5bcfbef5a5557f80c44035dd42a9c8474cb04836e3328a6b0a7f0c065d5b601ff92bfcd4dee4a7a7c3273ac9e0648ae7a1e3bb52acdd95627de9266a04767

data/lib/textrepo/error.rb

@@ -1,12 +1,36 @@
 module Textrepo
+
+  ##
+  # Following errors might occur in repository operations:
+  #   +--------------------------+---------------------+
+  #   | operation (args)         | error type          |
+  #   +--------------------------+---------------------+
+  #   | create (timestamp, text) | Duplicate timestamp |
+  #   |                          | Empty text          |
+  #   +--------------------------+---------------------+
+  #   | read   (timestamp)       | Missing timestamp   |
+  #   +--------------------------+---------------------+
+  #   | update (timestamp, text) | Mssing timestamp    |
+  #   |                          | Empty text          |
+  #   +--------------------------+---------------------+
+  #   | delete (timestamp)       | Missing timestamp   |
+  #   +--------------------------+---------------------+
+
   class Error < StandardError; end
 
+  # :stopdoc:
   module ErrMsg
     UNKNOWN_REPO_TYPE   = 'unknown type for repository: %s'
     DUPLICATE_TIMESTAMP = 'duplicate timestamp: %s'
     EMPTY_TEXT          = 'empty text'
     MISSING_TIMESTAMP   = 'missing timestamp: %s'
+    INVALID_TIMESTAMP_STRING = "invalid string as timestamp: %s"
   end
+  # :startdoc:
+
+  ##
+  # An error raised if unknown type was specified as the repository
+  # type.
 
   class UnknownRepoTypeError < Error
     def initialize(type)
@@ -14,20 +38,9 @@ module Textrepo
     end
   end
 
-  # Following errors might occur in repository operations:
-  # +--------------------------+---------------------+
-  # | operation (args)         | error type          |
-  # +--------------------------+---------------------+
-  # | create (timestamp, text) | Duplicate timestamp |
-  # |                          | Empty text          |
-  # +--------------------------+---------------------+
-  # | read   (timestamp)       | Missing timestamp   |
-  # +--------------------------+---------------------+
-  # | update (timestamp, text) | Mssing timestamp    |
-  # |                          | Empty text          |
-  # +--------------------------+---------------------+
-  # | delete (timestamp)       | Missing timestamp   |
-  # +--------------------------+---------------------+
+  ##
+  # An error raised if the specified timestamp has already exist in
+  # the repository.
 
   class DuplicateTimestampError < Error
     def initialize(timestamp)
@@ -35,16 +48,33 @@ module Textrepo
     end
   end
 
+  ##
+  # An error raised if the given text is empty.
+
   class EmptyTextError < Error
     def initialize
       super(ErrMsg::EMPTY_TEXT)
     end
   end
 
+  ##
+  # An error raised if the given timestamp has not exist in the
+  # repository.
+
   class MissingTimestampError < Error
     def initialize(timestamp)
       super(ErrMsg::MISSING_TIMESTAMP % timestamp)
     end
   end
 
+  ##
+  # An error raised if an argument is invalid to convert a
+  # Textrepo::Timestamp object.
+
+  class InvalidTimestampStringError < Error
+    def initialize(str)
+      super(ErrMsg::INVALID_TIMESTAMP_STRING % str)
+    end
+  end
+
 end

data/lib/textrepo/file_system_repository.rb

@@ -208,9 +208,18 @@ module Textrepo
 
     def find_entries(stamp_pattern)
       Dir.glob("#{@path}/**/#{stamp_pattern}*.#{@extname}").map { |e|
-        Timestamp.parse_s(timestamp_str(e))
-      }
+        begin
+          Timestamp.parse_s(timestamp_str(e))
+        rescue InvalidTimestampStringError => _
+          # Just ignore the erroneous entry, since it is not a text in
+          # the repository.  It may be a garbage, or some kind of
+          # hidden stuff of the repository, ... etc.
+          nil
+        end
+      }.compact
     end
 
+    # :startdoc:
+
   end
 end

data/lib/textrepo/timestamp.rb

@@ -72,8 +72,11 @@ module Textrepo
       #    yyyymoddhhmiss sfx      yyyy    mo    dd    hh    mi    ss    sfx
       #   "20201230123456"     -> "2020", "12", "30", "12", "34", "56"
       #   "20201230123456_789" -> "2020", "12", "30", "12", "34", "56", "789"
+      #
+      # Raises InvalidTimestampStringError if nil was passed as an arguemnt.
 
       def split_stamp(stamp_str)
+        raise InvalidTimestampStringError, stamp_str if stamp_str.nil?
         #    yyyy  mo    dd    hh    mi      ss      sfx
         a = [0..3, 4..5, 6..7, 8..9, 10..11, 12..13, 15..17].map {|r| stamp_str[r]}
         a[-1].nil? ? a[0..-2] : a
@@ -83,13 +86,20 @@ module Textrepo
       # Generate a Timestamp object from a string which represents a
       # timestamp, such "20201028163400".
       #
+      # Raises InvalidTimestampStringError if cannot convert the
+      # argument into a Timestamp object.
+      #
       # :call-seq:
       #     parse_s("20201028163400") -> Timestamp
       #     parse_s("20201028163529_034") -> Timestamp
 
       def parse_s(stamp_str)
-        year, mon, day, hour, min, sec , sfx = split_stamp(stamp_str).map(&:to_i)
-        Timestamp.new(Time.new(year, mon, day, hour, min, sec), sfx)
+        begin
+          ye, mo, da, ho, mi, se, sfx = split_stamp(stamp_str).map(&:to_i)
+          Timestamp.new(Time.new(ye, mo, da, ho, mi, se), sfx)
+        rescue InvalidTimestampStringError, ArgumentError => _
+          raise InvalidTimestampStringError, stamp_str
+        end
       end
 
     end

data/lib/textrepo/version.rb

@@ -1,3 +1,3 @@
 module Textrepo
-  VERSION = '0.4.4'
+  VERSION = '0.4.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: textrepo
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - mnbi
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-28 00:00:00.000000000 Z
+date: 2020-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler