text_helpers 1.0.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 821b971353a180079293995889c2ac37c578e4afbeb2fb4ab4f2b23d885121fa
-  data.tar.gz: 90b1c2814b154bd44b5c862c4cb65b3874eb4def96a8e3f87e7c39d28e9373da
+  metadata.gz: 196566e88af14d22f2703223fcb8a334f44d0bc6162b2a90e92ea722840da6a6
+  data.tar.gz: bdf313faa479139cac2acf301b8c80e28f83448de3da1d1e8145b1408c91cdaa
 SHA512:
-  metadata.gz: ab19b219ea2f6b4877e1da8d103395836c7666154711591a255e093750059f72415fb283d6f427086ad96782375fa92cce9dfff4645b98fe38af203401b1a46f
-  data.tar.gz: 07b98f9af2b8258d696b3cb067ad54a25bf8e68e4d51f490e5f449dca418ef055cd562ae91ead997eb4be4c62a9587f83bc52bc97b52fd3f811bc176003eccac
+  metadata.gz: 95e9ff9a22f917aa08ff7b227c922abc56f0285d29ef581e0b43402a26777c98979737364da42cf015f1719f64f992e8b48caa6f3f7d9dd58468c689a8801285
+  data.tar.gz: 4346400f3ffb3a02404d899fe28ebea2b57e3481afd65a13321215e91e16a04a6d788141486a7893c37c3f9d38993312ed9b67363c2b45e4c16bc96e9a6e23ee

data/CHANGELOG.md

@@ -0,0 +1,102 @@
+# Change Log
+
+## [1.2.0] - 2022-01-05
+
+### Changes
+
+- Add support for Rails 7 (thanks to @boatrite)
+
+## [1.1.1] - 2021-02-02
+
+### Changes
+
+- Bump minimum redcarpet version for security (thanks to @n00dle)
+
+## [1.1.0] - 2020-12-02
+
+### New Features
+
+- Add `rel=noopener` to external links (thanks to @n00dle)
+
+## [1.0.1] - 2020-12-02
+
+### Changes
+
+- Support cascading backends by default
+
+## [1.0.0] - 2020-03-27
+
+### Changes
+
+- **(Breaking)** Drop explicit support for Ruby versions below 2.6
+
+### Bug Fixes
+
+- Properly support translations using I18n::Pluralization backend (thanks to @jhanggi)
+
+## [0.7.2] - 2019-07-06
+
+### Bug Fixes
+
+- Improve orphaned text matcher targeting
+
+## [0.7.1] - 2019-07-05
+
+### Bug Fixes
+
+- Prevent unnecessary non-breaking spaces in generated HTML
+
+### Changes
+
+- Improve `NotImplementedError` messaging (thanks to @stephen-puiszis)
+- Update README with spec setup instructions (thanks to @jhanggi)
+
+## [0.7.0] - 2016-05-06
+
+### New features
+
+- Automatically load entire locale directory via Railtie
+
+## [0.6.1] - 2015-10-01
+
+### Changes
+
+- Bump version requirement for Redcarpet gem to address memory leaks
+
+## [0.6.0] - 2015-06-15
+
+### New Features
+
+- Apply `target=_blank` attribute to anchor tags pointed at external URLs
+
+## [0.5.3] - 2015-02-25
+
+### Changes
+
+- Update spec helpers for compatibility with RSpec 3 (thanks to @gabrielg)
+
+## [0.5.2] - 2015-02-03
+
+### Changes
+
+- Support cascading backends for interpolated keys (thanks to @gabrielg)
+
+## [0.5.1] - 2015-01-23
+
+### New Features
+
+- Add RSpec helpers (thanks to @gabrielg)
+
+[1.2.0]: https://github.com/ahorner/text-helpers/compare/v1.1.1...v1.2.0
+[1.1.1]: https://github.com/ahorner/text-helpers/compare/v1.1.0...v1.1.1
+[1.1.0]: https://github.com/ahorner/text-helpers/compare/v1.0.1...v1.1.0
+[1.0.1]: https://github.com/ahorner/text-helpers/compare/v1.0.0...v1.0.1
+[1.0.0]: https://github.com/ahorner/text-helpers/compare/v0.7.2...v1.0.0
+[0.7.2]: https://github.com/ahorner/text-helpers/compare/v0.7.1...v0.7.2
+[0.7.1]: https://github.com/ahorner/text-helpers/compare/v0.7.0...v0.7.1
+[0.7.0]: https://github.com/ahorner/text-helpers/compare/v0.6.1...v0.7.0
+[0.6.1]: https://github.com/ahorner/text-helpers/compare/v0.6.0...v0.6.1
+[0.6.0]: https://github.com/ahorner/text-helpers/compare/v0.5.3...v0.6.0
+[0.5.3]: https://github.com/ahorner/text-helpers/compare/v0.5.2...v0.5.3
+[0.5.2]: https://github.com/ahorner/text-helpers/compare/v0.5.1...v0.5.2
+[0.5.1]: https://github.com/ahorner/text-helpers/compare/v0.5.0...v0.5.1

data/lib/text_helpers/railtie.rb

@@ -65,8 +65,14 @@ module TextHelpers
     initializer "text_helpers.setup_exception_handling", after: 'after_initialize' do
       next unless config.text_helpers.raise_on_missing_translations
 
-      if config.respond_to?(:action_view)
-        config.action_view.raise_on_missing_translations = true
+      if Rails::VERSION::MAJOR >= 7
+        if config.respond_to?(:i18n)
+          config.i18n.raise_on_missing_translations = true
+        end
+      else
+        if config.respond_to?(:action_view)
+          config.action_view.raise_on_missing_translations = true
+        end
       end
 
       TextHelpers.install_i18n_exception_handler

data/lib/text_helpers/translation.rb

@@ -12,7 +12,7 @@ module TextHelpers
       attributes = [
         ("href=\"#{link}\"" if link),
         ("title=\"#{title}\"" if title),
-        ("target=\"_blank\"" if link =~ PROTOCOL_MATCHER),
+        ("target=\"_blank\" rel=\"noopener\"" if link.match?(PROTOCOL_MATCHER)),
       ]
 
       "<a #{attributes.compact.join(" ")}>#{content}</a>"
@@ -37,14 +37,14 @@ module TextHelpers
       options = html_safe_options(options)
       text = I18n.t(key, **{
         scope: self.translation_scope,
-        default: "!#{key}!"
+        default: "!#{key}!",
+        cascade: true,
       }.merge(options)).strip
 
-      interpolation_options = options.dup
-      interpolation_options[:cascade] = true unless interpolation_options.has_key?(:cascade)
+      interpolation_options = { cascade: true }.merge(options)
 
       # Interpolate any keypaths (e.g., `!some.lookup.path/key!`) found in the text.
-      while text =~ KEYPATH_MATCHER do
+      while text.match?(KEYPATH_MATCHER) do
         text = text.gsub(KEYPATH_MATCHER) { |match| I18n.t($1, **interpolation_options) }
       end
 

data/lib/text_helpers/version.rb

@@ -1,3 +1,3 @@
 module TextHelpers
-  VERSION = "1.0.0"
+  VERSION = "1.2.0"
 end

data/test/lib/text_helpers/translation_test.rb

@@ -1,4 +1,4 @@
-require_relative '../../test_helper'
+require_relative "../../test_helper"
 
 describe TextHelpers::Translation do
   before do
@@ -119,12 +119,12 @@ describe TextHelpers::Translation do
         assert_equal "<em>#{@scoped_text}</em>\n", @helper.html(:test_key, inline: true, orphans: true)
       end
 
-      it "renders internal links without a target" do
+      it "renders internal links without a target or rel" do
         assert_equal "<a href=\"/internal/path\">Internal&nbsp;link</a>\n", @helper.html(:internal_link, inline: true)
       end
 
-      it "renders external links with target='_blank'" do
-        assert_equal "<a href=\"http://external.com\" target=\"_blank\">External&nbsp;link</a>\n", @helper.html(:external_link, inline: true)
+      it "renders external links with target='_blank' and rel='noopener'" do
+        assert_equal "<a href=\"http://external.com\" target=\"_blank\" rel=\"noopener\">External&nbsp;link</a>\n", @helper.html(:external_link, inline: true)
       end
 
       it "interpolates values wrapped in !!" do
@@ -242,6 +242,14 @@ describe TextHelpers::Translation do
           I18n.backend = @original_backend
         end
 
+        it "cascades the requested key by default" do
+          I18n.backend.store_translations(:en, {test_scoped_key: "a translation"})
+          assert_equal "a translation", @helper.text(:test_scoped_key, scope: "some.unnecessary.scope")
+
+          I18n.backend.store_translations(:en, {some: {test_scoped_key: "a scoped translation"}})
+          assert_equal "a scoped translation", @helper.text(:test_scoped_key, scope: "some.unnecessary.scope")
+        end
+
         it "cascades the interpolated key by default" do
           I18n.backend.store_translations(:en, {test_scoped_key: "a translation"})
 

data/text_helpers.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency("activesupport")
   gem.add_dependency("i18n", ">=0.6.8")
-  gem.add_dependency("redcarpet", ">=3.3.3")
+  gem.add_dependency("redcarpet", ">=3.5.1")
 
   gem.add_development_dependency("rake")
   gem.add_development_dependency("railties")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: text_helpers
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Andrew Horner
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-27 00:00:00.000000000 Z
+date: 2022-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.3
+        version: 3.5.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.3
+        version: 3.5.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -89,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -108,7 +109,7 @@ homepage: https://github.com/ahorner/text-helpers
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -123,8 +124,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.32
+signing_key:
 specification_version: 4
 summary: TextHelpers is a gem which supplies some basic utilities for text localization
   in Rails projects.  The library is intended to make it simple to keep your application's