text_helpers 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 903554bdd7d36e4e370e3ee49c9b4fea2ce583c0
-  data.tar.gz: a44bc31df0e1ee330828bc7fce8c744cef1b851a
+  metadata.gz: aab61ab2ec51e7a9457ad3fc762341ecc59862b7
+  data.tar.gz: 687b06a1b1ee2447c5fb29248307f74726550589
 SHA512:
-  metadata.gz: cd7cbf44933933fde4fef80f20346ce5f69acef7c5faf5842f73397db143ec3a13b59b2ada6ced119fc9500b76f0a1ff832d81d3bce9cf8f4054168c8f712a1b
-  data.tar.gz: ce8278cd00a6b9ec4df5e4aaaf9ae6486fb5a4e7212b9f4d0528647f05a32104958b01df0fe2e333ef0350130070f41357f8ec011c8e0a6b7094e94077c3b74d
+  metadata.gz: c03051dbfce0714ee802493eb44ecabeeb669b9eef87a847b5a21c3a03380832f247ed9192032b804dd8363046fe8c474600fbd3bc16c221587d7337bf380f2a
+  data.tar.gz: 800a199fde5ee931a01078e1a08f2587952b577c9852b30dae3ea726f24cd3d6740edd96d1277871718df97f815b72bb80f16bc1cb1dd1c65d09ce2dbfbe7438

data/README.md

@@ -60,7 +60,9 @@ The controller text helpers described above can be accessed in controller specs
 
 ### Temporary/Stub Localizations
 
-`text_helpers/rspec.rb` contains some helpers for setting up a test localization environment during your test runs.
+`text_helpers/rspec.rb` contains some helpers for setting up a test localization
+environment during your test runs. You can enable the helper methods by adding
+the `:text_helpers` tag to the examples that require them.
 
 To configure it, `require "text_helpers/rspec"` and configure the `before` and
 `after` hooks appropriately:
@@ -69,11 +71,13 @@ To configure it, `require "text_helpers/rspec"` and configure the `before` and
 require 'text_helpers/rspec'
 
 RSpec.configure do |config|
+  config.include TextHelpers::RSpec::TestHelpers, text_helpers: true
+
   config.before(:suite) do
     TextHelpers::RSpec.setup_spec_translations
   end
 
-  config.after(:each) do
+  config.after(:each, :text_helpers) do
     TextHelpers::RSpec.reset_spec_translations
   end
 end
@@ -83,7 +87,13 @@ Temporary localizations can then be defined within your examples via the
 `#set_translation` method, like so:
 
 ```
-set_translation('models.user.attributes.name', 'Name')
+describe "with a translation set", :text_helpers do
+  before do
+    set_translation('models.user.attributes.name', 'Name')
+  end
+
+  it { ... }
+end
 ```
 
 ## Configuration & Initialization

data/lib/text_helpers/translation.rb

@@ -22,7 +22,7 @@ module TextHelpers
 
   module Translation
 
-    ORPHAN_MATCHER = /\s(?![^<]*>)(\S+\s*<\/(?:p|li)>)/.freeze
+    ORPHAN_MATCHER = /[ \t](?![^<]*>)(\S+\s*<\/(?:p|li)>)/.freeze
 
     # Public: Get the I18n localized text for the passed key.
     #
@@ -82,7 +82,7 @@ module TextHelpers
       smartify(@renderer.render(text))
     end
 
-    # Protected: Auto-apply smart quotes and to the passed text.
+    # Internal: Auto-apply smart quotes to the passed text.
     #
     # text - A String which should be passed through the SmartyPants renderer.
     #
@@ -91,16 +91,16 @@ module TextHelpers
       Redcarpet::Render::SmartyPants.render(text)
     end
 
-    # Protected: The proper scope for I18n translation.
+    # Internal: The proper scope for I18n translation.
     #
     # Must be implemented by any classes which include this module.
     #
     # Raises NotImplementedError.
     def translation_scope
-      raise NotImplementedError
+      raise NotImplementedError, "must implement a public method `translation_scope` to determine I18n scope"
     end
 
-    # Protected: Convert all passed in arguments into html-safe strings
+    # Internal: Convert all passed in arguments into html-safe strings
     #
     # hash - a set of key-value pairs, which converts the second argument into an html-safe string
     #

data/lib/text_helpers/version.rb

@@ -1,3 +1,3 @@
 module TextHelpers
-  VERSION = "0.7.0"
+  VERSION = "0.7.1"
 end

data/test/lib/text_helpers/translation_test.rb

@@ -9,6 +9,7 @@ describe TextHelpers::Translation do
     before do
       @scoped_text = "Scoped lookup"
       @global_text = "Global lookup"
+      @single_word_text = "Single"
       @email_address = "user@example.org"
       @multiline_text = <<-MULTI.gsub(/^[ \t]+/, '')
         This is some multiline text.
@@ -30,6 +31,7 @@ describe TextHelpers::Translation do
           email_key:               "<#{@email_address}>",
           test_key:                "*#{@scoped_text}*",
           list_key:                "* #{@scoped_text}",
+          single_word_list_key:    "* #{@single_word_text}",
           interpolated_key:        "Global? (!test_key!)",
           interpolated_scoped_key: "Global? (!test_scoped_key!)",
           interpol_arg_key:        "Interpolate global? (!interpolated_key!)",
@@ -74,6 +76,16 @@ describe TextHelpers::Translation do
         assert_equal expected, @helper.html(:list_key)
       end
 
+      it "does not inject `&nbsp;` entities in HTML list items unnecessarily" do
+        expected = <<-EXPECTED.gsub(/^[ \t]+/, '')
+        <ul>
+        <li>#{@single_word_text}</li>
+        </ul>
+        EXPECTED
+
+        assert_equal expected, @helper.html(:single_word_list_key)
+      end
+
       it "does not modify HTML tags" do
         expected = "<p><a href=\"mailto:#{@email_address}\">#{@email_address}</a></p>\n"
         assert_equal expected, @helper.html(:email_key)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: text_helpers
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Andrew Horner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-06 00:00:00.000000000 Z
+date: 2019-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport