text_based_nested_set 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78749e7217cec62deb80deeead9fc78f0a772ef7
-  data.tar.gz: 8d4c60d74da99f5713ca8fb6b1c8d01c48de47e9
+  metadata.gz: aa90ceee83e89edf345915734c9b5ec744fd610c
+  data.tar.gz: cab3873fbbbf845540707dab84d8f1227e9889e3
 SHA512:
-  metadata.gz: baa53fc66973c9493c9e1a76fcf17ddbf478676b4ff82d098368286ea1317d80f49bae1a04b2ab5953136bfacd6d80219e03726019466e19b96fc80686964e5a
-  data.tar.gz: 08abf2d09fea02c5b9444268b6205a1362c48f837792f9bffcdef38e718c998304cff070b29b8291b1db8c570556c67abdc386a73e7c1161524b9da3bdd8d35f
+  metadata.gz: fc1d0749a43faaea964cf15a84964516d23c0398a2e4615566012639999bfb6e84da134dceacad326d5ef24e8236073f7bf952098c3f6c8f1b7eedd1e1817bdf
+  data.tar.gz: 45e8bd6d91f6f3074d402ab9807e4f88450403a206e8b1e62ff80d965952c49faa1e1315bc5c36df41fe41afe0ded7c845942ebf4edae7dcf3f1df94e1bae03f

data/lib/text_based_nested_set/model.rb

@@ -15,6 +15,16 @@ module BeyondAlbert
               r.rebuild
             end
           end
+
+          def position_valid?
+            root_nodes = where(parent_id: 0)
+            root_nodes.each do |r|
+              unless r.check_position
+                return false
+              end
+            end
+            true
+          end
         end
 
         def move_to_root
@@ -136,7 +146,7 @@ module BeyondAlbert
 
         def ancestors
           parent_ids = self.path.split('/').select {|v| v != "" && v != "0"}
-          current_class.where(id: parent_ids)
+          current_class.where(id: parent_ids).order("LENGTH(path) ASC")
         end
 
         def self_and_ancestors
@@ -202,9 +212,25 @@ module BeyondAlbert
           end
         end
 
+        def check_position
+          logger = Logger.new(STDOUT)
+          if self.children.size != 0
+            if self.children.size == self.children.last.position + 1
+              self.children.each do |c|
+                c.check_position
+              end
+            else
+              logger.info("position not correct, node id: #{self.id}")
+              return false
+            end
+          end
+          return true
+        end
+
         private
 
         def in_tenacious_transaction(&block)
+          logger = Logger.new(STDOUT)
           retry_count = 0
           begin
             transaction(&block)

data/lib/text_based_nested_set/version.rb

@@ -1,3 +1,3 @@
 module TextBasedNestedSet
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/text_based_nested_set_spec.rb

@@ -21,7 +21,7 @@ describe 'TextBasedNestedSet' do
     @child_1_2_1 = create(:category, id: 3, name: "child_1_2_1", parent_id: 6, path: "/0/1/2/6/", position: 0)
   end
 
-  describe 'move_to_root' do
+  describe '#move_to_root' do
     it 'should move to the root of the tree' do
       @child_1_2.move_to_root
       @child_1_2.reload
@@ -38,7 +38,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'move_to_left_of' do
+  describe '#move_to_left_of' do
     it 'should move to the left of target node' do
       @child_1_2.move_to_left_of(@child_2)
 
@@ -54,7 +54,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'move_to_right_of' do
+  describe '#move_to_right_of' do
     it 'should move to the right of target node' do
       @child_1_1.move_to_right_of(@child_1)
 
@@ -70,7 +70,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'move_to_child_of' do
+  describe '#move_to_child_of' do
     it 'should move to the child of target node' do
       @child_1_2.move_to_child_of(@child_1_1)
 
@@ -84,7 +84,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'parent' do
+  describe '#parent' do
     it "should return current node's parent node" do
       expect(@child_1_1.parent.name).to eq("child_1")
     end
@@ -94,39 +94,39 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'ancestors' do
+  describe '#ancestors' do
     it "should return current node's ancestors node" do
       expect(@child_1_1.ancestors).to eq([@root, @child_1])
     end
   end
 
-  describe 'self_and_ancestors' do
+  describe '#self_and_ancestors' do
     it "should return current node's ancestors node include self" do
       expect(@child_1_1.self_and_ancestors).to eq([@root, @child_1, @child_1_1])
     end
   end
 
-  describe 'children' do
+  describe '#children' do
     it "should return current node's children node" do
       expect(@child_1.children).to eq([@child_1_1, @child_1_2, @child_1_3])
     end
   end
 
-  describe 'descendants' do
+  describe '#descendants' do
     it "should return current node's all descendants" do
       expect(@child_1.descendants).to eq([@child_1_1, @child_1_2, @child_1_3, @child_1_2_1, @child_1_1_1])
       expect(@root.descendants).to eq([@child_1, @child_2, @child_1_1, @child_1_2, @child_1_3, @child_1_2_1, @child_1_1_1])
     end
   end
 
-  describe 'self_and_descendants' do
+  describe '#self_and_descendants' do
     it "should return current node and it's all descendants" do
       expect(@child_1.self_and_descendants).to eq([@child_1, @child_1_1, @child_1_2, @child_1_3, @child_1_2_1, @child_1_1_1])
       expect(@root.self_and_descendants).to eq([@root, @child_1, @child_2, @child_1_1, @child_1_2, @child_1_3, @child_1_2_1, @child_1_1_1])
     end
   end
 
-  describe 'right_sibling' do
+  describe '#right_sibling' do
     it "should return current node's right sibling" do
       expect(@child_1_2.right_sibling).to eq(@child_1_3)
     end
@@ -136,7 +136,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'left_sibling' do
+  describe '#left_sibling' do
     it "should return current node's left sibling" do
       expect(@child_1_2.left_sibling).to eq(@child_1_1)
     end
@@ -146,7 +146,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'root?' do
+  describe '#root?' do
     it "should return true if current node is root node" do
       expect(@root.root?).to eq(true)
     end
@@ -165,7 +165,7 @@ describe 'TextBasedNestedSet' do
     end
   end
 
-  describe 'rebuild' do
+  describe '#rebuild' do
     it "should rebuild current node's all descendants, set path and position again " do
       @root.descendants.each do |d|
         d.update(path: nil, position: nil)
@@ -197,6 +197,30 @@ describe 'TextBasedNestedSet' do
     end
   end
 
+  describe 'position_valid?' do
+    it "should return true if all records' position in table is right" do
+      expect(Category.position_valid?).to eq(true)
+    end
+
+    it "should return false if some records' position in table is out of order" do
+      @child_2.position = 0
+      @child_2.save!
+      expect(Category.position_valid?).to eq(false)
+    end
+  end
+
+  describe '#check_position' do
+    it "should return true if current tree's children's position is right" do     
+      expect(@child_1.check_position).to eq(true)
+    end
+
+    it "should return false if current tree's children's position is out of order" do
+      @child_1_3.position = 4
+      @child_1_3.save!
+      expect(@child_1.check_position).to eq(false)
+    end
+  end
+
   describe 'private destroy_descendants' do
     it 'should destroy descendants when itself be destroyed' do
       @child_1.destroy
@@ -206,7 +230,7 @@ describe 'TextBasedNestedSet' do
   end
 
   describe 'default value test' do
-    it 'should create a root node' do
+    it 'should create a root node with default value: parent_id: 0, path: "/0/", position: 0' do
       root1 = create(:category, name: 'root1')
       expect(root1.parent_id).to eq(0)
       expect(root1.path).to eq('/0/')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: text_based_nested_set
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - beyondalbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2015-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler