testimonials 0.1.2 → 0.1.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +8 -0
- data/app/views/testimonials/testimonials/show.html.erb +4 -2
- data/lib/testimonials/version.rb +1 -1
- data/lib/testimonials/widget.js +7 -1
- metadata +1 -1
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: ca7fa3a534c13036edc28e6206c06b5e4ef82949cafaeee614a2d196509c2176
|
|
4
|
+
data.tar.gz: 140a7b0783d3284076def56a598a0c70bb72f1208b2a6158b62c09d634eeaeb2
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 6eebe2d3c06afff74b999f4a8a29120a97d3a2e78eeb0ff1429df26bf14a9303c66861665489fdb10104c9f7557bca3ad140f466ddb4a4b2a2116d465c3bc302
|
|
7
|
+
data.tar.gz: 343195af39cd476f4a74728ab5e11997efa834806c7213aa3ab3b61bba933a6f2d89ccb6d255a9463b9089f9a4ebba5af078ff968db4b2adfff1fe1c6ad97cb3
|
data/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,13 @@
|
|
|
1
1
|
# Changelog
|
|
2
2
|
|
|
3
|
+
## 0.1.3
|
|
4
|
+
|
|
5
|
+
- Video playback no longer pauses itself moments after play in Firefox: the
|
|
6
|
+
`#t=0.1` poster-frame fragment made Firefox seek a MediaRecorder webm that
|
|
7
|
+
has no seek index, stalling the stream. The fragment is gone (widget and
|
|
8
|
+
dashboard); `preload="metadata"` still paints the first frame in Chrome
|
|
9
|
+
and Firefox.
|
|
10
|
+
|
|
3
11
|
## 0.1.2
|
|
4
12
|
|
|
5
13
|
- The widget dialog goes full-screen on mobile (no bottom sheet, no animations):
|
|
@@ -17,9 +17,11 @@
|
|
|
17
17
|
|
|
18
18
|
<div class="card pad" style="margin-bottom: 16px;">
|
|
19
19
|
<% if @testimonial.video_attached? %>
|
|
20
|
-
<%# #t=0.1
|
|
20
|
+
<%# No #t=0.1 fragment: MediaRecorder webm has no seek index, and
|
|
21
|
+
Firefox honors media fragments literally — the pending seek stalls
|
|
22
|
+
playback right after play. preload="metadata" paints the frame. %>
|
|
21
23
|
<video class="playback" controls preload="metadata"
|
|
22
|
-
src="<%= testimonial_video_path(@testimonial)
|
|
24
|
+
src="<%= testimonial_video_path(@testimonial) %>"></video>
|
|
23
25
|
<p class="muted">
|
|
24
26
|
<%= link_to "⬇ #{t('testimonials.dashboard.download_video', default: 'Download video')}",
|
|
25
27
|
testimonial_video_path(@testimonial, download: 1) %>
|
data/lib/testimonials/version.rb
CHANGED
data/lib/testimonials/widget.js
CHANGED
|
@@ -390,7 +390,13 @@
|
|
|
390
390
|
playback.controls = true;
|
|
391
391
|
playback.playsInline = true;
|
|
392
392
|
playback.preload = "metadata";
|
|
393
|
-
|
|
393
|
+
// No #t=0.1 fragment here either (see the review-stage comment):
|
|
394
|
+
// MediaRecorder webm has no seek index, and Firefox honors the
|
|
395
|
+
// fragment literally — the pending seek stalls playback a moment
|
|
396
|
+
// after play. preload="metadata" already paints the first frame in
|
|
397
|
+
// Chrome and Firefox; iOS shows the controls on a blank frame, which
|
|
398
|
+
// beats a player that pauses itself.
|
|
399
|
+
playback.src = state.existingVideoUrl;
|
|
394
400
|
wrap.appendChild(playback);
|
|
395
401
|
wrap.appendChild(attachedVideoChip(form, wrap, playback, function () {
|
|
396
402
|
state.removeExistingVideo = true;
|