test-redef 1.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6047a2115ef0cf71503c4221619fef15645afe1
-  data.tar.gz: 001a8a1f7e1ea8c96ca0baacbe5285c052f321c5
+  metadata.gz: b1d0499975b9a3b2197b73ed016e48ebb72b9744
+  data.tar.gz: d19562cb49b2e12237c1de3e712c49aeb237a54b
 SHA512:
-  metadata.gz: 37837c324a1102703ee596c15a69b4c09f5fa9b9687c1b3aa4725f08553fa755e741372e6956aada91f23495661fd4b2198769640a8175c940744c053582e5f3
-  data.tar.gz: c37f32c2b9c4b5cea2717f421a96ab2fe0fd62219932c83f0f7d0eec10c48b505089918837f31a38fcd856b9181a7d75688fde5f5e3f982b56fbc0ef3fd4f8ea
+  metadata.gz: e32c1c58a46fc75081e524c1967884d97e8f24d19440ad4cfc2fd960f20911e327511f97413ed48286f84229c47d73c06e86f46ef4f5b01c2fb50d089be034b6
+  data.tar.gz: f3713d6511c5248cf769d6fc308d796decc358319b0395e6a9c63c4d75c0b0dc764b62f18b59ce2dae9aeeecbbf67f737dd595895ee3369be97b0e09be2bbe11

data/lib/test/redef.rb

@@ -33,10 +33,10 @@ class Test::Redef
   end
 
   def self.publicize_method(*methods)
-    orig_access_level = {}
     method_syms = []
     methods.each do |class_method_name|
       klass, method_name = parse_class_and_method(class_method_name)
+      next if klass.public_instance_methods.include?(method_name)
       method_syms << [klass, method_name]
       klass.send(:public, method_name)
     end
@@ -81,7 +81,7 @@ class Test::Redef
   def [](method_name)
     c = Class.new
     c.instance_exec(self, method_name) do |rs, rs_method_name|
-      [:called, :args, :object, :reset].each do |method|
+      [:called, :args, :object, :reset, :called?].each do |method|
         define_method(method) { rs.__send__(method, rs_method_name) }
       end
     end
@@ -180,7 +180,7 @@ class Test::Redef
         klass.__send__(:alias_method, hider, method_name)
         real_redef_method_name = "__redef_new_method_#{@@redef_next_id}"
         temporary_methods << [klass, real_redef_method_name]
-        @@redef_next_id += 1;
+        @@redef_next_id += 1
         klass.__send__(:define_method, real_redef_method_name, method)
         arity = method.arity
 

data/test/redef.rb

@@ -137,6 +137,7 @@ class RedefTest < Test::Unit::TestCase
       assert_equal( [["pacifies-empiricism\'s"]], rd['TestClass#test_method'].args )
 
       assert_equal( 1, rd[:class_method].called )
+      assert( rd[:class_method].called? )
       assert_equal( [[]], rd[:class_method].args )
     end
   end
@@ -152,6 +153,8 @@ class RedefTest < Test::Unit::TestCase
       assert_equal( 0, rd['TestClass#both_class_and_instance'].called )
       assert_equal( 0, rd['TestClass.both_class_and_instance'].called )
 
+      assert( !rd['TestClass#both_class_and_instance'].called? )
+      assert( !rd['TestClass.both_class_and_instance'].called? )
 
       assert_equal( 'new_instance', a.both_class_and_instance )
       assert_equal( 'new_class', TestClass.both_class_and_instance )
@@ -208,13 +211,25 @@ class RedefTest < Test::Unit::TestCase
     assert_raises( NoMethodError ) do
       a.private_method
     end
-    Test::Redef.publicize_method('TestClass#private_method', 'TestClass.private_class_method') do
+    Test::Redef.publicize_method(
+      'TestClass#private_method',
+      'TestClass.private_class_method',
+      'TestClass#test_method',
+      'TestClass.class_method',
+    ) do
       assert_equal( 'orig private method', a.private_method )
       assert_equal( 'bolero-mute', TestClass.private_class_method )
+      assert_equal( 'orig', a.test_method )
+      assert_equal( 'orig', TestClass.class_method )
     end
+
     assert_raises( NoMethodError ) do
       a.private_method
     end
+
+    # don't privatize methods that were public
+    assert_equal( 'orig', a.test_method )
+    assert_equal( 'orig', TestClass.class_method )
   end
 
   # this sometimes seems like a good idea, but can lead to subtle bugs

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: test-redef
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: 1.0.1
 platform: ruby
 authors:
-- Nearbuy Systems
+- RetailNext
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-14 00:00:00.000000000 Z
+date: 2014-09-04 00:00:00.000000000 Z
 dependencies: []
 description: Replace methods with test code, get feedback on how they are called and
   put it all back together when your test is done.
@@ -21,7 +21,7 @@ files:
 - Rakefile
 - lib/test/redef.rb
 - test/redef.rb
-homepage: http://github.com/nearbuy/test-redef
+homepage: http://github.com/retailnext/test-redef
 licenses:
 - MIT
 metadata: {}
@@ -31,18 +31,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: Scopped and logged monkey patching for unit tests
+summary: Scoped and logged monkey patching for unit tests
 test_files: []