test-prof 1.5.0 → 1.6.0

data/lib/test_prof/rspec_stamp/parser/ripper.rb

@@ -0,0 +1,128 @@
+# frozen_string_literal: true
+
+require "ripper"
+
+module TestProf
+  module RSpecStamp
+    module Parser
+      class Ripper
+        def parse(code)
+          sexp = ::Ripper.sexp(code)
+          return unless sexp
+
+          # sexp has the following format:
+          # [:program,
+          #   [
+          #     [
+          #       :command,
+          #       [:@ident, "it", [1, 0]],
+          #       [:args_add_block, [ ... ]]
+          #     ]
+          #   ]
+          # ]
+          #
+          # or
+          #
+          # [:program,
+          #   [
+          #     [
+          #       :vcall,
+          #       [:@ident, "it", [1, 0]]
+          #     ]
+          #   ]
+          # ]
+          res = Result.new
+
+          fcall = sexp[1][0][1]
+          args_block = sexp[1][0][2]
+
+          if fcall.first == :fcall
+            fcall = fcall[1]
+          elsif fcall.first == :var_ref
+            res.fname = [parse_const(fcall), sexp[1][0][3][1]].join(".")
+            args_block = sexp[1][0][4]
+          end
+
+          res.fname ||= fcall[1]
+
+          return res if args_block.nil?
+
+          args_block = args_block[1] if args_block.first == :arg_paren
+
+          args = args_block[1]
+
+          if args.first.first == :string_literal
+            res.desc = parse_literal(args.shift)
+          elsif args.first.first == :var_ref || args.first.first == :const_path_ref
+            res.desc_const = parse_const(args.shift)
+          end
+
+          parse_arg(res, args.shift) until args.empty?
+
+          res
+        end
+
+        private
+
+        def parse_arg(res, arg)
+          if arg.first == :symbol_literal
+            res.add_tag parse_literal(arg)
+          elsif arg.first == :bare_assoc_hash
+            parse_hash(res, arg[1])
+          end
+        end
+
+        def parse_hash(res, hash_arg)
+          hash_arg.each do |(_, label, val)|
+            res.add_htag label[1][0..-2].to_sym, parse_value(val)
+          end
+        end
+
+        # Expr of the form:
+        #  bool - [:var_ref, [:@kw, "true", [1, 24]]]
+        #  string - [:string_literal, [:string_content, [...]]]
+        #  int - [:@int, "3", [1, 52]]]]
+        def parse_value(expr)
+          case expr.first
+          when :var_ref
+            expr[1][1] == "true"
+          when :@int
+            expr[1].to_i
+          when :@float
+            expr[1].to_f
+          else
+            parse_literal(expr)
+          end
+        end
+
+        # Expr of the form:
+        #  [:string_literal, [:string_content, [:@tstring_content, "is", [1, 4]]]]
+        def parse_literal(expr)
+          val = expr[1][1][1]
+          val = val.to_sym if expr[0] == :symbol_literal ||
+            expr[0] == :assoc_new
+          val
+        end
+
+        # Expr of the form:
+        #  [:var_ref, [:@const, "User", [1, 9]]]
+        #
+        #  or
+        #
+        #  [:const_path_ref, [:const_path_ref, [:var_ref,
+        #    [:@const, "User", [1, 17]]],
+        #    [:@const, "Guest", [1, 23]]],
+        #    [:@const, "Collection", [1, 30]]
+        def parse_const(expr)
+          if expr.first == :var_ref
+            expr[1][1]
+          elsif expr.first == :@const
+            expr[1]
+          elsif expr.first == :const_path_ref
+            expr[1..].map(&method(:parse_const)).join("::")
+          end
+        end
+      end
+    end
+  end
+end

data/lib/test_prof/rspec_stamp/parser.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "ripper"
-
 module TestProf
   module RSpecStamp
     # Parse examples headers
@@ -27,126 +25,16 @@ module TestProf
         end
       end
 
-      class << self
-        def parse(code)
-          sexp = Ripper.sexp(code)
-          return unless sexp
-
-          # sexp has the following format:
-          # [:program,
-          #   [
-          #     [
-          #       :command,
-          #       [:@ident, "it", [1, 0]],
-          #       [:args_add_block, [ ... ]]
-          #     ]
-          #   ]
-          # ]
-          #
-          # or
-          #
-          # [:program,
-          #   [
-          #     [
-          #       :vcall,
-          #       [:@ident, "it", [1, 0]]
-          #     ]
-          #   ]
-          # ]
-          res = Result.new
-
-          fcall = sexp[1][0][1]
-          args_block = sexp[1][0][2]
-
-          if fcall.first == :fcall
-            fcall = fcall[1]
-          elsif fcall.first == :var_ref
-            res.fname = [parse_const(fcall), sexp[1][0][3][1]].join(".")
-            args_block = sexp[1][0][4]
-          end
-
-          res.fname ||= fcall[1]
-
-          return res if args_block.nil?
-
-          args_block = args_block[1] if args_block.first == :arg_paren
-
-          args = args_block[1]
-
-          if args.first.first == :string_literal
-            res.desc = parse_literal(args.shift)
-          elsif args.first.first == :var_ref || args.first.first == :const_path_ref
-            res.desc_const = parse_const(args.shift)
-          end
-
-          parse_arg(res, args.shift) until args.empty?
-
-          res
+      instance =
+        begin
+          require_relative "parser/prism"
+          self::Prism.new
+        rescue LoadError
+          require_relative "parser/ripper"
+          self::Ripper.new
         end
-        # rubocop: enable Metrics/CyclomaticComplexity
-        # rubocop: enable Metrics/PerceivedComplexity
 
-        private
-
-        def parse_arg(res, arg)
-          if arg.first == :symbol_literal
-            res.add_tag parse_literal(arg)
-          elsif arg.first == :bare_assoc_hash
-            parse_hash(res, arg[1])
-          end
-        end
-
-        def parse_hash(res, hash_arg)
-          hash_arg.each do |(_, label, val)|
-            res.add_htag label[1][0..-2].to_sym, parse_value(val)
-          end
-        end
-
-        # Expr of the form:
-        #  bool - [:var_ref, [:@kw, "true", [1, 24]]]
-        #  string - [:string_literal, [:string_content, [...]]]
-        #  int - [:@int, "3", [1, 52]]]]
-        def parse_value(expr)
-          case expr.first
-          when :var_ref
-            expr[1][1] == "true"
-          when :@int
-            expr[1].to_i
-          when :@float
-            expr[1].to_f
-          else
-            parse_literal(expr)
-          end
-        end
-
-        # Expr of the form:
-        #  [:string_literal, [:string_content, [:@tstring_content, "is", [1, 4]]]]
-        def parse_literal(expr)
-          val = expr[1][1][1]
-          val = val.to_sym if expr[0] == :symbol_literal ||
-            expr[0] == :assoc_new
-          val
-        end
-
-        # Expr of the form:
-        #  [:var_ref, [:@const, "User", [1, 9]]]
-        #
-        #  or
-        #
-        #  [:const_path_ref, [:const_path_ref, [:var_ref,
-        #    [:@const, "User", [1, 17]]],
-        #    [:@const, "Guest", [1, 23]]],
-        #    [:@const, "Collection", [1, 30]]
-        def parse_const(expr)
-          if expr.first == :var_ref
-            expr[1][1]
-          elsif expr.first == :@const
-            expr[1]
-          elsif expr.first == :const_path_ref
-            expr[1..].map(&method(:parse_const)).join("::")
-          end
-        end
-      end
+      define_singleton_method(:parse) { |code| instance.parse(code) }
     end
   end
 end

data/lib/test_prof/rspec_stamp.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "test_prof/core"
 require "test_prof/logging"
 require "test_prof/rspec_stamp/parser"
 

data/lib/test_prof/rubocop.rb

@@ -1,13 +1,14 @@
 # frozen_string_literal: true
 
-require "test_prof/utils"
-supported = TestProf::Utils.verify_gem_version("rubocop", at_least: "0.51.0")
-unless supported
-  warn "TestProf cops require RuboCop >= 0.51.0 to run."
-  return
-end
+warn <<~MSG
+  !!!
 
-require "rubocop"
+  Please, update your .rubocop.yml configuration to load TestProf plugin as follows (and fix the error below):
 
-require "test_prof/cops/plugin"
-require "test_prof/cops/rspec/aggregate_examples"
+  plugins:
+    - test-prof
+
+  !!!
+
+
+MSG

data/lib/test_prof/tps_prof/profiler.rb

@@ -1,18 +1,27 @@
 # frozen_string_literal: true
 
 require "test_prof/utils/sized_ordered_set"
+require "forwardable"
 
 module TestProf
   module TPSProf
     class Profiler
-      attr_reader :top_count, :groups, :total_count, :total_time, :threshold
+      extend Forwardable
 
-      def initialize(top_count, threshold: 10)
-        @threshold = threshold
-        @top_count = top_count
+      attr_reader :top_count, :groups, :total_count, :total_time,
+        :config
+
+      def_delegators :@config, :min_examples_count, :min_group_time, :min_target_tps,
+        :mode, :max_examples_count, :max_group_time, :min_tps
+
+      def initialize(top_count, config)
+        @config = config
+        # In strict mode, we use the sorted set to keep track of offenders
+        # to show in the end
+        @top_count = (config.mode == :strict) ? 100 : top_count
         @total_count = 0
         @total_time = 0.0
-        @groups = Utils::SizedOrderedSet.new(top_count, sort_by: :tps)
+        @groups = Utils::SizedOrderedSet.new(top_count, sort_by: :penalty)
       end
 
       def group_started(id)
@@ -22,20 +31,48 @@ module TestProf
         @group_started_at = TestProf.now
       end
 
-      def group_finished(id)
-        return unless @examples_count >= threshold
+      def group_finished(group)
+        return unless @examples_count >= min_examples_count
+
+        total_time = TestProf.now - @group_started_at
+        shared_setup_time = total_time - @examples_time
+
+        return unless total_time >= min_group_time
 
-        # Context-time
-        group_time = (TestProf.now - @group_started_at) - @examples_time
-        run_time = @examples_time + group_time
+        tps = (@examples_count / total_time).round(2)
 
-        groups << {
-          id: id,
-          run_time: run_time,
-          group_time: group_time,
+        return unless tps < min_target_tps
+
+        # How much time did we waste compared to the target TPS
+        penalty = @examples_count * ((1.0 / tps) - (1.0 / min_target_tps))
+
+        item = {
+          id: group,
+          total_time: total_time,
+          shared_setup_time: shared_setup_time,
           count: @examples_count,
-          tps: -(@examples_count / run_time).round(2)
+          tps: tps,
+          penalty: penalty
         }
+
+        if mode == :strict
+          location = group.metadata[:location]
+
+          if TPSProf.handle_group_strictly(
+            GroupInfo.new(
+              group: group,
+              location: location,
+              examples_count: @examples_count,
+              total_time: total_time,
+              tps: tps,
+              penalty: penalty
+            )
+          )
+            groups << item
+          end
+        else
+          groups << item
+        end
       end
 
       def example_started(id)

data/lib/test_prof/tps_prof/reporter/text.rb

@@ -23,25 +23,45 @@ module TestProf
             <<~MSG
               Total TPS (tests per second): #{total_tps}
 
-              Top #{profiler.top_count} slowest suites by TPS (tests per second) (min examples per group: #{profiler.threshold}):
-
             MSG
 
+          if profiler.mode == :strict
+            return if groups.empty?
+
+            msgs << if groups.size < profiler.top_count
+              <<~MSG
+                Suites violating TPS limits:
+
+              MSG
+            else
+              <<~MSG
+                Top #{profiler.top_count} suites violating TPS limits:
+
+              MSG
+            end
+          else
+            msgs <<
+              <<~MSG
+                Top #{profiler.top_count} slowest suites by TPS (tests per second):
+
+              MSG
+          end
+
           groups.each do |group|
             description = group[:id].top_level_description
             location = group[:id].metadata[:location]
-            time = group[:run_time]
-            group_time = group[:group_time]
+            time = group[:total_time]
+            setup_time = group[:shared_setup_time]
             count = group[:count]
-            tps = -group[:tps]
+            tps = group[:tps]
 
             msgs <<
               <<~GROUP
-                #{description.truncate} (#{location}) – #{tps} TPS (#{time.duration} / #{count}), group time: #{group_time.duration}
+                #{description.truncate} (#{location}) – #{tps} TPS (#{time.duration} / #{count}, shared setup time: #{setup_time.duration})
               GROUP
           end
 
-          log :info, msgs.join
+          log((profiler.mode == :strict) ? :error : :info, msgs.join)
         end
       end
     end

data/lib/test_prof/tps_prof/rspec.rb

@@ -15,27 +15,50 @@ module TestProf
       attr_reader :reporter, :profiler
 
       def initialize
-        @profiler = Profiler.new(TPSProf.config.top_count, threshold: TPSProf.config.threshold)
+        @profiler = Profiler.new(TPSProf.config.top_count, TPSProf.config)
         @reporter = TPSProf.config.reporter
 
-        log :info, "TPSProf enabled (top-#{TPSProf.config.top_count})"
+        conf = TPSProf.config
+        if conf.mode == :strict
+          config_parts = []
+
+          if conf.custom_strict_handler
+            config_parts << "custom handler"
+          else
+            config_parts << "max examples: #{conf.max_examples_count}" if conf.max_examples_count
+            config_parts << "max group time: #{conf.max_group_time}" if conf.max_group_time
+            config_parts << "min tps: #{conf.min_tps}" if conf.min_tps
+          end
+
+          log :info, "TPSProf strict enabled (#{config_parts.join(", ")})"
+        else
+          log :info, "TPSProf enabled (top-#{TPSProf.config.top_count})"
+        end
       end
 
       def example_group_started(notification)
         return unless notification.group.top_level?
+        return if notification.group.metadata[:tps_prof] == :ignore
+
         profiler.group_started notification.group
       end
 
       def example_group_finished(notification)
         return unless notification.group.top_level?
+        return if notification.group.metadata[:tps_prof] == :ignore
+
         profiler.group_finished notification.group
       end
 
       def example_started(notification)
+        return if notification.example.metadata[:tps_prof] == :ignore
+
         profiler.example_started notification.example
       end
 
       def example_finished(notification)
+        return if notification.example.metadata[:tps_prof] == :ignore
+
         profiler.example_finished notification.example
       end
 

data/lib/test_prof/tps_prof.rb

@@ -8,25 +8,81 @@ module TestProf
   #
   # Example:
   #
+  #   # Show top-10 groups with the worst TPS
   #   TPS_PROF=10 rspec ...
   #
+  #   # Report (as errors) groups with lower TPS
+  #   TPS_PROF_MIN_TPS=10 TPS_PROF=strict rspec ...
   module TPSProf
+    class Error < StandardError; end
+
+    class GroupInfo < Struct.new(:group, :location, :examples_count, :total_time, :tps, :penalty, keyword_init: true)
+    end
+
     class Configuration
-      attr_accessor :top_count, :threshold, :reporter
+      attr_accessor :top_count, :reporter, :mode
+
+      # Thresholds
+      attr_accessor(
+        :min_examples_count, # Ignore groups with fewer examples
+        :min_group_time,     # Ignore groups with less total time (in seconds)
+        :min_target_tps,     # Ignore groups with higher TPS
+        :max_examples_count, # Report groups with more examples in strict mode
+        :max_group_time,     # Report groups with more total time in strict mode
+        :min_tps             # Report groups with lower TPS in strict mode
+      )
+
+      attr_reader :custom_strict_handler
 
       def initialize
-        @top_count = ENV["TPS_PROF"].to_i
-        @top_count = 10 if @top_count == 1
-        @threshold = ENV.fetch("TPS_PROF_MIN", 10).to_i
+        @mode = (ENV["TPS_PROF_MODE"] || ((ENV["TPS_PROF"] == "strict") ? :strict : :profile)).to_sym
+        @top_count = ENV["TPS_PROF_COUNT"]&.to_i || ((ENV["TPS_PROF"].to_i > 1) ? ENV["TPS_PROF"].to_i : nil) || 10
+
+        @min_examples_count = ENV.fetch("TPS_PROF_MIN_EXAMPLES", 10).to_i
+        @min_group_time = ENV.fetch("TPS_PROF_MIN_TIME", 5).to_i
+        @min_target_tps = ENV.fetch("TPS_PROF_TARGET_TPS", 30).to_i
+
+        @max_examples_count = ENV["TPS_PROF_MAX_EXAMPLES"]&.to_i
+        @max_group_time = ENV["TPS_PROF_MAX_TIME"]&.to_i
+        @min_tps = ENV["TPS_PROF_MIN_TPS"]&.to_i
+
         @reporter = resolve_reporter(ENV["TPS_PROF_FORMAT"])
       end
 
+      def strict_handler
+        @strict_handler ||= method(:default_strict_handler)
+      end
+
+      def strict_handler=(val)
+        @strict_handler = val
+        @custom_strict_handler = true
+      end
+
       private
 
       def resolve_reporter(format)
         # TODO: support other formats
         TPSProf::Reporter::Text.new
       end
+
+      def default_strict_handler(group_info)
+        error_msg = nil
+        location = group_info.location
+
+        if max_examples_count && group_info.examples_count > max_examples_count
+          error_msg ||= "Group #{location} has too many examples: #{group_info.examples_count} > #{max_examples_count}"
+        end
+
+        if max_group_time && group_info.total_time > max_group_time
+          error_msg ||= "Group #{location} has too long total time: #{group_info.total_time} > #{max_group_time}"
+        end
+
+        if min_tps && group_info.tps < min_tps
+          error_msg ||= "Group #{location} has too low TPS: #{group_info.tps} < #{min_tps}"
+        end
+
+        raise error_msg if error_msg
+      end
     end
 
     class << self
@@ -37,6 +93,15 @@ module TestProf
       def configure
         yield config
       end
+
+      def handle_group_strictly(group_info)
+        reporter = ::RSpec.configuration.reporter
+        config.strict_handler.call(group_info)
+        false
+      rescue => err
+        reporter.notify_non_example_exception(Error.new(err.message), "")
+        true
+      end
     end
   end
 end

data/lib/test_prof/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TestProf
-  VERSION = "1.5.0"
+  VERSION = "1.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: test-prof
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-12-04 00:00:00.000000000 Z
+date: 2026-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,6 +123,15 @@ files:
 - lib/minitest/base_reporter.rb
 - lib/minitest/event_prof_formatter.rb
 - lib/minitest/test_prof_plugin.rb
+- lib/rubocop/test_prof.rb
+- lib/rubocop/test_prof/cops/rspec/aggregate_examples.rb
+- lib/rubocop/test_prof/cops/rspec/aggregate_examples/its.rb
+- lib/rubocop/test_prof/cops/rspec/aggregate_examples/line_range_helpers.rb
+- lib/rubocop/test_prof/cops/rspec/aggregate_examples/matchers_with_side_effects.rb
+- lib/rubocop/test_prof/cops/rspec/aggregate_examples/metadata_helpers.rb
+- lib/rubocop/test_prof/cops/rspec/aggregate_examples/node_matchers.rb
+- lib/rubocop/test_prof/cops/rspec/language.rb
+- lib/rubocop/test_prof/plugin.rb
 - lib/test-prof.rb
 - lib/test_prof.rb
 - lib/test_prof/any_fixture.rb
@@ -135,14 +144,6 @@ files:
 - lib/test_prof/before_all.rb
 - lib/test_prof/before_all/adapters/active_record.rb
 - lib/test_prof/before_all/isolator.rb
-- lib/test_prof/cops/plugin.rb
-- lib/test_prof/cops/rspec/aggregate_examples.rb
-- lib/test_prof/cops/rspec/aggregate_examples/its.rb
-- lib/test_prof/cops/rspec/aggregate_examples/line_range_helpers.rb
-- lib/test_prof/cops/rspec/aggregate_examples/matchers_with_side_effects.rb
-- lib/test_prof/cops/rspec/aggregate_examples/metadata_helpers.rb
-- lib/test_prof/cops/rspec/aggregate_examples/node_matchers.rb
-- lib/test_prof/cops/rspec/language.rb
 - lib/test_prof/core.rb
 - lib/test_prof/event_prof.rb
 - lib/test_prof/event_prof/custom_events.rb
@@ -200,12 +201,12 @@ files:
 - lib/test_prof/recipes/rspec/let_it_be.rb
 - lib/test_prof/recipes/rspec/sample.rb
 - lib/test_prof/rspec_dissect.rb
-- lib/test_prof/rspec_dissect/collectors/base.rb
-- lib/test_prof/rspec_dissect/collectors/before.rb
-- lib/test_prof/rspec_dissect/collectors/let.rb
+- lib/test_prof/rspec_dissect/collector.rb
 - lib/test_prof/rspec_dissect/rspec.rb
 - lib/test_prof/rspec_stamp.rb
 - lib/test_prof/rspec_stamp/parser.rb
+- lib/test_prof/rspec_stamp/parser/prism.rb
+- lib/test_prof/rspec_stamp/parser/ripper.rb
 - lib/test_prof/rspec_stamp/rspec.rb
 - lib/test_prof/rubocop.rb
 - lib/test_prof/ruby_prof.rb