test-prof 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db12b48471cc8814d90d2388415798a742a5b5d69f61862bc88c12ac118e80c2
-  data.tar.gz: 9c930443a46e765d13b4528725d795aef8e4a2ab9b9c2c7a3939e2cb458ebd03
+  metadata.gz: 97628c14c29719b463c2937602d31e201bafcf3f910b94fb11ee28bd8f23aaf5
+  data.tar.gz: 4f924233ae1dfeb81bcca92624c741980c8d7c07a5a02d88909a08685a1980d4
 SHA512:
-  metadata.gz: 6fe1ff6102261d0b8c3c9e88e982255996b01ec6a34a9bc0d812a5021e8dd193aba57feca87d467c99f93973e98ed4cc4e94c94e8e1ab2e7b61dce806eeebedc
-  data.tar.gz: db01e089936817767666c9d8d8fc11c0e2765bbb254be6e1baa5fac3ab26de7ad6d2b937dca7c6f0bef72fb60045caef2e909bf196978ebe94aef0c7f54da1c4
+  metadata.gz: 865839f6c518c531be8c41701beb5714fadbbd1824cb96af8509e7a6b601973551a1bbdd0019000df001c82916c12d1232ee9caefeeb1be2eef384056f57da8a
+  data.tar.gz: 775d73f88529efdf0c3ad9d93354b0ca18c58640a2fc958d9615773b16f53776d8006d93a1c3094fd02f57bd2d1a412edd35e955369ed477f3102e6a443a1556

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 1.4.3 (2024-12-18)
+
+- Fix handling new (lazy) connection pools in `before_all`. ([@palkan][])
+
+- Updates Rubocop::Cop code to comply with most modern API. ([@aseroff][])
+
 ## 1.4.2 (2024-09-03) 🗓️
 
 - Ignore default scopes in `ActiveRecord::Base#refind`. ([@palkan][])

data/lib/test_prof/any_fixture/dump.rb

@@ -69,7 +69,7 @@ module TestProf
         end
 
         def commit
-          return unless defined?(:@file)
+          return unless instance_variable_defined?(:@file)
 
           file.close
 

data/lib/test_prof/before_all/adapters/active_record.rb

@@ -10,6 +10,7 @@ module TestProf
         class << self
           if ::ActiveRecord::Base.connection.pool.respond_to?(:pin_connection!)
             def begin_transaction
+              subscribe!
               ::ActiveRecord::Base.connection_handler.connection_pool_list(:writing).each do |pool|
                 pool.pin_connection!(true)
               end
@@ -19,6 +20,26 @@ module TestProf
               ::ActiveRecord::Base.connection_handler.connection_pool_list(:writing).each do |pool|
                 pool.unpin_connection!
               end
+              unsubscribe!
+            end
+
+            def subscribe!
+              Thread.current[:before_all_connection_subscriber] = ActiveSupport::Notifications.subscribe("!connection.active_record") do |_, _, _, _, payload|
+                connection_name = payload[:connection_name] if payload.key?(:connection_name)
+                shard = payload[:shard] if payload.key?(:shard)
+                next unless connection_name
+
+                pool = ::ActiveRecord::Base.connection_handler.retrieve_connection_pool(connection_name, shard: shard)
+                next unless pool && pool.role == :writing
+
+                pool.pin_connection!(true)
+              end
+            end
+
+            def unsubscribe!
+              return unless Thread.current[:before_all_connection_subscriber]
+              ActiveSupport::Notifications.unsubscribe(Thread.current[:before_all_connection_subscriber])
+              Thread.current[:before_all_connection_subscriber] = nil
             end
           else
             def all_connections

data/lib/test_prof/cops/rspec/aggregate_examples/its.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module RSpec
-      class AggregateExamples < ::RuboCop::Cop::Cop
+      class AggregateExamples < ::RuboCop::Cop::Base
         # @example `its`
         #
         #   # Supports regular `its` call with an attribute/method name,

data/lib/test_prof/cops/rspec/aggregate_examples/line_range_helpers.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module RSpec
-      class AggregateExamples < ::RuboCop::Cop::Cop
+      class AggregateExamples < ::RuboCop::Cop::Base
         # @internal Support methods for keeping newlines around examples.
         module LineRangeHelpers
           include RangeHelp

data/lib/test_prof/cops/rspec/aggregate_examples/matchers_with_side_effects.rb

@@ -5,7 +5,7 @@ require "test_prof/cops/rspec/language"
 module RuboCop
   module Cop
     module RSpec
-      class AggregateExamples < ::RuboCop::Cop::Cop
+      class AggregateExamples < ::RuboCop::Cop::Base
         # When aggregated, the expectations will fail when not supposed to or
         # have a risk of not failing when expected to. One example is
         # `validate_presence_of :comment` as it leaves an empty comment after

data/lib/test_prof/cops/rspec/aggregate_examples/metadata_helpers.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module RSpec
-      class AggregateExamples < ::RuboCop::Cop::Cop
+      class AggregateExamples < ::RuboCop::Cop::Base
         # @internal
         #   Support methods for example metadata.
         #   Examples with similar metadata are grouped.

data/lib/test_prof/cops/rspec/aggregate_examples/node_matchers.rb

@@ -5,7 +5,7 @@ require "test_prof/cops/rspec/language"
 module RuboCop
   module Cop
     module RSpec
-      class AggregateExamples < ::RuboCop::Cop::Cop
+      class AggregateExamples < ::RuboCop::Cop::Base
         # @internal
         #   Node matchers and searchers.
         module NodeMatchers

data/lib/test_prof/cops/rspec/aggregate_examples.rb

@@ -108,7 +108,8 @@ module RuboCop
       #     expect(number).to be_odd
       #   end
       #
-      class AggregateExamples < ::RuboCop::Cop::Cop
+      class AggregateExamples < ::RuboCop::Cop::Base
+        extend AutoCorrector
         include LineRangeHelpers
         include MetadataHelpers
         include NodeMatchers
@@ -123,29 +124,22 @@ module RuboCop
         def on_block(node)
           example_group_with_several_examples(node) do |all_examples|
             example_clusters(all_examples).each do |_, examples|
-              examples[1..].each do |example|
+              examples.drop(1).each do |example|
                 add_offense(example,
-                  location: :expression,
-                  message: message_for(example, examples[0]))
+                  message: message_for(example, examples[0])) do |corrector|
+                    clusters = example_clusters_for_autocorrect(example)
+                    clusters.each do |metadata, examples|
+                      range = range_for_replace(examples)
+                      replacement = aggregated_example(examples, metadata)
+                      corrector.replace(range, replacement)
+                      examples.drop(1).map { |example| drop_example(corrector, example) }
+                    end
+                  end
               end
             end
           end
         end
 
-        def autocorrect(example_node)
-          clusters = example_clusters_for_autocorrect(example_node)
-          return if clusters.empty?
-
-          lambda do |corrector|
-            clusters.each do |metadata, examples|
-              range = range_for_replace(examples)
-              replacement = aggregated_example(examples, metadata)
-              corrector.replace(range, replacement)
-              examples[1..].map { |example| drop_example(corrector, example) }
-            end
-          end
-        end
-
         private
 
         # Clusters of examples in the same example group, on the same nesting

data/lib/test_prof/factory_doctor.rb

@@ -105,10 +105,9 @@ module TestProf
       # Do not analyze code within the block
       def ignore
         @ignored = true
-        res = yield
+        yield
       ensure
         @ignored = false
-        res
       end
 
       def ignore!

data/lib/test_prof/recipes/minitest/before_all.rb

@@ -104,7 +104,7 @@ module TestProf
           if base.respond_to?(:parallelize_teardown)
             base.parallelize_teardown do
               last_klass = ::Minitest.previous_klass
-              if last_klass&.respond_to?(:parallelized) && last_klass&.parallelized
+              if last_klass&.respond_to?(:parallelized) && last_klass.parallelized
                 last_klass.before_all_executor&.deactivate!
               end
             end

data/lib/test_prof/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TestProf
-  VERSION = "1.4.2"
+  VERSION = "1.4.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: test-prof
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-03 00:00:00.000000000 Z
+date: 2024-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler