test-kitchen 1.2.1 → 1.3.0

data/spec/kitchen/state_file_spec.rb

@@ -16,11 +16,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require_relative '../spec_helper'
+require_relative "../spec_helper"
 
-require 'kitchen/errors'
-require 'kitchen/state_file'
-require 'kitchen/util'
+require "kitchen/errors"
+require "kitchen/state_file"
+require "kitchen/util"
 
 class YamledState
   attr_accessor :yoinks
@@ -28,8 +28,8 @@ end
 
 describe Kitchen::StateFile do
 
-  let(:state_file)  { Kitchen::StateFile.new('/tmp', 'oftheunion') }
-  let(:file_name)   { '/tmp/.kitchen/oftheunion.yml' }
+  let(:state_file)  { Kitchen::StateFile.new("/tmp", "oftheunion") }
+  let(:file_name)   { "/tmp/.kitchen/oftheunion.yml" }
 
   before do
     FakeFS.activate!
@@ -47,61 +47,68 @@ describe Kitchen::StateFile do
       state_file.read.must_equal(Hash.new)
     end
 
+    it "returns and empty hash if the file is zero length" do
+      stub_state_file!("")
+
+      state_file.read.must_equal(Hash.new)
+    end
+
     it "returns a Hash with symbolized keys from the state file" do
       stub_state_file!
 
-      state_file.read.must_equal({
+      state_file.read.must_equal(
         :cloud_id => 42,
-        :flavor => 'extra_crispy'
-      })
+        :flavor => "extra_crispy"
+      )
     end
 
     it "arbitrary objects aren't deserialized from state file" do
-      stub_state_file! <<-'YAML'.gsub(/^ {8}/, '')
+      stub_state_file! <<-'YAML'.gsub(/^ {8}/, "")
         --- !ruby/object:YamledState
         yoinks: zoinks
       YAML
 
       state_file.read.class.wont_equal YamledState
       state_file.read.class.must_equal Hash
-      state_file.read.must_equal({ :yoinks => 'zoinks' })
+      state_file.read.must_equal(:yoinks => "zoinks")
     end
 
     it "raises a StateFileLoadError if the state file cannot be parsed" do
-      stub_state_file!('&*%^*')
+      stub_state_file!("&*%^*")
 
       proc { state_file.read }.must_raise Kitchen::StateFileLoadError
     end
+
   end
 
   describe "#write" do
 
     it "creates the directory path to the state file" do
-      File.directory?('/tmp/.kitchen').must_equal false
+      File.directory?("/tmp/.kitchen").must_equal false
       state_file.write({})
-      File.directory?('/tmp/.kitchen').must_equal true
+      File.directory?("/tmp/.kitchen").must_equal true
     end
 
     it "writes a state file with stringified keys" do
-      state_file.write({ :thekey => 'thyself' })
+      state_file.write(:thekey => "thyself")
 
-      IO.read(file_name).split("\n").must_include 'thekey: thyself'
+      IO.read(file_name).split("\n").must_include "thekey: thyself"
     end
   end
 
   describe "#destroy" do
 
     it "executes if no file exists" do
-      File.exists?(file_name).must_equal false
+      File.exist?(file_name).must_equal false
       state_file.destroy
-      File.exists?(file_name).must_equal false
+      File.exist?(file_name).must_equal false
     end
 
     it "deletes the state file" do
       stub_state_file!
       state_file.destroy
 
-      File.exists?(file_name).must_equal false
+      File.exist?(file_name).must_equal false
     end
   end
 
@@ -109,7 +116,7 @@ describe Kitchen::StateFile do
 
   def stub_state_file!(yaml_string = nil)
     if yaml_string.nil?
-      yaml_string = <<-'YAML'.gsub(/^ {8}/, '')
+      yaml_string = <<-'YAML'.gsub(/^ {8}/, "")
         ---
         cloud_id: 42
         flavor: extra_crispy
@@ -117,6 +124,6 @@ describe Kitchen::StateFile do
     end
 
     FileUtils.mkdir_p(File.dirname(file_name))
-    File.open(file_name, 'wb') { |f| f.write(yaml_string) }
+    File.open(file_name, "wb") { |f| f.write(yaml_string) }
   end
 end

data/spec/kitchen/suite_spec.rb

@@ -16,18 +16,18 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require_relative '../spec_helper'
+require_relative "../spec_helper"
 
-require 'kitchen/errors'
-require 'kitchen/suite'
+require "kitchen/errors"
+require "kitchen/suite"
 
 describe Kitchen::Suite do
 
   let(:opts) do
     {
       :name => "suitezy",
-      :includes => ["testbuntu", "testcent"],
-      :excludes => ["prodbuntu"]
+      :includes => %w[testbuntu testcent],
+      :excludes => %w[prodbuntu]
     }
   end
 
@@ -43,7 +43,7 @@ describe Kitchen::Suite do
   end
 
   it "returns the includes" do
-    suite.includes.must_equal ["testbuntu", "testcent"]
+    suite.includes.must_equal %w[testbuntu testcent]
   end
 
   it "returns an empty Array when includes not given" do
@@ -52,7 +52,7 @@ describe Kitchen::Suite do
   end
 
   it "returns the excludes" do
-    suite.excludes.must_equal ["prodbuntu"]
+    suite.excludes.must_equal %w[prodbuntu]
   end
 
   it "returns an empty Array when excludes not given" do

data/spec/kitchen/util_spec.rb

@@ -16,21 +16,21 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require_relative '../spec_helper'
+require_relative "../spec_helper"
 
-require 'logger'
+require "logger"
 
-require 'kitchen/util'
+require "kitchen/util"
 
 describe Kitchen::Util do
 
-  describe '.to_logger_level' do
+  describe ".to_logger_level" do
 
     it "returns nil for invalid symbols" do
       Kitchen::Util.to_logger_level(:nope).must_be_nil
     end
 
-    %w{debug info warn error fatal}.each do |level|
+    %w[debug info warn error fatal].each do |level|
       it "returns Logger::#{level.upcase} for :#{level} input" do
         Kitchen::Util.to_logger_level(level.to_sym).
           must_equal Logger.const_get(level.upcase)
@@ -44,7 +44,7 @@ describe Kitchen::Util do
       Kitchen::Util.from_logger_level("nope").must_equal :fatal
     end
 
-    %w{debug info warn error fatal}.each do |level|
+    %w[debug info warn error fatal].each do |level|
       it "returns :#{level} for Logger::#{level.upcase} input" do
         Kitchen::Util.from_logger_level(Logger.const_get(level.upcase)).
           must_equal(level.to_sym)
@@ -66,8 +66,8 @@ describe Kitchen::Util do
 
     it "converts string keys into symbols" do
       Kitchen::Util.
-        symbolized_hash({ "one" => [{ "two" => :three, :four => "five" }] }).
-        must_equal({ :one => [{ :two => :three, :four => "five" }] })
+        symbolized_hash("one" => [{ "two" => :three, :four => "five" }]).
+        must_equal(:one => [{ :two => :three, :four => "five" }])
     end
   end
 
@@ -85,8 +85,8 @@ describe Kitchen::Util do
 
     it "converts symbol keys into strings" do
       Kitchen::Util.
-        stringified_hash({ :one => [{ :two => :three, "four" => "five" }] }).
-        must_equal({ "one" => [{ "two" => :three, "four" => "five" }] })
+        stringified_hash(:one => [{ :two => :three, "four" => "five" }]).
+        must_equal("one" => [{ "two" => :three, "four" => "five" }])
     end
   end
 
@@ -104,4 +104,62 @@ describe Kitchen::Util do
       Kitchen::Util.duration(48033).must_equal "(800m33.00s)"
     end
   end
+
+  describe ".wrap_unix_command" do
+
+    it "returns the wrapped command" do
+    end
+
+    it "returns a false if command is nil" do
+      Kitchen::Util.wrap_command(nil).must_equal("sh -c '\nfalse\n'")
+    end
+
+    it "returns a true if command string is empty" do
+      Kitchen::Util.wrap_command("yoyo").must_equal("sh -c '\nyoyo\n'")
+    end
+
+    it "handles a command string with a trailing newline" do
+      Kitchen::Util.wrap_command("yep\n").must_equal("sh -c '\nyep\n'")
+    end
+  end
+
+  describe ".outdent!" do
+
+    it "modifies the argument string in place, destructively" do
+      string = "yep"
+
+      Kitchen::Util.outdent!(string).object_id.must_equal string.object_id
+    end
+
+    it "returns the same string if no leading whitespace exists" do
+      string = "one\ntwo\nthree"
+
+      Kitchen::Util.outdent!(string).must_equal "one\ntwo\nthree"
+    end
+
+    it "strips same amount of leading whitespace as found on first line" do
+      string = "  one\n    two\n      three\nfour"
+
+      Kitchen::Util.outdent!(string).must_equal "one\n  two\n    three\nfour"
+    end
+  end
+
+  describe ".shell_helpers" do
+
+    %w[
+      exists do_wget do_curl do_fetch do_perl do_python do_download
+    ].each do |func|
+      it "contains a #{func} shell function" do
+        Kitchen::Util.shell_helpers.must_match "#{func}() {"
+      end
+    end
+
+    it "does not contain bare single quotes" do
+      Kitchen::Util.shell_helpers.wont_match "'"
+    end
+
+    def regexify(str)
+      Regexp.new("^\s+" + Regexp.escape(str) + "$")
+    end
+  end
 end

data/spec/kitchen_spec.rb

@@ -0,0 +1,107 @@
+# -*- encoding: utf-8 -*-
+#
+# Author:: Fletcher Nichol (<fnichol@nichol.ca>)
+#
+# Copyright (C) 2014, Fletcher Nichol
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require_relative "spec_helper"
+
+require "kitchen"
+
+describe "Kitchen" do
+
+  let(:stdout) { StringIO.new }
+
+  before do
+    FakeFS.activate!
+    FileUtils.mkdir_p(Dir.pwd)
+    stdout.stubs(:tty?).returns(true)
+    @orig_stdout = $stdout
+    $stdout = stdout
+  end
+
+  after do
+    $stdout = @orig_stdout
+    FakeFS.deactivate!
+    FakeFS::FileSystem.clear
+  end
+
+  describe "defaults" do
+
+    it "sets DEFAULT_LOG_LEVEL to :info" do
+      Kitchen::DEFAULT_LOG_LEVEL.must_equal :info
+    end
+
+    it "sets DEFAULT_TEST_DIR to test/integration, which is frozen" do
+      Kitchen::DEFAULT_TEST_DIR.must_equal "test/integration"
+      Kitchen::DEFAULT_TEST_DIR.frozen?.must_equal true
+    end
+
+    it "sets DEFAULT_LOG_DIR to .kitchen/logs, which is frozen" do
+      Kitchen::DEFAULT_LOG_DIR.must_equal ".kitchen/logs"
+      Kitchen::DEFAULT_LOG_DIR.frozen?.must_equal true
+    end
+  end
+
+  it ".tty? returns true if $stdout.tty? is true" do
+    Kitchen.tty?.must_equal true
+  end
+
+  it ".tty? returns flse is $stdout.tty? is false" do
+    stdout.stubs(:tty?).returns(false)
+
+    Kitchen.tty?.must_equal false
+  end
+
+  it ".source_root returns the root path of the gem" do
+    Kitchen.source_root.
+      must_equal Pathname.new(File.expand_path("../..", __FILE__))
+  end
+
+  it ".default_logger is a Kitchen::Logger" do
+    Kitchen.default_logger.must_be_instance_of Kitchen::Logger
+  end
+
+  it ".default_logger returns a $stdout logger" do
+    Kitchen.default_logger.warn("uhoh")
+
+    stdout.string.must_match %r{ uhoh$}
+  end
+
+  it ".default_file_logger is a Kitchen::Logger" do
+    Kitchen.default_file_logger.must_be_instance_of Kitchen::Logger
+  end
+
+  it ".default_file_logger returns a logger that uses $stdout" do
+    Kitchen.default_logger.warn("uhoh")
+
+    stdout.string.must_match %r{ uhoh$}
+  end
+
+  it ".default_file_logger returns a logger that uses a file" do
+    Kitchen.default_file_logger.warn("uhoh")
+
+    IO.read(File.join(%w[.kitchen logs kitchen.log])).
+      must_match %r{ -- Kitchen: uhoh$}
+  end
+
+  it "sets Kitchen.logger to a Kitchen::Logger" do
+    Kitchen.default_logger.must_be_instance_of Kitchen::Logger
+  end
+
+  it "sets Kitchen.mutex to a Mutex" do
+    Kitchen.mutex.must_be_instance_of Mutex
+  end
+end

data/spec/spec_helper.rb

@@ -16,24 +16,29 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-gem 'minitest'
+gem "minitest"
 
-require 'simplecov'
-SimpleCov.adapters.define 'gem' do
-  command_name 'Specs'
+if ENV["CODECLIMATE_REPO_TOKEN"]
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+elsif ENV["COVERAGE"]
+  require "simplecov"
+  SimpleCov.profiles.define "gem" do
+    command_name "Specs"
 
-  add_filter '.gem/'
-  add_filter '/spec/'
-  add_filter '/lib/vendor/'
+    add_filter ".gem/"
+    add_filter "/spec/"
+    add_filter "/lib/vendor/"
 
-  add_group 'Libraries', '/lib/'
+    add_group "Libraries", "/lib/"
+  end
+  SimpleCov.start "gem"
 end
-SimpleCov.start 'gem'
 
-require 'fakefs/safe'
-require 'minitest/autorun'
-require 'mocha/setup'
-require 'tempfile'
+require "fakefs/safe"
+require "minitest/autorun"
+require "mocha/setup"
+require "tempfile"
 
 # Nasty hack to redefine IO.read in terms of File#read for fakefs
 class IO

data/support/chef-client-zero.rb

@@ -17,19 +17,20 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require 'rubygems'
-require 'chef/config'
-require 'chef_zero/server'
-require 'chef/chef_fs/chef_fs_data_store'
-require 'chef/chef_fs/config'
-require 'fileutils'
+require "rubygems"
+require "chef/config"
+require "chef_zero/server"
+require "chef/chef_fs/chef_fs_data_store"
+require "chef/chef_fs/config"
+require "English"
+require "fileutils"
 
 # Bust out of our self-imposed sandbox before running chef-client so
 # gems installed via gem_package land in Chef's GEM_HOME.
 #
 # https://github.com/opscode/test-kitchen/issues/240
 #
-ENV['GEM_HOME'] = ENV['GEM_PATH'] = ENV['GEM_CACHE'] = nil
+ENV["GEM_HOME"] = ENV["GEM_PATH"] = ENV["GEM_CACHE"] = nil
 
 class ChefClientZero
 
@@ -64,12 +65,12 @@ class ChefClientZero
   end
 
   def repo_path
-    ENV.fetch('CHEF_REPO_PATH', Dir.pwd)
+    ENV.fetch("CHEF_REPO_PATH", Dir.pwd)
   end
 
   def run_chef_client
     system("chef-client", *ARGV)
-    fail if $? != 0
+    fail if $CHILD_STATUS != 0
   end
 end