test-kitchen 1.14.1 → 1.14.2

data/spec/kitchen/transport_spec.rb

@@ -25,14 +25,11 @@ require "kitchen/transport"
 require "kitchen/transport/base"
 
 module Kitchen
-
   module Transport
-
     class Coolbeans < Kitchen::Transport::Base
     end
 
     class ItDepends < Kitchen::Transport::Base
-
       attr_reader :verify_call_count
 
       def initialize(config = {})
@@ -46,7 +43,6 @@ module Kitchen
     end
 
     class UnstableDepends < Kitchen::Transport::Base
-
       def verify_dependencies
         raise UserError, "Oh noes, you don't have software!"
       end
@@ -55,9 +51,7 @@ module Kitchen
 end
 
 describe Kitchen::Transport do
-
   describe ".for_plugin" do
-
     before do
       Kitchen::Transport.stubs(:require).returns(true)
     end
@@ -69,7 +63,7 @@ describe Kitchen::Transport do
     end
 
     it "returns a transport initialized with its config" do
-      transport = Kitchen::Transport.for_plugin("coolbeans", :foo => "bar")
+      transport = Kitchen::Transport.for_plugin("coolbeans", foo: "bar")
 
       transport[:foo].must_equal "bar"
     end
@@ -92,21 +86,21 @@ describe Kitchen::Transport do
     it "raises ClientError if the transport could not be required" do
       Kitchen::Transport.stubs(:require).raises(LoadError)
 
-      proc { Kitchen::Transport.for_plugin("coolbeans", {}) }.
-        must_raise Kitchen::ClientError
+      proc { Kitchen::Transport.for_plugin("coolbeans", {}) }
+        .must_raise Kitchen::ClientError
     end
 
     it "raises ClientError if the transport's class constant was not found" do
       # pretend require worked
       Kitchen::Transport.stubs(:require).returns(true)
 
-      proc { Kitchen::Transport.for_plugin("nope", {}) }.
-        must_raise Kitchen::ClientError
+      proc { Kitchen::Transport.for_plugin("nope", {}) }
+        .must_raise Kitchen::ClientError
     end
 
     it "raises UserError if #verify_dependencies failes" do
-      proc { Kitchen::Transport.for_plugin("unstable_depends", {}) }.
-        must_raise Kitchen::UserError
+      proc { Kitchen::Transport.for_plugin("unstable_depends", {}) }
+        .must_raise Kitchen::UserError
     end
   end
 end

data/spec/kitchen/util_spec.rb

@@ -23,56 +23,51 @@ require "logger"
 require "kitchen/util"
 
 describe Kitchen::Util do
-
   describe ".to_logger_level" do
-
     it "returns nil for invalid symbols" do
       Kitchen::Util.to_logger_level(:nope).must_be_nil
     end
 
-    %w[debug info warn error fatal].each do |level|
+    %w{debug info warn error fatal}.each do |level|
       it "returns Logger::#{level.upcase} for :#{level} input" do
-        Kitchen::Util.to_logger_level(level.to_sym).
-          must_equal Logger.const_get(level.upcase)
+        Kitchen::Util.to_logger_level(level.to_sym)
+                     .must_equal Logger.const_get(level.upcase)
       end
     end
   end
 
   describe ".from_logger_level" do
-
     it "returns :fatal for invalid symbols" do
       Kitchen::Util.from_logger_level("nope").must_equal :fatal
     end
 
-    %w[debug info warn error fatal].each do |level|
+    %w{debug info warn error fatal}.each do |level|
       it "returns :#{level} for Logger::#{level.upcase} input" do
-        Kitchen::Util.from_logger_level(Logger.const_get(level.upcase)).
-          must_equal(level.to_sym)
+        Kitchen::Util.from_logger_level(Logger.const_get(level.upcase))
+                     .must_equal(level.to_sym)
       end
     end
   end
 
   describe ".symbolized_hash" do
-
     it "returns itself if not a hash" do
       obj = Object.new
       Kitchen::Util.symbolized_hash(obj).must_equal obj
     end
 
     it "preserves a symbolized hash" do
-      hash = { :one => [{ :two => "three" }] }
+      hash = { one: [{ two: "three" }] }
       Kitchen::Util.symbolized_hash(hash).must_equal hash
     end
 
     it "converts string keys into symbols" do
-      Kitchen::Util.
-        symbolized_hash("one" => [{ "two" => :three, :four => "five" }]).
-        must_equal(:one => [{ :two => :three, :four => "five" }])
+      Kitchen::Util
+        .symbolized_hash("one" => [{ "two" => :three, :four => "five" }])
+        .must_equal(one: [{ two: :three, four: "five" }])
     end
   end
 
   describe ".stringified_hash" do
-
     it "returns itself if not a hash" do
       obj = Object.new
       Kitchen::Util.stringified_hash(obj).must_equal obj
@@ -84,14 +79,13 @@ describe Kitchen::Util do
     end
 
     it "converts symbol keys into strings" do
-      Kitchen::Util.
-        stringified_hash(:one => [{ :two => :three, "four" => "five" }]).
-        must_equal("one" => [{ "two" => :three, "four" => "five" }])
+      Kitchen::Util
+        .stringified_hash(one: [{ :two => :three, "four" => "five" }])
+        .must_equal("one" => [{ "two" => :three, "four" => "five" }])
     end
   end
 
   describe ".duration" do
-
     it "turns nil into a zero" do
       Kitchen::Util.duration(nil).must_equal "(0m0.00s)"
     end
@@ -101,12 +95,11 @@ describe Kitchen::Util do
     end
 
     it "formats large values into minutes and seconds" do
-      Kitchen::Util.duration(48033).must_equal "(800m33.00s)"
+      Kitchen::Util.duration(48_033).must_equal "(800m33.00s)"
     end
   end
 
   describe ".wrap_unix_command" do
-
     it "returns the wrapped command" do
     end
 
@@ -124,7 +117,6 @@ describe Kitchen::Util do
   end
 
   describe ".outdent!" do
-
     it "modifies the argument string in place, destructively" do
       string = "yep"
 
@@ -145,10 +137,9 @@ describe Kitchen::Util do
   end
 
   describe ".shell_helpers" do
-
-    %w[
+    %w{
       exists do_wget do_curl do_fetch do_perl do_python do_download
-    ].each do |func|
+    }.each do |func|
       it "contains a #{func} shell function" do
         Kitchen::Util.shell_helpers.must_match "#{func}() {"
       end
@@ -159,7 +150,7 @@ describe Kitchen::Util do
     end
 
     def regexify(str)
-      Regexp.new("^\s+" + Regexp.escape(str) + "$")
+      Regexp.new("^ +" + Regexp.escape(str) + "$")
     end
   end
 end

data/spec/kitchen/verifier/base_spec.rb

@@ -26,11 +26,8 @@ require "kitchen/verifier/base"
 require "kitchen/transport/base"
 
 module Kitchen
-
   module Verifier
-
     class TestingDummy < Kitchen::Verifier::Base
-
       attr_reader :called_create_sandbox, :called_cleanup_sandbox
 
       def install_command
@@ -65,11 +62,10 @@ module Kitchen
 end
 
 describe Kitchen::Verifier::Base do
-
   let(:logged_output)   { StringIO.new }
   let(:logger)          { Logger.new(logged_output) }
-  let(:platform)        { stub(:os_type => nil, :shell_type => nil) }
-  let(:suite)           { stub(:name => "germany") }
+  let(:platform)        { stub(os_type: nil, shell_type: nil) }
+  let(:suite)           { stub(name: "germany") }
   let(:config)          { Hash.new }
 
   let(:transport) do
@@ -80,12 +76,12 @@ describe Kitchen::Verifier::Base do
 
   let(:instance) do
     stub(
-      :name => "coolbeans",
-      :to_str => "instance",
-      :logger => logger,
-      :platform => platform,
-      :suite => suite,
-      :transport => transport
+      name: "coolbeans",
+      to_str: "instance",
+      logger: logger,
+      platform: platform,
+      suite: suite,
+      transport: transport
     )
   end
 
@@ -94,9 +90,7 @@ describe Kitchen::Verifier::Base do
   end
 
   describe "configuration" do
-
     describe "for unix operating systems" do
-
       before { platform.stubs(:os_type).returns("unix") }
 
       it ":sudo defaults to true" do
@@ -113,7 +107,6 @@ describe Kitchen::Verifier::Base do
     end
 
     describe "for windows operating systems" do
-
       before { platform.stubs(:os_type).returns("windows") }
 
       it ":sudo defaults to nil" do
@@ -124,8 +117,8 @@ describe Kitchen::Verifier::Base do
         verifier[:sudo_command].must_equal nil
       end
 
-      it ":root_path defaults to $env:TEMP\\verifier" do
-        verifier[:root_path].must_equal "$env:TEMP\\verifier"
+      it ':root_path defaults to $env:TEMP\\verifier' do
+        verifier[:root_path].must_equal '$env:TEMP\\verifier'
       end
     end
 
@@ -147,7 +140,6 @@ describe Kitchen::Verifier::Base do
   end
 
   describe "#call" do
-
     let(:state) { Hash.new }
     let(:cmd)   { verifier.call(state) }
 
@@ -210,8 +202,8 @@ describe Kitchen::Verifier::Base do
     it "logs to info" do
       cmd
 
-      logged_output.string.
-        must_match(/INFO -- : Transferring files to instance$/)
+      logged_output.string
+                   .must_match(/INFO -- : Transferring files to instance$/)
     end
 
     it "uploads sandbox files" do
@@ -227,29 +219,27 @@ describe Kitchen::Verifier::Base do
     end
 
     it "raises an ActionFailed on transfer when TransportFailed is raised" do
-      connection.stubs(:upload).
-        raises(Kitchen::Transport::TransportFailed.new("dang"))
+      connection.stubs(:upload)
+                .raises(Kitchen::Transport::TransportFailed.new("dang"))
 
       proc { cmd }.must_raise Kitchen::ActionFailed
     end
 
     it "raises an ActionFailed on execute when TransportFailed is raised" do
-      connection.stubs(:execute).
-        raises(Kitchen::Transport::TransportFailed.new("dang"))
+      connection.stubs(:execute)
+                .raises(Kitchen::Transport::TransportFailed.new("dang"))
 
       proc { cmd }.must_raise Kitchen::ActionFailed
     end
   end
 
   [:init_command, :install_command, :prepare_command, :run_command].each do |cmd|
-
     it "has a #{cmd} method" do
       verifier.public_send(cmd).must_be_nil
     end
   end
 
   describe "sandbox" do
-
     after do
       begin
         verifier.cleanup_sandbox
@@ -265,8 +255,8 @@ describe Kitchen::Verifier::Base do
       verifier.create_sandbox
 
       File.directory?(verifier.sandbox_path).must_equal true
-      format("%o", File.stat(verifier.sandbox_path).mode)[1, 4].
-        must_equal "0755"
+      format("%o", File.stat(verifier.sandbox_path).mode)[1, 4]
+        .must_equal "0755"
     end
 
     it "#create_sandbox logs an info message" do
@@ -278,8 +268,8 @@ describe Kitchen::Verifier::Base do
     it "#create_sandbox logs a debug message" do
       verifier.create_sandbox
 
-      logged_output.string.
-        must_match debug_line_starting_with("Creating local sandbox in ")
+      logged_output.string
+                   .must_match debug_line_starting_with("Creating local sandbox in ")
     end
 
     it "#cleanup_sandbox deletes the sandbox directory" do
@@ -293,23 +283,21 @@ describe Kitchen::Verifier::Base do
       verifier.create_sandbox
       verifier.cleanup_sandbox
 
-      logged_output.string.
-        must_match debug_line_starting_with("Cleaning up local sandbox in ")
+      logged_output.string
+                   .must_match debug_line_starting_with("Cleaning up local sandbox in ")
     end
 
     def info_line(msg)
-      %r{^I, .* : #{Regexp.escape(msg)}$}
+      /^I, .* : #{Regexp.escape(msg)}$/
     end
 
     def debug_line_starting_with(msg)
-      %r{^D, .* : #{Regexp.escape(msg)}}
+      /^D, .* : #{Regexp.escape(msg)}/
     end
   end
 
   describe "#sudo" do
-
     describe "with :sudo set" do
-
       before { config[:sudo] = true }
 
       it "prepends sudo command" do
@@ -324,7 +312,6 @@ describe Kitchen::Verifier::Base do
     end
 
     describe "with :sudo falsey" do
-
       before { config[:sudo] = false }
 
       it "does not include sudo command" do
@@ -340,9 +327,7 @@ describe Kitchen::Verifier::Base do
   end
 
   describe "#prefix_command" do
-
     describe "with :command_prefix set" do
-
       before { config[:command_prefix] = "my_prefix" }
 
       it "prepends the command with the prefix" do
@@ -351,7 +336,6 @@ describe Kitchen::Verifier::Base do
     end
 
     describe "with :command_prefix unset" do
-
       before { config[:command_prefix] = nil }
 
       it "returns an unaltered command" do

data/spec/kitchen/verifier/busser_spec.rb

@@ -22,20 +22,19 @@ require "kitchen"
 require "kitchen/verifier/busser"
 
 describe Kitchen::Verifier::Busser do
-
   let(:logged_output) { StringIO.new }
   let(:logger)        { Logger.new(logged_output) }
   let(:config)        { Hash.new }
-  let(:platform)      { stub(:os_type => nil, :shell_type => nil) }
-  let(:suite)         { stub(:name => "germany") }
+  let(:platform)      { stub(os_type: nil, shell_type: nil) }
+  let(:suite)         { stub(name: "germany") }
 
   let(:instance) do
     stub(
-      :name => "coolbeans",
-      :logger => logger,
-      :platform => platform,
-      :suite => suite,
-      :to_str => "instance"
+      name: "coolbeans",
+      logger: logger,
+      platform: platform,
+      suite: suite,
+      to_str: "instance"
     )
   end
 
@@ -46,30 +45,30 @@ describe Kitchen::Verifier::Busser do
   let(:files) do
     {
       "mondospec/charlie" => {
-        :content => "charlie",
-        :perms => (running_tests_on_windows? ? "0644" : "0764")
+        content: "charlie",
+        perms: (running_tests_on_windows? ? "0644" : "0764"),
       },
       "minispec/beta" => {
-        :content => "beta",
-        :perms => "0644"
+        content: "beta",
+        perms: "0644",
       },
       "abba/alpha" => {
-        :content => "alpha",
-        :perms => (running_tests_on_windows? ? "0444" : "0440")
-      }
+        content: "alpha",
+        perms: (running_tests_on_windows? ? "0444" : "0440"),
+      },
     }
   end
 
   let(:helper_files) do
     {
       "minispec/spec_helper" => {
-        :content => "helping",
-        :perms => "0644"
+        content: "helping",
+        perms: "0644",
       },
       "abba/common" => {
-        :content => "yeppers",
-        :perms => (running_tests_on_windows? ? "0644" : "0664")
-      }
+        content: "yeppers",
+        perms: (running_tests_on_windows? ? "0644" : "0664"),
+      },
     }
   end
 
@@ -98,12 +97,10 @@ describe Kitchen::Verifier::Busser do
   end
 
   describe "configuration" do
-
     describe "for unix operating systems" do
-
-      before {
+      before do
         platform.stubs(:os_type).returns("unix")
-      }
+      end
 
       it ":ruby_bindir defaults the an Omnibus Chef installation" do
         verifier[:ruby_bindir].must_equal "/opt/chef/embedded/bin"
@@ -117,18 +114,17 @@ describe Kitchen::Verifier::Busser do
     end
 
     describe "for windows operating systems" do
-
       before { platform.stubs(:os_type).returns("windows") }
 
       it ":ruby_bindir defaults the an Omnibus Chef installation" do
-        verifier[:ruby_bindir].
-          must_equal "$env:systemdrive\\opscode\\chef\\embedded\\bin"
+        verifier[:ruby_bindir]
+          .must_equal '$env:systemdrive\\opscode\\chef\\embedded\\bin'
       end
 
       it ":busser_bin defaults to a binstub under :root_path" do
-        config[:root_path] = "\\beep"
+        config[:root_path] = '\\beep'
 
-        verifier[:busser_bin].must_equal "\\beep\\bin\\busser.bat"
+        verifier[:busser_bin].must_equal '\\beep\\bin\\busser.bat'
       end
     end
 
@@ -183,13 +179,10 @@ describe Kitchen::Verifier::Busser do
   end
 
   describe "#install_command" do
-
     let(:cmd) { verifier.install_command }
 
     describe "with no suite test files" do
-
       describe "for bourne shells" do
-
         before { platform.stubs(:shell_type).returns("bourne") }
 
         it "returns nil" do
@@ -198,7 +191,6 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for powershell shells on windows os types" do
-
         before do
           platform.stubs(:shell_type).returns("powershell")
           platform.stubs(:os_type).returns("windows")
@@ -211,9 +203,7 @@ describe Kitchen::Verifier::Busser do
     end
 
     describe "with suite test files" do
-
       describe "common behavior" do
-
         before do
           platform.stubs(:shell_type).returns("fake")
           create_test_files
@@ -233,7 +223,6 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for bourne shells" do
-
         before do
           platform.stubs(:shell_type).returns("bourne")
           create_test_files
@@ -259,8 +248,8 @@ describe Kitchen::Verifier::Busser do
 
         it "sets gem install arguments" do
           cmd.must_match regexify(
-            "gem_install_args=\"busser --no-rdoc --no-ri --no-format-executable" \
-            " -n /r/bin --no-user-install\""
+            'gem_install_args="busser --no-rdoc --no-ri --no-format-executable' \
+            ' -n /r/bin --no-user-install"'
           )
         end
 
@@ -281,13 +270,12 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for powershell shells on windows os types" do
-
         before do
           platform.stubs(:shell_type).returns("powershell")
           platform.stubs(:os_type).returns("windows")
           create_test_files
-          config[:ruby_bindir] = "\\rbd"
-          config[:root_path] = "\\r"
+          config[:ruby_bindir] = '\\rbd'
+          config[:root_path] = '\\r'
         end
 
         common_powershell_variable_specs
@@ -308,8 +296,8 @@ describe Kitchen::Verifier::Busser do
 
         it "sets gem install arguments" do
           cmd.must_match regexify(
-            "$gem_install_args = \"busser --no-rdoc --no-ri --no-format-executable" \
-            " -n \\r\\bin --no-user-install\""
+            '$gem_install_args = "busser --no-rdoc --no-ri --no-format-executable' \
+            ' -n \\r\\bin --no-user-install"'
           )
         end
 
@@ -326,13 +314,10 @@ describe Kitchen::Verifier::Busser do
   end
 
   describe "#init_command" do
-
     let(:cmd) { verifier.init_command }
 
     describe "with no suite test files" do
-
       describe "for bourne shells" do
-
         before { platform.stubs(:shell_type).returns("bourne") }
 
         it "returns nil" do
@@ -341,7 +326,6 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for powershell shells on windows os types" do
-
         before do
           platform.stubs(:shell_type).returns("powershell")
           platform.stubs(:os_type).returns("windows")
@@ -354,9 +338,7 @@ describe Kitchen::Verifier::Busser do
     end
 
     describe "with suite test files" do
-
       describe "common behavior" do
-
         before do
           platform.stubs(:shell_type).returns("fake")
           create_test_files
@@ -376,7 +358,6 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for bourne shells" do
-
         before do
           platform.stubs(:shell_type).returns("bourne")
           create_test_files
@@ -403,19 +384,18 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for powershell shells on windows os types" do
-
         before do
           platform.stubs(:shell_type).returns("powershell")
           platform.stubs(:os_type).returns("windows")
           create_test_files
-          config[:ruby_bindir] = "\\rbd"
-          config[:root_path] = "\\r"
+          config[:ruby_bindir] = '\\rbd'
+          config[:root_path] = '\\r'
         end
 
         common_powershell_variable_specs
 
         it "runs busser's suite cleanup" do
-          config[:root_path] = "\\b"
+          config[:root_path] = '\\b'
 
           cmd.must_match regexify(%{& \\b\\bin\\busser.bat suite cleanup})
         end
@@ -424,13 +404,10 @@ describe Kitchen::Verifier::Busser do
   end
 
   describe "#run_command" do
-
     let(:cmd) { verifier.run_command }
 
     describe "with no suite test files" do
-
       describe "for bourne shells" do
-
         before { platform.stubs(:shell_type).returns("bourne") }
 
         it "returns nil" do
@@ -439,7 +416,6 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for powershell shells on windows os types" do
-
         before do
           platform.stubs(:shell_type).returns("powershell")
           platform.stubs(:os_type).returns("windows")
@@ -452,9 +428,7 @@ describe Kitchen::Verifier::Busser do
     end
 
     describe "with suite test files" do
-
       describe "common behavior" do
-
         before do
           platform.stubs(:shell_type).returns("fake")
           create_test_files
@@ -474,7 +448,6 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for bourne shells" do
-
         before do
           platform.stubs(:shell_type).returns("bourne")
           create_test_files
@@ -501,19 +474,18 @@ describe Kitchen::Verifier::Busser do
       end
 
       describe "for powershell shells on windows os types" do
-
         before do
           platform.stubs(:shell_type).returns("powershell")
           platform.stubs(:os_type).returns("windows")
           create_test_files
-          config[:ruby_bindir] = "\\rbd"
-          config[:root_path] = "\\r"
+          config[:ruby_bindir] = '\\rbd'
+          config[:root_path] = '\\r'
         end
 
         common_powershell_variable_specs
 
         it "runs busser's test" do
-          config[:root_path] = "\\b"
+          config[:root_path] = '\\b'
 
           cmd.must_match regexify(%{& \\b\\bin\\busser.bat test})
         end
@@ -522,7 +494,6 @@ describe Kitchen::Verifier::Busser do
   end
 
   describe "#create_sandbox" do
-
     before do
       create_test_files
     end
@@ -557,7 +528,6 @@ describe Kitchen::Verifier::Busser do
   end
 
   describe "Busser legacy behavior for code calling old method names" do
-
     let(:busser) { verifier }
 
     it "responds to #setup_cmd which calls #install_command" do
@@ -605,6 +575,6 @@ describe Kitchen::Verifier::Busser do
   end
 
   def warn_line_with(msg)
-    %r{^W, .* : #{Regexp.escape(msg)}}
+    /^W, .* : #{Regexp.escape(msg)}/
   end
 end