tessa 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7f3dd0551a23f631be89b7befc712c7ddbd0e59
-  data.tar.gz: 35378a19a53e6f06410b4527618ea422040a6fdd
+  metadata.gz: 8a12436b10f2fa00988bce92ba546e84d7d39f33
+  data.tar.gz: b601a69166646ac06659519cecee7f487609edbf
 SHA512:
-  metadata.gz: 2b13cd9b633e0a3185a5dcea73743c99e8362348ee5640433185fa3d66fae7467c641e2204cd1499767c7ff2801cc4b8d49aa8c793b79357db6fa0214ac9537e
-  data.tar.gz: 08a6da9b9941798f92fe9957b6754e0cdc8434cd31eaa5d7afec23ce55e79ce6cdf0dfcae8ec64132236887b0a33f90734f7e3522f8ce3088606defa5ab3373a
+  metadata.gz: eb4517664519fcf6f650fc715b1f08cf556df91618bf7ba52a1171b6f9f11fc0bf452276562c563c19ba99a178837422e1fa2e5d8d55ebff89f510fac297d925
+  data.tar.gz: a83ec8ea8bc251c9d9420654e98b728d5e524bebade9ad89f3174b11eaebae433a0fa5259137afd6588b3c1ffdc94cc5e990fff24da091b675b259270f18a19f

data/.travis.yml

@@ -4,3 +4,6 @@ notifications:
   email: false
 rvm:
   - 2.1.0
+addons:
+  code_climate:
+    repo_token: a1d1020f21ac7490fa6c577e7718c505a0bc7f13a5e4537ec7ca9f1a594bad07

data/Gemfile

@@ -7,3 +7,7 @@ group :development do
   gem 'pry'
   gem 'dotenv'
 end
+
+group :test do
+  gem "codeclimate-test-reporter", require: nil
+end

data/README.md

@@ -35,12 +35,12 @@ TODO: Write usage instructions here
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
 
-  [0]: https://github.com/watermarkchurch/tessa
+  [0]: https://github.com/watermarkchurch/tessa-client
   [1]: https://img.shields.io/gem/v/tessa.svg?style=flat
   [2]: http://rubygems.org/gems/tessa "Gem Version"
-  [3]: https://img.shields.io/travis/watermarkchurch/tessa/master.svg?style=flat
-  [4]: https://travis-ci.org/watermarkchurch/tessa "Build Status"
-  [5]: https://codeclimate.com/github/watermarkchurch/tessa/badges/coverage.svg
-  [6]: https://codeclimate.com/github/watermarkchurch/tessa "Coverage Status"
-  [7]: https://img.shields.io/codeclimate/github/watermarkchurch/tessa.svg?style=flat
-  [8]: https://codeclimate.com/github/watermarkchurch/tessa "Code Climate"
+  [3]: https://img.shields.io/travis/watermarkchurch/tessa-client/master.svg?style=flat
+  [4]: https://travis-ci.org/watermarkchurch/tessa-client "Build Status"
+  [5]: https://codeclimate.com/github/watermarkchurch/tessa-client/badges/coverage.svg
+  [6]: https://codeclimate.com/github/watermarkchurch/tessa-client "Coverage Status"
+  [7]: https://img.shields.io/codeclimate/github/watermarkchurch/tessa-client.svg?style=flat
+  [8]: https://codeclimate.com/github/watermarkchurch/tessa-client "Code Climate"

data/lib/tessa.rb

@@ -13,7 +13,7 @@ require "tessa/controller_helpers"
 require "tessa/model"
 require "tessa/rack_upload_proxy"
 require "tessa/upload"
-
+require "tessa/view_helpers"
 
 module Tessa
   def self.config

data/lib/tessa/asset.rb

@@ -27,5 +27,11 @@ module Tessa
                   connection: Tessa.config.connection)
       new_from_response connection.get("/assets/#{ids.join(",")}")
     end
+
+    def failure?
+      false
+    end
   end
 end
+
+require 'tessa/asset/failure'

data/lib/tessa/asset/failure.rb

@@ -0,0 +1,37 @@
+require 'delegate'
+
+class Tessa::Asset::Failure < SimpleDelegator
+  attr_reader :message
+
+  def initialize(id:, message:)
+    @message = message
+    super(::Tessa::Asset.new(id: id))
+  end
+
+  def self.factory(id:, response:)
+    new(id: id, message: message_from_status(response.status))
+  end
+
+  def self.message_from_status(status)
+    case status.to_s
+    when /5\d{2}/
+      "The service is unavailable at this time."
+    when /4\d{2}/
+      "There was a problem retrieving the data for this asset."
+    else
+      "An error occurred."
+    end
+  end
+
+  def failure?
+    true
+  end
+
+  def meta
+    {
+      name: "Not Found",
+      size: "0",
+      mime_type: "application/octet-stream"
+    }
+  end
+end

data/lib/tessa/model.rb

@@ -38,6 +38,14 @@ module Tessa
         else
           Tessa::Asset.find(ids)
         end
+      rescue Tessa::RequestFailed => err
+        if ids.is_a?(Array)
+          ids.map do |id|
+            Tessa::Asset::Failure.factory(id: id, response: err.response)
+          end
+        else
+          Tessa::Asset::Failure.factory(id: ids, response: err.response)
+        end
       end
 
     end

data/lib/tessa/version.rb

@@ -1,3 +1,3 @@
 module Tessa
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/lib/tessa/view_helpers.rb

@@ -0,0 +1,21 @@
+module Tessa
+  module ViewHelpers
+    def tessa_image_tag(asset)
+      handle_asset_failure(asset) do
+        image_tag(asset.private_url)
+      end
+    end
+
+    private
+
+    def handle_asset_failure(asset)
+      if asset.failure?
+        content_tag(:div, asset.message, class: "tessa-asset-failure")
+      else
+        yield
+      end
+    end
+  end
+end
+
+ActionView::Base.send :include, Tessa::ViewHelpers if defined?(ActionView)

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
 require 'tessa'
 
 Dir[File.expand_path("../support/*.rb", __FILE__)].each do |file|

data/spec/tessa/asset/failure_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+RSpec.describe Tessa::Asset::Failure do
+  subject(:failure) { described_class.new(args) }
+  let(:id) { rand(100) }
+  let(:args) {
+    { id: id, message: "Test" }
+  }
+
+  describe "#initialize" do
+    it "sets id to attribute" do
+      expect(failure.id).to eq(args[:id])
+    end
+
+    it "sets message to attribute" do
+      expect(failure.message).to eq(args[:message])
+    end
+  end
+
+  describe ".factory" do
+    let(:message) { 'test message' }
+    let(:response) { double(status: 500) }
+    subject(:failure) { described_class.factory(id: id, response: response) }
+
+
+    it "returns instance of Failure" do
+      expect(described_class).to receive(:message_from_status)
+        .with(response.status).and_return(message)
+      expect(failure.id).to eq(id)
+      expect(failure.message).to eq(message)
+    end
+  end
+
+  it "responds like a blank asset" do
+    asset = Tessa::Asset.new
+    expect(failure.status).to eq(asset.status)
+    expect(failure.strategy).to eq(asset.strategy)
+    expect(failure.public_url).to eq(asset.public_url)
+    expect(failure.private_url).to eq(asset.private_url)
+    expect(failure.delete_url).to eq(asset.delete_url)
+  end
+
+  describe "#failure?" do
+    it "returns true" do
+      expect(failure).to be_failure
+    end
+  end
+end

data/spec/tessa/asset_change_set_spec.rb

@@ -90,8 +90,8 @@ RSpec.describe Tessa::AssetChangeSet do
       }
 
       it "only calls apply on unique elements" do
-        expect(set.changes[0]).to receive(:apply)
-        expect(set.changes[1]).not_to receive(:apply)
+        expect(el = set.changes.uniq.first).to receive(:apply)
+        (set.changes - [el]).each { |o| expect(el).to_not receive(:apply) }
         set.apply
       end
     end

data/spec/tessa/asset_spec.rb

@@ -65,7 +65,13 @@ RSpec.describe Tessa::Asset do
     include_examples "remote call macro", :delete, "/assets/123", Tessa::Asset
   end
 
-  describe "#find" do
+  describe "#failure?" do
+    it "returns false" do
+      expect(asset.failure?).to be(false)
+    end
+  end
+
+  describe ".find" do
     let(:faraday_stubs) {
       Faraday::Adapter::Test::Stubs.new do |stub|
         stub.get("/assets/#{id_query}") { |env| [200, {}, remote_response.to_json] }

data/spec/tessa/model_spec.rb

@@ -327,6 +327,81 @@ RSpec.describe Tessa::Model do
     end
   end
 
+  describe "#fetch_tessa_remote_assets" do
+    subject(:result) { model.new.fetch_tessa_remote_assets(arg) }
+
+    before do
+      model.asset :avatar
+    end
+
+    context "argument is `nil`" do
+      let(:arg) { nil }
+
+      it "returns nil" do
+        expect(result).to be_nil
+      end
+    end
+
+    context "argument is `[]`" do
+      let(:arg) { [] }
+
+      it "returns []" do
+        expect(result).to be_a(Array)
+        expect(result).to be_empty
+      end
+    end
+
+    context "when argument is not blank" do
+      let(:id) { rand(100) }
+      let(:arg) { id }
+
+      it "calls Tessa::Asset.find with arguments" do
+        expect(Tessa::Asset).to receive(:find).with(arg)
+        result
+      end
+
+      context "when Tessa::Asset.find raises RequestFailed exception" do
+        let(:error) {
+          Tessa::RequestFailed.new("test exception", double(status: '500'))
+        }
+
+        before do
+          allow(Tessa::Asset).to receive(:find).and_raise(error)
+        end
+
+        context "argument is single id" do
+          let(:arg) { id }
+
+          it "returns Failure" do
+            expect(result).to be_a(Tessa::Asset::Failure)
+          end
+
+          it "returns asset with proper data" do
+            expect(result.id).to eq(arg)
+          end
+        end
+
+        context "argument is array" do
+          let(:arg) { [ id, id * 2 ] }
+
+          it "returns array" do
+            expect(result).to be_a(Array)
+          end
+
+          it "returns instances of Failure" do
+            expect(result).to all( be_a(Tessa::Asset::Failure) )
+          end
+
+          it "returns array with an asset for each id passed" do
+            arg.zip(result) do |a, r|
+              expect(r.id).to eq(a)
+            end
+          end
+        end
+      end
+    end
+  end
+
   describe "#remove_all_tessa_assets" do
     let(:instance) { model.new }
     before do

data/tessa.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["jpowell@watermark.org", "tpetticrew@watermark.org"]
   spec.summary       = %q{Manage your assets.}
   spec.description   = %q{Manage your assets.}
-  spec.homepage      = "https://github.com/watermarkchurch/tessa"
+  spec.homepage      = "https://github.com/watermarkchurch/tessa-client"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tessa
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Justin Powell
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-20 00:00:00.000000000 Z
+date: 2015-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -99,6 +99,7 @@ files:
 - Rakefile
 - lib/tessa.rb
 - lib/tessa/asset.rb
+- lib/tessa/asset/failure.rb
 - lib/tessa/asset_change.rb
 - lib/tessa/asset_change_set.rb
 - lib/tessa/config.rb
@@ -109,8 +110,10 @@ files:
 - lib/tessa/response_factory.rb
 - lib/tessa/upload.rb
 - lib/tessa/version.rb
+- lib/tessa/view_helpers.rb
 - spec/spec_helper.rb
 - spec/support/remote_call_macro.rb
+- spec/tessa/asset/failure_spec.rb
 - spec/tessa/asset_change_set_spec.rb
 - spec/tessa/asset_change_spec.rb
 - spec/tessa/asset_spec.rb
@@ -121,7 +124,7 @@ files:
 - spec/tessa/rack_upload_proxy_spec.rb
 - spec/tessa/upload_spec.rb
 - tessa.gemspec
-homepage: https://github.com/watermarkchurch/tessa
+homepage: https://github.com/watermarkchurch/tessa-client
 licenses:
 - MIT
 metadata: {}
@@ -148,6 +151,7 @@ summary: Manage your assets.
 test_files:
 - spec/spec_helper.rb
 - spec/support/remote_call_macro.rb
+- spec/tessa/asset/failure_spec.rb
 - spec/tessa/asset_change_set_spec.rb
 - spec/tessa/asset_change_spec.rb
 - spec/tessa/asset_spec.rb