terrestrial 0.1.1 → 0.3.0

data/spec/graph_persistence_spec.rb

@@ -1,28 +1,26 @@
 require "spec_helper"
 
 require "support/have_persisted_matcher"
-require "support/mapper_setup"
-require "support/sequel_persistence_setup"
+require "support/object_store_setup"
 require "support/seed_data_setup"
 require "terrestrial"
 
 RSpec.describe "Graph persistence" do
-  include_context "mapper setup"
-  include_context "sequel persistence setup"
+  include_context "object store setup"
   include_context "seed data setup"
 
-  subject(:mapper) { mappers.fetch(:users) }
+  subject(:user_store) { object_store.fetch(:users) }
 
   let(:user) {
-    mapper.where(id: "users/1").first
+    user_store.where(id: "users/1").first
   }
 
   context "without associations" do
-    let(:modified_email) { "bestie+modified@gmail.com" }
+    let(:modified_email) { "hasel+modified@gmail.com" }
 
     it "saves the root object" do
       user.email = modified_email
-      mapper.save(user)
+      user_store.save(user)
 
       expect(datastore).to have_persisted(
         :users,
@@ -35,7 +33,7 @@ RSpec.describe "Graph persistence" do
 
     it "doesn't send associated objects to the database as columns" do
       user.email = modified_email
-      mapper.save(user)
+      user_store.save(user)
 
       expect(datastore).not_to have_persisted(
         :users,
@@ -50,7 +48,7 @@ RSpec.describe "Graph persistence" do
       it "saves the object" do
         user.email << "MUTATED"
 
-        mapper.save(user)
+        user_store.save(user)
 
         expect(datastore).to have_persisted(
           :users,
@@ -69,7 +67,7 @@ RSpec.describe "Graph persistence" do
 
     it "saves the associated object" do
       post.body = modified_post_body
-      mapper.save(user)
+      user_store.save(user)
 
       expect(datastore).to have_persisted(
         :posts,
@@ -92,7 +90,7 @@ RSpec.describe "Graph persistence" do
 
     it "saves the associated object" do
       comment.body = modified_comment_body
-      mapper.save(user)
+      user_store.save(user)
 
       expect(datastore).to have_persisted(
         :comments,
@@ -133,7 +131,7 @@ RSpec.describe "Graph persistence" do
     it "persists the object" do
       user.posts.push(new_post)
 
-      mapper.save(user)
+      user_store.save(user)
 
       expect(datastore).to have_persisted(
         :posts,
@@ -144,6 +142,18 @@ RSpec.describe "Graph persistence" do
         )
       )
     end
+
+    context "when the collection is not loaded until the new object is persisted" do
+      it "is consistent with the datastore" do
+        user.posts.push(new_post)
+
+        user_store.save(user)
+
+        expect(user.posts.to_a.map(&:id)).to eq(
+          ["posts/1", "posts/2", "posts/neu"]
+        )
+      end
+    end
   end
 
   context "delete an object from a has many association" do
@@ -157,7 +167,7 @@ RSpec.describe "Graph persistence" do
 
     it "delete the object from the datastore on save" do
       user.posts.delete(post)
-      mapper.save(user)
+      user_store.save(user)
 
       expect(datastore).not_to have_persisted(
         :posts,
@@ -182,7 +192,7 @@ RSpec.describe "Graph persistence" do
       it "deletes the 'join table' record" do
         category = post.categories.first
         post.categories.delete(category)
-        mapper.save(user)
+        user_store.save(user)
 
         expect(datastore).not_to have_persisted(
           :categories_to_posts,
@@ -196,7 +206,7 @@ RSpec.describe "Graph persistence" do
       it "does not delete the object" do
         category = post.categories.first
         post.categories.delete(category)
-        mapper.save(user)
+        user_store.save(user)
 
         expect(datastore).to have_persisted(
           :categories,
@@ -220,7 +230,7 @@ RSpec.describe "Graph persistence" do
 
       it "persists the change" do
         post_with_one_category.categories.push(new_category)
-        mapper.save(user)
+        user_store.save(user)
 
         expect(datastore).to have_persisted(
           :categories_to_posts,
@@ -245,7 +255,7 @@ RSpec.describe "Graph persistence" do
 
       it "persists the change" do
         category.name = modified_category_name
-        mapper.save(user)
+        user_store.save(user)
 
         expect(datastore).to have_persisted(
           :categories,
@@ -258,13 +268,13 @@ RSpec.describe "Graph persistence" do
     end
 
     context "node loaded as root has undefined one to many association" do
-      let(:post_mapper) { mappers[:posts] }
-      let(:post) { post_mapper.where(id: "posts/1").first }
+      let(:post_store) { object_store[:posts] }
+      let(:post) { post_store.where(id: "posts/1").first }
 
       it "persists the changes to the root node" do
         post.body = "modified body"
 
-        post_mapper.save(post)
+        post_store.save(post)
 
         expect(datastore).to have_persisted(
           :posts,
@@ -278,7 +288,7 @@ RSpec.describe "Graph persistence" do
       it "does not overwrite unused foreign key" do
         post.body = "modified body"
 
-        post_mapper.save(post)
+        post_store.save(post)
 
         expect(datastore).to have_persisted(
           :posts,
@@ -291,6 +301,52 @@ RSpec.describe "Graph persistence" do
     end
   end
 
+  context "when a many to one association is nil" do
+    context "when the object does not have a reference to its parent" do
+      it "populates that association with a nil" do
+        post = Post.new(
+          id: "posts/orphan",
+          subject: "Nils gonna getcha",
+          body: "",
+          created_at: Time.parse("2015-09-05T15:00:00+01:00"),
+          categories: [],
+          comments: [],
+        )
+
+        object_store[:posts].save(post)
+
+        expect(datastore).to have_persisted(
+          :posts,
+          hash_including(
+            id: "posts/orphan",
+            author_id: nil,
+          )
+        )
+      end
+    end
+
+    context "when an existing partent object reference is set to nil" do
+      it "populates that association with a nil" do
+        comment = user
+          .posts
+          .flat_map(&:comments)
+          .detect { |c| c.id == "comments/1" }
+
+        comment.commenter = nil
+
+        user_store.save(user)
+
+        expect(datastore).to have_persisted(
+          :comments,
+          hash_including(
+            id: "comments/1",
+            commenter_id: nil,
+          )
+        )
+      end
+    end
+  end
+
   context "when a save operation fails (some object is not persistable)" do
     let(:unpersistable_object) { ->() { } }
 
@@ -301,8 +357,8 @@ RSpec.describe "Graph persistence" do
         user.first_name = "this will be rolled back"
         user.posts.first.subject = unpersistable_object
 
-        mapper.save(user)
-      rescue Sequel::Error
+        user_store.save(user)
+      rescue Terrestrial::Error
       end
 
       post_change = datastore[:users].to_a.map(&:to_a).sort

data/spec/graph_traversal_spec.rb

@@ -1,20 +1,18 @@
 require "spec_helper"
 
-require "support/mapper_setup"
-require "support/sequel_persistence_setup"
+require "support/object_store_setup"
 require "support/seed_data_setup"
 require "terrestrial"
 
 RSpec.describe "Graph traversal" do
-  include_context "mapper setup"
-  include_context "sequel persistence setup"
+  include_context "object store setup"
   include_context "seed data setup"
 
   describe "associations" do
-    subject(:mapper) { user_mapper }
+    subject(:user_store) { object_store[:users] }
 
     let(:user_query) {
-      mapper.where(id: "users/1")
+      user_store.where(id: "users/1")
     }
 
     let(:user) { user_query.first }
@@ -43,6 +41,16 @@ RSpec.describe "Graph traversal" do
       ).to eq("oh noes")
     end
 
+    context "when a many to one association foreign key is nil" do
+      before do
+        datastore[:comments].update(commenter_id: nil)
+      end
+
+      it "populates that association with a nil" do
+        expect(user.posts.flat_map(&:comments).flat_map(&:commenter).uniq).to eq([nil])
+      end
+    end
+
     describe "lazy loading" do
       let(:post_factory) { double(:post_factory, call: nil) }
 

data/spec/new_graph_persistence_spec.rb

@@ -1,15 +1,13 @@
 require "spec_helper"
-require "support/mapper_setup"
-require "support/sequel_persistence_setup"
+require "support/object_store_setup"
 require "support/have_persisted_matcher"
 
 RSpec.describe "Persist a new graph in empty datastore" do
-  include_context "mapper setup"
-  include_context "sequel persistence setup"
+  include_context "object store setup"
 
   context "given a graph of new objects" do
     it "persists the root node" do
-      user_mapper.save(hansel)
+      object_store[:users].save(hansel)
 
       expect(datastore).to have_persisted(:users, {
         id: hansel.id,
@@ -20,7 +18,7 @@ RSpec.describe "Persist a new graph in empty datastore" do
     end
 
     it "persists one to many related nodes 1 level deep" do
-      user_mapper.save(hansel)
+      object_store[:users].save(hansel)
 
       expect(datastore).to have_persisted(:posts, hash_including(
         id: "posts/1",
@@ -39,7 +37,7 @@ RSpec.describe "Persist a new graph in empty datastore" do
 
     context "deep node with two foreign keys" do
       it "persists the node with both foreign keys" do
-        user_mapper.save(hansel)
+        object_store[:users].save(hansel)
 
         expect(datastore).to have_persisted(:comments, {
           id: "comments/1",
@@ -51,7 +49,7 @@ RSpec.describe "Persist a new graph in empty datastore" do
     end
 
     it "persists many to many related nodes" do
-      user_mapper.save(hansel)
+      object_store[:users].save(hansel)
 
       expect(datastore).to have_persisted(:categories, {
         id: "categories/1",
@@ -60,12 +58,48 @@ RSpec.describe "Persist a new graph in empty datastore" do
     end
 
     it "persists a 'join table' to faciliate many to many" do
-      user_mapper.save(hansel)
+      object_store[:users].save(hansel)
 
       expect(datastore).to have_persisted(:categories_to_posts, {
         category_id: "categories/1",
         post_id: "posts/1",
       })
     end
+
+    context "when saving an object a second time" do
+      context "when the first time fails" do
+        before do
+          error = attempt_unpersistable_save
+          unless error.is_a?(Terrestrial::UpsertError)
+            raise "Unpersistable save did not raise an error. Expected this save to fail."
+          end
+          hansel.email = "hansel@gmail.com"
+        end
+
+        let(:unpersistable) { ->() {} }
+
+        it "successfully saves all attributes the second time" do
+          object_store[:users].save(hansel)
+
+          expect(datastore).to have_persisted(
+            :users,
+            hash_including(
+              id: hansel.id,
+              email: hansel.email,
+              first_name: hansel.first_name,
+              last_name: hansel.last_name,
+            )
+          )
+        end
+
+        def attempt_unpersistable_save
+          email = hansel.email
+          hansel.email = unpersistable
+          object_store[:users].save(hansel)
+        rescue Terrestrial::UpsertError => e
+          e
+        end
+      end
+    end
   end
 end

data/spec/object_identity_spec.rb

@@ -1,18 +1,16 @@
 require "spec_helper"
 
-require "support/mapper_setup"
-require "support/sequel_persistence_setup"
+require "support/object_store_setup"
 require "support/seed_data_setup"
 require "terrestrial"
 
 RSpec.describe "Object identity" do
-  include_context "mapper setup"
-  include_context "sequel persistence setup"
+  include_context "object store setup"
   include_context "seed data setup"
 
-  subject(:mapper) { mappers.fetch(:users) }
+  subject(:user_store) { object_store.fetch(:users) }
 
-  let(:user) { mapper.where(id: "users/1").first }
+  let(:user) { user_store.where(id: "users/1").first }
   let(:post) { user.posts.first }
 
   context "when using arbitrary where query" do
@@ -46,7 +44,7 @@ RSpec.describe "Object identity" do
     end
 
     context "when eager loading" do
-      let(:user_query) { mapper.where(id: "users/1") }
+      let(:user_query) { user_store.where(id: "users/1") }
 
       let(:eager_category) {
         user_query

data/spec/ordered_association_spec.rb

@@ -1,18 +1,16 @@
 require "spec_helper"
 
-require "support/mapper_setup"
-require "support/sequel_persistence_setup"
+require "support/object_store_setup"
 require "support/seed_data_setup"
 require "terrestrial"
 require "terrestrial/configurations/conventional_configuration"
 
 RSpec.describe "Ordered associations" do
-  include_context "mapper setup"
-  include_context "sequel persistence setup"
+  include_context "object store setup"
   include_context "seed data setup"
 
   context "one to many association ordered by `created_at DESC`" do
-    let(:posts) { user_mapper.first.posts }
+    let(:posts) { object_store[:users].first.posts }
 
     before do
       configs.fetch(:users).fetch(:associations).fetch(:posts).merge!(
@@ -40,7 +38,7 @@ RSpec.describe "Ordered associations" do
       )
     end
 
-    let(:categories) { user_mapper.first.posts.first.categories }
+    let(:categories) { object_store[:users].first.posts.first.categories }
 
     it "enumerates the objects in order specified in the config" do
       expect(categories.map(&:id)).to eq(

data/spec/predefined_queries_spec.rb

@@ -1,17 +1,15 @@
 require "spec_helper"
 
-require "support/mapper_setup"
-require "support/sequel_persistence_setup"
+require "support/object_store_setup"
 require "support/seed_data_setup"
 require "terrestrial"
 require "terrestrial/configurations/conventional_configuration"
 
 RSpec.describe "Predefined subset queries" do
-  include_context "mapper setup"
-  include_context "sequel persistence setup"
+  include_context "object store setup"
   include_context "seed data setup"
 
-  subject(:users) { user_mapper }
+  subject(:users) { object_store[:users] }
 
   context "on the top level mapper" do
     context "subset is defined with a block" do
@@ -41,7 +39,7 @@ RSpec.describe "Predefined subset queries" do
       configs.fetch(:posts).merge!(
         subsets: {
           body_contains: ->(dataset, search_string) {
-            dataset.where("body like '%#{search_string}%'")
+            dataset.where(body: /#{search_string}/)
           },
         },
       )