termtter 1.6.0 → 1.7.0

data/lib/termtter/rubytter_proxy.rb

@@ -1,13 +1,17 @@
+config.set_default(:memory_cache_size, 10000)
+
 module Termtter
   class RubytterProxy
     include Hookable
 
+    attr_reader :rubytter
+
     def initialize(*args)
       @rubytter = Rubytter.new(*args)
     end
 
     def method_missing(method, *args, &block)
-      if @rubytter.methods.include?(method.to_s)
+      if @rubytter.respond_to?(method)
         result = nil
         begin
           modified_args = args
@@ -16,9 +20,9 @@ module Termtter
             modified_args = hook.call(*modified_args)
           end
 
-          timeout(config.timeout) do
-            result = @rubytter.__send__(method, *modified_args)
-          end
+          from = Time.now
+          result = call_rubytter_or_use_cache(method, *modified_args, &block)
+          Termtter::Client.logger.debug "rubytter_proxy: #{method}(#{modified_args.inspect[1...-1]}), %.2fsec" % (Time.now - from)
 
           self.class.call_hooks("post_#{method}", *args)
         rescue HookCanceled
@@ -28,5 +32,62 @@ module Termtter
         super
       end
     end
+
+    def status_cache_store
+      # TODO: DB store とかにうまいこと切り替えられるようにしたい
+      @status_cache_store ||= MemoryCache.new(config.memory_cache_size)
+    end
+
+    def users_cache_store
+      @users_cache_store ||= MemoryCache.new(config.memory_cache_size)
+    end
+
+    def cached_user(screen_name)
+      users_cache_store[screen_name]
+    end
+
+    def call_rubytter_or_use_cache(method, *args, &block)
+      case method
+      when :show
+        if status_cache_store.key?(args[0].to_i)
+          status_cache_store[args[0].to_i]
+        else
+          status = call_rubytter(method, *args, &block)
+          store_status_cache(status)
+          status
+        end
+      when :home_timeline, :user_timeline, :friends_timeline, :search
+        statuses = call_rubytter(method, *args, &block)
+        statuses.each do |status|
+          store_status_cache(status)
+        end
+        statuses
+      else
+        call_rubytter(method, *args, &block)
+      end
+    end
+
+    def store_status_cache(status)
+      return if status_cache_store.key?(status.id)
+      status_cache_store[status.id] = status
+      store_user_cache(status.user)
+    end
+
+    def store_user_cache(user)
+      return if users_cache_store.key?(user.screen_name)
+      users_cache_store[user.screen_name] = user
+    end
+
+    def call_rubytter(method, *args, &block)
+      config.retry.times do
+        begin
+          timeout(config.timeout) do
+            return @rubytter.__send__(method, *args, &block)
+          end
+        rescue TimeoutError
+        end
+      end
+      raise TimeoutError, 'execution expired'
+    end
   end
 end

data/lib/termtter/system_extensions.rb

@@ -8,6 +8,11 @@ require 'termtter/system_extensions/windows' if win?
 require 'termtter/system_extensions/core_compatibles'
 require 'termtter/system_extensions/termtter_compatibles'
 
+unless Readline.const_defined?(:NATIVE_REFRESH_LINE_METHOD)
+  # Latest 'readline.so' has native 'refresh_line' method.
+  Readline::NATIVE_REFRESH_LINE_METHOD = Readline.respond_to?(:refresh_line)
+end
+
 require 'dl/import'
 module Readline
   begin
@@ -18,18 +23,29 @@ module Readline
         extend DL::Importer
       end
       pathes = Array(ENV['TERMTTER_EXT_LIB'] || [
+        '/usr/lib64/libreadline.so',
+        '/usr/local/lib64/libreadline.so',
         '/opt/local/lib/libreadline.dylib',
         '/usr/lib/libreadline.so',
         '/usr/local/lib/libreadline.so',
         File.join(Gem.bindir, 'readline.dll')
       ])
       dlload(pathes.find { |path| File.exist?(path)})
-      extern 'int rl_refresh_line(int, int)'
+      extern 'int rl_parse_and_bind (char *)'
     end
-    def self.refresh_line
-      LIBREADLINE.rl_refresh_line(0, 0)
+    def self.rl_parse_and_bind(str)
+      LIBREADLINE.rl_parse_and_bind(str.to_s)
+    end
+    unless Readline::NATIVE_REFRESH_LINE_METHOD
+      module LIBREADLINE
+        extern 'int rl_refresh_line(int, int)'
+      end
+      def self.refresh_line
+        LIBREADLINE.rl_refresh_line(0, 0)
+      end
     end
   rescue Exception
+    def self.rl_parse_and_bind(str);end
     def self.refresh_line;end
   end
 end
@@ -45,13 +61,28 @@ def create_highline
 end
 
 def open_browser(url)
-  case RUBY_PLATFORM
-  when /linux/
-    system 'firefox', url
-  when /mswin(?!ce)|mingw|bccwin/
-    system 'explorer', url
+  if ENV['KDE_FULL_SESSION'] == 'true'
+    system 'kfmclient', 'exec', url
+  elsif ENV['GNOME_DESKTOP_SESSION_ID']
+    system 'gnome-open', url
+  elsif !(/not found/ =~ `which exo-open`)
+    # FIXME: is fungible system('exo-open').nil? for lambda {...}
+    system 'exo-open', url
   else
-    system 'open', url
+    case RUBY_PLATFORM.downcase
+    when /linux/
+      system 'firefox', url
+    when /darwin/
+      system 'open', url
+    when /mswin(?!ce)|mingw|bccwin/
+      system 'start', url
+    else
+      system 'firefox', url
+    end
   end
 end
 
+if Readline.respond_to?(:input=)
+  # temporary measure for Readline stops other threads problem.
+  Readline.input = STDIN
+end

data/lib/termtter/task.rb

@@ -11,7 +11,8 @@ module Termtter
       @work = true
     end
     def execute
-      exec_proc.call(self) if work
+      args = if exec_proc.arity.zero? then [] else [self] end
+      exec_proc.call(*args) if work
     end
   end
 end

data/spec/plugins/defaults/hashtag_spec.rb

@@ -2,6 +2,7 @@ require File.dirname(__FILE__) + '/../../spec_helper'
 
 describe 'plugin hashtag' do
   before do
+    Termtter::Client.clear_hooks
     Termtter::Client.setup_task_manager
     Termtter::Client.plug 'defaults'
   end
@@ -12,30 +13,30 @@ describe 'plugin hashtag' do
     end
 
     it 'should add hashtag "test"' do
-      Termtter::Client.call_commands('hashtag add test')
-      Termtter::Client.public_storage[:hashtags].should == Set.new('#test')
+      Termtter::Client.execute('hashtag add test')
+      Termtter::Client.public_storage[:hashtags].should == Set.new(['#test'])
     end
 
     it 'should add hashtag "#test"' do
-      Termtter::Client.call_commands('hashtag add #test')
-      Termtter::Client.public_storage[:hashtags].should == Set.new('#test')
+      Termtter::Client.execute('hashtag add #test')
+      Termtter::Client.public_storage[:hashtags].should == Set.new(['#test'])
     end
 
     it 'should add hashtags "foo", "bar"' do
-      Termtter::Client.call_commands('hashtag add foo bar')
+      Termtter::Client.execute('hashtag add foo bar')
       Termtter::Client.public_storage[:hashtags].should == Set.new(["#foo", "#bar"])
     end
   end
 
   describe 'spec for hook of hashtag' do
     before do
-      Termtter::Client.call_commands('hashtag add foo bar')
+      Termtter::Client.execute('hashtag add foo bar')
     end
 
     it 'add hashtags as args of command' do
       @update_command = Termtter::Client.commands[:update]
       @update_command.exec_proc.should_receive(:call).with("test #foo #bar")
-      Termtter::Client.call_commands('update test')
+      Termtter::Client.execute('update test')
     end
   end
 end

data/spec/plugins/defaults/list_spec.rb

@@ -0,0 +1,33 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe 'plugin lists' do
+  before do
+    Termtter::Client.setup_task_manager
+    config.user_name = 'jugyo'
+    @twitter_stub = Object.new
+    Termtter::API.stub!(:twitter).and_return(@twitter_stub)
+  end
+
+  describe 'command list' do
+    before do
+      Termtter::Client.plug 'defaults'
+      @command = Termtter::Client.commands[:list]
+    end
+
+    it 'command name is :lists' do
+      @command.name.should == :list
+    end
+
+    it 'should call with no user_name' do
+      response = []
+      @twitter_stub.should_receive(:home_timeline).and_return(response)
+      Termtter::Client.execute('list')
+    end
+
+    it 'should call with user_name' do
+      response = []
+      @twitter_stub.should_receive(:user_timeline).with('termtter', {}).and_return(response)
+      Termtter::Client.execute('list termtter')
+    end
+  end
+end

data/spec/plugins/defaults/plugin_spec.rb

@@ -0,0 +1,17 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe 'plugin hashtag' do
+  before do
+    Termtter::Client.clear_hooks
+    Termtter::Client.setup_task_manager
+    Termtter::Client.plug 'defaults'
+  end
+
+  it 'should search plugin file' do
+    Termtter::Client.search_plugin_file('plugin').should ==
+      File.expand_path(File.join(File.dirname(__FILE__), '../../..//lib/plugins/defaults/plugin.rb'))
+  end
+
+  # TODO: more specs...
+end
+

data/spec/plugins/defaults/retweet_spec.rb

@@ -0,0 +1,205 @@
+# -*- coding: utf-8 -*-
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe 'Termtter::Client.post_retweet' do
+  describe 'posts a retweet based on the given post by someone,' do
+    completely_same_as_the_following = lambda {
+      Termtter::Client.plug 'defaults/retweet'
+
+      mock = Object.new
+      def mock.user
+        mock2 = Object.new
+        def mock2.protected
+          true
+        end
+
+        def mock2.screen_name
+          'ujihisa'
+        end
+        mock2
+      end
+
+      def mock.text
+        'hi'
+      end
+
+      mock3 = Object.new
+      def mock3.update(text)
+        text.should == 'my comment RT @ujihisa: hi'
+      end
+      def mock3.retweet(id)
+        id
+      end
+
+      Termtter::API.should_receive(:twitter).and_return(mock3)
+      Termtter::Client.
+        should_receive(:confirm).
+        with('ujihisa is protected! Are you sure?', false).
+        and_return true
+      be_quiet do
+        Termtter::Client.post_retweet(mock, 'my comment')
+      end
+    }
+
+    describe 'with your own comment,' do
+      it 'and without confirming in the original post being not protected' do
+        Termtter::Client.plug 'defaults/retweet'
+
+        mock = Object.new
+        def mock.user
+          mock2 = Object.new
+          def mock2.protected
+            false
+          end
+
+          def mock2.screen_name
+            'ujihisa'
+          end
+          mock2
+        end
+
+        def mock.text
+          'hi'
+        end
+
+        mock3 = Object.new
+        def mock3.update(text)
+          text.should == 'my comment RT @ujihisa: hi'
+        end
+
+        Termtter::API.should_receive(:twitter).and_return(mock3)
+        be_quiet do
+          Termtter::Client.post_retweet(mock, 'my comment')
+        end
+      end
+
+      it 'and use QT if config.plugins.retweet.quotetweet is true' do
+        config.plugins.retweet.quotetweet = true
+        Termtter::Client.plug 'defaults/retweet'
+
+        mock = Object.new
+        def mock.user
+          mock2 = Object.new
+          def mock2.protected
+            false
+          end
+
+          def mock2.screen_name
+            'ujihisa'
+          end
+          mock2
+        end
+
+        def mock.text
+          'hi'
+        end
+
+        mock3 = Object.new
+        def mock3.update(text)
+          text.should == 'my comment QT @ujihisa: hi'
+        end
+
+        Termtter::API.should_receive(:twitter).and_return(mock3)
+        be_quiet do
+          Termtter::Client.post_retweet(mock, 'my comment')
+        end
+        config.plugins.retweet.quotetweet = false
+      end
+
+
+      it 'and with confirming in the original post being protected' do
+        completely_same_as_the_following.call
+      end
+    end
+
+    describe 'without your own comment,' do
+      it 'and without confirming in the original post being not protected' do
+        Termtter::Client.plug 'defaults/retweet'
+
+        mock = Object.new
+        def mock.user
+          mock2 = Object.new
+          def mock2.protected
+            false
+          end
+
+          def mock2.screen_name
+            'ujihisa'
+          end
+          mock2
+        end
+
+        def mock.text
+          'hi'
+        end
+
+        def mock.id
+          123
+        end
+
+        mock3 = Object.new
+        def mock3.retweet(id)
+          id.should == 123
+        end
+
+        Termtter::API.should_receive(:twitter).and_return(mock3)
+        be_quiet do
+          Termtter::Client.post_retweet(mock)
+        end
+      end
+
+      it 'and don\'t use QT if config.plugins.retweet.quotetweet is true' do
+        config.plugins.retweet.quotetweet = true
+        Termtter::Client.plug 'defaults/retweet'
+
+        mock = Object.new
+        def mock.user
+          mock2 = Object.new
+          def mock2.protected
+            false
+          end
+
+          def mock2.screen_name
+            'ujihisa'
+          end
+          mock2
+        end
+
+        def mock.text
+          'hi'
+        end
+
+        def mock.id
+          123
+        end
+
+        mock3 = Object.new
+        def mock3.retweet(id)
+          id.should == 123
+        end
+
+        def mock3.update(text)
+          text.should == 'RT @ujihisa: hi'
+        end
+
+        Termtter::API.should_receive(:twitter).and_return(mock3)
+        be_quiet do
+          Termtter::Client.post_retweet(mock)
+        end
+        config.plugins.retweet.quotetweet = false
+      end
+
+      it 'and with confirming in the original post being protected' do
+        completely_same_as_the_following.call
+      end
+    end
+  end
+end
+
+describe 'Plugin `retweet`' do
+  it 'registers a commond when it is loaded' do
+    Termtter::Client.should_receive(:register_command).at_least(5).times
+    Termtter::Client.plug 'defaults/retweet'
+  end
+end