terminal-shop 3.9.0 → 3.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8641a7314cfe99c67112619c269abe92eeb80b2ab8afbf552713b5164c3a1f5c
-  data.tar.gz: 4b040668b4aa5ca2bf01798abed02611a0a932f2a6641881b30a0c15c57995fd
+  metadata.gz: 045164efa87078339e485df768aeeb1396b50b065e508c8f55de1f847a6c0b2d
+  data.tar.gz: 70f4256c27c436a237556e0e5eeb04400cce7fec891e56fe1e1a4173c75dec72
 SHA512:
-  metadata.gz: 3e5944cb9959d6936ca56ce7aa8f6cee16fe64fc19a5a2a53ab84220dfbb6d94738a534f5200fd8578f1d46d88e4363f7b26d1c1627325fbc99a2f2969ff1165
-  data.tar.gz: 7c5b1d0265e12770da0be79d3bdea8e94932bb400112f58a72b7df96d072f5f6a024a6ce50f29ee42957b50eb1ab280ba52d8c4986fd845dd0f676e66c784f6e
+  metadata.gz: f2ed700093e40e5a1bbcff5065d0a56a79cf8506a22ee7d9e18f702c9c61504440770f41a3d2eca92b7111184177bae0ff963c2685334389409feea0837c078a
+  data.tar.gz: 26ba3456b464e1ed33f4fe5e07e1404bf97c67fc7833c82b20943d239ba0d1f7db878a5ef81cacf9303bd338f7d3aaa54ec94c92d10aa27a57ab06dfe637b237

data/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## 3.9.2 (2025-10-15)
+
+Full Changelog: [v3.9.1...v3.9.2](https://github.com/terminaldotshop/terminal-sdk-ruby/compare/v3.9.1...v3.9.2)
+
+### Bug Fixes
+
+* coroutine leaks from connection pool ([609da82](https://github.com/terminaldotshop/terminal-sdk-ruby/commit/609da8210e3c355913e5464b72b4bf562e984024))
+* should not reuse buffers for `IO.copy_stream` interop ([51cbae7](https://github.com/terminaldotshop/terminal-sdk-ruby/commit/51cbae7450fb445d494a6e8a1161ab2c87a980f6))
+
+
+### Chores
+
+* ignore linter error for tests having large collections ([6d41fa1](https://github.com/terminaldotshop/terminal-sdk-ruby/commit/6d41fa1ca081d582e52a432a2d953952bf6d15f1))
+
+## 3.9.1 (2025-09-30)
+
+Full Changelog: [v3.9.0...v3.9.1](https://github.com/terminaldotshop/terminal-sdk-ruby/compare/v3.9.0...v3.9.1)
+
+### Bug Fixes
+
+* always send `filename=...` for multipart requests where a file is expected ([e4027f3](https://github.com/terminaldotshop/terminal-sdk-ruby/commit/e4027f383a8f0c5e2ffe470a552d4b8a9c75f21a))
+
+
+### Chores
+
+* **internal:** codegen related update ([09f1843](https://github.com/terminaldotshop/terminal-sdk-ruby/commit/09f184386ef53243e1159fa9a76e2bf8a8bfe165))
+
 ## 3.9.0 (2025-09-27)
 
 Full Changelog: [v3.8.10...v3.9.0](https://github.com/terminaldotshop/terminal-sdk-ruby/compare/v3.8.10...v3.9.0)

data/README.md

@@ -17,7 +17,7 @@ To use this gem, install via Bundler by adding the following to your application
 <!-- x-release-please-start-version -->
 
 ```ruby
-gem "terminal-shop", "~> 3.9.0"
+gem "terminal-shop", "~> 3.9.2"
 ```
 
 <!-- x-release-please-end -->

data/lib/terminal_shop/file_part.rb

@@ -38,18 +38,21 @@ module TerminalShop
     def to_yaml(*a) = read.to_yaml(*a)
 
     # @param content [Pathname, StringIO, IO, String]
-    # @param filename [String, nil]
+    # @param filename [Pathname, String, nil]
     # @param content_type [String, nil]
     def initialize(content, filename: nil, content_type: nil)
-      @content = content
+      @content_type = content_type
       @filename =
-        case content
-        in Pathname
-          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        case [filename, (@content = content)]
+        in [String | Pathname, _]
+          ::File.basename(filename)
+        in [nil, Pathname]
+          content.basename.to_path
+        in [nil, IO]
+          content.to_path
         else
-          filename.nil? ? nil : ::File.basename(filename)
+          filename
         end
-      @content_type = content_type
     end
   end
 end

data/lib/terminal_shop/internal/transport/pooled_net_requester.rb

@@ -134,9 +134,9 @@ module TerminalShop
 
           # rubocop:disable Metrics/BlockLength
           enum = Enumerator.new do |y|
-            with_pool(url, deadline: deadline) do |conn|
-              next if finished
+            next if finished
 
+            with_pool(url, deadline: deadline) do |conn|
               req, closing = self.class.build_request(request) do
                 self.class.calibrate_socket_timeout(conn, deadline)
               end
@@ -149,7 +149,7 @@ module TerminalShop
 
               self.class.calibrate_socket_timeout(conn, deadline)
               conn.request(req) do |rsp|
-                y << [conn, req, rsp]
+                y << [req, rsp]
                 break if finished
 
                 rsp.read_body do |bytes|
@@ -160,6 +160,8 @@ module TerminalShop
                 end
                 eof = true
               end
+            ensure
+              conn.finish if !eof && conn&.started?
             end
           rescue Timeout::Error
             raise TerminalShop::Errors::APITimeoutError.new(url: url, request: req)
@@ -168,16 +170,11 @@ module TerminalShop
           end
           # rubocop:enable Metrics/BlockLength
 
-          conn, _, response = enum.next
+          _, response = enum.next
           body = TerminalShop::Internal::Util.fused_enum(enum, external: true) do
             finished = true
-            tap do
-              enum.next
-            rescue StopIteration
-              nil
-            end
+            loop { enum.next }
           ensure
-            conn.finish if !eof && conn&.started?
             closing&.call
           end
           [Integer(response.code), response, body]

data/lib/terminal_shop/internal/type/file_input.rb

@@ -82,17 +82,20 @@ module TerminalShop
           #
           # @return [Pathname, StringIO, IO, String, Object]
           def dump(value, state:)
-            # rubocop:disable Lint/DuplicateBranch
             case value
+            in StringIO | String
+              # https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
+              # while not required, a filename is recommended, and in practice many servers do expect this
+              TerminalShop::FilePart.new(value, filename: "upload")
             in IO
               state[:can_retry] = false
+              value.to_path.nil? ? TerminalShop::FilePart.new(value, filename: "upload") : value
             in TerminalShop::FilePart if value.content.is_a?(IO)
               state[:can_retry] = false
+              value
             else
+              value
             end
-            # rubocop:enable Lint/DuplicateBranch
-
-            value
           end
 
           # @api private

data/lib/terminal_shop/internal/util.rb

@@ -473,10 +473,9 @@ module TerminalShop
         # @return [Enumerable<String>]
         def writable_enum(&blk)
           Enumerator.new do |y|
-            buf = String.new
             y.define_singleton_method(:write) do
-              self << buf.replace(_1)
-              buf.bytesize
+              self << _1.dup
+              _1.bytesize
             end
 
             blk.call(y)

data/lib/terminal_shop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TerminalShop
-  VERSION = "3.9.0"
+  VERSION = "3.9.2"
 end

data/rbi/terminal_shop/file_part.rbi

@@ -27,7 +27,7 @@ module TerminalShop
     sig do
       params(
         content: T.any(Pathname, StringIO, IO, String),
-        filename: T.nilable(String),
+        filename: T.nilable(T.any(Pathname, String)),
         content_type: T.nilable(String)
       ).returns(T.attached_class)
     end

data/sig/terminal_shop/file_part.rbs

@@ -14,7 +14,7 @@ module TerminalShop
 
     def initialize: (
       Pathname | StringIO | IO | String content,
-      ?filename: String?,
+      ?filename: (Pathname | String)?,
       ?content_type: String?
     ) -> void
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: terminal-shop
 version: !ruby/object:Gem::Version
-  version: 3.9.0
+  version: 3.9.2
 platform: ruby
 authors:
 - Terminal
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-27 00:00:00.000000000 Z
+date: 2025-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool