tep 0.11.0

data/test/test_broadcast.rb

@@ -0,0 +1,197 @@
+require_relative "helper"
+
+# Tep::Broadcast: in-process topic broker. v1 stores (topic, fd)
+# pairs; publish writes payload bytes to every matching fd. These
+# tests exercise the registry shape via fake fds (-1 / synthetic
+# ints); real delivery to live sockets gets covered when the WS
+# battery lands and integrates Broadcast end-to-end. The publish()
+# return value is "matched count," not "successful writes" -- bad
+# fds silently fail at sphttp_write_str without affecting the
+# match count.
+class TestBroadcast < TepTest
+  app_source <<~RB
+    require 'sinatra'
+
+    before do
+      res.headers["Content-Type"] = "text/plain"
+    end
+
+    # Reset between cases so test ordering doesn't matter.
+    get '/reset' do
+      Tep::Broadcast.clear.to_s
+    end
+
+    get '/subscribe' do
+      topic = params[:topic]
+      fd    = params[:fd].to_i
+      Tep::Broadcast.subscribe(topic, fd).to_s
+    end
+
+    get '/subscribe_ws' do
+      topic = params[:topic]
+      fd    = params[:fd].to_i
+      Tep::Broadcast.subscribe_ws(topic, fd).to_s
+    end
+
+    get '/unsubscribe' do
+      sub_id = params[:sub_id].to_i
+      Tep::Broadcast.unsubscribe(sub_id).to_s
+    end
+
+    get '/unsubscribe_fd' do
+      fd = params[:fd].to_i
+      Tep::Broadcast.unsubscribe_fd(fd).to_s
+    end
+
+    get '/publish' do
+      topic   = params[:topic]
+      payload = params[:payload]
+      Tep::Broadcast.publish(topic, payload).to_s
+    end
+
+    get '/subscriber_count' do
+      Tep::Broadcast.subscriber_count.to_s
+    end
+
+    get '/subscribers_for' do
+      topic = params[:topic]
+      Tep::Broadcast.subscribers_for(topic).to_s
+    end
+  RB
+
+  # Helper: reset between tests so state doesn't carry.
+  def setup
+    super
+    get("/reset")
+  end
+
+  def subscribe(topic, fd)
+    get("/subscribe?topic=#{topic}&fd=#{fd}").body.to_i
+  end
+
+  def publish(topic, payload)
+    get("/publish?topic=#{topic}&payload=#{payload}").body.to_i
+  end
+
+  def subscriber_count
+    get("/subscriber_count").body.to_i
+  end
+
+  def subscribers_for(topic)
+    get("/subscribers_for?topic=#{topic}").body.to_i
+  end
+
+  # ---- empty registry ----
+
+  def test_publish_to_empty_registry_returns_zero
+    assert_equal 0, publish("room:lobby", "hello")
+  end
+
+  def test_subscriber_count_starts_at_zero
+    assert_equal 0, subscriber_count
+  end
+
+  def test_subscribers_for_unknown_topic_is_zero
+    assert_equal 0, subscribers_for("never-subscribed")
+  end
+
+  # ---- subscribe + count ----
+
+  def test_subscribe_grows_registry
+    subscribe("room:lobby", -1)
+    assert_equal 1, subscriber_count
+    assert_equal 1, subscribers_for("room:lobby")
+  end
+
+  def test_multiple_subscribers_same_topic
+    subscribe("room:lobby", -1)
+    subscribe("room:lobby", -2)
+    subscribe("room:lobby", -3)
+    assert_equal 3, subscribers_for("room:lobby")
+  end
+
+  def test_subscribers_segregated_by_topic
+    subscribe("room:lobby", -1)
+    subscribe("room:lobby", -2)
+    subscribe("room:other", -3)
+    assert_equal 2, subscribers_for("room:lobby")
+    assert_equal 1, subscribers_for("room:other")
+  end
+
+  # ---- publish matching ----
+
+  def test_publish_returns_matched_count
+    subscribe("room:lobby", -1)
+    subscribe("room:lobby", -2)
+    subscribe("room:other", -3)
+    assert_equal 2, publish("room:lobby", "hi")
+  end
+
+  def test_publish_to_unmatched_topic_zero
+    subscribe("room:lobby", -1)
+    assert_equal 0, publish("never", "hi")
+  end
+
+  # ---- unsubscribe (by sub_id) ----
+
+  def test_unsubscribe_by_id_drops_one
+    sub_id = subscribe("room:lobby", -1)
+    subscribe("room:lobby", -2)
+    get("/unsubscribe?sub_id=#{sub_id}")
+    assert_equal 1, subscribers_for("room:lobby")
+  end
+
+  # ---- unsubscribe_fd (by fd, multi-topic) ----
+
+  def test_unsubscribe_fd_drops_all_for_fd
+    subscribe("room:lobby", -1)
+    subscribe("room:other", -1)   # same fd, different topic
+    subscribe("room:lobby", -2)
+    dropped = get("/unsubscribe_fd?fd=-1").body.to_i
+    assert_equal 2, dropped
+    assert_equal 1, subscribers_for("room:lobby")
+    assert_equal 0, subscribers_for("room:other")
+  end
+
+  def test_unsubscribe_fd_unknown_zero
+    subscribe("room:lobby", -1)
+    dropped = get("/unsubscribe_fd?fd=-999").body.to_i
+    assert_equal 0, dropped
+  end
+
+  # ---- subscribe_ws (WebSocket frame mode) ----
+
+  def test_subscribe_ws_grows_registry
+    get("/subscribe_ws?topic=room:lobby&fd=-1")
+    assert_equal 1, subscriber_count
+    assert_equal 1, subscribers_for("room:lobby")
+  end
+
+  def test_subscribe_ws_publish_match_count
+    # Subscribe two WS, one raw -- all three should match a publish
+    # to that topic (delivery mode doesn't affect match counting).
+    get("/subscribe_ws?topic=room:lobby&fd=-1")
+    get("/subscribe_ws?topic=room:lobby&fd=-2")
+    get("/subscribe?topic=room:lobby&fd=-3")
+    assert_equal 3, publish("room:lobby", "hi")
+  end
+
+  def test_subscribe_ws_unsubscribe_fd_drops
+    # Mixed-mode subscriptions for one fd: subscribe_ws on a
+    # different topic + subscribe on the same fd. unsubscribe_fd
+    # drops both.
+    get("/subscribe_ws?topic=room:lobby&fd=-1")
+    get("/subscribe?topic=room:other&fd=-1")
+    dropped = get("/unsubscribe_fd?fd=-1").body.to_i
+    assert_equal 2, dropped
+  end
+
+  # ---- clear ----
+
+  def test_clear_drops_everything
+    subscribe("room:lobby", -1)
+    subscribe("room:other", -2)
+    get("/reset")
+    assert_equal 0, subscriber_count
+  end
+end

data/test/test_broadcast_pg.rb

@@ -0,0 +1,135 @@
+require_relative "helper"
+
+# Tep::Broadcast PG backend: cross-worker pub/sub via
+# LISTEN/NOTIFY. Gated on PG_TEST_URL like test_pg.rb.
+#
+#   PG_TEST_URL=postgresql://postgres:postgres@127.0.0.1:5432/postgres \
+#     ruby test/test_broadcast_pg.rb
+#
+# Test strategy: configure the backend at on_start, then exercise
+# publish() + poll_pg_once() within a single tep app instance. PG's
+# LISTEN/NOTIFY delivers a worker's own NOTIFYs back to it (the
+# "LISTEN sees own publishes" property), so a single-process app
+# can validate the full wire round-trip without needing to spin up
+# a second worker.
+class TestBroadcastPg < TepTest
+  PG_URL = ENV["PG_TEST_URL"]
+  CHANNEL = "tep_broadcast_test_#{$$}"
+
+  app_source <<~RB
+    require 'sinatra'
+
+    PG_URL  = "#{PG_URL}"
+    CHANNEL = "#{CHANNEL}"
+
+    on_start do
+      Tep::Broadcast.enable_pg_backend(PG_URL, CHANNEL)
+    end
+
+    before do
+      res.headers["Content-Type"] = "text/plain"
+    end
+
+    get '/reset' do
+      Tep::Broadcast.clear.to_s
+    end
+
+    get '/subscribe' do
+      topic = params[:topic]
+      fd    = params[:fd].to_i
+      Tep::Broadcast.subscribe(topic, fd).to_s
+    end
+
+    get '/publish' do
+      topic   = params[:topic]
+      payload = params[:payload]
+      Tep::Broadcast.publish(topic, payload).to_s
+    end
+
+    get '/poll' do
+      timeout = params[:timeout].to_i
+      Tep::Broadcast.poll_pg_once(timeout).to_s
+    end
+
+    get '/encode_wire' do
+      topic   = params[:topic]
+      payload = params[:payload]
+      Tep::Broadcast.encode_wire(topic, payload)
+    end
+
+    get '/decode_wire' do
+      wire = params[:wire]
+      Tep::Broadcast.deliver_wire_local(wire).to_s
+    end
+  RB
+
+  def setup
+    if PG_URL.nil? || PG_URL.empty?
+      skip "PG_TEST_URL not set (e.g. PG_TEST_URL=postgresql:///postgres). " \
+           "See test/test_pg.rb header for the docker recipe."
+    end
+    super
+    get("/reset")
+  end
+
+  # ---- Wire format round-trip (no PG, no NOTIFY -- pure encoding) ----
+
+  def test_encode_wire_length_prefixed
+    res = get("/encode_wire?topic=room:lobby&payload=hello")
+    # "10:room:lobbyhello" -- 10 chars in topic "room:lobby" then payload "hello"
+    assert_equal "10:room:lobbyhello", res.body
+  end
+
+  def test_encode_wire_empty_payload
+    res = get("/encode_wire?topic=t&payload=")
+    assert_equal "1:t", res.body
+  end
+
+  def test_decode_wire_delivers_to_local_subs
+    # Subscribe a fake fd to a topic, then decode-and-deliver a
+    # wire-format payload as if it had come in via PG NOTIFY.
+    get("/subscribe?topic=room:lobby&fd=-1")
+    res = get("/decode_wire?wire=10:room:lobbyhello")
+    # Matched 1 local subscriber.
+    assert_equal "1", res.body
+  end
+
+  def test_decode_wire_unsubscribed_topic_zero
+    res = get("/decode_wire?wire=4:nope")
+    assert_equal "0", res.body
+  end
+
+  # ---- End-to-end PG NOTIFY round trip ----
+
+  def test_publish_then_poll_round_trips_via_pg
+    # Publish a message -- NOTIFY's PG.
+    get("/publish?topic=pg_round_trip&payload=ping")
+    # Poll for the NOTIFY (we sent it; LISTEN sees own publishes).
+    res = get("/poll?timeout=2000")
+    assert_equal "1", res.body
+  end
+
+  def test_poll_returns_zero_on_timeout
+    # With no preceding publish + no other publisher on the channel,
+    # poll should time out cleanly.
+    res = get("/poll?timeout=100")
+    assert_equal "0", res.body
+  end
+
+  def test_publish_with_local_sub_also_matches_local
+    # Local fan-out still works alongside PG NOTIFY. Subscribe a
+    # local fake fd, publish -- match count reflects the local sub.
+    get("/subscribe?topic=mixed_topic&fd=-1")
+    res = get("/publish?topic=mixed_topic&payload=hi")
+    assert_equal "1", res.body
+  end
+
+  def test_publish_with_no_local_sub_matches_zero_but_still_notifies
+    # No local subs -- match count is 0, but publish still ran the
+    # PG NOTIFY (subsequent poll confirms).
+    res = get("/publish?topic=remote_only&payload=hi")
+    assert_equal "0", res.body
+    poll_res = get("/poll?timeout=2000")
+    assert_equal "1", poll_res.body
+  end
+end

data/test/test_cache.rb

@@ -0,0 +1,98 @@
+require_relative "helper"
+
+# HTTP caching battery (issue #152): Cache-Control / ETag / Last-Modified
+# response helpers + conditional-GET 304 short-circuit.
+class TestCache < TepTest
+  app_source <<~RB
+    require 'sinatra'
+
+    get '/etag' do
+      res.etag("v1")
+      "etag-body"
+    end
+
+    get '/lastmod' do
+      res.last_modified(1700000000)   # fixed epoch -> stable Last-Modified
+      "lastmod-body"
+    end
+
+    get '/cc' do
+      res.cache_control("public, max-age=60")
+      "cc-body"
+    end
+
+    get '/exp' do
+      res.expires(60)
+      "exp-body"
+    end
+
+    get '/nostore' do
+      res.no_store
+      "ns-body"
+    end
+  RB
+
+  # ---- ETag / If-None-Match ----
+
+  def test_etag_present_on_normal_get
+    res = get("/etag")
+    assert_equal "200", res.code
+    assert_equal "\"v1\"", res["ETag"]
+    assert_equal "etag-body", res.body
+  end
+
+  def test_if_none_match_match_returns_304_no_body
+    res = get("/etag", {"If-None-Match" => "\"v1\""})
+    assert_equal "304", res.code
+    assert_equal "", res.body.to_s
+    assert_equal "\"v1\"", res["ETag"]   # validator preserved on 304
+  end
+
+  def test_if_none_match_star_returns_304
+    res = get("/etag", {"If-None-Match" => "*"})
+    assert_equal "304", res.code
+  end
+
+  def test_if_none_match_mismatch_returns_200
+    res = get("/etag", {"If-None-Match" => "\"other\""})
+    assert_equal "200", res.code
+    assert_equal "etag-body", res.body
+  end
+
+  # ---- Last-Modified / If-Modified-Since ----
+
+  def test_last_modified_header_is_http_date
+    res = get("/lastmod")
+    assert_equal "200", res.code
+    assert_match(/GMT\z/, res["Last-Modified"])
+  end
+
+  def test_if_modified_since_equal_returns_304
+    first = get("/lastmod")
+    res = get("/lastmod", {"If-Modified-Since" => first["Last-Modified"]})
+    assert_equal "304", res.code
+    assert_equal "", res.body.to_s
+  end
+
+  def test_if_modified_since_older_returns_200
+    res = get("/lastmod", {"If-Modified-Since" => "Sat, 01 Jan 2000 00:00:00 GMT"})
+    assert_equal "200", res.code
+    assert_equal "lastmod-body", res.body
+  end
+
+  # ---- Cache-Control / Expires ----
+
+  def test_cache_control_verbatim
+    assert_equal "public, max-age=60", get("/cc")["Cache-Control"]
+  end
+
+  def test_expires_sets_expires_and_max_age
+    res = get("/exp")
+    assert_equal "max-age=60", res["Cache-Control"]
+    assert_match(/GMT\z/, res["Expires"])
+  end
+
+  def test_no_store_shortcut
+    assert_equal "no-store", get("/nostore")["Cache-Control"]
+  end
+end

data/test/test_cache_static.rb

@@ -0,0 +1,48 @@
+require_relative "helper"
+
+# Caching phase 2 (#152): static files served via send_file (public_dir)
+# carry a size-mtime ETag + Last-Modified and revalidate to 304.
+class TestCacheStatic < TepTest
+  app_source <<~RB
+    set :public_dir, '#{File.expand_path("../public", __dir__)}'
+
+    get '/' do
+      "root"
+    end
+  RB
+
+  def test_static_file_has_validators
+    res = get("/hello.txt")
+    assert_equal "200", res.code
+    refute_nil res["ETag"]
+    assert_match(/GMT\z/, res["Last-Modified"])
+    assert_match(/static file serving/, res.body)
+  end
+
+  def test_static_if_none_match_returns_304
+    etag = get("/hello.txt")["ETag"]
+    res = get("/hello.txt", {"If-None-Match" => etag})
+    assert_equal "304", res.code
+    assert_equal "", res.body.to_s
+    assert_equal etag, res["ETag"]   # validator preserved on 304
+  end
+
+  def test_static_if_modified_since_equal_returns_304
+    lm = get("/hello.txt")["Last-Modified"]
+    res = get("/hello.txt", {"If-Modified-Since" => lm})
+    assert_equal "304", res.code
+    assert_equal "", res.body.to_s
+  end
+
+  def test_static_if_modified_since_old_returns_200
+    res = get("/hello.txt", {"If-Modified-Since" => "Sat, 01 Jan 2000 00:00:00 GMT"})
+    assert_equal "200", res.code
+    assert_match(/static file serving/, res.body)
+  end
+
+  def test_static_if_none_match_mismatch_returns_200
+    res = get("/hello.txt", {"If-None-Match" => "\"nope\""})
+    assert_equal "200", res.code
+    assert_match(/static file serving/, res.body)
+  end
+end

data/test/test_cookies.rb

@@ -0,0 +1,52 @@
+require_relative "helper"
+
+class TestCookies < TepTest
+  app_source <<~RB
+    get '/echo' do
+      "name=" + cookies["name"] + " mood=" + cookies["mood"]
+    end
+
+    get '/set' do
+      set_cookie "user", "alice"
+      "ok"
+    end
+
+    get '/set-flagged' do
+      set_cookie "session_id", "xyz"
+      "ok"
+    end
+  RB
+
+  def test_round_trip
+    res = get("/echo", "Cookie" => "name=alice; mood=happy")
+    assert_equal "200", res.code
+    assert_equal "name=alice mood=happy", res.body
+  end
+
+  def test_url_decoded_value
+    res = get("/echo", "Cookie" => "name=hello%20world; mood=ok")
+    assert_equal "name=hello world mood=ok", res.body
+  end
+
+  def test_missing_cookie_is_empty
+    res = get("/echo", "Cookie" => "name=alice")
+    assert_equal "name=alice mood=", res.body
+  end
+
+  def test_set_cookie_writes_header
+    res = get("/set")
+    assert_equal "200", res.code
+    assert_equal "user=alice", res["set-cookie"]
+  end
+
+  def test_set_cookie_value_is_url_encoded
+    res = get("/set-flagged")
+    assert_match(/^session_id=xyz/, res["set-cookie"])
+  end
+
+  def test_no_cookie_header_no_crash
+    res = get("/echo")
+    assert_equal "200", res.code
+    assert_equal "name= mood=", res.body
+  end
+end

data/test/test_erb.rb

@@ -0,0 +1,53 @@
+require_relative "helper"
+
+class TestErb < TepTest
+  app_source <<~RB
+    require 'sinatra'
+
+    set :views, '#{File.expand_path("views", __dir__)}'
+
+    get '/hello/:who' do
+      erb :hello, locals: { name: params[:who], mood: "happy" }
+    end
+
+    get '/sober/:who' do
+      erb :hello, locals: { name: params[:who], mood: "neutral" }
+    end
+
+    get '/list/:n' do
+      erb :list, locals: { count: params[:n] }
+    end
+
+    get '/no-locals' do
+      erb :hello
+    end
+  RB
+
+  def test_simple_interpolation
+    res = get("/hello/world")
+    assert_equal "200", res.code
+    assert_match(/hello, world!/, res.body)
+  end
+
+  def test_conditional_block
+    happy = get("/hello/world")
+    assert_match(/cheerful/, happy.body)
+    sober = get("/sober/world")
+    refute_match(/cheerful/, sober.body)
+  end
+
+  def test_loop_block
+    res = get("/list/3")
+    assert_equal "200", res.code
+    assert_match(/<li>item 0</, res.body)
+    assert_match(/<li>item 1</, res.body)
+    assert_match(/<li>item 2</, res.body)
+    refute_match(/<li>item 3</, res.body)
+  end
+
+  def test_no_locals_renders_empty_for_missing_keys
+    res = get("/no-locals")
+    assert_equal "200", res.code
+    assert_match(/hello, !/, res.body)
+  end
+end

data/test/test_erb_ivars.rb

@@ -0,0 +1,58 @@
+require_relative "helper"
+
+# Sinatra-style `@ivar` template locals: a handler (or `before`
+# filter) sets `@name = ...`, and the template reads it via
+# `<%= @name %>`. The translator stores ivars on a per-request bag
+# (req.ivars) and threads it as a second arg to `tep_view_<name>`.
+class TestErbIvars < TepTest
+  app_source <<~RB
+    require 'sinatra'
+
+    set :views, '#{File.expand_path("views", __dir__)}'
+
+    before do
+      @greeting = "filter-said-hi"
+    end
+
+    get '/greet/:who/:n' do
+      @name  = params[:who]
+      @count = params[:n]
+      erb :greet
+    end
+
+    get '/mixed/:who' do
+      @name = params[:who]
+      erb :mixed, locals: { greeting: "from-explicit-locals" }
+    end
+  RB
+
+  def test_ivar_threading
+    res = get("/greet/alice/1")
+    assert_equal "200", res.code
+    assert_match(/hi, alice!/, res.body)
+    assert_match(/visited 1 times/, res.body)
+    assert_match(/welcome\./, res.body)
+  end
+
+  def test_ivar_int_to_s_coercion
+    # @count = params[:n] writes a string already, but the rewriter's
+    # `.to_s` wrap means the same code would still work if @count
+    # held a literal integer (which the template's <%= ... %> renders
+    # back to a string).
+    res = get("/greet/bob/3")
+    assert_equal "200", res.code
+    assert_match(/visited 3 times/, res.body)
+    refute_match(/welcome\./, res.body)  # only renders for count == "1"
+  end
+
+  def test_locals_and_ivars_coexist
+    res = get("/mixed/charlie")
+    assert_equal "200", res.code
+    assert_match(/hello, charlie/, res.body)
+    assert_match(/locals greeting: from-explicit-locals/, res.body)
+    # The before-filter set @greeting; the explicit `locals: {...}`
+    # call doesn't shadow it because they're separate hashes in the
+    # template signature.
+    assert_match(/ivar greeting: filter-said-hi/, res.body)
+  end
+end