temporalio 0.2.0 → 0.4.0

data/Rakefile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/BlockLength, Lint/MissingCopEnableDirective, Style/DocumentationMethod
+# rubocop:disable Lint/MissingCopEnableDirective, Style/DocumentationMethod
 
 require 'bundler/gem_tasks'
 require 'rb_sys/cargo/metadata'
@@ -55,8 +55,9 @@ module CustomizeYardWarnings # rubocop:disable Style/Documentation
     super
   rescue YARD::Parser::UndocumentableError
     # We ignore if it's an API warning
-    raise unless statement.last.file.start_with?('lib/temporalio/api/') ||
-                 statement.last.file.start_with?('lib/temporalio/internal/bridge/api/')
+    last_file = statement.last.file
+    raise unless (last_file.start_with?('lib/temporalio/api/') && last_file.count('/') > 3) ||
+                 last_file.start_with?('lib/temporalio/internal/bridge/api/')
   end
 end
 
@@ -64,302 +65,15 @@ YARD::Handlers::Ruby::ConstantHandler.prepend(CustomizeYardWarnings)
 
 YARD::Rake::YardocTask.new { |t| t.options = ['--fail-on-warning'] }
 
-require 'fileutils'
-require 'google/protobuf'
+Rake::Task[:yard].enhance([:copy_parent_files]) do
+  rm ['LICENSE', 'README.md']
+end
 
 namespace :proto do
   desc 'Generate API and Core protobufs'
   task :generate do
-    # Remove all existing
-    FileUtils.rm_rf('lib/temporalio/api')
-
-    def generate_protos(api_protos)
-      # Generate API to temp dir and move
-      FileUtils.rm_rf('tmp-proto')
-      FileUtils.mkdir_p('tmp-proto')
-      sh 'bundle exec grpc_tools_ruby_protoc ' \
-         '--proto_path=ext/sdk-core/sdk-core-protos/protos/api_upstream ' \
-         '--proto_path=ext/sdk-core/sdk-core-protos/protos/api_cloud_upstream ' \
-         '--proto_path=ext/additional_protos ' \
-         '--ruby_out=tmp-proto ' \
-         "#{api_protos.join(' ')}"
-
-      # Walk all generated Ruby files and cleanup content and filename
-      Dir.glob('tmp-proto/temporal/api/**/*.rb') do |path|
-        # Fix up the import
-        content = File.read(path)
-        content.gsub!(%r{^require 'temporal/(.*)_pb'$}, "require 'temporalio/\\1'")
-        File.write(path, content)
-
-        # Remove _pb from the filename
-        FileUtils.mv(path, path.sub('_pb', ''))
-      end
-
-      # Move from temp dir and remove temp dir
-      FileUtils.cp_r('tmp-proto/temporal/api', 'lib/temporalio')
-      FileUtils.rm_rf('tmp-proto')
-    end
-
-    # Generate from API with Google ones removed
-    generate_protos(Dir.glob('ext/sdk-core/sdk-core-protos/protos/api_upstream/**/*.proto').reject do |proto|
-      proto.include?('google')
-    end)
-
-    # Generate from Cloud API
-    generate_protos(Dir.glob('ext/sdk-core/sdk-core-protos/protos/api_cloud_upstream/**/*.proto'))
-
-    # Generate additional protos
-    generate_protos(Dir.glob('ext/additional_protos/**/*.proto'))
-
-    # Write files that will help with imports. We are requiring the
-    # request_response and not the service because the service depends on Google
-    # API annotations we don't want to have to depend on.
-    File.write(
-      'lib/temporalio/api/cloud/cloudservice.rb',
-      <<~TEXT
-        # frozen_string_literal: true
-
-        require 'temporalio/api/cloud/cloudservice/v1/request_response'
-      TEXT
-    )
-    File.write(
-      'lib/temporalio/api/workflowservice.rb',
-      <<~TEXT
-        # frozen_string_literal: true
-
-        require 'temporalio/api/workflowservice/v1/request_response'
-      TEXT
-    )
-    File.write(
-      'lib/temporalio/api/operatorservice.rb',
-      <<~TEXT
-        # frozen_string_literal: true
-
-        require 'temporalio/api/operatorservice/v1/request_response'
-      TEXT
-    )
-    File.write(
-      'lib/temporalio/api.rb',
-      <<~TEXT
-        # frozen_string_literal: true
-
-        require 'temporalio/api/cloud/cloudservice'
-        require 'temporalio/api/common/v1/grpc_status'
-        require 'temporalio/api/errordetails/v1/message'
-        require 'temporalio/api/operatorservice'
-        require 'temporalio/api/workflowservice'
-
-        module Temporalio
-          # Raw protocol buffer models.
-          module Api
-          end
-        end
-      TEXT
-    )
-
-    # Write the service classes that have the RPC calls
-    def write_service_file(qualified_service_name:, file_name:, class_name:, service_enum:)
-      # Do service lookup
-      desc = Google::Protobuf::DescriptorPool.generated_pool.lookup(qualified_service_name)
-      raise 'Failed finding service descriptor' unless desc
-
-      # Open file to generate Ruby code
-      File.open("lib/temporalio/client/connection/#{file_name}.rb", 'w') do |file|
-        file.puts <<~TEXT
-          # frozen_string_literal: true
-
-          # Generated code.  DO NOT EDIT!
-
-          require 'temporalio/api'
-          require 'temporalio/client/connection/service'
-          require 'temporalio/internal/bridge/client'
-
-          module Temporalio
-            class Client
-              class Connection
-                # #{class_name} API.
-                class #{class_name} < Service
-                  # @!visibility private
-                  def initialize(connection)
-                    super(connection, Internal::Bridge::Client::#{service_enum})
-                  end
-        TEXT
-
-        desc.each do |method|
-          # Camel case to snake case
-          rpc = method.name.gsub(/([A-Z])/, '_\1').downcase.delete_prefix('_')
-          file.puts <<-TEXT
-
-        # Calls #{class_name}.#{method.name} API call.
-        #
-        # @param request [#{method.input_type.msgclass}] API request.
-        # @param rpc_retry [Boolean] Whether to implicitly retry known retryable errors.
-        # @param rpc_metadata [Hash<String, String>, nil] Headers to include on the RPC call.
-        # @param rpc_timeout [Float, nil] Number of seconds before timeout.
-        # @return [#{method.output_type.msgclass}] API response.
-        def #{rpc}(request, rpc_retry: false, rpc_metadata: nil, rpc_timeout: nil)
-          invoke_rpc(
-            rpc: '#{rpc}',
-            request_class: #{method.input_type.msgclass},
-            response_class: #{method.output_type.msgclass},
-            request:,
-            rpc_retry:,
-            rpc_metadata:,
-            rpc_timeout:
-          )
-        end
-          TEXT
-        end
-
-        file.puts <<~TEXT
-                end
-              end
-            end
-          end
-        TEXT
-      end
-
-      # Open file to generate RBS code
-      # TODO(cretz): Improve this when RBS proto is supported
-      File.open("sig/temporalio/client/connection/#{file_name}.rbs", 'w') do |file|
-        file.puts <<~TEXT
-          # Generated code.  DO NOT EDIT!
-
-          module Temporalio
-            class Client
-              class Connection
-                class #{class_name} < Service
-                  def initialize: (Connection) -> void
-        TEXT
-
-        desc.each do |method|
-          # Camel case to snake case
-          rpc = method.name.gsub(/([A-Z])/, '_\1').downcase.delete_prefix('_')
-          file.puts <<-TEXT
-        def #{rpc}: (untyped request, ?rpc_retry: bool, ?rpc_metadata: Hash[String, String]?, ?rpc_timeout: Float?) -> untyped
-          TEXT
-        end
-
-        file.puts <<~TEXT
-                end
-              end
-            end
-          end
-        TEXT
-      end
-    end
-
-    require './lib/temporalio/api/workflowservice/v1/service'
-    write_service_file(
-      qualified_service_name: 'temporal.api.workflowservice.v1.WorkflowService',
-      file_name: 'workflow_service',
-      class_name: 'WorkflowService',
-      service_enum: 'SERVICE_WORKFLOW'
-    )
-    require './lib/temporalio/api/operatorservice/v1/service'
-    write_service_file(
-      qualified_service_name: 'temporal.api.operatorservice.v1.OperatorService',
-      file_name: 'operator_service',
-      class_name: 'OperatorService',
-      service_enum: 'SERVICE_OPERATOR'
-    )
-    require './lib/temporalio/api/cloud/cloudservice/v1/service'
-    write_service_file(
-      qualified_service_name: 'temporal.api.cloud.cloudservice.v1.CloudService',
-      file_name: 'cloud_service',
-      class_name: 'CloudService',
-      service_enum: 'SERVICE_CLOUD'
-    )
-
-    # Generate Rust code
-    def generate_rust_match_arm(file:, qualified_service_name:, service_enum:, trait:)
-      # Do service lookup
-      desc = Google::Protobuf::DescriptorPool.generated_pool.lookup(qualified_service_name)
-      file.puts <<~TEXT
-        #{service_enum} => match call.rpc.as_str() {
-      TEXT
-
-      desc.to_a.sort_by(&:name).each do |method|
-        # Camel case to snake case
-        rpc = method.name.gsub(/([A-Z])/, '_\1').downcase.delete_prefix('_')
-        file.puts <<~TEXT
-          "#{rpc}" => rpc_call!(self, callback, call, #{trait}, #{rpc}),
-        TEXT
-      end
-      file.puts <<~TEXT
-          _ => Err(error!("Unknown RPC call {}", call.rpc)),
-        },
-      TEXT
-    end
-    File.open('ext/src/client_rpc_generated.rs', 'w') do |file|
-      file.puts <<~TEXT
-        // Generated code.  DO NOT EDIT!
-
-        use magnus::{Error, Ruby};
-        use temporal_client::{CloudService, OperatorService, WorkflowService};
-
-        use super::{error, rpc_call};
-        use crate::{
-            client::{Client, RpcCall, SERVICE_CLOUD, SERVICE_OPERATOR, SERVICE_WORKFLOW},
-            util::AsyncCallback,
-        };
-
-        impl Client {
-            pub fn invoke_rpc(&self, service: u8, callback: AsyncCallback, call: RpcCall) -> Result<(), Error> {
-                match service {
-      TEXT
-      generate_rust_match_arm(
-        file:,
-        qualified_service_name: 'temporal.api.workflowservice.v1.WorkflowService',
-        service_enum: 'SERVICE_WORKFLOW',
-        trait: 'WorkflowService'
-      )
-      generate_rust_match_arm(
-        file:,
-        qualified_service_name: 'temporal.api.operatorservice.v1.OperatorService',
-        service_enum: 'SERVICE_OPERATOR',
-        trait: 'OperatorService'
-      )
-      generate_rust_match_arm(
-        file:,
-        qualified_service_name: 'temporal.api.cloud.cloudservice.v1.CloudService',
-        service_enum: 'SERVICE_CLOUD',
-        trait: 'CloudService'
-      )
-      file.puts <<~TEXT
-                    _ => Err(error!("Unknown service")),
-                }
-            }
-        }
-      TEXT
-    end
-    sh 'cargo', 'fmt', '--', 'ext/src/client_rpc_generated.rs'
-
-    # Generate core protos
-    FileUtils.rm_rf('lib/temporalio/internal/bridge/api')
-    # Generate API to temp dir
-    FileUtils.rm_rf('tmp-proto')
-    FileUtils.mkdir_p('tmp-proto')
-    sh 'bundle exec grpc_tools_ruby_protoc ' \
-       '--proto_path=ext/sdk-core/sdk-core-protos/protos/api_upstream ' \
-       '--proto_path=ext/sdk-core/sdk-core-protos/protos/local ' \
-       '--ruby_out=tmp-proto ' \
-       "#{Dir.glob('ext/sdk-core/sdk-core-protos/protos/local/**/*.proto').join(' ')}"
-    # Walk all generated Ruby files and cleanup content and filename
-    Dir.glob('tmp-proto/temporal/sdk/**/*.rb') do |path|
-      # Fix up the imports
-      content = File.read(path)
-      content.gsub!(%r{^require 'temporal/(.*)_pb'$}, "require 'temporalio/\\1'")
-      content.gsub!(%r{^require 'temporalio/sdk/core/(.*)'$}, "require 'temporalio/internal/bridge/api/\\1'")
-      File.write(path, content)
-
-      # Remove _pb from the filename
-      FileUtils.mv(path, path.sub('_pb', ''))
-    end
-    # Move from temp dir and remove temp dir
-    FileUtils.mkdir_p('lib/temporalio/internal/bridge/api')
-    FileUtils.cp_r(Dir.glob('tmp-proto/temporal/sdk/core/*'), 'lib/temporalio/internal/bridge/api')
-    FileUtils.rm_rf('tmp-proto')
+    require_relative 'extra/proto_gen'
+    ProtoGen.new.run
   end
 end
 
@@ -380,7 +94,7 @@ Rake::Task[:build].enhance([:copy_parent_files]) do
 end
 
 task :rust_lint do
-  sh 'cargo', 'clippy'
+  sh 'cargo', 'clippy', '-p', 'temporalio_bridge', '--no-deps', '--', '-Dwarnings'
   sh 'cargo', 'fmt', '--check'
 end
 

data/ext/Cargo.toml

@@ -20,6 +20,8 @@ temporal-sdk-core = { version = "0.1.0", path = "./sdk-core/core", features = ["
 temporal-sdk-core-api = { version = "0.1.0", path = "./sdk-core/core-api" }
 temporal-sdk-core-protos = { version = "0.1.0", path = "./sdk-core/sdk-core-protos" }
 tokio = "1.26"
+tokio-stream = "0.1"
+tokio-util = "0.7"
 tonic = "0.12"
 tracing = "0.1"
 url = "2.2"

data/lib/temporalio/activity/complete_async_error.rb

@@ -3,7 +3,7 @@
 require 'temporalio/error'
 
 module Temporalio
-  class Activity
+  module Activity
     # Error raised inside an activity to mark that the activity will be completed asynchronously.
     class CompleteAsyncError < Error
     end

data/lib/temporalio/activity/context.rb

@@ -3,7 +3,7 @@
 require 'temporalio/error'
 
 module Temporalio
-  class Activity
+  module Activity
     # Context accessible only within an activity. Use {current} to get the current context. Contexts are fiber or thread
     # local so may not be available in a newly started thread from an activity and may have to be propagated manually.
     class Context
@@ -48,6 +48,12 @@ module Temporalio
         raise NotImplementedError
       end
 
+      # @return [Object, nil] Activity class instance. This should always be present except for advanced cases where the
+      #   definition was manually created without any instance getter/creator.
+      def instance
+        raise NotImplementedError
+      end
+
       # Record a heartbeat on the activity.
       #
       # Heartbeats should be used for all non-immediately-returning, non-local activities and they are required to
@@ -101,7 +107,17 @@ module Temporalio
         }.freeze
       end
 
-      # TODO(cretz): metric meter
+      # @return [Metric::Meter] Metric meter to create metrics on, with some activity-specific attributes already set.
+      # @raise [RuntimeError] Called within a {Testing::ActivityEnvironment} and it was not set.
+      def metric_meter
+        raise NotImplementedError
+      end
+
+      # @return [Client] Temporal client this activity worker is running in.
+      # @raise [RuntimeError] Called within a {Testing::ActivityEnvironment} and it was not set.
+      def client
+        raise NotImplementedError
+      end
     end
   end
 end

data/lib/temporalio/activity/definition.rb

@@ -1,76 +1,191 @@
 # frozen_string_literal: true
 
+require 'temporalio/internal/proto_utils'
+
 module Temporalio
-  class Activity
-    # Definition of an activity. Activities are usually classes/instances that extend {Activity}, but definitions can
-    # also be manually created with a proc/block.
+  module Activity
+    # Base class for all activities.
+    #
+    # Activities can be given to a worker as instances of this class, which will call execute on the same instance for
+    # each execution, or given to the worker as the class itself which instantiates the activity for each execution.
+    #
+    # All activities must implement {execute}. Inside execute, {Activity::Context.current} can be used to access the
+    # current context to get information, issue heartbeats, etc.
+    #
+    # By default, the activity is named as its unqualified class name. This can be customized with {activity_name}.
+    #
+    # By default, the activity uses the `:default` executor which is usually the thread-pool based executor. This can be
+    # customized with {activity_executor}.
+    #
+    # By default, upon cancellation {::Thread.raise} or {::Fiber.raise} is called with a {Error::CanceledError}. This
+    # can be disabled by passing `false` to {activity_cancel_raise}.
+    #
+    # See documentation for more detail on activities.
     class Definition
-      # @return [String, Symbol] Name of the activity.
-      attr_reader :name
-
-      # @return [Proc] Proc for the activity.
-      attr_reader :proc
-
-      # @return [Symbol] Name of the executor. Default is `:default`.
-      attr_reader :executor
-
-      # @return [Boolean] Whether to raise in thread/fiber on cancellation. Default is `true`.
-      attr_reader :cancel_raise
-
-      # Obtain a definition representing the given activity, which can be a class, instance, or definition.
-      #
-      # @param activity [Activity, Class<Activity>, Definition] Activity to get definition for.
-      # @return Definition Obtained definition.
-      def self.from_activity(activity)
-        # Class means create each time, instance means just call, definition
-        # does nothing special
-        case activity
-        when Class
-          raise ArgumentError, "Class '#{activity}' does not extend Activity" unless activity < Activity
-
-          details = activity._activity_definition_details
-          new(
-            name: details[:activity_name],
-            executor: details[:activity_executor],
-            cancel_raise: details[:activity_cancel_raise],
-            # Instantiate and call
-            proc: proc { |*args| activity.new.execute(*args) }
-          )
-        when Activity
-          details = activity.class._activity_definition_details
-          new(
-            name: details[:activity_name],
-            executor: details[:activity_executor],
-            cancel_raise: details[:activity_cancel_raise],
-            # Just call
-            proc: proc { |*args| activity.execute(*args) }
-          )
-        when Activity::Definition
-          activity
-        else
-          raise ArgumentError, "#{activity} is not an activity class, instance, or definition"
+      class << self
+        protected
+
+        # Override the activity name which is defaulted to the unqualified class name.
+        #
+        # @param name [String, Symbol] Name to use.
+        def activity_name(name)
+          if !name.is_a?(Symbol) && !name.is_a?(String)
+            raise ArgumentError,
+                  'Activity name must be a symbol or string'
+          end
+
+          @activity_name = name.to_s
+        end
+
+        # Override the activity executor which is defaulted to `:default`.
+        #
+        # @param executor_name [Symbol] Executor to use.
+        def activity_executor(executor_name)
+          raise ArgumentError, 'Executor name must be a symbol' unless executor_name.is_a?(Symbol)
+
+          @activity_executor = executor_name
+        end
+
+        # Override whether the activity uses Thread/Fiber raise for cancellation which is defaulted to true.
+        #
+        # @param cancel_raise [Boolean] Whether to raise.
+        def activity_cancel_raise(cancel_raise)
+          unless cancel_raise.is_a?(TrueClass) || cancel_raise.is_a?(FalseClass)
+            raise ArgumentError, 'Must be a boolean'
+          end
+
+          @activity_cancel_raise = cancel_raise
+        end
+
+        # Set an activity as dynamic. Dynamic activities do not have names and handle any activity that is not otherwise
+        # registered. A worker can only have one dynamic activity. It is often useful to use {activity_raw_args} with
+        # this.
+        #
+        # @param value [Boolean] Whether the activity is dynamic.
+        def activity_dynamic(value = true) # rubocop:disable Style/OptionalBooleanParameter
+          raise ArgumentError, 'Must be a boolean' unless value.is_a?(TrueClass) || value.is_a?(FalseClass)
+
+          @activity_dynamic = value
+        end
+
+        # Have activity arguments delivered to `execute` as {Converters::RawValue}s. These are wrappers for the raw
+        # payloads that have not been converted to types (but they have been decoded by the codec if present). They can
+        # be converted with {Context#payload_converter}.
+        #
+        # @param value [Boolean] Whether the activity accepts raw arguments.
+        def activity_raw_args(value = true) # rubocop:disable Style/OptionalBooleanParameter
+          raise ArgumentError, 'Must be a boolean' unless value.is_a?(TrueClass) || value.is_a?(FalseClass)
+
+          @activity_raw_args = value
         end
       end
 
-      # Manually create activity definition. Most users will use an instance/class of {Activity}.
-      #
-      # @param name [String, Symbol] Name of the activity.
-      # @param proc [Proc, nil] Proc for the activity, or can give block.
-      # @param executor [Symbol] Name of the executor.
-      # @param cancel_raise [Boolean] Whether to raise in thread/fiber on cancellation.
-      # @yield Use this block as the activity. Cannot be present with `proc`.
-      def initialize(name:, proc: nil, executor: :default, cancel_raise: true, &block)
-        @name = name
-        if proc.nil?
-          raise ArgumentError, 'Must give proc or block' unless block_given?
-
-          proc = block
-        elsif block_given?
-          raise ArgumentError, 'Cannot give proc and block'
+      # @!visibility private
+      def self._activity_definition_details
+        activity_name = @activity_name
+        raise 'Cannot have activity name specified for dynamic activity' if activity_name && @activity_dynamic
+
+        # Default to unqualified class name if not dynamic
+        activity_name ||= name.to_s.split('::').last unless @activity_dynamic
+        {
+          activity_name:,
+          activity_executor: @activity_executor || :default,
+          activity_cancel_raise: @activity_cancel_raise.nil? || @activity_cancel_raise,
+          activity_raw_args: @activity_raw_args.nil? ? false : @activity_raw_args
+        }
+      end
+
+      # Implementation of the activity. The arguments should be positional and this should return the value on success
+      # or raise an error on failure.
+      def execute(*args)
+        raise NotImplementedError, 'Activity did not implement "execute"'
+      end
+
+      # Definition info of an activity. Activities are usually classes/instances that extend {Definition}, but
+      # definitions can also be manually created with a block via {initialize} here.
+      class Info
+        # @return [String, Symbol, nil] Name of the activity, or nil if the activity is dynamic.
+        attr_reader :name
+
+        # @return [Object, Proc, nil] The pre-created instance or the proc to create/return it.
+        attr_reader :instance
+
+        # @return [Proc] Proc for the activity. Should use {Context#instance} to access the instance.
+        attr_reader :proc
+
+        # @return [Symbol] Name of the executor. Default is `:default`.
+        attr_reader :executor
+
+        # @return [Boolean] Whether to raise in thread/fiber on cancellation. Default is `true`.
+        attr_reader :cancel_raise
+
+        # @return [Boolean] Whether to use {Converters::RawValue}s as arguments.
+        attr_reader :raw_args
+
+        # Obtain definition info representing the given activity, which can be a class, instance, or definition info.
+        #
+        # @param activity [Definition, Class<Definition>, Info] Activity to get info for.
+        # @return Info Obtained definition info.
+        def self.from_activity(activity)
+          # Class means create each time, instance means just call, definition
+          # does nothing special
+          case activity
+          when Class
+            unless activity < Definition
+              raise ArgumentError,
+                    "Class '#{activity}' does not extend Temporalio::Activity::Definition"
+            end
+
+            details = activity._activity_definition_details
+            new(
+              name: details[:activity_name],
+              instance: proc { activity.new },
+              executor: details[:activity_executor],
+              cancel_raise: details[:activity_cancel_raise],
+              raw_args: details[:activity_raw_args]
+            ) { |*args| Context.current.instance&.execute(*args) }
+          when Definition
+            details = activity.class._activity_definition_details
+            new(
+              name: details[:activity_name],
+              instance: activity,
+              executor: details[:activity_executor],
+              cancel_raise: details[:activity_cancel_raise],
+              raw_args: details[:activity_raw_args]
+            ) { |*args| Context.current.instance&.execute(*args) }
+          when Info
+            activity
+          else
+            raise ArgumentError, "#{activity} is not an activity class, instance, or definition info"
+          end
+        end
+
+        # Manually create activity definition info. Most users will use an instance/class of {Definition}.
+        #
+        # @param name [String, Symbol, nil] Name of the activity or nil for dynamic activity.
+        # @param instance [Object, Proc, nil] The pre-created instance or the proc to create/return it.
+        # @param executor [Symbol] Name of the executor.
+        # @param cancel_raise [Boolean] Whether to raise in thread/fiber on cancellation.
+        # @param raw_args [Boolean] Whether to use {Converters::RawValue}s as arguments.
+        # @yield Use this block as the activity.
+        def initialize(
+          name:,
+          instance: nil,
+          executor: :default,
+          cancel_raise: true,
+          raw_args: false,
+          &block
+        )
+          @name = name
+          @instance = instance
+          raise ArgumentError, 'Must give block' unless block_given?
+
+          @proc = block
+          @executor = executor
+          @cancel_raise = cancel_raise
+          @raw_args = raw_args
+          Internal::ProtoUtils.assert_non_reserved_name(name)
         end
-        @proc = proc
-        @executor = executor
-        @cancel_raise = cancel_raise
       end
     end
   end