temporal_tables 3.0.0.pre.rc.1 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31e81d8469855b4283e3a56ef636df6c13866fc68327e1b8795ce22e09682a23
-  data.tar.gz: 3d5d3d9cb10a01573bb52edacf2941612545443c1af19e275f181578a8e11678
+  metadata.gz: 263d71547d60d6a668202ad900b21ee8d683615dd4afc096e37a9d9a53489b33
+  data.tar.gz: acc012e82bd6deae7872b22fb80ee8d6dbea27cf53f73dd9b87fb303015540ce
 SHA512:
-  metadata.gz: ac18fbf6c986bd41d3ec0804d203ef54f042304c693017e69b3885129ac344e7401cdac59903fdc9d6deb3cc77273f051a6f175da317be8fac7505b2b1b88b5a
-  data.tar.gz: 0c6d6cb23559785e115afb4fadf9d9d7af4d1565971aa78dde486a3cfee3538809ad99117e1d2d5d792da681a6cb8db22d0451ce787755e94f90bdceb1ddec7d
+  metadata.gz: f4543bec2427c87c59f2c0df7edea2fbaa6072ae583584c8bbcf54ea60e8de2e03ec290c0375ba91608a0cd32aec00ac11106ae0391b8632b03f60170dcffdd5
+  data.tar.gz: 0dc70cd60fc891be32c8f22f440bf3ed6ede26c5c1e6b5f028d3930166c1fcb92df528930364d0e8983bb9dd9128596ea2b64f5d48efd5c3af1373d1f2505e4a

data/.github/workflows/test.yml

@@ -4,6 +4,8 @@ on:
   push:
     branches:
       - '**'
+    tags:
+      - "v*.*.*"
   pull_request:
     branches:
       - master
@@ -44,7 +46,7 @@ jobs:
         ruby-version: "${{ matrix.ruby }}"
     - name: Bundle
       run: |
-        gem install bundler:2.2.15
+        gem install bundler:2.4.10
         bundle install
 
     - name: Run Rubocop
@@ -55,3 +57,20 @@ jobs:
         PGHOST: localhost
         PGUSER: postgres
       run: bundle exec rspec
+
+  publish:
+    needs: [tests]
+    runs-on: ubuntu-latest
+    if: startsWith(github.ref, 'refs/tags/v')
+
+    permissions:
+      contents: write
+      id-token: write
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.2.2"
+          bundler-cache: true
+      - uses: rubygems/release-gem@v1

data/README.md

@@ -1,4 +1,4 @@
-[![Actions Status](https://github.com/bkroeker/temporal_tables/workflows/Continuous%20Integration/badge.svg?branch=master)](https://github.com/bkroeker/temporal_tables/actions)
+[![Continuous Integration](https://github.com/bkroeker/temporal_tables/actions/workflows/test.yml/badge.svg)](https://github.com/bkroeker/temporal_tables/actions/workflows/test.yml)
 
 # TemporalTables
 

data/gemfiles/Gemfile.6.1.mysql.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (3.0.0)
-      rails (>= 6.0, < 7.2)
+    temporal_tables (3.0.1)
+      rails (>= 6.1, < 7.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/Gemfile.6.1.pg.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (3.0.0)
-      rails (>= 6.0, < 7.2)
+    temporal_tables (3.0.1)
+      rails (>= 6.1, < 7.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/Gemfile.7.0.mysql.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (3.0.0)
-      rails (>= 6.0, < 7.2)
+    temporal_tables (3.0.1)
+      rails (>= 6.1, < 7.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/Gemfile.7.0.pg.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (3.0.0)
-      rails (>= 6.0, < 7.2)
+    temporal_tables (3.0.1)
+      rails (>= 6.1, < 7.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/Gemfile.7.1.mysql.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (3.0.0)
-      rails (>= 6.0, < 7.2)
+    temporal_tables (3.0.1)
+      rails (>= 6.1, < 7.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/Gemfile.7.1.pg.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (3.0.0)
-      rails (>= 6.0, < 7.2)
+    temporal_tables (3.0.1)
+      rails (>= 6.1, < 7.2)
 
 GEM
   remote: https://rubygems.org/

data/lib/temporal_tables/association_extensions.rb

@@ -10,8 +10,12 @@ module TemporalTables
       # Using responds_to? results in an infinite loop stack overflow.
       if @owner.public_methods.include?(:at_value)
         # If this is a history record but no at time was given,
-        # assume the record's effective to date
-        super.at(@owner.at_value || @owner.eff_to)
+        # assume the record's effective to date minus 1 microsecond
+        # The logic here is to provide the association's history record at the end of
+        # the parent record's effective period. Since effective ranges are exclusive of
+        # the eff_to value, and the eff_* columns are datetime types with a precision of microseconds,
+        # 1 microsecond before eff_to is the end of the inclusive boundary to accomplish this.
+        super.at(@owner.at_value || (@owner.eff_to - TemporalTables::ONE_MICROSECOND))
       else
         super
       end

data/lib/temporal_tables/constants.rb

@@ -2,4 +2,5 @@
 
 module TemporalTables
   END_OF_TIME = '9999-12-31'
+  ONE_MICROSECOND = 0.000001.seconds
 end

data/lib/temporal_tables/temporal_class.rb

@@ -42,8 +42,7 @@ module TemporalTables
               association.macro, association.name,
               **association.options.merge(
                 class_name: clazz.name,
-                foreign_key: association.foreign_key,
-                primary_key: clazz.orig_class.primary_key
+                foreign_key: association.foreign_key
               )
             )
           end

data/lib/temporal_tables/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TemporalTables
-  VERSION = '3.0.0-rc.1'
+  VERSION = '3.0.1'
 end

data/spec/basic_history_spec.rb

@@ -229,6 +229,26 @@ describe Person do
       end
     end
   end
+
+  describe 'when removing a creature' do
+    let!(:wart) { Wart.create person: emily, hairiness: 3 }
+
+    before do
+      emily.destroy!
+      sleep 0.1
+    end
+
+    it 'destroys associated warts and we remember the historical association' do
+      expect(emily).to be_destroyed
+      expect { wart.reload }.to raise_error(ActiveRecord::RecordNotFound) # as it belonged to emily
+
+      wart_h = wart.history.last # the last version of the wart
+      expect(wart_h).to be_present
+
+      emily_h = wart_h.person
+      expect(emily_h).to be_present # we should be able to tell what person our wart belonged to
+    end
+  end
 end
 
 describe Bird do
@@ -244,3 +264,19 @@ describe Bird do
     end
   end
 end
+
+describe Hamster do
+  context 'with tables that have non-default primary key names' do
+    let(:hamster) { Hamster.create name: 'Fluffy' }
+    let(:wheel) { HamsterWheel.create hamster: hamster }
+
+    it 'can create instance of class with nested class name with history entries' do
+      expect(hamster).not_to be_nil
+      expect(wheel).not_to be_nil
+      expect(hamster.hamster_wheel).not_to be_nil
+      hamster_history = Hamster.history.at(Time.now.utc).first
+      expect(hamster_history).not_to be_nil
+      expect(hamster_history.hamster_wheel).not_to be_nil
+    end
+  end
+end

data/spec/internal/app/models/hamster.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class Hamster < ActiveRecord::Base
+  self.primary_key = :uuid
+
+  has_one :hamster_wheel, foreign_key: :hamster_uuid, inverse_of: :hamster
+end

data/spec/internal/app/models/hamster_wheel.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class HamsterWheel < ActiveRecord::Base
+  belongs_to :hamster, foreign_key: :hamster_uuid, primary_key: :uuid, inverse_of: :hamster_wheel
+end

data/spec/internal/app/models/person.rb

@@ -2,6 +2,6 @@
 
 class Person < ActiveRecord::Base
   belongs_to :coven
-  has_many :warts
+  has_many :warts, dependent: :destroy
   has_many :flying_machines
 end

data/spec/internal/db/schema.rb

@@ -69,4 +69,22 @@ ActiveRecord::Schema.define do
     t.belongs_to :bird, type: (postgres ? :uuid : :integer)
     t.integer :height
   end
+
+  if postgres
+    create_table :hamsters, id: false do |t|
+      t.column :uuid, :uuid, default: 'gen_random_uuid()'
+      t.string :name
+    end
+    execute 'ALTER TABLE hamsters ADD PRIMARY KEY (uuid);'
+    add_temporal_table :hamsters
+  else
+    create_table :hamsters, primary_key: :uuid, temporal: true do |t|
+      t.string :name
+    end
+  end
+
+  create_table :hamster_wheels, id: (postgres ? :uuid : :integer), temporal: true do |t|
+    t.column :hamster_uuid, (postgres ? :uuid : :bigint), null: false
+    t.foreign_key :hamsters, column: :hamster_uuid, primary_key: :uuid
+  end
 end

data/temporal_tables.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
   gem.required_ruby_version = '>= 3.0.0'
   gem.metadata = { 'rubygems_mfa_required' => 'true' }
 
-  gem.add_dependency 'rails', '>= 6.0', '< 7.2'
+  gem.add_dependency 'rails', '>= 6.1', '< 7.2'
   gem.add_development_dependency 'combustion', '~> 1'
   gem.add_development_dependency 'database_cleaner'
   gem.add_development_dependency 'gemika', '~> 0.8'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: temporal_tables
 version: !ruby/object:Gem::Version
-  version: 3.0.0.pre.rc.1
+  version: 3.0.1
 platform: ruby
 authors:
 - Brent Kroeker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-08 00:00:00.000000000 Z
+date: 2024-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.2'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.2'
@@ -224,6 +224,8 @@ files:
 - spec/internal/app/models/coven.rb
 - spec/internal/app/models/dog.rb
 - spec/internal/app/models/flying_machine.rb
+- spec/internal/app/models/hamster.rb
+- spec/internal/app/models/hamster_wheel.rb
 - spec/internal/app/models/person.rb
 - spec/internal/app/models/rocket_broom.rb
 - spec/internal/app/models/wart.rb
@@ -250,9 +252,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.4.10
 signing_key: 
@@ -268,6 +270,8 @@ test_files:
 - spec/internal/app/models/coven.rb
 - spec/internal/app/models/dog.rb
 - spec/internal/app/models/flying_machine.rb
+- spec/internal/app/models/hamster.rb
+- spec/internal/app/models/hamster_wheel.rb
 - spec/internal/app/models/person.rb
 - spec/internal/app/models/rocket_broom.rb
 - spec/internal/app/models/wart.rb