temporal_tables 0.8.1 → 1.0.1

data/gemfiles/Gemfile.7.0.mysql.lock

@@ -0,0 +1,173 @@
+PATH
+  remote: ..
+  specs:
+    temporal_tables (1.0.1)
+      rails (>= 6.0, < 7.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (7.0.0)
+      actionpack (= 7.0.0)
+      activesupport (= 7.0.0)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (7.0.0)
+      actionpack (= 7.0.0)
+      activejob (= 7.0.0)
+      activerecord (= 7.0.0)
+      activestorage (= 7.0.0)
+      activesupport (= 7.0.0)
+      mail (>= 2.7.1)
+    actionmailer (7.0.0)
+      actionpack (= 7.0.0)
+      actionview (= 7.0.0)
+      activejob (= 7.0.0)
+      activesupport (= 7.0.0)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (7.0.0)
+      actionview (= 7.0.0)
+      activesupport (= 7.0.0)
+      rack (~> 2.0, >= 2.2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (7.0.0)
+      actionpack (= 7.0.0)
+      activerecord (= 7.0.0)
+      activestorage (= 7.0.0)
+      activesupport (= 7.0.0)
+      globalid (>= 0.6.0)
+      nokogiri (>= 1.8.5)
+    actionview (7.0.0)
+      activesupport (= 7.0.0)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (7.0.0)
+      activesupport (= 7.0.0)
+      globalid (>= 0.3.6)
+    activemodel (7.0.0)
+      activesupport (= 7.0.0)
+    activerecord (7.0.0)
+      activemodel (= 7.0.0)
+      activesupport (= 7.0.0)
+    activestorage (7.0.0)
+      actionpack (= 7.0.0)
+      activejob (= 7.0.0)
+      activerecord (= 7.0.0)
+      activesupport (= 7.0.0)
+      marcel (~> 1.0)
+      mini_mime (>= 1.1.0)
+    activesupport (7.0.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    builder (3.2.4)
+    byebug (11.1.3)
+    combustion (1.3.5)
+      activesupport (>= 3.0.0)
+      railties (>= 3.0.0)
+      thor (>= 0.14.6)
+    concurrent-ruby (1.1.9)
+    crass (1.0.6)
+    database_cleaner (2.0.1)
+      database_cleaner-active_record (~> 2.0.0)
+    database_cleaner-active_record (2.0.1)
+      activerecord (>= 5.a)
+      database_cleaner-core (~> 2.0.0)
+    database_cleaner-core (2.0.1)
+    diff-lcs (1.5.0)
+    erubi (1.10.0)
+    gemika (0.6.1)
+    globalid (1.0.0)
+      activesupport (>= 5.0)
+    i18n (1.8.11)
+      concurrent-ruby (~> 1.0)
+    loofah (2.13.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (1.0.2)
+    method_source (1.0.0)
+    mini_mime (1.1.2)
+    minitest (5.15.0)
+    mysql2 (0.5.3)
+    nio4r (2.5.8)
+    nokogiri (1.12.5-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.12.5-x86_64-darwin)
+      racc (~> 1.4)
+    racc (1.6.0)
+    rack (2.2.3)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (7.0.0)
+      actioncable (= 7.0.0)
+      actionmailbox (= 7.0.0)
+      actionmailer (= 7.0.0)
+      actionpack (= 7.0.0)
+      actiontext (= 7.0.0)
+      actionview (= 7.0.0)
+      activejob (= 7.0.0)
+      activemodel (= 7.0.0)
+      activerecord (= 7.0.0)
+      activestorage (= 7.0.0)
+      activesupport (= 7.0.0)
+      bundler (>= 1.15.0)
+      railties (= 7.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.4.2)
+      loofah (~> 2.3)
+    railties (7.0.0)
+      actionpack (= 7.0.0)
+      activesupport (= 7.0.0)
+      method_source
+      rake (>= 12.2)
+      thor (~> 1.0)
+      zeitwerk (~> 2.5)
+    rake (13.0.6)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.3)
+    thor (1.1.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    websocket-driver (0.7.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.5)
+    zeitwerk (2.5.3)
+
+PLATFORMS
+  arm64-darwin-20
+  x86_64-darwin-19
+
+DEPENDENCIES
+  byebug
+  combustion
+  database_cleaner
+  gemika
+  mysql2
+  rails (~> 7.0.0)
+  rake
+  rspec (~> 3.4)
+  temporal_tables!
+
+BUNDLED WITH
+   2.2.3

data/gemfiles/{Gemfile.5.2.pg → Gemfile.7.0.pg}

@@ -1,7 +1,7 @@
 source 'https://rubygems.org'
 
 # Runtime dependencies
-gem 'rails', '~> 5.2.0'
+gem 'rails', '~> 7.0.0'
 gem 'pg', '>= 0.18', '< 2.0'
 
 # Development dependencies

data/gemfiles/Gemfile.7.0.pg.lock

@@ -0,0 +1,173 @@
+PATH
+  remote: ..
+  specs:
+    temporal_tables (1.0.1)
+      rails (>= 6.0, < 7.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (7.0.0)
+      actionpack (= 7.0.0)
+      activesupport (= 7.0.0)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (7.0.0)
+      actionpack (= 7.0.0)
+      activejob (= 7.0.0)
+      activerecord (= 7.0.0)
+      activestorage (= 7.0.0)
+      activesupport (= 7.0.0)
+      mail (>= 2.7.1)
+    actionmailer (7.0.0)
+      actionpack (= 7.0.0)
+      actionview (= 7.0.0)
+      activejob (= 7.0.0)
+      activesupport (= 7.0.0)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (7.0.0)
+      actionview (= 7.0.0)
+      activesupport (= 7.0.0)
+      rack (~> 2.0, >= 2.2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (7.0.0)
+      actionpack (= 7.0.0)
+      activerecord (= 7.0.0)
+      activestorage (= 7.0.0)
+      activesupport (= 7.0.0)
+      globalid (>= 0.6.0)
+      nokogiri (>= 1.8.5)
+    actionview (7.0.0)
+      activesupport (= 7.0.0)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (7.0.0)
+      activesupport (= 7.0.0)
+      globalid (>= 0.3.6)
+    activemodel (7.0.0)
+      activesupport (= 7.0.0)
+    activerecord (7.0.0)
+      activemodel (= 7.0.0)
+      activesupport (= 7.0.0)
+    activestorage (7.0.0)
+      actionpack (= 7.0.0)
+      activejob (= 7.0.0)
+      activerecord (= 7.0.0)
+      activesupport (= 7.0.0)
+      marcel (~> 1.0)
+      mini_mime (>= 1.1.0)
+    activesupport (7.0.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    builder (3.2.4)
+    byebug (11.1.3)
+    combustion (1.3.5)
+      activesupport (>= 3.0.0)
+      railties (>= 3.0.0)
+      thor (>= 0.14.6)
+    concurrent-ruby (1.1.9)
+    crass (1.0.6)
+    database_cleaner (2.0.1)
+      database_cleaner-active_record (~> 2.0.0)
+    database_cleaner-active_record (2.0.1)
+      activerecord (>= 5.a)
+      database_cleaner-core (~> 2.0.0)
+    database_cleaner-core (2.0.1)
+    diff-lcs (1.5.0)
+    erubi (1.10.0)
+    gemika (0.6.1)
+    globalid (1.0.0)
+      activesupport (>= 5.0)
+    i18n (1.8.11)
+      concurrent-ruby (~> 1.0)
+    loofah (2.13.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (1.0.2)
+    method_source (1.0.0)
+    mini_mime (1.1.2)
+    minitest (5.15.0)
+    nio4r (2.5.8)
+    nokogiri (1.12.5-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.12.5-x86_64-darwin)
+      racc (~> 1.4)
+    pg (1.2.3)
+    racc (1.6.0)
+    rack (2.2.3)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (7.0.0)
+      actioncable (= 7.0.0)
+      actionmailbox (= 7.0.0)
+      actionmailer (= 7.0.0)
+      actionpack (= 7.0.0)
+      actiontext (= 7.0.0)
+      actionview (= 7.0.0)
+      activejob (= 7.0.0)
+      activemodel (= 7.0.0)
+      activerecord (= 7.0.0)
+      activestorage (= 7.0.0)
+      activesupport (= 7.0.0)
+      bundler (>= 1.15.0)
+      railties (= 7.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.4.2)
+      loofah (~> 2.3)
+    railties (7.0.0)
+      actionpack (= 7.0.0)
+      activesupport (= 7.0.0)
+      method_source
+      rake (>= 12.2)
+      thor (~> 1.0)
+      zeitwerk (~> 2.5)
+    rake (13.0.6)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.3)
+    thor (1.1.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    websocket-driver (0.7.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.5)
+    zeitwerk (2.5.3)
+
+PLATFORMS
+  arm64-darwin-20
+  x86_64-darwin-19
+
+DEPENDENCIES
+  byebug
+  combustion
+  database_cleaner
+  gemika
+  pg (>= 0.18, < 2.0)
+  rails (~> 7.0.0)
+  rake
+  rspec (~> 3.4)
+  temporal_tables!
+
+BUNDLED WITH
+   2.2.3

data/lib/temporal_tables/arel_table.rb

@@ -1,19 +1,20 @@
+# frozen_string_literal: true
+
 module TemporalTables
-  # This is required for eager_load to work in Rails 6.0
+  # This is required for eager_load to work
   module ArelTable
     def create_join(to, constraint = nil, klass = Arel::Nodes::InnerJoin)
       join = super
-      if at_value = Thread.current[:at_time]
-        join = join.
-          and(to[:eff_to].gteq(at_value)).
-          and(to[:eff_from].lteq(at_value))
+      at_value = Thread.current[:at_time]
+      if at_value
+        join =
+          join
+          .and(to[:eff_to].gteq(at_value))
+          .and(to[:eff_from].lteq(at_value))
       end
       join
     end
   end
 end
 
-case Rails::VERSION::MAJOR
-when 6
-  Arel::Table.prepend TemporalTables::ArelTable
-end
+Arel::Table.prepend TemporalTables::ArelTable

data/lib/temporal_tables/association_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TemporalTables
   # Uses the time from the "at" field stored in the record to filter queries
   # made to associations.

data/lib/temporal_tables/connection_adapters/mysql_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TemporalTables
   module ConnectionAdapters
     module AbstractMysqlAdapter
@@ -7,7 +9,7 @@ module TemporalTables
         execute "drop trigger #{table_name}_ad"
       end
 
-      def create_temporal_triggers(table_name)
+      def create_temporal_triggers(table_name) # rubocop:disable Metrics/MethodLength
         column_names = columns(table_name).map(&:name)
 
         execute %{
@@ -17,7 +19,7 @@ module TemporalTables
             set @current_time = utc_timestamp(6);
 
             insert into #{temporal_name(table_name)} (#{column_names.join(', ')}, eff_from)
-            values (#{column_names.collect {|c| "new.#{c}"}.join(', ')}, @current_time);
+            values (#{column_names.collect { |c| "new.#{c}" }.join(', ')}, @current_time);
 
           end
         }
@@ -33,7 +35,7 @@ module TemporalTables
             and eff_to = '9999-12-31';
 
             insert into #{temporal_name(table_name)} (#{column_names.join(', ')}, eff_from)
-            values (#{column_names.collect {|c| "new.#{c}"}.join(', ')}, @current_time);
+            values (#{column_names.collect { |c| "new.#{c}" }.join(', ')}, @current_time);
 
           end
         }

data/lib/temporal_tables/connection_adapters/postgresql_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TemporalTables
   module ConnectionAdapters
     module PostgreSQLAdapter
@@ -7,7 +9,7 @@ module TemporalTables
         execute "drop trigger #{table_name}_ad on #{table_name}"
       end
 
-      def create_temporal_triggers(table_name)
+      def create_temporal_triggers(table_name) # rubocop:disable Metrics/MethodLength
         column_names = columns(table_name).map(&:name)
 
         execute %{
@@ -18,7 +20,7 @@ module TemporalTables
               cur_time := localtimestamp;
 
               insert into #{temporal_name(table_name)} (#{column_list(column_names)}, eff_from)
-              values (#{column_names.collect {|c| "new.#{c}"}.join(', ')}, cur_time);
+              values (#{column_names.collect { |c| "new.#{c}" }.join(', ')}, cur_time);
 
               return null;
             end
@@ -41,7 +43,7 @@ module TemporalTables
                 and eff_to = '9999-12-31';
 
               insert into #{temporal_name(table_name)} (#{column_list(column_names)}, eff_from)
-              values (#{column_names.collect {|c| "new.#{c}"}.join(', ')}, cur_time);
+              values (#{column_names.collect { |c| "new.#{c}" }.join(', ')}, cur_time);
 
               return null;
             end

data/lib/temporal_tables/history_hook.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TemporalTables
   # This hooks in a "history" method to ActiveRecord::Base which will
   # return the class's History class.  The history class extends the original
@@ -8,14 +10,15 @@ module TemporalTables
   #  end
   #
   #  Person         #=> Person(id: integer, name: string)
-  #  Person.history #=> PersonHistory(history_id: integer, id: integer, name: string, eff_from: datetime, eff_to: datetime)
+  #  Person.history #=> PersonHistory(history_id: integer, id: integer,
+  #                     name: string, eff_from: datetime, eff_to: datetime)
   module HistoryHook
-    def self.included(base)
+    def self.included(base) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
       base.class_eval do
         # Return this class's history class.
         # If it doesn't exist yet, create and initialize it, as well
         # as all dependent classes (through associations).
-        def self.history
+        def self.history # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
           raise "Can't view history of history" if name =~ /History$/
 
           history_class = "#{name}History"
@@ -25,7 +28,7 @@ module TemporalTables
           new_class = Class.new(self) do
             include TemporalTables::TemporalClass
           end
-          segments = history_class.split("::")
+          segments = history_class.split('::')
           object_class = segments[0...-1].inject(Object) { |o, s| o.const_get(s) }
           object_class.const_set segments.last, new_class
 
@@ -47,4 +50,4 @@ module TemporalTables
   end
 end
 
-ActiveRecord::Base.send :include, TemporalTables::HistoryHook
+ActiveRecord::Base.include TemporalTables::HistoryHook

data/lib/temporal_tables/preloader_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TemporalTables
   # Uses the at time when fetching preloaded records
   module PreloaderExtensions

data/lib/temporal_tables/reflection_extensions.rb

@@ -1,21 +1,18 @@
+# frozen_string_literal: true
+
 module TemporalTables
-  # This is required for eager_load to work in Rails 5.2.x
+  # This is required for eager_load to work in 6.1
   module AbstractReflectionExtensions
-    def build_join_constraint(table, foreign_table)
+    def join_scope(table, foreign_table, foreign_klass)
       constraint = super
-      if at_value = Thread.current[:at_time]
-        constraint = constraint.and(klass.build_temporal_constraint(at_value))
-      end
-      constraint
-    end
-  end
-end
+      at_value = Thread.current[:at_time]
+
+      return constraint unless at_value
 
-case Rails::VERSION::MAJOR
-when 5
-  case Rails::VERSION::MINOR
-  when 2
-    ActiveRecord::Reflection::AbstractReflection.prepend TemporalTables::AbstractReflectionExtensions
+      constraint.where(klass.build_temporal_constraint(at_value))
+    end
   end
 end
 
+prepend_reflection = ActiveRecord.version > ::Gem::Version.new('6.1.0')
+ActiveRecord::Reflection::AbstractReflection.prepend TemporalTables::AbstractReflectionExtensions if prepend_reflection

data/lib/temporal_tables/relation_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TemporalTables
   # Stores the time from the "at" field into each of the resulting objects
   # so that it can be carried forward in subsequent queries.
@@ -9,21 +11,11 @@ module TemporalTables
     end
 
     def at_value
-      case Rails::VERSION::MINOR
-      when 0
-        @values.fetch(:at, nil) || Thread.current[:at_time]
-      else
-        get_value(:at) || Thread.current[:at_time]
-      end
+      @values.fetch(:at, nil) || Thread.current[:at_time]
     end
 
     def at_value=(value)
-      case Rails::VERSION::MINOR
-      when 0
-        @values[:at] = value
-      else
-        set_value(:at, value)
-      end
+      @values[:at] = value
     end
 
     def at(*args)
@@ -32,13 +24,11 @@ module TemporalTables
 
     def at!(value)
       self.at_value = value
-      self.where!(klass.build_temporal_constraint(value))
+      where!(klass.build_temporal_constraint(value))
     end
 
     def to_sql(*args)
-      threadify_at do
-        super *args
-      end
+      threadify_at { super(*args) }
     end
 
     def threadify_at
@@ -53,9 +43,7 @@ module TemporalTables
     end
 
     def limited_ids_for(*args)
-      threadify_at do
-        super *args
-      end
+      threadify_at { super(*args) }
     end
 
     def exec_queries
@@ -63,17 +51,16 @@ module TemporalTables
       #  MyClass.includes(:associations)
       # happens within this exec_queries call.  That's why we needed to
       # store the at_time in the thread above.
-      threadify_at do
-        super
-      end
+      records = threadify_at { super }
 
       if historical?
         # Store the at value on each record returned
-        @records.each do |r|
+        records.each do |r|
           r.at_value = at_value
         end
       end
-      @records
+      @records = records
+      records
     end
 
     def historical?