temporal_tables 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a2a5e35b72b615ab7c9e690bcaab833583834b3fd440e762cab86ae545fc8fd
-  data.tar.gz: 11429f65bbc062d283f85271811f2dbbe867d1b420906365490c51b783a53f54
+  metadata.gz: 99487832a04f3cf0a4d0936ed7054a084603a9cdc861d173af7321cf01a5f82c
+  data.tar.gz: 75344eb90c649477ff8df2fd49a7fdc6d47a49e8eb5d4b3fbde57334a5986726
 SHA512:
-  metadata.gz: f764f397e1c647a3eeda69b133c230e03ce1df412d05ad2e3a3f5e851b2c86f524d3f692dc875ad0c03eeb433ca041390a91bf8b79065ebce0e9b7a98ad1c1ff
-  data.tar.gz: cd93d55c4f1dd33b05f78a5a67fe30003c6dc16cfbb3f139c4ec7514544ab96846ed32edf128360c2077ce745c0c0238e3229c37a7bb4e5a795aed1770a644d8
+  metadata.gz: 0b7701e46c1188110f8cb6d4b8bedf311d6eea112a5304cfbddc7caef4e7b40c340a6a935b8dc111c531b9d4ad78fe98737d0db05562f4f067ab93c19a8ca8a6
+  data.tar.gz: c6403266a1982acc8e23ce6e529b5825cb5f01f0bb29602ec8d5faacf4f3ccc72d89f9bb734a2de7f08b6f386aa1c0c225b6b8f9b32d1671536717ae5cd7d71c

data/.travis.yml

@@ -2,12 +2,10 @@ rvm:
   - 2.5.4
 
 gemfile:
-  - gemfiles/Gemfile.5.0.pg
   - gemfiles/Gemfile.5.1.pg
   - gemfiles/Gemfile.5.2.pg
   - gemfiles/Gemfile.6.0.pg
 
-  - gemfiles/Gemfile.5.0.mysql
   - gemfiles/Gemfile.5.1.mysql
   - gemfiles/Gemfile.5.2.mysql
   - gemfiles/Gemfile.6.0.mysql

data/README.md

@@ -2,7 +2,7 @@
 
 Easily recall what your data looked like at any point in the past!  TemporalTables sets up and maintains history tables to track all temporal changes to to your data.
 
-Currently tested on Ruby 2.5.4, Rails 5.0 - 6.0, Postgres 11.3, MySQL 8.0.13
+Currently tested on Ruby 2.5.4, Rails 5.1 - 6.1, Postgres 11.3, MySQL 8.0.13
 
 ## Installation
 

data/gemfiles/Gemfile.5.1.mysql.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (0.7.0)
+    temporal_tables (0.8.0)
       rails (>= 5.0, < 6.1)
 
 GEM

data/gemfiles/Gemfile.5.1.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (0.7.0)
+    temporal_tables (0.8.0)
       rails (>= 5.0, < 6.1)
 
 GEM

data/gemfiles/Gemfile.5.2.mysql.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (0.7.0)
+    temporal_tables (0.8.0)
       rails (>= 5.0, < 6.1)
 
 GEM

data/gemfiles/Gemfile.5.2.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (0.7.0)
+    temporal_tables (0.8.0)
       rails (>= 5.0, < 6.1)
 
 GEM

data/gemfiles/Gemfile.6.0.mysql.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (0.7.0)
+    temporal_tables (0.8.0)
       rails (>= 5.0, < 6.1)
 
 GEM

data/gemfiles/Gemfile.6.0.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    temporal_tables (0.7.0)
+    temporal_tables (0.8.0)
       rails (>= 5.0, < 6.1)
 
 GEM

data/lib/temporal_tables/temporal_adapter.rb

@@ -26,14 +26,16 @@ module TemporalTables
     end
 
     def add_temporal_table(table_name, options = {})
+      id = id_column(table_name)
+
       create_table temporal_name(table_name), options.merge(id: false, primary_key: "history_id", temporal_bypass: true) do |t|
-        t.integer   :id
-        t.datetime :eff_from, :null => false, limit: 6
-        t.datetime :eff_to,   :null => false, limit: 6, :default => "9999-12-31"
+        t.column   :id, id.type
+        t.datetime :eff_from, null: false, limit: 6
+        t.datetime :eff_to,   null: false, limit: 6, default: "9999-12-31"
 
         for c in columns(table_name)
           next if c.name == "id"
-          t.send c.type, c.name, :limit => c.limit
+          t.send c.type, c.name, limit: c.limit
         end
       end
 
@@ -184,5 +186,9 @@ module TemporalTables
         raise "Rails version not supported"
       end
     end
+
+    def id_column(table_name)
+      columns(table_name).detect { |c| c.name == "id" }
+    end
   end
 end

data/lib/temporal_tables/version.rb

@@ -1,3 +1,3 @@
 module TemporalTables
-  VERSION = "0.7.1"
+  VERSION = "0.8.0"
 end

data/spec/basic_history_spec.rb

@@ -139,4 +139,25 @@ describe Person do
       end
     end
   end
+
+  # The following only tests non-integer ids for postgres (see schema.rb)
+  describe "when spawning and aging a creature with a non-integer id" do
+    let!(:cat) { Cat.create name: "Mr. Mittens", color: "black" }
+
+    before do
+      cat.lives.create started_at: 3.years.ago
+      @init_time = Time.now
+      cat.update name: "Old Mr. Mittens"
+      cat.lives.first.update ended_at: Time.now, death_reason: "fell into cauldron"
+      cat.lives.create started_at: Time.now
+    end
+
+    it "shows one life at the beginning" do
+      expect(cat.history.at(@init_time).last.lives.size).to eq(1)
+    end
+
+    it "shows two lives at the end" do
+      expect(cat.history.last.lives.size).to eq(2)
+    end
+  end
 end

data/spec/internal/app/models/cat.rb

@@ -0,0 +1,3 @@
+class Cat < ActiveRecord::Base
+  has_many :lives, class_name: "CatLife"
+end

data/spec/internal/app/models/cat_life.rb

@@ -0,0 +1,3 @@
+class CatLife < ActiveRecord::Base
+  belongs_to :cat
+end

data/spec/internal/db/schema.rb

@@ -1,4 +1,10 @@
+postgres = ActiveRecord::Base.connection.class.name == "ActiveRecord::ConnectionAdapters::PostgreSQLAdapter"
+
 ActiveRecord::Schema.define do
+  if postgres
+    enable_extension "pgcrypto"
+  end
+
   create_table :people, temporal: true, force: true do |t|
     t.belongs_to :coven
     t.string :name
@@ -19,4 +25,16 @@ ActiveRecord::Schema.define do
     t.string :type
     t.string :model
   end
+
+  create_table :cats, id: (postgres ? :uuid : :integer), temporal: true, force: true do |t|
+    t.string :name
+    t.string :color
+  end
+
+  create_table :cat_lives, id: (postgres ? :uuid : :integer), temporal: true do |t|
+    t.belongs_to :cat, type: (postgres ? :uuid : :integer)
+    t.timestamp :started_at
+    t.timestamp :ended_at
+    t.string :death_reason
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: temporal_tables
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Brent Kroeker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-19 00:00:00.000000000 Z
+date: 2020-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -90,10 +90,6 @@ files:
 - README.md
 - Rakefile
 - config.ru
-- gemfiles/Gemfile.5.0.mysql
-- gemfiles/Gemfile.5.0.mysql.lock
-- gemfiles/Gemfile.5.0.pg
-- gemfiles/Gemfile.5.0.pg.lock
 - gemfiles/Gemfile.5.1.mysql
 - gemfiles/Gemfile.5.1.mysql.lock
 - gemfiles/Gemfile.5.1.pg
@@ -125,6 +121,8 @@ files:
 - spec/basic_history_spec.rb
 - spec/extensions/combustion.rb
 - spec/internal/app/models/broom.rb
+- spec/internal/app/models/cat.rb
+- spec/internal/app/models/cat_life.rb
 - spec/internal/app/models/coven.rb
 - spec/internal/app/models/flying_machine.rb
 - spec/internal/app/models/person.rb
@@ -164,6 +162,8 @@ test_files:
 - spec/basic_history_spec.rb
 - spec/extensions/combustion.rb
 - spec/internal/app/models/broom.rb
+- spec/internal/app/models/cat.rb
+- spec/internal/app/models/cat_life.rb
 - spec/internal/app/models/coven.rb
 - spec/internal/app/models/flying_machine.rb
 - spec/internal/app/models/person.rb

data/gemfiles/Gemfile.5.0.mysql

@@ -1,16 +0,0 @@
-source 'https://rubygems.org'
-
-# Runtime dependencies
-gem 'rails', '~> 5.0.0'
-gem 'mysql2', '~> 0.4.4'
-
-# Development dependencies
-gem 'rspec', '~> 3.4'
-gem 'rake'
-gem 'byebug'
-gem 'database_cleaner'
-gem 'combustion'
-gem 'gemika'
-
-# Gem under test
-gem 'temporal_tables', :path => '..'

data/gemfiles/Gemfile.5.0.mysql.lock

@@ -1,147 +0,0 @@
-PATH
-  remote: ..
-  specs:
-    temporal_tables (0.7.0)
-      rails (>= 5.0, < 6.1)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actioncable (5.0.7.1)
-      actionpack (= 5.0.7.1)
-      nio4r (>= 1.2, < 3.0)
-      websocket-driver (~> 0.6.1)
-    actionmailer (5.0.7.1)
-      actionpack (= 5.0.7.1)
-      actionview (= 5.0.7.1)
-      activejob (= 5.0.7.1)
-      mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 2.0)
-    actionpack (5.0.7.1)
-      actionview (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      rack (~> 2.0)
-      rack-test (~> 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.7.1)
-      activesupport (= 5.0.7.1)
-      builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activejob (5.0.7.1)
-      activesupport (= 5.0.7.1)
-      globalid (>= 0.3.6)
-    activemodel (5.0.7.1)
-      activesupport (= 5.0.7.1)
-    activerecord (5.0.7.1)
-      activemodel (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      arel (~> 7.0)
-    activesupport (5.0.7.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    arel (7.1.4)
-    builder (3.2.3)
-    byebug (10.0.2)
-    combustion (1.0.0)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
-      thor (>= 0.14.6)
-    concurrent-ruby (1.1.4)
-    crass (1.0.4)
-    database_cleaner (1.7.0)
-    diff-lcs (1.3)
-    erubis (2.7.0)
-    gemika (0.3.4)
-    globalid (0.4.1)
-      activesupport (>= 4.2.0)
-    i18n (1.5.1)
-      concurrent-ruby (~> 1.0)
-    loofah (2.2.3)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    mail (2.7.1)
-      mini_mime (>= 0.1.1)
-    method_source (0.9.2)
-    mini_mime (1.0.1)
-    mini_portile2 (2.4.0)
-    minitest (5.11.3)
-    mysql2 (0.4.10)
-    nio4r (2.3.1)
-    nokogiri (1.10.0)
-      mini_portile2 (~> 2.4.0)
-    rack (2.0.6)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails (5.0.7.1)
-      actioncable (= 5.0.7.1)
-      actionmailer (= 5.0.7.1)
-      actionpack (= 5.0.7.1)
-      actionview (= 5.0.7.1)
-      activejob (= 5.0.7.1)
-      activemodel (= 5.0.7.1)
-      activerecord (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      bundler (>= 1.3.0)
-      railties (= 5.0.7.1)
-      sprockets-rails (>= 2.0.0)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.0.4)
-      loofah (~> 2.2, >= 2.2.2)
-    railties (5.0.7.1)
-      actionpack (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
-    rake (12.3.2)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
-    sprockets (3.7.2)
-      concurrent-ruby (~> 1.0)
-      rack (> 1, < 3)
-    sprockets-rails (3.2.1)
-      actionpack (>= 4.0)
-      activesupport (>= 4.0)
-      sprockets (>= 3.0.0)
-    thor (0.20.3)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
-    websocket-driver (0.6.5)
-      websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  byebug
-  combustion
-  database_cleaner
-  gemika
-  mysql2 (~> 0.4.4)
-  rails (~> 5.0.0)
-  rake
-  rspec (~> 3.4)
-  temporal_tables!
-
-BUNDLED WITH
-   1.17.3

data/gemfiles/Gemfile.5.0.pg

@@ -1,16 +0,0 @@
-source 'https://rubygems.org'
-
-# Runtime dependencies
-gem 'rails', '~> 5.0.0'
-gem 'pg', '>= 0.18', '< 2.0'
-
-# Development dependencies
-gem 'rspec', '~> 3.4'
-gem 'rake'
-gem 'byebug'
-gem 'database_cleaner'
-gem 'combustion'
-gem 'gemika'
-
-# Gem under test
-gem 'temporal_tables', :path => '..'

data/gemfiles/Gemfile.5.0.pg.lock

@@ -1,147 +0,0 @@
-PATH
-  remote: ..
-  specs:
-    temporal_tables (0.7.0)
-      rails (>= 5.0, < 6.1)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actioncable (5.0.7.1)
-      actionpack (= 5.0.7.1)
-      nio4r (>= 1.2, < 3.0)
-      websocket-driver (~> 0.6.1)
-    actionmailer (5.0.7.1)
-      actionpack (= 5.0.7.1)
-      actionview (= 5.0.7.1)
-      activejob (= 5.0.7.1)
-      mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 2.0)
-    actionpack (5.0.7.1)
-      actionview (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      rack (~> 2.0)
-      rack-test (~> 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.7.1)
-      activesupport (= 5.0.7.1)
-      builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activejob (5.0.7.1)
-      activesupport (= 5.0.7.1)
-      globalid (>= 0.3.6)
-    activemodel (5.0.7.1)
-      activesupport (= 5.0.7.1)
-    activerecord (5.0.7.1)
-      activemodel (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      arel (~> 7.0)
-    activesupport (5.0.7.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    arel (7.1.4)
-    builder (3.2.3)
-    byebug (10.0.2)
-    combustion (1.0.0)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
-      thor (>= 0.14.6)
-    concurrent-ruby (1.1.4)
-    crass (1.0.4)
-    database_cleaner (1.7.0)
-    diff-lcs (1.3)
-    erubis (2.7.0)
-    gemika (0.3.4)
-    globalid (0.4.1)
-      activesupport (>= 4.2.0)
-    i18n (1.5.1)
-      concurrent-ruby (~> 1.0)
-    loofah (2.2.3)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    mail (2.7.1)
-      mini_mime (>= 0.1.1)
-    method_source (0.9.2)
-    mini_mime (1.0.1)
-    mini_portile2 (2.4.0)
-    minitest (5.11.3)
-    nio4r (2.3.1)
-    nokogiri (1.10.0)
-      mini_portile2 (~> 2.4.0)
-    pg (1.1.3)
-    rack (2.0.6)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails (5.0.7.1)
-      actioncable (= 5.0.7.1)
-      actionmailer (= 5.0.7.1)
-      actionpack (= 5.0.7.1)
-      actionview (= 5.0.7.1)
-      activejob (= 5.0.7.1)
-      activemodel (= 5.0.7.1)
-      activerecord (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      bundler (>= 1.3.0)
-      railties (= 5.0.7.1)
-      sprockets-rails (>= 2.0.0)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.0.4)
-      loofah (~> 2.2, >= 2.2.2)
-    railties (5.0.7.1)
-      actionpack (= 5.0.7.1)
-      activesupport (= 5.0.7.1)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
-    rake (12.3.2)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
-    sprockets (3.7.2)
-      concurrent-ruby (~> 1.0)
-      rack (> 1, < 3)
-    sprockets-rails (3.2.1)
-      actionpack (>= 4.0)
-      activesupport (>= 4.0)
-      sprockets (>= 3.0.0)
-    thor (0.20.3)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
-    websocket-driver (0.6.5)
-      websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  byebug
-  combustion
-  database_cleaner
-  gemika
-  pg (>= 0.18, < 2.0)
-  rails (~> 5.0.0)
-  rake
-  rspec (~> 3.4)
-  temporal_tables!
-
-BUNDLED WITH
-   1.17.3