temporal_tables 0.6.10 → 0.7.0

data/lib/temporal_tables.rb

@@ -9,58 +9,59 @@ require "temporal_tables/association_extensions"
 require "temporal_tables/join_extensions"
 require "temporal_tables/preloader_extensions"
 require "temporal_tables/reflection_extensions"
+require "temporal_tables/arel_table"
 require "temporal_tables/version"
 
 module TemporalTables
-	class Railtie < ::Rails::Railtie
-		initializer "temporal_tables.load" do
-			# Iterating the subclasses will find any adapter implementations
-			# which are in use by the rails app, and mixin the temporal functionality.
-			# It's necessary to do this on the implementations in order for the
-			# alias method chain hooks to work.
-			ActiveRecord::ConnectionAdapters::AbstractAdapter.subclasses.each do |subclass|
-				subclass.send :prepend, TemporalTables::TemporalAdapter
+  class Railtie < ::Rails::Railtie
+    initializer "temporal_tables.load" do
+      # Iterating the subclasses will find any adapter implementations
+      # which are in use by the rails app, and mixin the temporal functionality.
+      # It's necessary to do this on the implementations in order for the
+      # alias method chain hooks to work.
+      ActiveRecord::ConnectionAdapters::AbstractAdapter.subclasses.each do |subclass|
+        subclass.send :prepend, TemporalTables::TemporalAdapter
 
-				module_name = subclass.name.split("::").last
-				subclass.send :prepend, TemporalTables::ConnectionAdapters.const_get(module_name) if TemporalTables::ConnectionAdapters.const_defined?(module_name)
-			end
+        module_name = subclass.name.split("::").last
+        subclass.send :prepend, TemporalTables::ConnectionAdapters.const_get(module_name) if TemporalTables::ConnectionAdapters.const_defined?(module_name)
+      end
 
-			ActiveRecord::Base.send :include, TemporalTables::Whodunnit
-		end
-	end
+      ActiveRecord::Base.send :include, TemporalTables::Whodunnit
+    end
+  end
 
-	@@create_by_default = false
-	def self.create_by_default
-		@@create_by_default
-	end
-	def self.create_by_default=(default)
-		@@create_by_default = default
-	end
+  @@create_by_default = false
+  def self.create_by_default
+    @@create_by_default
+  end
+  def self.create_by_default=(default)
+    @@create_by_default = default
+  end
 
-	@@skipped_temporal_tables = [:schema_migrations, :sessions, :ar_internal_metadata]
-	def self.skip_temporal_table_for(*tables)
-		@@skipped_temporal_tables += tables
-	end
-	def self.skipped_temporal_tables
-		@@skipped_temporal_tables.dup
-	end
+  @@skipped_temporal_tables = [:schema_migrations, :sessions, :ar_internal_metadata]
+  def self.skip_temporal_table_for(*tables)
+    @@skipped_temporal_tables += tables
+  end
+  def self.skipped_temporal_tables
+    @@skipped_temporal_tables.dup
+  end
 
-	@@add_updated_by_field = false
-	@@updated_by_type = :string
-	@@updated_by_proc = nil
-	def self.updated_by_type
-		@@updated_by_type
-	end
-	def self.updated_by_proc
-		@@updated_by_proc
-	end
-	def self.add_updated_by_field(type = :string, &block)
-		if block_given?
-			@@add_updated_by_field = true
-			@@updated_by_type = type
-			@@updated_by_proc = block
-		end
+  @@add_updated_by_field = false
+  @@updated_by_type = :string
+  @@updated_by_proc = nil
+  def self.updated_by_type
+    @@updated_by_type
+  end
+  def self.updated_by_proc
+    @@updated_by_proc
+  end
+  def self.add_updated_by_field(type = :string, &block)
+    if block_given?
+      @@add_updated_by_field = true
+      @@updated_by_type = type
+      @@updated_by_proc = block
+    end
 
-		@@add_updated_by_field
-	end
+    @@add_updated_by_field
+  end
 end

data/spec/basic_history_spec.rb

@@ -1,142 +1,142 @@
 require 'spec_helper'
 
 describe Person do
-	let(:emily) { Person.create name: "Emily" }
-	let(:historical_emily) { emily.history.last }
-
-	before do
-		emily
-		@init_time = Time.now
-		sleep 0.1
-	end
-
-	describe "upon making significant life changes" do
-		let!(:coven) { Coven.create name: "Double Double Toil & Trouble" }
-		let!(:wart) { Wart.create person: emily, hairiness: 3 }
-
-		before do
-			emily.update_attributes name: "Grunthilda", coven: coven
-			sleep 0.1
-		end
-
-		describe "when affirming changes" do
-			it "should have new name" do
-				expect(emily.name).to eq("Grunthilda")
-				expect(historical_emily.name).to eq("Grunthilda")
-			end
-
-			it "should belong to coven" do
-				expect(emily.coven.name).to eq(coven.name)
-				expect(historical_emily.coven.name).to eq(coven.name)
-			end
-
-			it "should have a wart" do
-				expect(emily.warts).to eq([wart])
-				expect(emily.history.at(Time.now).last.warts).to eq([wart.history.last])
-			end
-
-			it "should allow scopes on associations" do
-				expect(emily.warts.very_hairy).to eq([wart])
-				expect(historical_emily.warts.very_hairy).to eq([wart.history.last])
-			end
-
-			it "should allow at value on class too" do
-				expect(Wart.history.at(Time.now).where(person: emily).count).to eq(1)
-				expect(Wart.history.at(1.minute.ago).where(person: emily).count).to eq(0)
-			end
-		end
-
-		describe "when reflecting on the past" do
-			let(:orig_emily) { emily.history.at(@init_time).last }
-
-			it "should have historical name" do
-				expect(orig_emily.name).to eq("Emily")
-				expect(orig_emily.at_value).to eq(@init_time)
-			end
-
-			it "should not belong to a coven or have warts" do
-				expect(orig_emily.coven).to eq(nil)
-				expect(orig_emily.warts.count).to eq(0)
-			end
-		end
-
-		describe "when preloading associations" do
-			let(:orig_emily) { emily.history.at(@init_time).preload(:warts).first }
-
-			it 'should preload the correct time' do
-				expect(orig_emily.warts).to be_empty
-			end
-		end
-
-		describe "when eager_loading associations" do
-			let(:orig_emily) { emily.history.at(@init_time).eager_load(:warts).first }
-
-			it 'should include the correct time' do
-				expect(orig_emily.warts).to be_empty
-			end
-
-			it 'should generate sensible sql' do
-				sql = emily.history.at(@init_time).eager_load(:warts).where(Wart.history.arel_table[:hairiness].gteq(2)).to_sql.split(/(FROM)|(WHERE)|(ORDER)/)
-				from = sql[2]
-				where = sql[4]
-
-				expect(from.scan(/.warts_h.\..eff_from./i).count).to eq(1)
-				expect(from.scan(/.warts_h.\..eff_to./i).count).to eq(1)
-
-				expect(where.scan(/.people_h.\..eff_from./i).count).to eq(1)
-				expect(where.scan(/.people_h.\..eff_to./i).count).to eq(1)
-				expect(where.scan(/.warts_h.\..eff_from./i).count).to eq(0)
-				expect(where.scan(/.warts_h.\..eff_to./i).count).to eq(0)
-			end
-		end
-
-		describe "when checking simple code values" do
-			it "should have correct class names" do
-				expect(emily.class.name).to eq("Person")
-				expect(historical_emily.class.name).to eq("PersonHistory")
-
-				expect(Person.history).to eq(PersonHistory)
-			end
-
-			it "should have correct class hierarchies" do
-				expect(emily.is_a?(Person)).to eq(true)
-				expect(emily.is_a?(PersonHistory)).to eq(false)
-
-				expect(historical_emily.is_a?(Person)).to eq(true)
-				expect(historical_emily.is_a?(PersonHistory)).to eq(true)
-			end
-		end
-
-		describe "when checking current state" do
-			it "should have correct information" do
-				# ie. we shouldn't break regular ActiveRecord behaviour
-				expect(Person.count).to eq(1)
-				expect(Wart.count).to eq(1)
-
-				emily = Person.first
-				expect(emily.warts.count).to eq(1)
-				expect(emily.warts.first.hairiness).to eq(3)
-
-				emily = Person.where(id: emily.id).eager_load(:warts).first
-				expect(emily.warts.count).to eq(1)
-				expect(emily.warts.first.hairiness).to eq(3)
-			end
-		end
-
-		describe "when working with STI one level deep" do
-			let!(:broom) { Broom.create person: emily, model: "Cackler 2000" }
-
-			it "should initialize model correctly" do
-				expect(emily.history.last.flying_machines).to eq([broom.history.last])
-			end
-		end
-
-		describe "when working with STI two levels deep" do
-			let!(:rocket_broom) { RocketBroom.create person: emily, model: "Pyrocackler 3000X" }
-
-			it "should initialize model correctly" do
-				expect(emily.history.last.flying_machines).to eq([rocket_broom.history.last])
-			end
-		end
-	end
+  let(:emily) { Person.create name: "Emily" }
+  let(:historical_emily) { emily.history.last }
+
+  before do
+    emily
+    @init_time = Time.now
+    sleep 0.1
+  end
+
+  describe "upon making significant life changes" do
+    let!(:coven) { Coven.create name: "Double Double Toil & Trouble" }
+    let!(:wart) { Wart.create person: emily, hairiness: 3 }
+
+    before do
+      emily.update name: "Grunthilda", coven: coven
+      sleep 0.1
+    end
+
+    describe "when affirming changes" do
+      it "should have new name" do
+        expect(emily.name).to eq("Grunthilda")
+        expect(historical_emily.name).to eq("Grunthilda")
+      end
+
+      it "should belong to coven" do
+        expect(emily.coven.name).to eq(coven.name)
+        expect(historical_emily.coven.name).to eq(coven.name)
+      end
+
+      it "should have a wart" do
+        expect(emily.warts).to eq([wart])
+        expect(emily.history.at(Time.now).last.warts).to eq([wart.history.last])
+      end
+
+      it "should allow scopes on associations" do
+        expect(emily.warts.very_hairy).to eq([wart])
+        expect(historical_emily.warts.very_hairy).to eq([wart.history.last])
+      end
+
+      it "should allow at value on class too" do
+        expect(Wart.history.at(Time.now).where(person: emily).count).to eq(1)
+        expect(Wart.history.at(1.minute.ago).where(person: emily).count).to eq(0)
+      end
+    end
+
+    describe "when reflecting on the past" do
+      let(:orig_emily) { emily.history.at(@init_time).last }
+
+      it "should have historical name" do
+        expect(orig_emily.name).to eq("Emily")
+        expect(orig_emily.at_value).to eq(@init_time)
+      end
+
+      it "should not belong to a coven or have warts" do
+        expect(orig_emily.coven).to eq(nil)
+        expect(orig_emily.warts.count).to eq(0)
+      end
+    end
+
+    describe "when preloading associations" do
+      let(:orig_emily) { emily.history.at(@init_time).preload(:warts).first }
+
+      it 'should preload the correct time' do
+        expect(orig_emily.warts).to be_empty
+      end
+    end
+
+    describe "when eager_loading associations" do
+      let(:orig_emily) { emily.history.at(@init_time).eager_load(:warts).first }
+
+      it 'should include the correct time' do
+        expect(orig_emily.warts).to be_empty
+      end
+
+      it 'should generate sensible sql' do
+        sql = emily.history.at(@init_time).eager_load(:warts).where(Wart.history.arel_table[:hairiness].gteq(2)).to_sql.split(/(FROM)|(WHERE)|(ORDER)/)
+        from = sql[2]
+        where = sql[4]
+
+        expect(from.scan(/.warts_h.\..eff_from./i).count).to eq(1)
+        expect(from.scan(/.warts_h.\..eff_to./i).count).to eq(1)
+
+        expect(where.scan(/.people_h.\..eff_from./i).count).to eq(1)
+        expect(where.scan(/.people_h.\..eff_to./i).count).to eq(1)
+        expect(where.scan(/.warts_h.\..eff_from./i).count).to eq(0)
+        expect(where.scan(/.warts_h.\..eff_to./i).count).to eq(0)
+      end
+    end
+
+    describe "when checking simple code values" do
+      it "should have correct class names" do
+        expect(emily.class.name).to eq("Person")
+        expect(historical_emily.class.name).to eq("PersonHistory")
+
+        expect(Person.history).to eq(PersonHistory)
+      end
+
+      it "should have correct class hierarchies" do
+        expect(emily.is_a?(Person)).to eq(true)
+        expect(emily.is_a?(PersonHistory)).to eq(false)
+
+        expect(historical_emily.is_a?(Person)).to eq(true)
+        expect(historical_emily.is_a?(PersonHistory)).to eq(true)
+      end
+    end
+
+    describe "when checking current state" do
+      it "should have correct information" do
+        # ie. we shouldn't break regular ActiveRecord behaviour
+        expect(Person.count).to eq(1)
+        expect(Wart.count).to eq(1)
+
+        emily = Person.first
+        expect(emily.warts.count).to eq(1)
+        expect(emily.warts.first.hairiness).to eq(3)
+
+        emily = Person.where(id: emily.id).eager_load(:warts).first
+        expect(emily.warts.count).to eq(1)
+        expect(emily.warts.first.hairiness).to eq(3)
+      end
+    end
+
+    describe "when working with STI one level deep" do
+      let!(:broom) { Broom.create person: emily, model: "Cackler 2000" }
+
+      it "should initialize model correctly" do
+        expect(emily.history.last.flying_machines).to eq([broom.history.last])
+      end
+    end
+
+    describe "when working with STI two levels deep" do
+      let!(:rocket_broom) { RocketBroom.create person: emily, model: "Pyrocackler 3000X" }
+
+      it "should initialize model correctly" do
+        expect(emily.history.last.flying_machines).to eq([rocket_broom.history.last])
+      end
+    end
+  end
 end

data/spec/internal/app/models/flying_machine.rb

@@ -1,3 +1,3 @@
 class FlyingMachine < ActiveRecord::Base
-	belongs_to :person
+  belongs_to :person
 end

data/spec/internal/app/models/person.rb

@@ -1,5 +1,5 @@
 class Person < ActiveRecord::Base
-	belongs_to :coven
-	has_many :warts
-	has_many :flying_machines
+  belongs_to :coven
+  has_many :warts
+  has_many :flying_machines
 end

data/spec/internal/db/schema.rb

@@ -1,22 +1,22 @@
 ActiveRecord::Schema.define do
-	create_table :people, temporal: true, force: true do |t|
-		t.belongs_to :coven
-		t.string :name
-	end
+  create_table :people, temporal: true, force: true do |t|
+    t.belongs_to :coven
+    t.string :name
+  end
 
-	create_table :covens, force: true do |t|
-		t.string :name
-	end
-	add_temporal_table :covens
+  create_table :covens, force: true do |t|
+    t.string :name
+  end
+  add_temporal_table :covens
 
-	create_table :warts, temporal: true, force: true do |t|
-		t.belongs_to :person
-		t.integer :hairiness
-	end
+  create_table :warts, temporal: true, force: true do |t|
+    t.belongs_to :person
+    t.integer :hairiness
+  end
 
-	create_table :flying_machines, temporal: true, force: true do |t|
-		t.belongs_to :person
-		t.string :type
-		t.string :model
-	end
+  create_table :flying_machines, temporal: true, force: true do |t|
+    t.belongs_to :person
+    t.string :type
+    t.string :model
+  end
 end

data/spec/spec_helper.rb

@@ -5,13 +5,13 @@ Dir["#{File.dirname(__FILE__)}/extensions/*.rb"].sort.each {|f| require f}
 Dir["#{File.dirname(__FILE__)}/support/*.rb"].sort.each {|f| require f}
 
 Combustion.initialize! :active_record do
-	Rails.env = TemporalTables::DatabaseAdapter.adapter_name
+  Rails.env = TemporalTables::DatabaseAdapter.adapter_name
 end
 
 DatabaseCleaner.strategy = :deletion
 
 RSpec.configure do |config|
-	config.before(:each) do
-		DatabaseCleaner.clean
-	end
+  config.before(:each) do
+    DatabaseCleaner.clean
+  end
 end

data/spec/support/database.rb

@@ -1,9 +1,9 @@
 module TemporalTables::DatabaseAdapter
-	def self.adapter_name
-		if Gemika::Env.gem?('pg')
-			"postgresql"
-		elsif Gemika::Env.gem?('mysql2')
-			"mysql"
-		end
-	end
+  def self.adapter_name
+    if Gemika::Env.gem?('pg')
+      "postgresql"
+    elsif Gemika::Env.gem?('mysql2')
+      "mysql"
+    end
+  end
 end

data/temporal_tables.gemspec

@@ -4,21 +4,21 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'temporal_tables/version'
 
 Gem::Specification.new do |gem|
-	gem.name          = "temporal_tables"
-	gem.version       = TemporalTables::VERSION
-	gem.authors       = ["Brent Kroeker"]
-	gem.email         = ["brent@bkroeker.com"]
-	gem.description   = %q{Easily recall what your data looked like at any point in the past!  TemporalTables sets up and maintains history tables to track all temporal changes to to your data.}
-	gem.summary       = %q{Tracks all history of changes to a table automatically in a history table.}
-	gem.homepage      = ""
+  gem.name          = "temporal_tables"
+  gem.version       = TemporalTables::VERSION
+  gem.authors       = ["Brent Kroeker"]
+  gem.email         = ["brent@bkroeker.com"]
+  gem.description   = %q{Easily recall what your data looked like at any point in the past!  TemporalTables sets up and maintains history tables to track all temporal changes to to your data.}
+  gem.summary       = %q{Tracks all history of changes to a table automatically in a history table.}
+  gem.homepage      = ""
 
-	gem.files         = `git ls-files`.split($/)
-	gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-	gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-	gem.require_paths = ["lib"]
+  gem.files         = `git ls-files`.split($/)
+  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
+  gem.require_paths = ["lib"]
 
-	gem.add_dependency "rails", "~> 5.0"
-	gem.add_development_dependency "rspec", "~> 3.4"
-	gem.add_development_dependency "combustion", "~> 0.9.1"
-	gem.add_development_dependency "gemika"
+  gem.add_dependency "rails", ">= 5.0", "<= 6.0"
+  gem.add_development_dependency "rspec", "~> 3.4"
+  gem.add_development_dependency "combustion", "~> 0.9.1"
+  gem.add_development_dependency "gemika"
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: temporal_tables
 version: !ruby/object:Gem::Version
-  version: 0.6.10
+  version: 0.7.0
 platform: ruby
 authors:
 - Brent Kroeker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-15 00:00:00.000000000 Z
+date: 2019-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -96,7 +102,12 @@ files:
 - gemfiles/Gemfile.5.2.mysql.lock
 - gemfiles/Gemfile.5.2.pg
 - gemfiles/Gemfile.5.2.pg.lock
+- gemfiles/Gemfile.6.0.mysql
+- gemfiles/Gemfile.6.0.mysql.lock
+- gemfiles/Gemfile.6.0.pg
+- gemfiles/Gemfile.6.0.pg.lock
 - lib/temporal_tables.rb
+- lib/temporal_tables/arel_table.rb
 - lib/temporal_tables/association_extensions.rb
 - lib/temporal_tables/connection_adapters/mysql_adapter.rb
 - lib/temporal_tables/connection_adapters/postgresql_adapter.rb
@@ -143,8 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Tracks all history of changes to a table automatically in a history table.