temescal 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 668a0e9c9bb3d5400a4b9b28302607767828bc0c
-  data.tar.gz: 1f1a62d3e48d5db8cd32b853a06ea116be8a3b69
+  metadata.gz: 2d87fe04c5479ea7fc4081a5c20c1e00ecab56f7
+  data.tar.gz: 311bdc3696f87f883d63b77924f05a1d9c448518
 SHA512:
-  metadata.gz: 614f71816ca80c27852abe47a8aef37702fc8eced6143613ed25735dd1bc3bc051a7e9d4f4dd1eefb1709aedc6537191354abaab13a837cc57bbc70469f91564
-  data.tar.gz: 1bf5f51abe2f31d8e2cd7b8595f97c4d6a86083f99d34f1d800e7e96495de41bae2017b62ec1bb6b7f1ced4a8ccf4fd04062b7c7ea7edde87484a2fd3c0799e9
+  metadata.gz: f478224b88e7cd8ca0bd5ecf9119c5593856c3c355a808953a0837ddd5f978c7a0e7529ec491306913e9365063095f2d3554f116c3cb3c099af31817606c7437
+  data.tar.gz: f713acaf1042b6864275125bfcdd01c2bb448a33119248b8ff9e548d978a5ce92f6e9e2a3bdc862b7b7e6f71c4ee81f0e3cb913dc4a97bac5e95c6820ca71475

data/README.md

@@ -1,7 +1,7 @@
 temescal
 ========
 
-[![Build Status](https://travis-ci.org/todd/temescal.png?branch=master)](https://travis-ci.org/todd/temescal) [![Coverage Status](https://coveralls.io/repos/todd/temescal/badge.png?branch=master)](https://coveralls.io/r/todd/temescal?branch=master) [![Code Climate](https://codeclimate.com/github/todd/temescal.png)](https://codeclimate.com/github/todd/temescal) [![Dependency Status](https://gemnasium.com/todd/temescal.png)](https://gemnasium.com/todd/temescal)
+[![Gem Version](https://badge.fury.io/rb/temescal.png)](http://badge.fury.io/rb/temescal) [![Build Status](https://travis-ci.org/todd/temescal.png?branch=master)](https://travis-ci.org/todd/temescal) [![Coverage Status](https://coveralls.io/repos/todd/temescal/badge.png?branch=master)](https://coveralls.io/r/todd/temescal?branch=master) [![Code Climate](https://codeclimate.com/github/todd/temescal.png)](https://codeclimate.com/github/todd/temescal) [![Dependency Status](https://gemnasium.com/todd/temescal.png)](https://gemnasium.com/todd/temescal)
 
 Temescal is Rack middleware that will automatically rescue exceptions for JSON APIs and render a nice, clean JSON response with the error information. No need to write custom error handling logic for your apps - Temescal will take care of it for you!
 ## Getting Started

data/lib/temescal/middleware.rb

@@ -1,5 +1,6 @@
 module Temescal
   class Middleware
+    NOT_FOUND_ERRORS = ["ActiveRecord::RecordNotFound", "Sinatra::NotFound"]
 
     # Public: Initializes the middleware.
     #
@@ -31,7 +32,7 @@ module Temescal
         $stderr.print formatted_error
         configuration.monitors.each { |monitor| monitor.report(@error) }
 
-        @status   = @error.respond_to?(:http_status) ? @error.http_status : 500
+        @status   = set_status
         @response = Response.build(@status, @error, message)
         @headers  = { "Content-Type"   => "application/json" }
       end
@@ -51,5 +52,11 @@ module Temescal
       message << @error.backtrace.join("\n  ")
       message << "\n\n"
     end
+
+    # Private: Returns the proper error code for the exception.
+    def set_status
+      return 404 if NOT_FOUND_ERRORS.include? @error.class.to_s
+      @error.respond_to?(:http_status) ? @error.http_status : 500
+    end
   end
 end

data/lib/temescal/version.rb

@@ -1,3 +1,3 @@
 module Temescal
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/lib/temescal/middleware_spec.rb

@@ -1,5 +1,8 @@
 require "spec_helper"
 
+require "active_record"
+require "sinatra"
+
 describe Temescal::Middleware do
   context "Ok response" do
     let(:app) { ->(env) { [200, env, "app" ] } }
@@ -86,6 +89,28 @@ describe Temescal::Middleware do
         expect(json["message"]).to eq "An error has occured - we'll get on it right away!"
       end
     end
+
+    context "with a Sinatra::NotFound error" do
+      it "should build a response with a 404 status code" do
+        app = ->(env) { raise Sinatra::NotFound.new }
+        middleware = Temescal::Middleware.new(app)
+
+        code, _, _ = middleware.call env_for("http://foobar.com")
+
+        expect(code).to eq 404
+      end
+    end
+
+    context "with an ActiveRecord::RecordNotFound error" do
+      it "should build a response with a 404 status code" do
+        app = ->(env) { raise ActiveRecord::RecordNotFound.new }
+        middleware = Temescal::Middleware.new(app)
+
+        code, _, _ = middleware.call env_for("http://foobar.com")
+
+        expect(code).to eq 404
+      end
+    end
   end
 
   context "Override middleware to raise exception" do

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: temescal
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Todd Bealmear
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-13 00:00:00.000000000 Z
+date: 2014-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Rack Middleware for gracefully handling exceptions for JSON APIs.
@@ -48,17 +48,17 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- temescal.gemspec
+- lib/temescal.rb
 - lib/temescal/configuration.rb
 - lib/temescal/middleware.rb
 - lib/temescal/monitors.rb
 - lib/temescal/response.rb
 - lib/temescal/version.rb
-- lib/temescal.rb
 - spec/lib/temescal/configuration_spec.rb
 - spec/lib/temescal/middleware_spec.rb
 - spec/lib/temescal/monitors_spec.rb
 - spec/spec_helper.rb
+- temescal.gemspec
 homepage: https://github.com/todd/temescal
 licenses:
 - MIT
@@ -69,17 +69,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.10
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Rack Middleware for gracefully handling exceptions for JSON APIs.