telephone 0.1.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2961c1545d60c8daef9cdc90a8ecea01c12ecd14357d446dbfe86cae84cc43c2
-  data.tar.gz: 27dad4361e48e380776fb3c32ea59855f95804e024b1aad879d84ad292f96a23
+  metadata.gz: 45fbcb9aaecf2dc2d66072e93b97b168c2a505f6d4e0cc1ed08cfad4e8267bb2
+  data.tar.gz: 4f3992fbc6840c3d624fadb7de3faa56f3952ba4b4b5eae7cde0b61ecdf343f6
 SHA512:
-  metadata.gz: 70159c4118b77a694873f4cf9f14d28bfbaae52692c28eaa95eafec80b06a91e8fd65dd76db1a849efdd5e7b5a294c5d1836a5b924c6df81eb9b9a636145c14e
-  data.tar.gz: 2bd95f410bc0bc92960c1e6065ecf5b0971dbc6792dff760cebef1494d1cdbc8efd5e87499d53a7eaae1786f8904a4280b570c9d59327995877a17fad20a8773
+  metadata.gz: ef63c3786eb25e545259ed90894ace7a67af3098028ebcdfc9206aa7bd995729dafa3ed5533a8109bd42696255216efb4db84e53fd9160304f8c7c868862dde5
+  data.tar.gz: 3a9419a284e42bde8b0de7bd8517a4dc7986e9f59b8c685a41059c8e5d81660d36c4aea2d3c3bba4610213211d243fceb2007103f2d79ac7f1fadea9be673431

data/README.md

@@ -94,6 +94,48 @@ You can also give a default value for an argument.
 argument :name, default: "Benjamin"
 ```
 
+Defaults can also be callable (procs or lambdas) that are evaluated at runtime. Callable defaults have access to other attributes and are processed in definition order:
+
+```ruby
+class GreetingService < ApplicationService
+  argument :first_name, default: "John"
+  argument :last_name, default: "Doe"
+  argument :full_name, default: -> { "#{first_name} #{last_name}" }
+  argument :created_at, default: -> { Time.current }
+
+  def call
+    "Hello, #{full_name}!"
+  end
+end
+
+GreetingService.call.result #=> "Hello, John Doe!"
+GreetingService.call(first_name: "Jane").result #=> "Hello, Jane Doe!"
+```
+
+Arguments can also be validated against a type. When `type:` is provided, the argument is checked with `is_a?` before the service runs. `nil` is allowed unless the argument is also marked as `required:`.
+
+```ruby
+class UpdateUserService < ApplicationService
+  argument :user, type: User, required: true
+
+  def call
+    user.update!(status: "active")
+  end
+end
+
+s = UpdateUserService.call(user: "not a user")
+s.success? #=> false
+s.errors.full_messages #=> ["User must be a User"]
+s.result #=> nil
+```
+
+Type validation works with any class or module:
+
+```ruby
+argument :tags, type: Array
+argument :metadata, type: Enumerable
+```
+
 ### Validations
 
 Since `Telephone::Service` includes `ActiveModel::Model`, you can define validations in the same way you would for an ActiveRecord model.
@@ -107,13 +149,49 @@ def admin_user?
 end
 ```
 
-If a validation fails, the service object will not execute and return `nil` as the result of th call. You can check the status of the service object by calling `success?`.
+If a validation fails, the service object will not execute and return `nil` as the result of the call. You can check the status of the service object by calling `success?`.
 
 ```ruby
 s = SomeService.call
 s.success? #=> false
 ```
 
+#### Internationalization
+
+Type validation errors are translated through I18n. Telephone ships with translations for:
+
+* `en` — English
+* `es` — Spanish
+* `fr` — French
+* `de` — German
+* `pt` — Portuguese
+* `ja` — Japanese
+* `zh-CN` — Chinese (Simplified)
+* `it` — Italian
+* `nl` — Dutch
+* `ru` — Russian
+* `ko` — Korean
+
+In a Rails app, these are used automatically based on the current locale:
+
+```ruby
+I18n.locale = :es
+
+s = UpdateUserService.call(user: "not a user")
+s.errors.full_messages #=> ["User debe ser un User"]
+```
+
+You can also override the default message in your own locale files:
+
+```yaml
+# config/locales/telephone.en.yml
+en:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "must be an instance of %{type}"
+```
+
 ## Best Practices
 
 Service objects are a great way to keep your code DRY and encapsulate business logic. As a rule of thumb, try to keep your service objects to a single responsibility. If you find yourself dealing with very complex logic, consider breaking it up into smaller services.

data/lib/telephone/locale/de.yml

@@ -0,0 +1,5 @@
+de:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "muss ein %{type} sein"

data/lib/telephone/locale/en.yml

@@ -0,0 +1,5 @@
+en:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "must be a %{type}"

data/lib/telephone/locale/es.yml

@@ -0,0 +1,5 @@
+es:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "debe ser un %{type}"

data/lib/telephone/locale/fr.yml

@@ -0,0 +1,5 @@
+fr:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "doit être un %{type}"

data/lib/telephone/locale/it.yml

@@ -0,0 +1,5 @@
+it:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "deve essere un %{type}"

data/lib/telephone/locale/ja.yml

@@ -0,0 +1,5 @@
+ja:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "%{type}である必要があります"

data/lib/telephone/locale/ko.yml

@@ -0,0 +1,5 @@
+ko:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "%{type}이어야 합니다"

data/lib/telephone/locale/nl.yml

@@ -0,0 +1,5 @@
+nl:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "moet een %{type} zijn"

data/lib/telephone/locale/pt.yml

@@ -0,0 +1,5 @@
+pt:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "deve ser um %{type}"

data/lib/telephone/locale/ru.yml

@@ -0,0 +1,5 @@
+ru:
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "должно быть %{type}"

data/lib/telephone/locale/zh-CN.yml

@@ -0,0 +1,5 @@
+"zh-CN":
+  activemodel:
+    errors:
+      messages:
+        invalid_type: "必须是 %{type}"

data/lib/telephone/service.rb

@@ -16,6 +16,34 @@ module Telephone
     #   Telephone::Service.call(foo: bar).result # "baz"
     attr_accessor :result
 
+    ##
+    # Primary responsibility of initialize is to instantiate the
+    # attributes of the service object with the expected values.
+    def initialize(attributes = {})
+      attributes = attributes.transform_keys(&:to_sym)
+
+      attributes.each do |key, value|
+        send("#{key}=", value)
+      end
+
+      self.class.defaults.each do |key, value|
+        next if attributes.key?(key)
+
+        resolved = if value.is_a?(Proc)
+          instance_exec(&value)
+        elsif value.respond_to?(:call)
+          value.call
+        else
+          value
+        end
+
+        send("#{key}=", resolved)
+      end
+
+      super
+      yield self if block_given?
+    end
+
     ##
     # Determines whether or not the action of the service
     # object was successful.
@@ -28,27 +56,55 @@ module Telephone
       errors.empty?
     end
 
+    def call
+      self.result = __call if valid?
+      self
+    end
+
     class << self
       ##
       # Defines a getter/setter for a service object argument. This also allows you
       # to pass in a default, or set the argument to "required" to add a validation
       # that runs before executing the block.
       #
+      # The default value can be a static value or any callable object (Proc, lambda,
+      # method, or any object that responds to #call) that will be evaluated at
+      # runtime when the service is instantiated.
+      #
+      # Callable defaults are evaluated in the context of the service instance,
+      # so they can access other attributes. They are processed in definition order,
+      # meaning a callable can depend on any argument defined before it.
+      #
+      # To store a Proc as the actual value, wrap it in another lambda:
+      #   argument :my_proc, default: -> { -> { puts "hi" } }
+      #
+      # You can also pass +type:+ to validate that the argument is an instance of
+      # the given class or module. Nil values are allowed unless the argument is
+      # also marked as required.
+      #
       # @example
       #   class SomeService < Telephone::Service
-      #     argument :foo, default: "bar"
-      #     argument :baz, required: true
+      #     argument :first_name, default: "John"
+      #     argument :last_name, default: "Doe"
+      #     argument :full_name, default: -> { "#{first_name} #{last_name}" }
+      #     argument :timestamp, default: -> { DateTime.current }
+      #     argument :user, type: User
       #
       #     def call
-      #       puts foo
-      #       puts baz
+      #       puts full_name
+      #       puts timestamp
       #     end
       #   end
-      def argument(arg, default: nil, required: false)
-        send(:attr_accessor, arg.to_sym)
-        send(:validates, arg.to_sym, presence: true) if required
+      def argument(arg, default: nil, required: false, type: nil)
+        arg = arg.to_sym
+        send(:attr_accessor, arg)
+        send(:validates, arg, presence: true) if required
+
+        if type
+          send(:validates_with, Telephone::TypeValidator, attributes: arg, with: type, allow_nil: true)
+        end
 
-        defaults[arg.to_sym] = default
+        defaults[arg] = default
       end
 
       ##
@@ -65,10 +121,21 @@ module Telephone
       #
       # @example
       #   Telephone::Service.call(foo: bar)
-      def call(**args)
-        instance = new(defaults.merge(args))
-        instance.result = instance.call if instance.valid?
-        instance
+      #   Telephone::Service.call({ foo: bar })
+      def call(*args, **kwargs)
+        new(args.extract_options!.merge(kwargs)).call
+      end
+
+      ##
+      # When the subclass overwrites the #call method, reassign it to #__call.
+      # This allows us to still control what happens in the instance level of #call.
+      def method_added(method_name)
+        if method_name == :call
+          alias_method :__call, :call
+          send(:remove_method, :call)
+        else
+          super
+        end
       end
     end
   end

data/lib/telephone/validators/type_validator.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "active_model"
+
+module Telephone
+  class TypeValidator < ActiveModel::EachValidator
+    def validate_each(record, attribute, value)
+      expected_type = options[:with]
+
+      return if value.is_a?(expected_type)
+
+      record.errors.add(
+        attribute,
+        :invalid_type,
+        **options.except(:with).merge(type: type_name(expected_type))
+      )
+    end
+
+    private
+
+    def type_name(type)
+      type.name || type.to_s
+    end
+  end
+end

data/lib/telephone/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Telephone
-  VERSION = "0.1.0"
+  VERSION = "1.1.0"
 end

data/lib/telephone.rb

@@ -1,3 +1,8 @@
 # frozen_string_literal: true
 
+require "i18n"
+
+I18n.load_path += Dir[File.join(__dir__, "telephone", "locale", "*.yml")]
+
+require "telephone/validators/type_validator"
 require "telephone/service"

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: telephone
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Benjamin Hargett
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-31 00:00:00.000000000 Z
+date: 2026-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -24,6 +23,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Utility class for creating and calling service objects.
 email: hargettbenjamin@gmail.com
 executables: []
@@ -32,7 +45,19 @@ extra_rdoc_files: []
 files:
 - README.md
 - lib/telephone.rb
+- lib/telephone/locale/de.yml
+- lib/telephone/locale/en.yml
+- lib/telephone/locale/es.yml
+- lib/telephone/locale/fr.yml
+- lib/telephone/locale/it.yml
+- lib/telephone/locale/ja.yml
+- lib/telephone/locale/ko.yml
+- lib/telephone/locale/nl.yml
+- lib/telephone/locale/pt.yml
+- lib/telephone/locale/ru.yml
+- lib/telephone/locale/zh-CN.yml
 - lib/telephone/service.rb
+- lib/telephone/validators/type_validator.rb
 - lib/telephone/version.rb
 homepage: https://github.com/bharget/telephone
 licenses: []
@@ -40,7 +65,6 @@ metadata:
   bug_tracker_uri: https://github.com/bharget/telephone/issues
   changelog_uri: https://github.com/bharget/telephone/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/bharget/telephone
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -48,7 +72,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -56,8 +80,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - none
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.6.3
 specification_version: 4
 summary: Utility class for creating and calling service objects.
 test_files: []