teksymmetry-reek 1.1.3.1

data/spec/reek/smells/uncommunicative_name_spec.rb

@@ -0,0 +1,123 @@
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require 'ostruct'
+require 'reek/method_context'
+require 'reek/smells/uncommunicative_name'
+
+include Reek
+include Reek::Smells
+
+describe UncommunicativeName, "method name" do
+  it 'should not report one-word method name' do
+    'def help(fred) basics(17) end'.should_not reek
+  end
+  it 'should report one-letter method name' do
+    'def x(fred) basics(17) end'.should reek_only_of(:UncommunicativeName, /x/)
+  end
+  it 'should report name of the form "x2"' do
+    'def x2(fred) basics(17) end'.should reek_only_of(:UncommunicativeName, /x2/)
+  end
+end
+
+describe UncommunicativeName, "field name" do
+  it 'should not report one-word field name' do
+    'class Thing; def help(fred) @simple end end'.should_not reek
+  end
+  it 'should report one-letter fieldname' do
+    'class Thing; def simple(fred) @x end end'.should reek_only_of(:UncommunicativeName, /@x/, /Thing/, /variable name/)
+  end
+  it 'should report name of the form "x2"' do
+    'class Thing; def simple(fred) @x2 end end'.should reek_only_of(:UncommunicativeName, /@x2/, /Thing/, /variable name/)
+  end
+  it 'should report one-letter fieldname in assignment' do
+    'class Thing; def simple(fred) @x = fred end end'.should reek_only_of(:UncommunicativeName, /@x/, /Thing/, /variable name/)
+  end
+end
+
+describe UncommunicativeName, "local variable name" do
+  it 'should not report one-word variable name' do
+    'def help(fred) simple = jim(45) end'.should_not reek
+  end
+  it 'should report one-letter variable name' do
+    'def simple(fred) x = jim(45) end'.should reek_only_of(:UncommunicativeName, /x/, /variable name/)
+  end
+  it 'should report name of the form "x2"' do
+    'def simple(fred) x2 = jim(45) end'.should reek_only_of(:UncommunicativeName, /x2/, /variable name/)
+  end
+  it 'should report variable name only once' do
+    'def simple(fred) x = jim(45); x = y end'.should reek_only_of(:UncommunicativeName, /x/)
+  end
+
+  it 'should report a bad name inside a block' do
+    src = 'def clean(text) text.each { q2 = 3 } end'
+    src.should reek_of(:UncommunicativeName, /q2/)
+  end
+end
+
+describe UncommunicativeName, "parameter name" do
+  it 'should not recognise *' do
+    'def help(xray, *) basics(17) end'.should_not reek
+  end
+  it "should report parameter's name" do
+    'def help(x) basics(17) end'.should reek_only_of(:UncommunicativeName, /x/, /variable name/)
+  end
+  it 'should report name of the form "x2"' do
+    'def help(x2) basics(17) end'.should reek_only_of(:UncommunicativeName, /x2/, /variable name/)
+  end
+end
+
+describe UncommunicativeName, "block parameter name" do
+  it "should report parameter's name" do
+    'def help() @stuff.each {|x|} end'.should reek_only_of(:UncommunicativeName, /x/, /block/, /variable name/)
+  end
+
+  it "should report method name via if context" do
+    src = <<EOS
+def bad
+  unless @mod then
+    @sig.each { |x| x.to_s }
+  end
+end
+EOS
+    src.should reek_only_of(:UncommunicativeName, /'x'/)
+  end
+end
+
+describe UncommunicativeName, "several names" do
+
+  it 'should report all bad names' do
+    ruby = Source.from_s('class Oof; def y(x) @z = x end end')
+    ruby.should reek_of(:UncommunicativeName, /'x'/)
+    ruby.should reek_of(:UncommunicativeName, /'y'/)
+    ruby.should reek_of(:UncommunicativeName, /'@z'/)
+  end
+
+  it 'should report all bad block parameters' do
+    source =<<EOS
+class Thing
+  def bad(fred)
+    @fred.each {|x| 4 - x }
+    @jim.each {|y| y - 4 }
+  end
+end
+EOS
+    source.should reek_of(:UncommunicativeName, /'x'/)
+    source.should reek_of(:UncommunicativeName, /'y'/)
+  end
+end
+
+describe UncommunicativeName, '#examine' do
+  before :each do
+    @report = Report.new
+    @uc = UncommunicativeName.new
+  end
+  
+  it 'should return true when reporting a smell' do
+    mc = MethodContext.new(StopContext.new, [:defn, :x, nil])
+    @uc.examine(mc, @report).should == true
+  end
+  
+  it 'should return false when not reporting a smell' do
+    mc = MethodContext.new(StopContext.new, [:defn, :not_bad, nil])
+    @uc.examine(mc, @report).should == false
+  end
+end

data/spec/reek/smells/utility_function_spec.rb

@@ -0,0 +1,93 @@
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
+
+require 'reek/smells/utility_function'
+
+include Reek
+include Reek::Smells
+
+describe UtilityFunction do
+
+  it 'should not report attrset' do
+    class Fred
+      attr_writer :xyz
+    end
+    Fred.should_not reek
+  end
+
+  it 'should count usages of self'do
+    'def <=>(other) Options[:sort_order].compare(self, other) end'.should_not reek
+  end
+  it 'should count self reference within a dstr' do
+    'def as(alias_name); "#{self} as #{alias_name}".to_sym; end'.should_not reek
+  end
+  it 'should count calls to self within a dstr' do
+    'def to_sql; "\'#{self.gsub(/\'/, "\'\'")}\'"; end'.should_not reek
+  end
+  it 'should report simple parameter call' do
+    'def simple(arga) arga.to_s end'.should reek_of(:UtilityFunction, /simple/)
+  end
+  it 'should report message chain' do
+    'def simple(arga) arga.b.c end'.should reek_of(:UtilityFunction, /simple/)
+  end
+  
+  it 'should not report overriding methods' do
+    class Father
+      def thing(ff); @kids = 0; end
+    end
+    class Son < Father
+      def thing(ff); ff; end
+    end
+    Son.should_not reek
+  end
+
+  it 'should not report class method' do
+    pending('bug')
+    source = <<EOS
+class Cache
+  class << self
+    def create_unless_known(attributes)
+      Cache.create(attributes) unless Cache.known?
+    end
+  end
+end
+EOS
+    source.should_not reek
+  end
+  
+  it 'should recognise a deep call' do
+    src = <<EOS
+class Red
+  def deep(text)
+    text.each { |mod| atts = shelve(mod) }
+  end
+
+  def shelve(val)
+    @shelf << val
+  end
+end
+EOS
+    src.should_not reek
+  end
+end
+
+describe UtilityFunction, 'should only report a method containing a call' do
+  it 'should not report empty method' do
+    'def simple(arga) end'.should_not reek
+  end
+  it 'should not report literal' do
+    'def simple(arga) 3; end'.should_not reek
+  end
+  it 'should not report instance variable reference' do
+    'def simple(arga) @yellow end'.should_not reek
+  end
+  it 'should not report vcall' do
+    'def simple(arga) y end'.should_not reek
+  end
+  it 'should not report references to self' do
+    'def into; self; end'.should_not reek
+  end
+
+  it 'should recognise an ivar reference within a block' do
+    'def clean(text) text.each { @fred = 3} end'.should_not reek
+  end
+end

data/spec/slow/inline_spec.rb

@@ -0,0 +1,40 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in inline.rb" do
+    ruby = File.new("#{SAMPLES_DIR}/inline.rb").to_source
+    ruby.should reek_of(:ControlCouple, /Inline::C#parse_signature/, /raw/)
+    ruby.should reek_of(:ControlCouple, /Module#inline/, /options/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /\(\$\?\ == 0\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /Inline.directory/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\("#endif"\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\("#ifdef __cplusplus"\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /module_name/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /warn\("Output:\\n\#\{result\}"\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#crap_for_windoze/, /Config::CONFIG\["libdir"\]/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /result.sub!\(\/\\A\\n\/, ""\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\["args"\]/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\["args"\].map/)
+    ruby.should reek_of(:Duplication, /Inline::C#initialize/, /stack.empty?/)
+    ruby.should reek_of(:Duplication, /Inline::C#load/, /so_name/)
+    ruby.should reek_of(:Duplication, /Inline::self.rootdir/, /env.nil?/)
+    ruby.should reek_of(:Duplication, /Module#inline/, /Inline.const_get\(lang\)/)
+    ruby.should reek_of(:FeatureEnvy, /Inline::C#strip_comments/, /src/)
+    ruby.should reek_of(:LargeClass, /Inline::C/, /instance variables/)
+    ruby.should reek_of(:LongMethod, /Inline::C#build/)
+    ruby.should reek_of(:LongMethod, /Inline::C#generate/)
+    ruby.should reek_of(:LongMethod, /Inline::C#parse_signature/)
+    ruby.should reek_of(:LongMethod, /Inline::self.rootdir/)
+    ruby.should reek_of(:LongMethod, /Module#inline/)
+    ruby.should reek_of(:NestedIterators, /Inline::C#build/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#build/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#build/, /'n'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#c/, /'c'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'x'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#parse_signature/, /'x'/)
+    ruby.should reek_of(:UtilityFunction, /Inline::C#strip_comments/)
+    ruby.report.should have_at_most(32).smells
+  end
+end

data/spec/slow/optparse_spec.rb

@@ -0,0 +1,109 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in optparse.rb" do
+    ruby = File.new("#{SAMPLES_DIR}/optparse.rb").to_source
+    ruby.should reek_of(:ControlCouple, /OptionParser#List#accept/, /pat/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /lopts/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /sopts/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#ParseError#set_option/, /eq/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#Switch#NoArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#Switch#OptionalArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#Switch#RequiredArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#block/, /o/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#block/, /s/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#block\/block/, /pkg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#getopts\/block/, /val/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#parse_in_order/, /setter/)
+    ruby.should reek_of(:Duplication, /OptionParser#Completion::complete/, /candidates.size/)
+    ruby.should reek_of(:Duplication, /OptionParser#Completion::complete/, /k.id2name/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#parse_arg/, /s.length/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect \{ \|s\| s\.length \}\.max/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect \{ \|s\| s\.length \}\.max\.to_i/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /\(indent \+ l\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.shift/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left\[-1\]/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /s.length/)
+    ruby.should reek_of(:Duplication, /OptionParser#getopts/, /result\[opt\] = false/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /default_style.guess\(arg = a\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /\(long << o = q.downcase\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /notwice\(a \? \(Object\) : \(TrueClass\), klass, "type"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /notwice\(NilClass, klass, "type"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(:convert\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(:convert\).to_proc/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.respond_to\?\(:convert\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /q.downcase/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /search\(:atype, o\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /search\(:atype, FalseClass\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /\(sdesc << "-\#\{q\}"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#order/, /argv\[0\]/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse/, /argv\[0\]/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /\$\!.set_option\(arg, true\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /cb.call\(val\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /setter.call\(sw.switch_name, val\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /sw.block/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /sw.switch_name/)
+    ruby.should reek_of(:Duplication, /OptionParser#permute/, /argv\[0\]/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#Completion::complete/, /candidates/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#List#accept/, /pat/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#Switch#summarize/, /left/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#order/, /argv/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#parse/, /argv/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#permute/, /argv/)
+    ruby.should reek_of(:LargeClass, /OptionParser/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Completion::complete/)
+    ruby.should reek_of(:LongMethod, /OptionParser#List#update/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Switch#PlacedArgument#parse/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Switch#parse_arg/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Switch#summarize/)
+    ruby.should reek_of(:LongMethod, /OptionParser#getopts/)
+    ruby.should reek_of(:LongMethod, /OptionParser#make_switch/)
+    ruby.should reek_of(:LongMethod, /OptionParser#parse_in_order/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#List#complete/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#List#update/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#Switch#initialize/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#Switch#summarize/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#complete/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#summarize/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#CompletingHash#match/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#Switch#summarize/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#block/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#complete/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#make_switch/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#make_switch/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#parse_in_order/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#parse_in_order/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Completion::complete/, /'k'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Completion::complete/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#List#accept/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#List#reject/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#List#update/, /'o'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#add_banner/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#parse_arg/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#parse_arg/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#self.guess/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#self.incompatible_argument_styles/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#summarize/, /'l'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#summarize/, /'r'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#summarize/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'f'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'k'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'o'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#load/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'a'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'n'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'o'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'q'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'c'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#search/, /'k'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#summarize/, /'l'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#ver/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /block/, /'q'/)
+    ruby.report.should have_at_most(117).smells
+  end
+end

data/spec/slow/redcloth_spec.rb

@@ -0,0 +1,101 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in redcloth.rb" do
+    ruby = File.new("#{SAMPLES_DIR}/redcloth.rb").to_source
+    ruby.should reek_of(:ControlCouple, /RedCloth#blocks\/block/, /deep_code/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#check_refs/, /text/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#pba/, /text_in/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_bq/, /atts/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_bq/, /cite/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_fn_/, /atts/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_p/, /atts/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth\[i\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /\(line_id - 1\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /lines\[\(line_id - 1\)\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /tl.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#clean_html/, /tags\[tag\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#pba/, /\$1.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /\(@pre_list.last << line\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /\(codepre - used_offtags.length\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /\(\(codepre - used_offtags.length\) > 0\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.zero?/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /htmlesc\(line, :NoQuotes\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags\["notextile"\]/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_markdown_atx/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_markdown_rule/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_markdown_setext/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_textile_lists/, /depth/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_html/, /raw/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_html/, /tags/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_white_space/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /indt/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#footnote_ref/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#htmlesc/, /str/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#incoming_entities/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#no_textile/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /style/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /text/)
+    ruby.should reek_of(:LargeClass, /RedCloth/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_markdown_bq/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:LongMethod, /RedCloth#blocks/)
+    ruby.should reek_of(:LongMethod, /RedCloth#clean_html/)
+    ruby.should reek_of(:LongMethod, /RedCloth#clean_white_space/)
+    ruby.should reek_of(:LongMethod, /RedCloth#glyphs_textile/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_markdown_link/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_markdown_reflink/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_image/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_link/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_span/)
+    ruby.should reek_of(:LongMethod, /RedCloth#pba/)
+    ruby.should reek_of(:LongMethod, /RedCloth#rip_offtags/)
+    ruby.should reek_of(:LongMethod, /RedCloth#to_html/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_bq/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_fn_/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_p/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#blocks/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#clean_html/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#clean_html/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#inline/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#inline_textile_span/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block/, /'a'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block/, /'b'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_lists/, /'i'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_lists/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_table/, /'x'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#clean_html/, /'q'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#clean_html/, /'q2'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#initialize/, /'r'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_markdown_link/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_markdown_reflink/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_code/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_image/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_link/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_span/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#refs_markdown/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#refs_textile/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#retrieve/, /'i'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#retrieve/, /'r'/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#block_markdown_rule/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#clean_html/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#flush_left/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#footnote_ref/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#h_align/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#htmlesc/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#incoming_entities/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#no_textile/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#v_align/)
+    ruby.report.should have_at_most(93).smells
+  end
+end

data/spec/slow/reek_source_spec.rb

@@ -0,0 +1,20 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'Reek source code:' do
+  Dir['lib/**/*.rb'].each do |path|
+    it "reports no smells in #{path}" do
+      File.new(path).should_not reek
+    end
+  end
+
+  it 'reports no smells via the Dir matcher' do
+    Dir['lib/**/*.rb'].should_not reek
+  end
+end
+
+describe 'RakeTask' do
+  it 'should report no duplication' do
+    report = `rake reek`.split("\n")
+    report.length.should == 1
+  end
+end