teems 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bdc6ea71a9d23f39629fd24d240992925cca1482b53b69df377a84870d66367f
-  data.tar.gz: 1d563de02f05c8a120130e3e792b508bbf4d1b2467937951a63f2a3efbb19410
+  metadata.gz: 554acde76f11331b9a92ba84e7a0972f0951b0e26f90019801550ab6767a3493
+  data.tar.gz: 39b410aaf606f2298871bb9f90f463f021dee51d08814fce7f0260d8432de8a5
 SHA512:
-  metadata.gz: 8c903fdae8e9946614e093ab4370e74abc03f7fab0d0a76509da02d07814e0083382f4a8f46e0e9131dd1eb3b16f0c36c5eeb96bb381778679bb92028574ad13
-  data.tar.gz: b3e6ff9fa9ec3adb9708a3ab97b30929d53a820e9d6239daaf4d359cee179c32448b306a7ac3ab26f336aa3c723402868a1206711637af791a974aa0e3f0e832
+  metadata.gz: 209764374cdd5674d1f9d5398d33fd2bccf6a1869d0ff0ec11dd5d5202e78de3cb2a24eb3dc4a2431df348cda73ee7d928816ae1210690bdca9ba8138596fcdc
+  data.tar.gz: 06ad5d91c6ae16bb936910d5dbd1f9d6fa85df7a7bb27caaed5b652acd1ee265cd3a8408be8842aa3f2a7d6c06099c9580fa40e089a5ebd18b70d6cf91169c0d

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## [0.3.3] - 2026-10-02
+
+### Added
+- Inline images (screenshots pasted into a message) are no longer dropped when message HTML is stripped. `teems messages` lists them under the message, and `--json` includes an `images` array with the AMS URL, full-size URL, alt text, and dimensions.
+- `teems messages --download` saves inline images alongside file attachments, fetching the original-resolution AMS view (falling back to the message's preview URL) with the skype token. The token is only sent to Teams/AMS hosts over HTTPS and is dropped on redirects elsewhere.
+- `teems sync` records inline images in `messages.json` and renders `[image: alt (WxH)]` placeholders in `messages.md`. `teems sync --images` downloads them into each chat's `images/` directory, links them from `messages.md`, and backfills already-synced chats.
+
+### Fixed
+- `teems messages <teams-url>` for a message in a group or 1:1 chat no longer fails with "Failed to fetch message"; those chats have no reply threads, so the replies endpoint's 404 now means no replies.
+- `teems messages --json <teams-url>` no longer crashes with "no implicit conversion from nil to integer" after printing the thread.
+
 ## [0.3.2] - 2026-09-29
 
 ### Added

data/README.md

@@ -56,8 +56,12 @@ teems cal delete 3           # Delete event #3
 teems messages <chat-id>                    # Read from a chat
 teems messages <channel-id> -t <team-id>    # Read from a channel
 teems messages <chat-id> -n 50              # Show more messages
+teems messages <chat-id> --json             # JSON, including inline image refs
+teems messages <chat-id> --download         # Save attachments and pasted images
 ```
 
+Screenshots pasted into a message are listed under it (`🖼️ image (881x179)`) and included in `--json` as `images` (AMS `url`, `full_size_url`, `alt`, `width`, `height`). `--download` saves the original-resolution image to the downloads directory as `image-<hash>-<n>.<ext>`, using your Teams skype token. The token is only sent to Teams/AMS hosts over HTTPS.
+
 ### Channels and Chats
 
 ```bash
@@ -151,8 +155,11 @@ teems activity                        # Show activity feed
 
 ```bash
 teems sync             # Sync chat history locally
+teems sync --images    # Also save pasted images beside each chat
 ```
 
+Each chat gets `messages.md`, `messages.json`, and `chat_metadata.json` under `~/.local/share/teems/sync/chats/`. Inline images are recorded in `messages.json` and rendered in `messages.md` as `[image: alt (WxH)]`. With `--images`, they are downloaded to the chat's `images/` directory (named by AMS object id, so each is fetched once) and `messages.md` links the saved copy instead. `--images` also rewrites already-synced chats so images in older messages are backfilled.
+
 ## Global Options
 
 | Option | Description |

data/lib/teems/commands/meeting.rb

@@ -613,10 +613,11 @@ module Teems
       private
 
       def output_meeting_json(target, classified)
+        call_events, recordings, transcripts = classified.values_at(:call_events, :recordings, :transcripts)
         output_json(thread_id: target[:thread_id],
-                    call_events: classified[:call_events].map { |event| json_call_event(event) },
-                    recordings: classified[:recordings].map { |rec| rec.slice(:time, :url, :call_id) },
-                    transcripts: classified[:transcripts].map { |item| item.slice(:time) })
+                    call_events: call_events.map { |event| json_call_event(event) },
+                    recordings: recordings.map { |rec| rec.slice(:time, :url, :call_id) },
+                    transcripts: transcripts.map { |item| item.slice(:time) })
         0
       end
 

data/lib/teems/commands/messages.rb

@@ -14,7 +14,7 @@ module Teems
       OPTIONS:
         -t, --team ID    Team ID (required for channel messages)
         -n, --limit N    Number of messages (default: 20)
-        --download       Download file attachments
+        --download       Download file attachments and inline images
         -o, --output-dir Directory for downloads (default: ~/.local/share/teems/downloads)
         -v, --verbose    Show debug output
         -q, --quiet      Suppress output
@@ -23,10 +23,13 @@ module Teems
       EXAMPLES:
         teems messages 19:abc123@thread.v2         # Read chat messages
         teems messages 19:abc123@thread.v2 -n 50   # Show 50 messages
+        teems messages 19:abc123@thread.v2 --download  # Save attachments + pasted images
         teems messages "https://teams.microsoft.com/l/message/19:abc@thread.v2/123?context=..."
                                                    # Show the linked message and its thread replies
     HELP
 
+    IMAGE_ICON = "\u{1F5BC}\u{FE0F}"
+
     # Display formatting for messages command
     module MessagesDisplay
       REACTION_EMOJI = {
@@ -45,6 +48,7 @@ module Teems
         puts format_message_header(message)
         puts "  #{formatted_content(message)}"
         display_attachments(message)
+        display_images(message)
         display_reactions(message)
         puts
       end
@@ -66,6 +70,11 @@ module Teems
         puts "  #{output.gray("\u{1F4CE} #{names.join(', ')}")}"
       end
 
+      def display_images(message)
+        summary = Formatters::FormatUtils.image_summary(message.images)
+        puts "  #{output.gray("#{IMAGE_ICON} #{summary}")}" unless summary.empty?
+      end
+
       def display_reactions(message)
         reactions = message.reactions
         return unless reactions.any?
@@ -85,7 +94,7 @@ module Teems
           created_at: message.created_at&.iso8601,
           importance: message.importance, reactions: message.reactions,
           attachments: message.attachments, edited: message.edited,
-          mentions: message.mentions }
+          mentions: message.mentions, images: message.images.map(&:as_json) }
       end
     end
 
@@ -95,14 +104,15 @@ module Teems
 
       def download_attachments(messages)
         attachments = find_downloadable(messages)
-        return puts('No downloadable attachments found') if attachments.empty?
+        images = inline_images(messages)
+        return puts('No downloadable attachments found') if attachments.empty? && images.empty?
 
-        execute_downloads(attachments)
+        execute_downloads(attachments, images)
       end
 
-      def execute_downloads(attachments)
+      def execute_downloads(attachments, images)
         dir = prepare_output_dir
-        count = attachments.sum { |att| download_one(att, dir) }
+        count = attachments.sum { |att| download_one(att, dir) } + images.sum { |entry| download_image(entry, dir) }
         puts "Downloaded #{count} file#{'s' if count != 1} to #{dir}" if count.positive?
       end
 
@@ -168,6 +178,29 @@ module Teems
       end
     end
 
+    # Download logic for images pasted inline into message bodies (Teams AMS objects)
+    module InlineImageDownload
+      private
+
+      # [message, image, 1-based position within the message] for every inline image
+      def inline_images(messages) = messages.flat_map { |msg| numbered_images(msg) }
+
+      def numbered_images(msg) = msg.images.map.with_index(1) { |image, number| [msg, image, number] }
+
+      def download_image(entry, dir)
+        msg, image, number = entry
+        print "#{IMAGE_ICON} Downloading #{image.label}..."
+        result = with_token_refresh { image_downloader.fetch(image) }
+        path = unique_path(dir, "image-#{msg.short_hash}-#{number}.#{result.extension}")
+        puts " done (#{Formatters::FormatUtils.format_bytes(File.binwrite(path, result.body))}) #{path}"
+        1
+      rescue StandardError => e
+        handle_download_error(e)
+      end
+
+      def image_downloader = @image_downloader ||= runner.inline_image_downloader
+    end
+
     # Fetch and render a single message and its thread replies
     module ThreadFetch
       private
@@ -175,7 +208,7 @@ module Teems
       def fetch_thread(thread_id, message_id)
         api = runner.messages_api
         parent_data = with_token_refresh { api.message(thread_id: thread_id, message_id: message_id) }
-        replies_data = with_token_refresh do
+        replies_data = fetch_replies do
           api.replies(thread_id: thread_id, message_id: message_id, limit: @options[:limit])
         end
         display_thread(parent_data, extract_messages_data(replies_data))
@@ -183,10 +216,19 @@ module Teems
         error("Failed to fetch message: #{e.message}")
       end
 
+      # Group and 1:1 chats have no reply threads; their replies endpoint returns 404
+      def fetch_replies(&)
+        with_token_refresh(&)
+      rescue ApiError => e
+        raise unless e.not_found?
+
+        {}
+      end
+
       def display_thread(parent_data, replies_data)
         parent = Models::Message.from_api(parent_data)
         replies = replies_data.map { |data| Models::Message.from_api(data) }.reject(&:system_message?).reverse
-        return output_json(thread_to_hash(parent, replies)) if @options[:json]
+        return output_json(thread_to_hash(parent, replies)) || 0 if @options[:json]
 
         render_thread(parent, replies)
         download_attachments([parent, *replies]) if @options[:download]
@@ -212,6 +254,7 @@ module Teems
     class Messages < Base
       include MessagesDisplay
       include AttachmentDownload
+      include InlineImageDownload
       include ThreadFetch
 
       def initialize(args, runner:)

data/lib/teems/commands/sync.rb

@@ -11,6 +11,7 @@ module Teems
       OPTIONS:
         --since DAYS     Number of days of history to sync (default: 180)
         --chat CHAT_ID   Sync only this chat
+        --images         Also download inline (pasted) images into each chat's images/ dir
         --auth           Authenticate via Safari before syncing
         --dry-run        Show what would be synced without writing files
         -v, --verbose    Show debug output
@@ -20,11 +21,13 @@ module Teems
         teems sync                         # Sync 6 months of all chats
         teems sync --since 30              # Sync last 30 days
         teems sync --chat 19:abc@thread.v2 # Sync a single chat
+        teems sync --images                # Include pasted screenshots
         teems sync --dry-run               # Preview what would be synced
 
       OUTPUT:
         Files are stored in ~/.local/share/teems/sync/chats/
         Each chat gets: messages.md, messages.json, chat_metadata.json
+        (plus images/ with --images; messages.md links saved images, otherwise [image: ...])
     HELP
 
     # Handles syncing individual chats: fetch, merge, retry on 404
@@ -70,7 +73,9 @@ module Teems
 
       def process_fetched_messages(chat, new_messages)
         chat_id = chat.id
-        return skip_unchanged(chat_id) if new_messages.empty? && @sync_store.last_synced_time(@state, chat_id)
+        # --images rewrites unchanged chats too, so images in already-synced messages are backfilled
+        unchanged = new_messages.empty? && !@options[:images]
+        return skip_unchanged(chat_id) if unchanged && @sync_store.last_synced_time(@state, chat_id)
 
         merge_and_update(chat, new_messages)
       end
@@ -83,7 +88,9 @@ module Teems
 
       def merge_and_update(chat, new_messages)
         existing_raw = @sync_store.read_messages_json(chat.id, state: @state)
-        all_messages = sync_engine.merge_and_write(chat, existing_raw, new_messages)
+        all_messages = sync_engine.merge_and_write(chat, existing_raw, new_messages) do |chat_dir, messages|
+          save_chat_images(chat_dir, messages)
+        end
         update_chat_state(chat, all_messages)
       end
 
@@ -138,6 +145,23 @@ module Teems
       end
     end
 
+    # Opt-in (--images) download of inline images into each synced chat directory
+    module SyncImageHandler
+      private
+
+      def save_chat_images(chat_dir, messages)
+        return unless @options[:images]
+
+        saved = sync_images.save(chat_dir, messages)
+        debug("  Saved #{saved} image(s)")
+        @stats[:images] += saved
+      end
+
+      def sync_images
+        @sync_images ||= Services::SyncImages.new(downloader: runner.inline_image_downloader, output: output)
+      end
+    end
+
     # Chat list fetching, dry-run display, and summary reporting
     module SyncDisplay
       private
@@ -211,6 +235,7 @@ module Teems
         skipped = @stats[:skipped]
         info("  Chats skipped (no new messages): #{skipped}") if skipped.positive?
         info("  Total messages: #{@stats[:messages_total]}")
+        info("  Images downloaded: #{@stats[:images]}") if @options[:images]
         display_error_count
       end
 
@@ -287,6 +312,7 @@ module Teems
     # Sync chat history locally as Markdown + JSON files
     class Sync < Base
       include SyncChatHandler
+      include SyncImageHandler
       include SyncDisplay
       include SyncAuth
 
@@ -318,6 +344,7 @@ module Teems
         '--since' => ->(opts, args) { opts[:since_days] = args.shift.to_i },
         '--chat' => ->(opts, args) { opts[:chat_id] = args.shift },
         '--dry-run' => ->(opts, _args) { opts[:dry_run] = true },
+        '--images' => ->(opts, _args) { opts[:images] = true },
         '--auth' => ->(opts, _args) { opts[:auth] = true }
       }.freeze
 
@@ -353,7 +380,7 @@ module Teems
       def init_sync_state
         @sync_store = Services::SyncStore.new
         @state = @sync_store.load_state
-        @stats = { synced: 0, skipped: 0, errors: 0, messages_total: 0 }
+        @stats = { synced: 0, skipped: 0, errors: 0, messages_total: 0, images: 0 }
         setup_api_logging
       end