tee_logger 2.4.1 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e038d2637ea600e0ee63ecff7d2be02d8692658b
-  data.tar.gz: 347e52f9ddd2ef5c76a4320951867d409062b368
+  metadata.gz: 769d6af48f3a6f679e38c6c411e3cd50f1975b33
+  data.tar.gz: 04cc26d406a0379be35fff2403fc5220c25664a5
 SHA512:
-  metadata.gz: 553e57ad94ea5cff19078c08d4b414a1df6d045d720a10743c9c1dbb15961d55cc00e2ab49dff9d02079e3b7a2253961166ad3753f8f44c060716bd4314b732f
-  data.tar.gz: 67aca467869d1aeef54ab6f225de2cb0a08d4d8e33307f48e75d75145b191ebfeb577d4b121df7b2b04452b796c2acbd3ffab1ae1ce3285c507f62188e356cdc
+  metadata.gz: deb859ba6ad1af5b756bb2c5786e79b64d4aa1f56e065f99363b3c31172ad625a53058437d7d51410dc9ca25bfceb4c2df6a6e6f4f49b1b13f46e553be397aa3
+  data.tar.gz: 34fbf45ece0f7598f71b6b3b2fd2ebe29799f9b04dcb10e9637477130b76e1d2f356feedc5846bf778218f347e687c554aa36dc1d7e2be181b3152f6a0ea9975

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# v2.5.0
+- level, progname and formatter were changed to instance variable
+- refactoring: disabling and enabling
+- rm ./lib/tee_logger/constants.rb. Constants move to ./lib/tee_logger.rb
+
 # v2.4.1
 - update README.md
 - and YARD comment

data/Gemfile

@@ -2,4 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in tee_logger.gemspec
 gemspec
-gem "codeclimate-test-reporter", group: :test, require: nil
+gem 'codeclimate-test-reporter', group: :test, require: nil
+gem 'simplecov-console', group: :test, require: nil

data/lib/tee_logger.rb

@@ -1,9 +1,13 @@
 require 'tee_logger/version'
-require 'tee_logger/constants'
 require 'logger'
 
 # namespace
 module TeeLogger
+  # no param of filename, set this filename
+  DEFAULT_FILE = './tee_logger.log'
+  # Implements targets
+  LOGGING_METHODS = [:debug, :info, :warn, :error, :fatal].freeze
+
   # shortcut for TeeLogger::TeeLogger.new
   # @see TeeLogger
   def self.new(logdev = DEFAULT_FILE, shift_age = 0, shift_size = 1_048_576)
@@ -13,18 +17,7 @@ module TeeLogger
   # main
   # @see http://www.rubydoc.info/stdlib/logger/Logger Logger
   class TeeLogger
-    # @param logdev String
-    # @param shift_age Integer
-    # @param shift_size Integer
-    # @see Logger#initialize
-    def initialize(logdev = DEFAULT_FILE, shift_age = 0, shift_size = 1_048_576)
-      @logfile = Logger.new(logdev, shift_age, shift_size)
-      @console = Logger.new($stdout)
-    end
-
     class << self
-      private
-
       # @!macro [attach] loglevel_check_methods
       #   @!method $1(name)
       #   @return [Boolean]
@@ -34,6 +27,7 @@ module TeeLogger
           @console.send(name)
         end
       end
+      private :define_loglevel_check_methods
 
       # @!macro [attach] logging_methods
       #   @!method $1(progname = nil, &block)
@@ -45,13 +39,19 @@ module TeeLogger
           @console.send(name, progname, &block)
         end
       end
+      private :define_logging_methods
     end
 
-    define_loglevel_check_methods :debug?
-    define_loglevel_check_methods :info?
-    define_loglevel_check_methods :warn?
-    define_loglevel_check_methods :error?
-    define_loglevel_check_methods :fatal?
+    attr_reader :level, :progname, :formatter
+
+    # @param logdev [String]
+    # @param shift_age [Integer]
+    # @param shift_size [Integer]
+    # @see Logger#initialize
+    def initialize(logdev = DEFAULT_FILE, shift_age = 0, shift_size = 1_048_576)
+      @logfile = Logger.new(logdev, shift_age, shift_size)
+      @console = Logger.new($stdout)
+    end
 
     define_logging_methods :debug
     define_logging_methods :info
@@ -59,48 +59,35 @@ module TeeLogger
     define_logging_methods :error
     define_logging_methods :fatal
 
-    # TODO: which value?
-    # @return [Integer]
-    def level
-      @logfile.level
-      @console.level
-    end
+    define_loglevel_check_methods :debug?
+    define_loglevel_check_methods :info?
+    define_loglevel_check_methods :warn?
+    define_loglevel_check_methods :error?
+    define_loglevel_check_methods :fatal?
 
     # @param level [Integer]
     def level=(level)
       @logfile.level = level
       @console.level = level
+      @level = level
     end
-    alias_method :sev_threshold,  :level
+    alias_method :sev_threshold, :level
     alias_method :sev_threshold=, :level=
 
-    # TODO: both values?
-    # @return [String]
-    def progname
-      @logfile.progname
-      @console.progname
-    end
-
     # @param name [String, Symbol]
     def progname=(name = nil)
       @logfile.progname = name
       @console.progname = name
-    end
-
-    # TODO: both values?
-    # @return [String]
-    def formatter
-      @logfile.formatter
-      @console.formatter
+      @progname = name
     end
 
     # @param formatter
     def formatter=(formatter)
       @logfile.formatter = formatter
       @console.formatter = formatter
+      @formatter = formatter
     end
 
-    # @todo Too miscellaneous
     # @param target [String, Symbol]
     # @yield before target disable, after target enable.
     def disable(target)
@@ -109,14 +96,19 @@ module TeeLogger
         yield
         enable(target)
       else
-        instance_variable_get("@#{target}").formatter = proc { |_, _, _, _| '' }
+        target_instance(target).formatter = proc { |_, _, _, _| '' }
       end
     end
 
-    # @todo Too miscellaneous
     # @param target [String, Symbol]
     def enable(target)
-      instance_variable_get("@#{target}").formatter = Logger::Formatter.new
+      target_instance(target).formatter = @formatter
+    end
+
+    private
+
+    def target_instance(target)
+      instance_variable_get("@#{target}")
     end
   end
 end

data/lib/tee_logger/version.rb

@@ -1,5 +1,5 @@
 # namespace
 module TeeLogger
   # version number
-  VERSION = '2.4.1'
+  VERSION = '2.5.0'
 end

data/tee_logger.gemspec

@@ -16,7 +16,9 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/k-ta-yamada/tee_logger'
   spec.license       = 'MIT'
 
+  # rubocop:disable Metrics/LineLength
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  # rubocop:enable Metrics/LineLength
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tee_logger
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.5.0
 platform: ruby
 authors:
 - k-ta-yamada
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-09-10 00:00:00.000000000 Z
+date: 2015-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -166,10 +166,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/console
-- bin/setup
 - lib/tee_logger.rb
-- lib/tee_logger/constants.rb
 - lib/tee_logger/version.rb
 - tee_logger.gemspec
 homepage: https://github.com/k-ta-yamada/tee_logger

data/bin/console

@@ -1,14 +0,0 @@
-#!/usr/bin/env ruby
-
-require "bundler/setup"
-require "tee_logger"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start

data/bin/setup

@@ -1,7 +0,0 @@
-#!/bin/bash
-set -euo pipefail
-IFS=$'\n\t'
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/lib/tee_logger/constants.rb

@@ -1,10 +0,0 @@
-require 'logger'
-
-# namespace
-module TeeLogger
-  # no param of filename, set this filename
-  DEFAULT_FILE = './tee_logger.log'
-
-  # Implements targets
-  LOGGING_METHODS = [:debug, :info, :warn, :error, :fatal].freeze
-end