technicalpickles-daywalker 0.1.0 → 0.1.1

data/README.rdoc

@@ -26,7 +26,7 @@ After registering, you will receive an email prompting you to activate the API k
     pp Daywalker::District.find_by_zip('27511')
     pp Daywalker::District.find_by_latlng(40.739157, -73.990929)
     pp Daywalker::Legislator.find(:one, :state => 'NY', :district => 4)
-    pp Daywalker::Legislator.find_all_by_state_and_senator('NY', :senator)
+    pp Daywalker::Legislator.find_all_by_state_and_title('NY', :senator)
   
 
 == FAQ

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 0
+:patch: 1
 :major: 0

data/lib/daywalker/base.rb

@@ -8,7 +8,12 @@ module Daywalker
     def self.handle_response(response)
       case response.code.to_i
       when 403 then raise BadApiKey
-      when 200 then parse(response.body)
+      when 200
+        begin
+          parse(response.body)
+        rescue => e
+          raise "Error while parsing #{response.body.inspect} => #{e.inspect}"
+        end
 
       when 400 then handle_bad_request(response.body)
       else          raise "Don't know how to handle code #{response.code.inspect}"

data/lib/daywalker/legislator.rb

@@ -91,8 +91,8 @@ module Daywalker
     #   Daywalker::Legislator.find_all_by_state_and_senator('NY', :senator)
     def self.find(sym, conditions)
       url = case sym
-      when :one then '/legislators.get'
-      when :all then '/legislators.getList'
+      when :one then '/legislators.get.xml'
+      when :all then '/legislators.getList.xml'
       else raise ArgumentError, "invalid argument #{sym.inspect}, only :one and :all are allowed"
       end
 

data/spec/daywalker/legislator_spec.rb

@@ -55,7 +55,7 @@ describe Daywalker::Legislator do
     describe 'by state and district, with one result,' do
       describe 'happy path' do
         before do
-          register_uri_with_response 'legislators.get?apikey=redacted&state=NY&district=4', 'legislators_find_by_ny_district_4.xml'
+          register_uri_with_response 'legislators.get.xml?apikey=redacted&state=NY&district=4', 'legislators_find_by_ny_district_4.xml'
           @legislator = Daywalker::Legislator.find(:one, :state => 'NY', :district => 4)
         end
 
@@ -67,7 +67,7 @@ describe Daywalker::Legislator do
 
       describe 'by state and district, with bad API key' do
         before do
-          register_uri_with_response 'legislators.get?apikey=redacted&state=NY&district=4', 'legislators_find_by_ny_district_4_bad_api.xml'
+          register_uri_with_response 'legislators.get.xml?apikey=redacted&state=NY&district=4', 'legislators_find_by_ny_district_4_bad_api.xml'
         end
 
         it 'should raise a missing parameter error for zip' do
@@ -84,7 +84,7 @@ describe Daywalker::Legislator do
       describe 'happy path' do
         before do
           # curl -i "http://services.sunlightlabs.com/api/legislators.getList.xml?state=NY&title=Sen&apikey=redacted" > legislators_find_ny_senators.xml
-          register_uri_with_response 'legislators.getList?state=NY&apikey=redacted&title=Sen', 'legislators_find_ny_senators.xml'
+          register_uri_with_response 'legislators.getList.xml?state=NY&apikey=redacted&title=Sen', 'legislators_find_ny_senators.xml'
           @legislators = Daywalker::Legislator.find(:all, :state => 'NY', :title => :senator)
         end
 
@@ -95,7 +95,7 @@ describe Daywalker::Legislator do
 
       describe 'with bad API key' do
         before do
-          register_uri_with_response 'legislators.getList?state=NY&apikey=redacted&title=Sen', 'legislators_find_ny_senators_bad_api.xml'
+          register_uri_with_response 'legislators.getList.xml?state=NY&apikey=redacted&title=Sen', 'legislators_find_ny_senators_bad_api.xml'
         end
 
         it 'should raise BadApiKey error' do
@@ -119,7 +119,7 @@ describe Daywalker::Legislator do
   # TODO switch this to mocking
   describe 'dynamic finder find_all_by_state_and_title' do
     before do
-      register_uri_with_response 'legislators.getList?state=NY&apikey=redacted&title=Sen', 'legislators_find_ny_senators.xml'
+      register_uri_with_response 'legislators.getList.xml?state=NY&apikey=redacted&title=Sen', 'legislators_find_ny_senators.xml'
 
       @legislators = Daywalker::Legislator.find_all_by_state_and_title('NY', :senator)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: technicalpickles-daywalker
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - Josh Nichols