teaspoon 0.8.0 → 0.9.0

data/spec/dummy/config/environments/development.rb

@@ -1,27 +1,41 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # In the development environment your application's code is reloaded on
   # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Show full error reports and disable caching
-  config.consider_all_requests_local       = true
+  # Do not eager load code on boot.
+  config.eager_load = false
+
+  # Show full error reports and disable caching.
+  config.consider_all_requests_local = true
   config.action_controller.perform_caching = false
 
-  # Print deprecation notices to the Rails logger
-  config.active_support.deprecation = :log
+  # Don't care if the mailer can't send.
+  # config.action_mailer.raise_delivery_errors = false
 
-  # Only use best-standards-support built into browsers
-  config.action_dispatch.best_standards_support = :builtin
+  # Print deprecation notices to the Rails logger.
+  config.active_support.deprecation = :log
 
-  # Do not compress assets
-  config.assets.compress = false
+  # Raise an error on page load if there are pending migrations.
+  # config.active_record.migration_error = :page_load
 
-  # Expands the lines which load the assets
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
   config.assets.debug = true
 
-  # Eager loading
-  config.eager_load = false
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
+  config.assets.digest = true
+
+  # Adds additional error checking when serving assets at runtime.
+  # Checks for improperly declared sprockets dependencies.
+  # Raises helpful error messages.
+  config.assets.raise_runtime_errors = true
+
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
 end

data/spec/dummy/config/environments/production.rb

@@ -0,0 +1,79 @@
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
+
+  # Code is not reloaded between requests.
+  config.cache_classes = true
+
+  # Eager load code on boot. This eager loads most of Rails and
+  # your application in memory, allowing both threaded web servers
+  # and those relying on copy on write to perform better.
+  # Rake tasks automatically ignore this option for performance.
+  config.eager_load = true
+
+  # Full error reports are disabled and caching is turned on.
+  config.consider_all_requests_local = false
+  config.action_controller.perform_caching = true
+
+  # Enable Rack::Cache to put a simple HTTP cache in front of your application
+  # Add `rack-cache` to your Gemfile before enabling this.
+  # For large-scale production use, consider using a caching reverse proxy like
+  # NGINX, varnish or squid.
+  # config.action_dispatch.rack_cache = true
+
+  # Disable serving static files from the `/public` folder by default since
+  # Apache or NGINX already handles this.
+  config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
+
+  # Compress JavaScripts and CSS.
+  config.assets.js_compressor = :uglifier
+  # config.assets.css_compressor = :sass
+
+  # Do not fallback to assets pipeline if a precompiled asset is missed.
+  config.assets.compile = false
+
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
+  config.assets.digest = true
+
+  # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
+
+  # Specifies the header that your server uses for sending files.
+  # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
+  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
+
+  # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
+  # config.force_ssl = true
+
+  # Use the lowest log level to ensure availability of diagnostic information
+  # when problems arise.
+  config.log_level = :debug
+
+  # Prepend all log lines with the following tags.
+  # config.log_tags = [ :subdomain, :uuid ]
+
+  # Use a different logger for distributed setups.
+  # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
+
+  # Use a different cache store in production.
+  # config.cache_store = :mem_cache_store
+
+  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
+  # config.action_controller.asset_host = 'http://assets.example.com'
+
+  # Ignore bad email addresses and do not raise email delivery errors.
+  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
+  # config.action_mailer.raise_delivery_errors = false
+
+  # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
+  # the I18n.default_locale when a translation cannot be found).
+  config.i18n.fallbacks = true
+
+  # Send deprecation notices to registered listeners.
+  config.active_support.deprecation = :notify
+
+  # Use default logging formatter so that PID and timestamp are not suppressed.
+  config.log_formatter = ::Logger::Formatter.new
+
+  # Do not dump schema after migrations.
+  # config.active_record.dump_schema_after_migration = false
+end

data/spec/dummy/config/environments/test.rb

@@ -1,5 +1,5 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # The test environment is used exclusively to run your application's
   # test suite. You never need to work with it otherwise. Remember that
@@ -7,23 +7,36 @@ Dummy::Application.configure do
   # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
 
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  # Do not eager load code on boot. This avoids loading your whole application
+  # just for the purpose of running a single test. If you are using a tool that
+  # preloads Rails for running tests, you may have to set it to true.
+  config.eager_load = false
+
+  # Configure static file server for tests with Cache-Control for performance.
+  config.serve_static_files = true
+  config.static_cache_control = 'public, max-age=3600'
 
-  # Show full error reports and disable caching
-  config.consider_all_requests_local       = true
+  # Show full error reports and disable caching.
+  config.consider_all_requests_local = true
   config.action_controller.perform_caching = false
 
-  # Raise exceptions instead of rendering exception templates
+  # Raise exceptions instead of rendering exception templates.
   config.action_dispatch.show_exceptions = false
 
-  # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
+  # Disable request forgery protection in test environment.
+  config.action_controller.allow_forgery_protection = false
+
+  # Tell Action Mailer not to deliver emails to the real world.
+  # The :test delivery method accumulates sent emails in the
+  # ActionMailer::Base.deliveries array.
+  # config.action_mailer.delivery_method = :test
 
-  # Print deprecation notices to the stderr
+  # Randomize the order test cases are executed.
+  config.active_support.test_order = :random
+
+  # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 
-  # Eager loading
-  config.eager_load = false
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
 end

data/spec/dummy/config/routes.rb

@@ -1,2 +1,2 @@
-Dummy::Application.routes.draw do
+Rails.application.routes.draw do
 end

data/spec/dummy/config/secrets.yml

@@ -0,0 +1,22 @@
+# Be sure to restart your server when you modify this file.
+
+# Your secret key is used for verifying the integrity of signed cookies.
+# If you change this key, all old signed cookies will become invalid!
+
+# Make sure the secret is at least 30 characters and all random,
+# no regular words or you'll be exposed to dictionary attacks.
+# You can use `rake secret` to generate a secure secret key.
+
+# Make sure the secrets in this file are kept private
+# if you're sharing your code publicly.
+
+development:
+  secret_key_base: a28312cb73c1f3bc98f5fa393a6d8347d067ef9c24ac90f40e8ea98315d448cfd0ebcf9079b04eb77358afd81522a521ddc1c5bc30b31d3cbf812ef904dd55a2
+
+test:
+  secret_key_base: 8fe67c730ce5c57f02cb83acf73e4d527b45e805639b2e9f56a6dc7cf579affa4838d75432903bbeb7f4766ec57d8392ff0f42e630615cbc2d564f8242a4471c
+
+# Do not keep production secrets in the repository,
+# instead read values from the environment.
+production:
+  secret_key_base: <%= ENV["SECRET_KEY_BASE"] %>

data/spec/features/console_reporter_spec.rb

@@ -43,18 +43,13 @@ feature "testing with teaspoon in the console", aruba: true do
 
     scenario "displays coverage information" do
       pending("needs istanbul to be installed") unless Teaspoon::Instrumentation.executable
-      pending("needs to be figured out")
-      # for some reason when loaded in the specs the instrumentation isn't working, though it is working in practice
-      #   confirmed that no data is coming through to Teaspoon::Coverage in the result reported by the console reporter
-      #   confirmed that instrument=true is being added to the asset source urls
-      # which means that our sprockets/rack shim doesn't work in this environment
       run_simple("bundle exec teaspoon -r ../../spec/teaspoon_env.rb --coverage=default app/assets/javascripts/integration/integration_spec.coffee", false)
 
       assert_partial_output("=============================== Coverage summary ===============================", all_output)
-      assert_partial_output("Statements   : 92.31% ( 12/13 )", all_output)
+      assert_partial_output("Statements   : 95.83% ( 23/24 )", all_output)
       assert_partial_output("Branches     : 100% ( 0/0 )", all_output)
-      assert_partial_output("Functions    : 75% ( 3/4 )", all_output)
-      assert_partial_output("Lines        : 92.31% ( 12/13 )", all_output)
+      assert_partial_output("Functions    : 92.31% ( 12/13 )", all_output)
+      assert_partial_output("Lines        : 95.83% ( 23/24 )", all_output)
       assert_partial_output("================================================================================", all_output)
     end
 

data/spec/features/hooks_spec.rb

@@ -8,11 +8,12 @@ feature "testing hooks in the browser" do
   let(:app) { Dummy::Application }
   let(:suites) {{
     "suite1" => {block: proc{ |suite| suite.hook :before, &proc{ File.write(temp_file, "") } }},
-    "suite2" => {block: proc{ |suite| suite.hook :after, &proc{ File.write(temp_file, "") } }}
+    "suite2" => {block: proc{ |suite| suite.hook :after, &proc{ File.write(temp_file, "") } }},
+    "suite3" => {block: proc{ |suite| suite.hook :with_arguments, &proc{ |args| File.write(temp_file, args["message"]) } }},
   }}
 
   before do
-    Teaspoon.configuration.stub(:suite_configs).and_return(suites)
+    allow(Teaspoon.configuration).to receive(:suite_configs).and_return(suites)
     FileUtils.mkdir_p('tmp')
     File.delete(temp_file) if File.exists?(temp_file)
     expect(File.exists?(temp_file)).to eql(false)
@@ -28,7 +29,7 @@ feature "testing hooks in the browser" do
 
     scenario "gives me the expected results" do
       post("/teaspoon/suite1/before")
-      expect(File.exists?(temp_file)).to be_true
+      expect(File.exists?(temp_file)).to be_truthy
     end
 
   end
@@ -39,9 +40,21 @@ feature "testing hooks in the browser" do
 
     scenario "gives me the expected results" do
       post("/teaspoon/suite2/after")
-      expect(File.exists?(temp_file)).to be_true
+      expect(File.exists?(temp_file)).to be_truthy
     end
 
   end
 
+  describe "requesting a before hook with arguments (using POST)" do
+    let(:temp_file) { "tmp/before_hook_test" }
+    let(:message) { "Hello World" }
+    let(:params) do
+      { args: { message: message } }
+    end
+
+    scenario "gives me the expected results" do
+      post("/teaspoon/suite3/with_arguments", params)
+      expect(File.open(temp_file).gets.chomp).to eq(message)
+    end
+  end
 end

data/spec/features/html_reporter_spec.rb

@@ -5,12 +5,23 @@ feature "testing with teaspoon in the browser", js: true do
   let(:spec_helper) { nil }
 
   before do
-    Teaspoon.configuration.stub(:suite_configs).and_return "integration" => {block: proc{ |suite|
+    Teaspoon::Suite.instance_variable_set(:@all, nil)
+    allow(Teaspoon.configuration).to receive(:suite_configs).and_return "integration" => {block: proc{ |suite|
       suite.matcher = "spec/dummy/app/assets/javascripts/integration/*_spec.{js,js.coffee,coffee}"
       suite.helper = spec_helper
     }}
   end
 
+  scenario "lists the suites" do
+    visit "/teaspoon"
+
+    within("#teaspoon-suite-list") do
+      expect(page).to have_text("integration")
+      expect(page).to have_text("integration/integration_spec.js")
+    end
+
+  end
+
   scenario "gives me the expected results" do
     visit "/teaspoon/integration"
 

data/spec/features/install_generator_spec.rb

@@ -7,7 +7,7 @@ feature "Installation", aruba: true do
     run_simple("bundle exec rails new testapp --skip-bundle")
     cd("testapp")
     append_to_file("Gemfile", %{\ngem "teaspoon", path: "#{File.expand_path('../../../', __FILE__)}"\n})
-    run_simple("bundle install --local")
+    run_simple("bundle install")
   end
 
   describe "running the generator" do
@@ -46,8 +46,7 @@ feature "Installation", aruba: true do
     scenario "installs using the mocha framework" do
       run_simple("bundle exec rails generate teaspoon:install --trace --framework=mocha")
 
-      check_file_content("spec/teaspoon_env.rb", %{    suite.use_framework :mocha}, true)
-      check_file_content("spec/teaspoon_env.rb", %{    #suite.javascripts = ["mocha/1.17.1", "teaspoon-mocha"]}, true)
+      check_file_content("spec/teaspoon_env.rb", %r{suite\.use_framework :mocha}, true)
     end
 
   end

data/spec/features/instrumentation_spec.rb

@@ -6,16 +6,16 @@ feature "instrumenting javascript" do
     pending("needs istanbul to be installed") unless Teaspoon::Instrumentation.executable
   end
 
-  scenario "requesting with instrument=true adds istanbul instrumentation" do
-    pending("needs to be figured out")
-    visit "/assets/instrumented1.js?instrument=true"
-    expect(html).to include("if (typeof __coverage__ === 'undefined') { __coverage__ = {}; }")
-  end
-
-  scenario "requesting without instrument=true doesn't do anything" do
-    pending("needs to be figured out")
-    visit "/assets/instrumented2.js?instrument=false"
-    expect(html).to_not include("if (typeof __coverage__ === 'undefined') { __coverage__ = {}; }")
-  end
+  #scenario "requesting with instrument=true adds istanbul instrumentation" do
+  #  pending("needs to be figured out")
+  #  visit "/assets/instrumented1.js?instrument=true"
+  #  expect(html).to include("if (typeof __coverage__ === 'undefined') { __coverage__ = {}; }")
+  #end
+  #
+  #scenario "requesting without instrument=true doesn't do anything" do
+  #  pending("needs to be figured out")
+  #  visit "/assets/instrumented2.js?instrument=false"
+  #  expect(html).to_not include("if (typeof __coverage__ === 'undefined') { __coverage__ = {}; }")
+  #end
 
 end

data/spec/javascripts/teaspoon/base/teaspoon_spec.coffee

@@ -24,7 +24,7 @@ describe "Teaspoon", ->
       spyOn(Teaspoon, 'reload')
       @spy = spyOn(Teaspoon, "Runner")
 
-    it "allows defering (thus not instantiating the runner)", ->
+    it "allows deferring (thus not instantiating the runner)", ->
       Teaspoon.defer = true
       Teaspoon.execute()
       expect(@spy).wasNotCalled()
@@ -32,3 +32,16 @@ describe "Teaspoon", ->
     it "will execute if it should", ->
       Teaspoon.execute()
       expect(@spy).toHaveBeenCalled()
+
+
+  describe ".hook", ->
+
+    beforeEach ->
+      @xhr = jasmine.createSpyObj("xhr", ["open", "setRequestHeader", "send"])
+      spyOn(window, "XMLHttpRequest").andReturn(@xhr)
+
+    it "makes the proper ajax request", ->
+      Teaspoon.hook("foo", {bar: "baz"})
+      expect(@xhr.open).toHaveBeenCalledWith("POST", "/teaspoon/default/foo", false)
+      expect(@xhr.setRequestHeader).toHaveBeenCalledWith("Content-Type", "application/json")
+      expect(@xhr.send).toHaveBeenCalledWith('{"args":{"bar":"baz"}}')

data/spec/spec_helper.rb

@@ -1,12 +1,11 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
 ENV["RAILS_ENV"] ||= "test"
 ENV["RAILS_ROOT"] = File.expand_path("../dummy", __FILE__)
 require File.expand_path("../dummy/config/environment", __FILE__)
 
-require "coveralls"
-Coveralls.wear!
-
 require "rspec/rails"
-require "rspec/autorun"
 require "capybara/rails"
 require "aruba/api"
 
@@ -19,4 +18,8 @@ RSpec.configure do |config|
   config.order = "random"
 
   config.run_all_when_everything_filtered = true
+
+  config.mock_with :rspec do |c|
+    c.syntax = :expect
+  end
 end

data/spec/teaspoon/command_line_spec.rb

@@ -22,9 +22,9 @@ describe Teaspoon::CommandLine do
   describe "#initialize" do
 
     before do
-      Teaspoon::Console.stub(:new).and_return(console)
-      subject.any_instance.stub(:abort)
-      subject.any_instance.stub(:opt_parser).and_return(parser)
+      allow(Teaspoon::Console).to receive(:new).and_return(console)
+      allow_any_instance_of(subject).to receive(:abort)
+      allow_any_instance_of(subject).to receive(:opt_parser).and_return(parser)
     end
 
     it "assigns @options and adds the files that were parsed out" do
@@ -32,28 +32,28 @@ describe Teaspoon::CommandLine do
     end
 
     it "aborts with a message on Teaspoon::EnvironmentNotFound" do
-      Teaspoon::Console.should_receive(:new).and_raise(Teaspoon::EnvironmentNotFound)
-      subject.any_instance.should_receive(:abort).with("Teaspoon::EnvironmentNotFound\nConsider using -r path/to/teaspoon_env\n")
+      expect(Teaspoon::Console).to receive(:new).and_raise(Teaspoon::EnvironmentNotFound)
+      expect_any_instance_of(subject).to receive(:abort).with("Teaspoon::EnvironmentNotFound\nConsider using -r path/to/teaspoon_env\n")
       subject.new
     end
 
     it "executes using Teaspoon::Console" do
-      Teaspoon::Console.should_receive(:new).with(files: ["file1", "file2"])
-      console.should_receive(:failures?)
+      expect(Teaspoon::Console).to receive(:new).with(files: ["file1", "file2"])
+      expect(console).to receive(:failures?)
       subject.new
     end
 
     it "aborts if Teaspoon::Console fails" do
-      subject.any_instance.should_receive(:abort)
-      console.should_receive(:failures?).and_return(true)
+      expect_any_instance_of(subject).to receive(:abort)
+      expect(console).to receive(:failures?).and_return(true)
       subject.new
     end
 
     it "logs a message and exits on abort" do
-      STDOUT.should_receive(:print).with("Teaspoon::EnvironmentNotFound\nConsider using -r path/to/teaspoon_env\n")
-      Teaspoon::Console.should_receive(:new).and_raise(Teaspoon::EnvironmentNotFound)
-      subject.any_instance.should_receive(:abort).and_call_original
-      expect { subject.new }.to raise_error SystemExit
+      expect(STDOUT).to receive(:print).with("Teaspoon::EnvironmentNotFound\nConsider using -r path/to/teaspoon_env\n")
+      expect(Teaspoon::Console).to receive(:new).and_raise(Teaspoon::EnvironmentNotFound)
+      expect_any_instance_of(subject).to receive(:abort).and_call_original
+      expect { subject.new }.to raise_error(SystemExit)
     end
 
   end
@@ -62,13 +62,13 @@ describe Teaspoon::CommandLine do
 
     before do
       @log = ""
-      STDOUT.stub(:print) { |s| @log << s }
-      Teaspoon::Console.stub(:new).and_return(console)
+      allow(STDOUT).to receive(:print) { |s| @log << s }
+      allow(Teaspoon::Console).to receive(:new).and_return(console)
     end
 
     it "has --help" do
       suppress_warnings { ARGV = ["--help"] }
-      expect { subject.new.opt_parser }.to raise_error SystemExit
+      expect { subject.new.opt_parser }.to raise_error(SystemExit)
       expect(@log).to include <<-OUTPUT.strip_heredoc
       Usage: teaspoon [options] [files]
 
@@ -76,6 +76,7 @@ describe Teaspoon::CommandLine do
           -d, --driver DRIVER              Specify driver:
                                              phantomjs (default)
                                              selenium
+                                             capybara_webkit
               --driver-options OPTIONS     Specify driver-specific options to pass into the driver.
                                              e.g. "--ssl-protocol=any --ssl-certificates-path=/path/to/certs".
                                              Driver options are only supported with phantomjs.
@@ -97,17 +98,7 @@ describe Teaspoon::CommandLine do
           -c, --[no-]color                 Enable/Disable color output.
           -e, --export [OUTPUT_PATH]       Exports the test suite as the full HTML (requires wget).
           -f, --format FORMATTERS          Specify formatters (comma separated)
-                                             dot (default) - dots
-                                             documentation - descriptive documentation
-                                             clean - like dots but doesn't log re-run commands
-                                             json - json formatter (raw teaspoon)
-                                             junit - junit compatible formatter
-                                             pride - yay rainbows!
-                                             snowday - makes you feel warm inside
-                                             swayze_or_oprah - quote from either Patrick Swayze or Oprah Winfrey
-                                             tap - test anything protocol formatter
-                                             tap_y - tap_yaml, format used by tapout
-                                             teamcity - teamcity compatible formatter
+                                           #{Teaspoon::Formatters.known_formatters.map(&:cli_help).join("\n" + (" " * 43))}
 
         **** Coverage ****
 
@@ -122,7 +113,7 @@ describe Teaspoon::CommandLine do
 
     it "has --version" do
       suppress_warnings { ARGV = ["--version"] }
-      expect { subject.new.opt_parser }.to raise_error SystemExit
+      expect { subject.new.opt_parser }.to raise_error(SystemExit)
       expect(@log).to match(/\d+\.\d+\.\d+\n/)
     end