teamlab 0.3.16 → 0.4.0

data/lib/teamlab.rb

@@ -1,19 +1,19 @@
 require_relative 'teamlab/version'
-require_relative 'teamlab/Config'
-require_relative 'teamlab/Request'
-require_relative 'teamlab/Response'
-require_relative 'teamlab/Modules/People'
-require_relative 'teamlab/Modules/Group'
-require_relative 'teamlab/Modules/Settings'
-require_relative 'teamlab/Modules/Files'
-require_relative 'teamlab/Modules/Project'
-require_relative 'teamlab/Modules/Crm'
-require_relative 'teamlab/Modules/Community'
-require_relative 'teamlab/Modules/Calendar'
-require_relative 'teamlab/Modules/Mail'
+require_relative 'teamlab/config'
+require_relative 'teamlab/request'
+require_relative 'teamlab/response'
+require_relative 'teamlab/modules/people'
+require_relative 'teamlab/modules/group'
+require_relative 'teamlab/modules/settings'
+require_relative 'teamlab/modules/files'
+require_relative 'teamlab/modules/project'
+require_relative 'teamlab/modules/portals'
+require_relative 'teamlab/modules/crm'
+require_relative 'teamlab/modules/community'
+require_relative 'teamlab/modules/calendar'
+require_relative 'teamlab/modules/mail'
 
 module Teamlab
-
   def self.people
     @people ||= Teamlab::People.new
   end
@@ -34,6 +34,10 @@ module Teamlab
     @project ||= Teamlab::Project.new
   end
 
+  def self.portal
+    @portal ||= Teamlab::Portal.new
+  end
+
   def self.crm
     @crm ||= Teamlab::Crm.new
   end
@@ -49,4 +53,4 @@ module Teamlab
   def self.mail
     @mail ||= Teamlab::Mail.new
   end
-end
+end

data/spec/lib/calendar_spec.rb

@@ -1,7 +1,6 @@
 require_relative '../spec_helper'
 
 describe '[Calendar]' do
-
   let(:teamlab_module) { :calendar }
 
   before :all do
@@ -47,7 +46,7 @@ describe '[Calendar]' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_event }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:calendar_ids][i += 1], random_word, {description: random_word, startDate: DateTime.now, endDate: DateTime.now, repeatType: '', alertType: '-1', isAllDayLong: false}] }
+      let(:args) { [DATA_COLLECTOR[:calendar_ids][i += 1], random_word, { description: random_word, startDate: DateTime.now, endDate: DateTime.now, repeatType: '', alertType: '-1', isAllDayLong: false }] }
       let(:add_data_to_collector) { true }
       let(:data_param) { :event_ids }
       let(:param_names) { %w(objectId) }
@@ -119,7 +118,7 @@ describe '[Calendar]' do
   describe '#update_calendar_user_view' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_calendar_user_view }
-      let(:args) { [random_id(:calendar), random_word, TIME_ZONES.sample, {textColor: 'red', backgroundColor: 'blue'}] }
+      let(:args) { [random_id(:calendar), random_word, TIME_ZONES.sample, { textColor: 'red', backgroundColor: 'blue' }] }
     end
   end
 

data/spec/lib/community_spec.rb

@@ -1,7 +1,6 @@
 require_relative '../spec_helper'
 
 describe '[Community]' do
-
   let(:teamlab_module) { :community }
 
   before :all do
@@ -35,7 +34,7 @@ describe '[Community]' do
   describe '#add_bookmark' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_bookmark }
-      let(:args) { [SOME_URL, random_word, {tags: [random_word(4), random_word(4), random_word(4)].join(', ')}] }
+      let(:args) { [SOME_URL, random_word, { tags: [random_word(4), random_word(4), random_word(4)].join(', ') }] }
       let(:add_data_to_collector) { true }
       let(:data_param) { :bookmark_ids }
       let(:param_names) { %w(id) }
@@ -65,7 +64,7 @@ describe '[Community]' do
   describe '#create_poll' do
     it_should_behave_like 'an api request' do
       let(:command) { :create_event }
-      let(:args) { [random_word, random_word, {type: 'Poll'}] }
+      let(:args) { [random_word, random_word, { type: 'Poll' }] }
       let(:add_data_to_collector) { true }
       let(:data_param) { :poll_ids }
       let(:param_names) { %w(id) }
@@ -138,7 +137,7 @@ describe '[Community]' do
   describe '#update_post' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_post }
-      let(:args) { [random_id(:community_post), random_word, random_word, {tags: [random_word(4), random_word(4), random_word(4)].join(',')}] }
+      let(:args) { [random_id(:community_post), random_word, random_word, { tags: [random_word(4), random_word(4), random_word(4)].join(',') }] }
     end
   end
 

data/spec/lib/crm_spec.rb

@@ -178,7 +178,7 @@ describe '[CRM]' do
     end
   end
 
-  #describe '#create_task_group' do
+  # describe '#create_task_group' do
   #  it_should_behave_like 'an api request' do
   #    let(:command) { :create_task_group }
   #    let(:args) { [random_word] }
@@ -186,7 +186,7 @@ describe '[CRM]' do
   #    let(:data_param) { :task_group_ids }
   #    let(:param_names) { %w(id) }
   #  end
-  #end
+  # end
 
   describe '#update_history_category' do
     it_should_behave_like 'an api request' do
@@ -244,7 +244,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_contact_info }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i+=1], info_type = CONTACT_INFO_TYPES.sample, random_word, random_info_category(info_type)] }
+      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i += 1], info_type = CONTACT_INFO_TYPES.sample, random_word, random_info_category(info_type)] }
       let(:add_data_to_collector) { true }
       let(:data_param) { :contact_info_ids }
       let(:param_names) { %w(id) }
@@ -253,7 +253,6 @@ describe '[CRM]' do
 
   describe '#quick_person_list_creation' do
     it_should_behave_like 'an api request' do
-      pending ('http://bugzserver/show_bug.cgi?id=23997')
       let(:command) { :quick_person_list_creation }
       let(:args) { [[[random_word, random_word], [random_word, random_word]]] }
     end
@@ -263,7 +262,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_opportunity_contact }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:opportunity_ids].last, DATA_COLLECTOR[:new_contact_ids][i+=1]] }
+      let(:args) { [DATA_COLLECTOR[:opportunity_ids].last, DATA_COLLECTOR[:new_contact_ids][i += 1]] }
     end
   end
 
@@ -488,7 +487,7 @@ describe '[CRM]' do
   describe '#add_tag_to_batch_contacts' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_tag_to_batch_contacts }
-      let(:args) { [(1..rand(1..4)).map {random_word(rand(3..6))}] }
+      let(:args) { [(1..rand(1..4)).map { random_word(rand(3..6)) }] }
     end
   end
 
@@ -509,7 +508,7 @@ describe '[CRM]' do
   describe '#set_is_portal_configured' do
     it_should_behave_like 'an api request' do
       let(:command) { :set_is_portal_configured }
-      let(:args) { [{configured: random_bool}] }
+      let(:args) { [{ configured: random_bool }] }
     end
   end
 
@@ -547,7 +546,7 @@ describe '[CRM]' do
   describe '#update_contact_status' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_contact_status }
-      let(:args) { [random_id(:contact_status), random_word, {color: COLORS_NAMES.sample}] }
+      let(:args) { [random_id(:contact_status), random_word, { color: COLORS_NAMES.sample }] }
     end
   end
 
@@ -632,12 +631,12 @@ describe '[CRM]' do
     end
   end
 
-  #describe '#change_contact_photo' do
+  # describe '#change_contact_photo' do
   #  it_should_behave_like 'an api request' do
   #    let(:command) { :change_contact_photo }
   #    let(:args) { [random_id(:new_contact), 'path_to_image'] }
   #  end
-  #end
+  # end
 
   describe '#update_person_and_its_company_status' do
     it_should_behave_like 'an api request' do
@@ -713,7 +712,7 @@ describe '[CRM]' do
 
   describe '#get_contact_upcoming_tasks' do
     it_should_behave_like 'an api request' do
-      #pending 'http://bugzserver/show_bug.cgi?id=23925'
+      # pending 'http://bugzserver/show_bug.cgi?id=23925'
       let(:command) { :get_contact_upcoming_tasks }
       let(:args) { [random_id(:new_contact)] }
     end
@@ -784,7 +783,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_persons_to_company }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:company_ids].last, DATA_COLLECTOR[:new_contact_ids][i+=1]] }
+      let(:args) { [DATA_COLLECTOR[:company_ids].last, DATA_COLLECTOR[:new_contact_ids][i += 1]] }
     end
   end
 
@@ -849,7 +848,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :add_contact_address }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i+=1], random_info_category('Address'), random_word] }
+      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i += 1], random_info_category('Address'), random_word] }
       let(:add_data_to_collector) { true }
       let(:data_param) { :contact_address_ids }
       let(:param_names) { %w() }
@@ -888,28 +887,28 @@ describe '[CRM]' do
   describe '#set_contact_access_rights' do
     it_should_behave_like 'an api request' do
       let(:command) { :set_contact_access_rights }
-      let(:args) { [ random_id(:new_contact) ] }
+      let(:args) { [random_id(:new_contact)] }
     end
   end
 
   describe '#update_company' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_company }
-      let(:args) { [ random_id(:company), random_word ] }
+      let(:args) { [random_id(:company), random_word] }
     end
   end
 
   describe '#update_contact_info' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_contact_info }
-      let(:args) { [ random_id(:contact_info), random_id(:new_contact), random_word ] }
+      let(:args) { [random_id(:contact_info), random_id(:new_contact), random_word] }
     end
   end
 
   describe '#change_contact_photo_by_url' do
     it_should_behave_like 'an api request' do
       let(:command) { :change_contact_photo_by_url }
-      let(:args) { [ random_id(:new_contact), IMAGE_URL ] }
+      let(:args) { [random_id(:new_contact), IMAGE_URL] }
     end
   end
 
@@ -917,7 +916,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       pending('http://bugzserver/show_bug.cgi?id=24002')
       let(:command) { :update_contact_address }
-      let(:args) { [ random_id(:new_contact), random_id(:contact_address), random_word ] }
+      let(:args) { [random_id(:new_contact), random_id(:contact_address), random_word] }
     end
   end
 
@@ -1094,7 +1093,7 @@ describe '[CRM]' do
   describe '#set_case_access_rights' do
     it_should_behave_like 'an api request' do
       let(:command) { :set_case_access_rights }
-      let(:args) { [random_id(:crm_case), {isPrivate: random_bool}] }
+      let(:args) { [random_id(:crm_case), { isPrivate: random_bool }] }
     end
   end
 
@@ -1108,7 +1107,7 @@ describe '[CRM]' do
   describe '#set_case_access_rights_by_filter' do
     it_should_behave_like 'an api request' do
       let(:command) { :set_case_access_rights_by_filter }
-      let(:args) { [{contactId: random_id(:new_contact), isPrivate: random_bool}] }
+      let(:args) { [{ contactId: random_id(:new_contact), isPrivate: random_bool }] }
     end
   end
 
@@ -1245,7 +1244,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :delete_opportunity_contact }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:opportunity_ids].last, DATA_COLLECTOR[:new_contact_ids][i+=1]] }
+      let(:args) { [DATA_COLLECTOR[:opportunity_ids].last, DATA_COLLECTOR[:new_contact_ids][i += 1]] }
     end
   end
 
@@ -1268,7 +1267,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       pending 'http://bugzserver/show_bug.cgi?id=23902'
       let(:command) { :delete_batch_contacts_by_filter }
-      let(:args) { [{tags: [random_word(4)]}] }
+      let(:args) { [{ tags: [random_word(4)] }] }
     end
   end
 
@@ -1319,7 +1318,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :delete_person_from_company }
       i = -1
-      let(:args) { [ DATA_COLLECTOR[:company_ids].last, DATA_COLLECTOR[:new_contact_ids][i+=1]] }
+      let(:args) { [DATA_COLLECTOR[:company_ids].last, DATA_COLLECTOR[:new_contact_ids][i += 1]] }
     end
   end
 
@@ -1328,14 +1327,14 @@ describe '[CRM]' do
       pending 'http://bugzserver/show_bug.cgi?id=24028'
       let(:command) { :delete_contact_address }
       i = -1
-      let(:args) { [ DATA_COLLECTOR[:new_contact_ids][i+=1], DATA_COLLECTOR[:contact_address_ids].shift ] }
+      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i += 1], DATA_COLLECTOR[:contact_address_ids].shift] }
     end
   end
 
   describe '#remove_contact_from_project' do
     it_should_behave_like 'an api request' do
       let(:command) { :remove_contact_from_project }
-      let(:args) { [ random_id(:new_contact), random_id(:project)] }
+      let(:args) { [random_id(:new_contact), random_id(:project)] }
     end
   end
 
@@ -1350,7 +1349,7 @@ describe '[CRM]' do
     it_should_behave_like 'an api request' do
       let(:command) { :delete_contact_info }
       i = -1
-      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i+=1], DATA_COLLECTOR[:contact_info_ids][i]] }
+      let(:args) { [DATA_COLLECTOR[:new_contact_ids][i += 1], DATA_COLLECTOR[:contact_info_ids][i]] }
     end
   end
 

data/spec/lib/files_spec.rb

@@ -24,9 +24,9 @@ describe '[Files]' do
   describe '#get_my_files' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_my_files }
-      #let(:add_data_to_collector) { true }
-      #let(:data_param) {:my_documents_ids}
-      #let(:param_names) {%w(current id)}
+      # let(:add_data_to_collector) { true }
+      # let(:data_param) {:my_documents_ids}
+      # let(:param_names) {%w(current id)}
     end
   end
 
@@ -34,8 +34,8 @@ describe '[Files]' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_trash }
       let(:add_data_to_collector) { true }
-      let(:data_param) {:trash_documents_ids}
-      let(:param_names) {%w(current id)}
+      let(:data_param) { :trash_documents_ids }
+      let(:param_names) { %w(current id) }
     end
   end
 
@@ -43,8 +43,8 @@ describe '[Files]' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_shared_docs }
       let(:add_data_to_collector) { true }
-      let(:data_param) {:shared_documents_ids}
-      let(:param_names) {%w(current id)}
+      let(:data_param) { :shared_documents_ids }
+      let(:param_names) { %w(current id) }
     end
   end
 
@@ -52,8 +52,8 @@ describe '[Files]' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_common_docs }
       let(:add_data_to_collector) { true }
-      let(:data_param) {:common_documents_ids}
-      let(:param_names) {%w(current id)}
+      let(:data_param) { :common_documents_ids }
+      let(:param_names) { %w(current id) }
     end
   end
 
@@ -62,8 +62,8 @@ describe '[Files]' do
       let(:command) { :new_folder }
       let(:args) { [random_id(:my_documents), random_word] }
       let(:add_data_to_collector) { true }
-      let(:data_param) {:new_folder_ids}
-      let(:param_names) {%w(current id)}
+      let(:data_param) { :new_folder_ids }
+      let(:param_names) { %w(current id) }
     end
   end
 
@@ -93,8 +93,8 @@ describe '[Files]' do
       let(:command) { :create_file }
       let(:args) { [random_id(:new_folder), random_word] }
       let(:add_data_to_collector) { true }
-      let(:data_param) {:new_file_ids}
-      let(:param_names) {%w(id)}
+      let(:data_param) { :new_file_ids }
+      let(:param_names) { %w(id) }
     end
   end
 
@@ -205,21 +205,21 @@ describe '[Files]' do
   describe '#move_files' do
     it_should_behave_like 'an api request' do
       let(:command) { :move_files }
-      let(:args) { [random_id(:new_folder), { fileids: DATA_COLLECTOR[:new_file_ids].sample(rand(1..4)), overwrite: random_bool}] }
+      let(:args) { [random_id(:new_folder), { fileids: DATA_COLLECTOR[:new_file_ids].sample(rand(1..4)), overwrite: random_bool }] }
     end
   end
 
   describe '#copy_to_folder' do
     it_should_behave_like 'an api request' do
       let(:command) { :copy_to_folder }
-      let(:args) { [random_id(:new_folder), { fileids: DATA_COLLECTOR[:new_file_ids].sample(rand(1..4)), overwrite: random_bool}] }
+      let(:args) { [random_id(:new_folder), { fileids: DATA_COLLECTOR[:new_file_ids].sample(rand(1..4)), overwrite: random_bool }] }
     end
   end
 
   describe '#delete' do
     it_should_behave_like 'an api request' do
       let(:command) { :delete }
-      let(:args) { [ folderIds: [], fileids: [] ] }
+      let(:args) { [folderIds: [], fileids: []] }
     end
   end
 
@@ -238,7 +238,7 @@ describe '[Files]' do
   describe '#finish_operations' do
     it_should_behave_like 'an api request' do
       let(:command) { :finish_operations }
-      let(:args) { [ folderIds: [random_id(:new_folder)], fileids: [random_id(:new_file)] ] }
+      let(:args) { [folderIds: [random_id(:new_folder)], fileids: [random_id(:new_file)]] }
     end
   end
 
@@ -273,14 +273,14 @@ describe '[Files]' do
   describe '#remove_file_sharing_rights' do
     it_should_behave_like 'an api request' do
       let(:command) { :remove_file_sharing_rights }
-      let(:args) { [ random_id(:new_file), [random_id(:user)] ] }
+      let(:args) { [random_id(:new_file), [random_id(:user)]] }
     end
   end
 
   describe '#remove_folder_sharing_rights' do
     it_should_behave_like 'an api request' do
       let(:command) { :remove_folder_sharing_rights }
-      let(:args) { [ random_id(:new_folder), [random_id(:user)] ] }
+      let(:args) { [random_id(:new_folder), [random_id(:user)]] }
     end
   end
 

data/spec/lib/group_spec.rb

@@ -33,8 +33,8 @@ describe '[Group]' do
       let(:command) { :add_group }
       let(:args) { [random_id(:user), random_word, DATA_COLLECTOR[:user_ids]] }
       let(:add_data_to_collector) { true }
-      let(:data_param) {:group_ids}
-      let(:param_names) {%w(id)}
+      let(:data_param) { :group_ids }
+      let(:param_names) { %w(id) }
     end
   end
 

data/spec/lib/mail_spec.rb

@@ -1,7 +1,6 @@
 require_relative '../spec_helper'
 
 describe '[Mail]' do
-
   let(:teamlab_module) { :mail }
 
   before :all do
@@ -15,7 +14,7 @@ describe '[Mail]' do
   describe '#create_tag' do
     it_should_behave_like 'an api request' do
       let(:command) { :create_tag }
-      let(:args) { [random_word(4), {style: rand(15)}] }
+      let(:args) { [random_word(4), { style: rand(15) }] }
     end
   end
 
@@ -36,7 +35,7 @@ describe '[Mail]' do
   describe '#get_message' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_message }
-      let(:args) {message_id}
+      let(:args) { message_id }
     end
   end
 

data/spec/lib/people_spec.rb

@@ -33,7 +33,7 @@ describe '[People]' do
   describe '#filter' do
     it_should_behave_like 'an api request' do
       let(:command) { :filter_people }
-      let(:args) { [{activationStatus: 1}] }
+      let(:args) { [{ activationStatus: 1 }] }
     end
   end
 
@@ -109,7 +109,7 @@ describe '[People]' do
   describe '#update_user' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_user }
-      let(:args) { [random_id(:new_user), random_bool, random_email, random_word, random_word, {comment: random_word}] }
+      let(:args) { [random_id(:new_user), random_bool, random_email, random_word, random_word, { comment: random_word }] }
     end
   end
 

data/spec/lib/portal_spec.rb

@@ -0,0 +1,25 @@
+require_relative '../spec_helper'
+
+describe '[Portals]' do
+  before :all do
+    Teamlab.configure do |config|
+      config.server = SERVER
+      config.username = USERNAME
+      config.password = PASSWORD
+    end
+  end
+
+  let(:teamlab_module) { :portal }
+
+  describe '#invite_user_url' do
+    it_should_behave_like 'an api request' do
+      let(:command) { :invite_user_url }
+    end
+  end
+
+  describe '#invite_visitor_url' do
+    it_should_behave_like 'an api request' do
+      let(:command) { :invite_visitor_url }
+    end
+  end
+end

data/spec/lib/project_spec.rb

@@ -1,7 +1,6 @@
 require_relative '../spec_helper'
 
 describe '[Project]' do
-
   before :all do
     Teamlab.configure do |config|
       config.server = SERVER
@@ -78,7 +77,7 @@ describe '[Project]' do
   describe '#create_project' do
     it_should_behave_like 'an api request' do
       let(:command) { :create_project }
-      let(:args) { [random_word, random_word, random_id(:user), random_word(3), random_bool, {participants: DATA_COLLECTOR[:user_ids]}] }
+      let(:args) { [random_word, random_word, random_id(:user), random_word(3), random_bool, { participants: DATA_COLLECTOR[:user_ids] }] }
       let(:add_data_to_collector) { true }
       let(:data_param) { :new_project_ids }
       let(:param_names) { %w(id) }
@@ -195,7 +194,7 @@ describe '[Project]' do
   describe '#get_message_by_filter' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_message_by_filter }
-      let(:args) { [{projectId: random_id(:new_project)}] }
+      let(:args) { [{ projectId: random_id(:new_project) }] }
     end
   end
 
@@ -461,7 +460,7 @@ describe '[Project]' do
   describe '#update_project' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_project }
-      let(:args) { [random_id(:new_project), random_word, random_id(:user), {private: random_bool, notify: random_bool}] }
+      let(:args) { [random_id(:new_project), random_word, random_id(:user), { private: random_bool, notify: random_bool }] }
     end
   end
 
@@ -503,7 +502,7 @@ describe '[Project]' do
   describe '#update_project_team' do
     it_should_behave_like 'an api request' do
       let(:command) { :update_project_team }
-      let(:args) { [random_id(:new_project), DATA_COLLECTOR[:user_ids].sample(rand(2..4)), {notify: random_bool}] }
+      let(:args) { [random_id(:new_project), DATA_COLLECTOR[:user_ids].sample(rand(2..4)), { notify: random_bool }] }
     end
   end
 
@@ -530,7 +529,7 @@ describe '[Project]' do
   describe '#get_task_by_filter' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_task_by_filter }
-      let(:args) { [{participant: random_id(:user)}] }
+      let(:args) { [{ participant: random_id(:user) }] }
     end
   end
 
@@ -655,7 +654,7 @@ describe '[Project]' do
   describe '#get_milestones_by_filter' do
     it_should_behave_like 'an api request' do
       let(:command) { :get_milestones_by_filter }
-      let(:args) { [{projectid: random_id(:new_project)}] }
+      let(:args) { [{ projectid: random_id(:new_project) }] }
     end
   end
 
@@ -803,5 +802,4 @@ describe '[Project]' do
       let(:args) { [DATA_COLLECTOR[:project_template_ids].pop] }
     end
   end
-
 end

data/spec/lib/settings_spec.rb

@@ -36,7 +36,7 @@ describe '[Settings]' do
 
   describe '#get_ldap_settings' do
     it_should_behave_like 'an api request', :pending do
-    pending 'only for self-hosted, error 500 when running on saas portal'
+      pending 'only for self-hosted, error 500 when running on saas portal'
       let(:command) { :get_ldap_settings }
     end
   end
@@ -97,7 +97,7 @@ describe '[Settings]' do
   describe '#set_security' do
     it_should_behave_like 'an api request' do
       let(:command) { :set_security }
-      let(:args) { [random_settings_entity_id, {enabled: random_bool}] }
+      let(:args) { [random_settings_entity_id, { enabled: random_bool }] }
     end
   end
 

data/spec/lib/{Teamlab_spec.rb → teamlab_spec.rb}

@@ -1,7 +1,6 @@
 require_relative '../spec_helper'
 
 describe Teamlab do
-
   before :all do
     Teamlab.configure do |config|
       config.server = SERVER
@@ -76,10 +75,7 @@ describe Teamlab do
     end
   end
 
-
-
   describe 'Cleaning enviroment' do
-
     describe '#delete_file' do
       it_should_behave_like 'an api request' do
         let(:teamlab_module) { :files }
@@ -104,4 +100,4 @@ describe Teamlab do
       end
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -12,13 +12,12 @@ shared_examples_for 'an api request' do |*flags|
       DATA_COLLECTOR[data_param] ||= []
       response = [@response.body['response']].flatten
       response.each do |cur_response|
-        DATA_COLLECTOR[data_param] << param_names.inject(cur_response) { |resp, param| resp[param] }
+        DATA_COLLECTOR[data_param] << param_names.inject(cur_response) { |a, e| a[e] }
       end
     end
   end
 
   context 'Successful api request' do
-
     it 'returns Teamlab::Response object' do
       expect(@response).to be_instance_of(Teamlab::Response)
     end