teamcity-ruby-client 0.4.0 → 1.0.0

data/spec/teamcity/client/buildtypes_spec.rb

@@ -13,28 +13,25 @@ describe 'BuildTypes' do
   # Get requests
   describe 'GET', :vcr do
 
-    before(:all) do
+    before(:each) do
+      TeamCity.reset
       TeamCity.configure do |config|
-        config.endpoint = 'http://localhost:8111/guestAuth/app/rest/7.0/'
+        config.endpoint = 'http://localhost:8111/guestAuth/app/rest'
       end
-    end
-
-    before(:each) do
       @tc = TeamCity
     end
 
     describe '.buildtypes' do
-
       it 'should fetch all the buildtypes' do
-        @tc.buildtypes.size.should eq(3)
+        build_types = @tc.buildtypes
+        build_types.should_not be_empty
       end
-
     end
 
     describe '.buildtype' do
-
       it 'should fetch the details of a buildtype by id' do
-        @tc.buildtype(id: 'bt2').id.should eq('bt2')
+        build_type = @tc.buildtypes[0]
+        @tc.buildtype(id: build_type.id).id.should_not be_empty
       end
 
       it 'should raise an error if the buildtype does not exist' do
@@ -48,32 +45,33 @@ describe 'BuildTypes' do
 
     describe '.buildtype_state' do
       it 'should fetch the state of the buildtype' do
-        pending "bug in rest api plugin"
-        @tc.buildtype_state(id: 'bt2')
+        build_type = @tc.buildtypes[0]
+        @tc.buildtype_state(id: build_type.id).should eq('false')
       end
     end
 
     describe '.buildtype_settings' do
+
+      before(:each) do
+        @build_type = @tc.buildtypes[0]
+      end
+
       it 'should fetch the settings for a given buildtype' do
-        @tc.buildtype_settings(id: 'bt2').should have_at_least(1).items
+        @tc.buildtype_settings(id: @build_type.id).should_not be_empty
       end
 
       it 'should return an array' do
-        @tc.buildtype_settings(id: 'bt2').should be_kind_of(Array)
+        @tc.buildtype_settings(id: @build_type.id).should be_kind_of(Array)
       end
     end
 
     describe '.buildtype_template' do
       it 'should return the attributes of the associated template' do
-        @tc.buildtype_template(id: 'bt2').id.should_not be_nil
+        @tc.buildtype_template(id: 'BuildTypeTests_BuildTypeWithTemplate').id.should_not be_nil
       end
 
       it 'should return nil if the buildtype is not associated with a template' do
-        @tc.buildtype_template(id: 'bt3').should be_nil
-      end
-
-      it 'should raise an exception if the response is not due to a template not assigned' do
-        expect { @tc.buildtype_template(id: 'bt500').should be_nil }.to raise_error
+        @tc.buildtype_template(id: 'BuildTypeTests_BuildTypeWithNoTemplate').should be_nil
       end
     end
 
@@ -91,33 +89,35 @@ describe 'BuildTypes' do
 
         before(:each) do
           @method_name = "buildtype_#{type}"
+          @buildtype_id_with_settings = 'BuildTypeTests_GetBuildTypeConfigTests'
+          @buildtype_id_with_no_settings = 'BuildTypeTests_GetBuildTypeEmptyConfigTests'
         end
 
-          it "should fetch the build configuration #{type} for a buildtype" do
-          @tc.send(@method_name, id: 'bt2').should have_at_least(1).items
+        it "should fetch the build configuration #{type} for a buildtype" do
+          @tc.send(@method_name, id: @buildtype_id_with_settings).should have_at_least(1).items
         end
 
         it 'should return an array' do
-          @tc.send(@method_name, id: 'bt2').should be_kind_of(Array)
+          @tc.send(@method_name, id: @buildtype_id_with_settings).should be_kind_of(Array)
         end
 
         it "should return nil if there are no #{type} defined" do
-          @tc.send(@method_name, id: 'bt4').should be_nil
+          @tc.send(@method_name, id: @buildtype_id_with_no_settings).should be_empty
         end
       end
     end
 
     describe '.buildtype_investigations' do
-      before(:all) do
+      before(:each) do
         configure_client_with_authentication
       end
 
       it 'should get investigation details' do
-        @tc.buildtype_investigations('bt9').should_not be_nil
+        @tc.buildtype_investigations('BuildTypeTests_GetBuildTypeWithInvestigations').should_not be_empty
       end
 
       it 'should return nil if no one is investigating' do
-        @tc.buildtype_investigations('bt9').should be_nil
+        @tc.buildtype_investigations('BuildTypeTests_GetBuildTypeWithNoInvestigations').should be_empty
       end
     end
   end
@@ -130,31 +130,54 @@ describe 'BuildTypes' do
 
     describe '.set_buildtype_parameter' do
       it 'should set a buildtype parameter' do
-        @tc.set_buildtype_parameter('bt3', 'set-this-parameter', 'some-value').should be_nil
+        buildtype_id = 'BuildTypeTests_PutSetBuildTypeParameters'
+        param_name = 'test-setting-buildtype-parameters'
+        param_value = 'param-value'
+        @tc.set_buildtype_parameter(buildtype_id, param_name, param_value).should eq(param_value)
       end
     end
 
     describe '.set_buildtype_field' do
+
+      before(:each) do
+        @buildtype_id = 'BuildTypeTests_PutSetBuildTypeField'
+      end
+
       it 'should set the buildtype name' do
-        @tc.set_buildtype_field('bt3', 'name', 'new-buildtype-name').should be_nil
+        field_name = 'name'
+        field_value = 'PutSetBuildTypeField_Name_Changed_By_Test'
+        @tc.set_buildtype_field(@buildtype_id, field_name, field_value).should eq(field_value)
       end
 
       it 'should set a projects description' do
-        @tc.set_buildtype_field('bt3', 'description', 'description-changed-by-test').should be_nil
+        field_name = 'description'
+        field_value = 'description-set_buildtype_field'
+        @tc.set_buildtype_field(@buildtype_id, field_name, field_value).should eq(field_value)
       end
 
       it 'should pause a project' do
-        @tc.set_buildtype_field('bt3', 'paused', 'true').should be_nil
+        field_name = 'paused'
+        field_value = 'true'
+        @tc.set_buildtype_field(@buildtype_id, field_name, field_value).should eq(field_value)
       end
     end
 
     describe '.set_build_step_field' do
+      before(:each) do
+        @buildtype_id = 'BuildTypeTests_PutSetBuildStepField'
+        @build_step_id = 'RUNNER_7'
+      end
+
       it 'should disable a build step' do
-        @tc.set_build_step_field('bt3', 'RUNNER_2', 'disabled', 'true')
+        field_name = 'disabled'
+        field_value = 'true'
+        @tc.set_build_step_field(@buildtype_id, @build_step_id, field_name, field_value)
       end
 
       it 'should enable a build step' do
-        @tc.set_build_step_field('bt3', 'RUNNER_2', 'disabled', 'false')
+        field_name = 'disabled'
+        field_value = 'false'
+        @tc.set_build_step_field(@build_type_id, @build_step_id, field_name, field_value)
       end
     end
   end
@@ -164,21 +187,25 @@ describe 'BuildTypes' do
       configure_client_with_authentication
     end
 
+    before(:each) do
+      @buildtype_id = 'BuildTypeTests_PostBuildTypeTests'
+    end
+
     describe '.attach_vcs_root' do
       it 'should attach a vcs root to a buildtype' do
-        @tc.attach_vcs_root('bt3', '1').id.should eq('1')
+        vcs_root_id = 'teamcity_ruby_client'
+        @tc.attach_vcs_root(@buildtype_id, vcs_root_id).id.should eq(vcs_root_id)
       end
     end
 
     describe '.create_agent_requirement' do
       it 'should create an agent requirement for a buildtype' do
-        buildtype_id = 'bt3'
-        parameter_name = 'test'
-        parameter_value = 'test'
+        parameter_name = 'post-agent-requirement-name'
+        parameter_value = 'post-agent-requirement-value'
         condition = 'equals'
-        args = [buildtype_id, parameter_name, parameter_value, condition]
+        args = [@buildtype_id, parameter_name, parameter_value, condition]
         response = @tc.create_agent_requirement(*args)
-        response.id.should eq('test')
+        response.id.should eq(parameter_name)
       end
     end
   end
@@ -188,21 +215,30 @@ describe 'BuildTypes' do
       configure_client_with_authentication
     end
 
+    before(:each) do
+      @buildtype_id = 'BuildTypeTests_DeleteBuildTypeSettings'
+    end
+
     describe '.delete_buildtype_parameter' do
       it 'should delete a buildtype parameter' do
-        @tc.delete_buildtype_parameter('bt3', 'delete-me').should be_nil
+        param_to_delete = 'delete-buildtype-param'
+        @tc.set_buildtype_parameter(@buildtype_id, param_to_delete, '')
+        @tc.delete_buildtype_parameter(@buildtype_id, 'delete-me').should be_nil
       end
     end
 
     describe '.delete_agent_requirement' do
       it 'should delete the agent requirement' do
-        @tc.delete_agent_requirement('bt3', 'test').should be_nil
+        agent_requirement_to_delete = 'delete-agent-requirement'
+        @tc.create_agent_requirement(@buildtype_id, agent_requirement_to_delete, '', 'equals')
+        @tc.delete_agent_requirement(@buildtype_id, agent_requirement_to_delete).should be_nil
       end
     end
 
     describe '.delete_buildtype' do
       it 'should delete a buildtype' do
-        @tc.delete_buildtype('bt8').should be_nil
+        project_id_to_delete = 'BuildTypeTests_DeleteBuildTypeRequest'
+        @tc.delete_buildtype(project_id_to_delete).should be_nil
       end
     end
   end

data/spec/teamcity/client/projects_spec.rb

@@ -15,7 +15,7 @@ describe 'Projects' do
 
     before(:all) do
       TeamCity.configure do |config|
-        config.endpoint = 'http://localhost:8111/guestAuth/app/rest/7.0/'
+        config.endpoint = 'http://localhost:8111/guestAuth/app/rest'
       end
     end
 
@@ -24,20 +24,15 @@ describe 'Projects' do
     end
 
     describe '.projects' do
-
       it 'should fetch projects' do
         @tc.projects.should_not be_nil
       end
-
-      it 'should return nil if there are no projects' do
-        @tc.projects.should be_nil
-      end
     end
 
     describe '.project' do
 
       it 'should fetch a single project by id' do
-        @tc.project(id: 'project2').should_not be_nil
+        @tc.project(id: 'GetProjectRequest').should_not be_nil
       end
 
       it 'should raise an error if the project does not exist' do
@@ -52,27 +47,27 @@ describe 'Projects' do
     describe '.project_buildtypes' do
 
       it 'should fetch all the buildTypes for a project' do
-        bts = @tc.project_buildtypes(id: 'project2')
+        bts = @tc.project_buildtypes(id: 'GetProjectBuildTypes')
         bts.each do |bt|
-          bt.projectId.should eq('project2')
+          bt.projectId.should eq('GetProjectBuildTypes')
         end
       end
 
-      it 'should return nil if the project does not have any build build types' do
-        bts = @tc.project_buildtypes(id: 'project5')
-        bts.should be_nil
+      it 'should return nil if the project does not have any build types' do
+        bts = @tc.project_buildtypes(id: 'GetProjectWithNoBuildTypes')
+        bts.should be_empty
       end
     end
 
     describe '.project_parameters' do
       it 'should fetch all the paramters for a given project' do
-        parameters = @tc.project_parameters(id: 'project2')
-        parameters.size.should eq(3)
+        parameters = @tc.project_parameters(id: 'GetProjectWithParameters')
+        parameters.size.should_not eq(0)
       end
 
       it 'should return nil if there are no parameters defined for a project' do
-        parameters = @tc.project_parameters(id: 'project3')
-        parameters.should be_nil
+        parameters = @tc.project_parameters(id: 'GetProjectWithNoParameters')
+        parameters.should be_empty
       end
 
       it 'should raise an error if the project does not exist' do
@@ -90,20 +85,20 @@ describe 'Projects' do
 
     describe '.create_project' do
       it 'should create a project' do
-        response = @tc.create_project('test-create-project')
-        response.id.should match(/project/)
+        response = @tc.create_project('PostCreateProject')
+        response.id.should eq('PostCreateProject')
       end
     end
 
     describe '.copy_project' do
       it 'should copy a project' do
-        source_project = @tc.project(id: 'project11')
-        copied_project_name = 'copy-project-testB'
+        @tc.create_project('PostProjectToBeCopied')
+        source_project = @tc.project(id: 'PostProjectToBeCopied')
+        copied_project_name = 'PostCopyProject'
         response = @tc.copy_project(
           source_project.id,
           copied_project_name,
-          :copyAllAssociatedSettings => true,
-          :shareVCSRoots             => true
+          :copyAllAssociatedSettings => true
         )
         response.name.should eq(copied_project_name)
       end
@@ -118,14 +113,18 @@ describe 'Projects' do
 
     describe '.delete_project' do
       it 'should delete a project' do
-        response = @tc.create_project('project-to-delete')
+        response = @tc.create_project('ProjectToDelete')
         @tc.delete_project(response.id).should be_nil
       end
     end
 
     describe '.delete_project_parameter' do
       it 'should delete a project parameter' do
-        response = @tc.delete_project_parameter('project2', 'delete-this-parameter')
+        project_id = 'DeleteProjectParameters'
+        param_to_delete = 'delete-this-param'
+        @tc.create_project(project_id)
+        @tc.set_project_parameter(project_id, param_to_delete, 'delete-me')
+        response = @tc.delete_project_parameter(project_id, param_to_delete)
         response.should be_nil
       end
     end
@@ -139,25 +138,35 @@ describe 'Projects' do
 
     describe '.set_project_parameter' do
       it 'should set a project parameter' do
-        @tc.set_project_parameter('project2', 'set-this-parameter', 'some-value').should be_nil
-      end
-
-      it 'should set a project parameter with a boolean value' do
-        @tc.set_project_parameter('project2', 'env.SET_ME', 'true')
+        project_id = 'PutCreateProjectParam'
+        param_name = 'set-with-param'
+        param_value = 'some-value'
+        @tc.create_project(project_id)
+        @tc.set_project_parameter(project_id, param_name, param_value).should eq(param_value)
       end
     end
 
     describe '.set_project_field' do
+
       it 'should set a projects name' do
-        @tc.set_project_field('project21', 'name', 'project-change-by-test').should be_nil
+        project_id = 'PutSetProjectNameField'
+        @tc.create_project(project_id)
+        field_value = 'PutNewProjectName'
+        @tc.set_project_field(project_id, 'name', field_value).should eq(field_value)
       end
 
       it 'should set a projects description' do
-        @tc.set_project_field('project21', 'description', 'description-changed-by-test').should be_nil
+        project_id = 'PutSetProjectDescriptionField'
+        @tc.create_project(project_id)
+        field_value = 'description-changed-by-test'
+        @tc.set_project_field(project_id, 'description', field_value).should eq(field_value)
       end
 
       it 'should archive a project' do
-        @tc.set_project_field('project21', 'archived', 'true').should be_nil
+        project_id = 'PutSetProjectArchiveField'
+        @tc.create_project(project_id)
+        field_value = 'true'
+        @tc.set_project_field(project_id, 'archived', field_value).should eq(field_value)
       end
     end
   end

data/spec/teamcity/client/vcs_roots_spec.rb

@@ -4,44 +4,33 @@ describe 'VCSRoots' do
 
   before(:each) do
     @tc = TeamCity
-  end
-
-  before(:all) do
-    TeamCity.configure do |config|
-      configure_client_with_authentication
-    end
-  end
-
-  after(:all) do
-    TeamCity.reset
+    configure_client_with_authentication
   end
 
   # GET requests
   describe 'GET', :vcr do
     describe '.vcs_roots' do
-
       it 'should fetch vcs roots' do
-        @tc.vcs_roots.should_not be_nil
+        @tc.vcs_roots.should have_at_least(1).items
       end
     end
 
     describe '.vcs_root_details' do
-
       it 'should fetch the vcs root details' do
-        response = @tc.vcs_root_details(1)
-        response.id.should eq(1)
+        vcs_root_id = @tc.vcs_roots.first.id
+        response = @tc.vcs_root_details(vcs_root_id)
+        response.id.should eq(vcs_root_id)
       end
     end
   end
 
   describe 'POST', :vcr do
-
     describe '.create_vcs_root' do
-
-      it 'should create a vcs root that is only shared within a project' do
-        vcs_name = 'testvcsroot'
+      it 'should create a vcs root that is shared with the project and sub-projects' do
+        project_id = @tc.projects[1].id
+        vcs_name = 'PostCreateVCSRoot'
         vcs_type = 'git'
-        response = @tc.create_vcs_root(vcs_name, vcs_type, :projectLocator => 'project2') do |properties|
+        response = @tc.create_vcs_root(vcs_name: vcs_name, vcs_type: vcs_type, project_id: project_id) do |properties|
           properties['branch'] = 'master'
           properties['url'] = 'git@github.com:jperry/teamcity-ruby-client.git'
           properties['authMethod'] = 'PRIVATE_KEY_DEFAULT'
@@ -49,15 +38,6 @@ describe 'VCSRoots' do
         end
         response.name.should eq(vcs_name)
         response.vcsName.should match(/#{vcs_type}/)
-        response.shared.should be_false
-      end
-
-      it 'should create a shared vcs root' do
-        response = @tc.create_vcs_root('sharedvcsroot', 'git', :shared => true) do |properties|
-          properties['branch'] = 'master'
-          properties['url'] = 'git@github.com:jperry/teamcity-ruby-client.git'
-        end
-        response.shared.should be_true
       end
     end
   end