teachers_pet 0.2.0 → 0.3.0

data/spec/commands/open_issue_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe 'open_issue' do
+  include CommandHelpers
+
+  context 'through CLI' do
+    def common_test(labels='')
+      issue_title = "Issue Test"
+      request_stubs = []
+
+      request_stubs << stub_get_json('https://testteacher:abc123@api.github.com/orgs/testorg',
+        login: 'testorg',
+        url: 'https://api.github.com/orgs/testorg'
+      )
+      request_stubs << stub_get_json('https://testteacher:abc123@api.github.com/orgs/testorg/teams?per_page=100', student_teams)
+      student_usernames.each do |username|
+        # Action checks that repos exist already
+        request_stubs << stub_request(:get, "https://testteacher:abc123@api.github.com/repos/testorg/#{username}-testrepo")
+      end
+
+      # create the issue in each repo
+      student_usernames.each do |username|
+        team_id = 0
+        student_teams.each do |st|
+          if st[:name].eql?(username)
+            team_id = st[:id]
+          end
+        end
+        issue_body = File.read(issue_fixture_path).gsub("\n", "\\n")
+        labels_list = labels.split(",").map(&:strip).to_s.delete(' ')
+        request_stubs << stub_request(:post, "https://testteacher:abc123@api.github.com/repos/testorg/#{username}-testrepo/issues").
+          with(body: "{\"labels\":#{labels_list},\"title\":\"#{issue_title}\",\"body\":\"#{issue_body}\"}").
+          to_return(status: 201)
+      end
+
+      teachers_pet(:open_issue,
+        repository: 'testrepo',
+        organization: 'testorg',
+
+        title: issue_title,
+        body: issue_fixture_path,
+        labels: labels,
+
+        students: students_list_fixture_path,
+
+        username: 'testteacher',
+        password: 'abc123'
+      )
+
+      request_stubs.each do |request_stub|
+        expect(request_stub).to have_been_requested.once
+      end
+    end
+
+    it "open issue no labels" do
+      common_test
+    end
+
+    it "open issue with labels" do
+      common_test('bug, feature')
+    end
+  end
+end

data/spec/commands/push_files_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe 'push_files' do
+  include CommandHelpers
+
+  it "runs" do
+    request_stubs = []
+    request_stubs << stub_get_json('https://testteacher:abc123@api.github.com/orgs/testorg',
+      login: 'testorg',
+      name: 'Test Org',
+      url: 'http://test.org'
+    )
+    request_stubs << stub_get_json('https://testteacher:abc123@api.github.com/orgs/testorg/teams?per_page=100', [
+      {
+        name: 'teststudent'
+      }
+    ])
+
+    teachers_pet(:push_files,
+      repository: 'assignment',
+      organization: 'testorg',
+
+      students: students_list_fixture_path,
+
+      username: 'testteacher',
+      password: 'abc123'
+    )
+
+    request_stubs.each do |request_stub|
+      expect(request_stub).to have_been_requested.once
+    end
+  end
+end

data/spec/fixtures/teams

@@ -0,0 +1 @@
+studentteam1 teststudent1 teststudent2

data/spec/spec_helper.rb

@@ -1,64 +1,24 @@
+require 'simplecov'
+SimpleCov.start do
+  add_group 'Actions' do |src_file|
+    file = src_file.filename
+    file.include?(File.join('lib', 'teachers_pet', 'actions')) && File.basename(file) != 'base.rb'
+  end
+  add_group 'Commands', '/lib/teachers_pet/commands/'
+  add_group 'Specs', '/spec/'
+end
+
+require 'active_support/core_ext/kernel/reporting'
 require 'csv'
 require 'json'
 require 'webmock/rspec'
 
 require_relative File.join('..', 'lib', 'teachers_pet')
+require_rel 'support'
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'
-end
-
-
-def stub_get_json(url, response)
-  stub_request(:get, url).to_return(
-    headers: {
-      'Content-Type' => 'application/json'
-    },
-    body: response.to_json
-  )
-end
-
-def students_list_fixture_path
-  File.join(File.dirname(__FILE__), 'fixtures', 'students')
-end
-
-def instructors_list_fixture_path
-  File.join(File.dirname(__FILE__), 'fixtures', 'instructors')
-end
-
-def issue_fixture_path
-  File.join(File.dirname(__FILE__), 'fixtures', 'issue.md')
-end
-
-def student_usernames
-  CSV.read(students_list_fixture_path).flatten
-end
-
-def student_teams
-  student_usernames.each_with_index.map do |username, i|
-    {
-      url: "https://api.github.com/teams/#{i}",
-      name: username,
-      id: i
-    }
-  end
-end
-
-def respond(question, response)
-  action.stub(:ask).with(question).and_return(response)
-end
-
-def confirm(question, response)
-  action.stub(:confirm).with(question, false).and_return(response)
-end
-
-def stub_github_config
-  respond("What is the API endpoint?", TeachersPet::Configuration.apiEndpoint)
-  respond("What is the Web endpoint?", TeachersPet::Configuration.webEndpoint)
-  respond("What is your username? (You must be an owner for the organization)?", 'testteacher')
-  action.stub(get_auth_method: 'password')
-  respond("What is your password?", 'abc123')
+  config.include CommonHelpers
 end

data/spec/support/command_helpers.rb

@@ -0,0 +1,11 @@
+module CommandHelpers
+  def teachers_pet(action, opts={})
+    script = TeachersPet::Cli.new
+    script.invoke(action, [], opts)
+  end
+
+  def expect_to_be_run_with(cls, opts)
+    expect(cls).to receive(:new).with(opts).once.and_call_original
+    expect_any_instance_of(cls).to receive(:run).once
+  end
+end

data/spec/support/common_helpers.rb

@@ -0,0 +1,52 @@
+module CommonHelpers
+  def stub_get_json(url, response)
+    stub_request(:get, url).to_return(
+      headers: {
+        'Content-Type' => 'application/json'
+      },
+      body: response.to_json
+    )
+  end
+
+  def fixtures_path
+    File.join(File.dirname(__FILE__), '..', 'fixtures')
+  end
+
+  def fixture_path(filename)
+    File.join(fixtures_path, filename)
+  end
+
+  def students_list_fixture_path
+    fixture_path('students')
+  end
+
+  def instructors_list_fixture_path
+    fixture_path('instructors')
+  end
+
+  def empty_list_fixture_path
+    fixture_path('empty')
+  end
+
+  def issue_fixture_path
+    fixture_path('issue.md')
+  end
+
+  def student_usernames
+    CSV.read(students_list_fixture_path).flatten
+  end
+
+  def instructor_usernames
+    CSV.read(instructors_list_fixture_path).flatten
+  end
+
+  def student_teams
+    student_usernames.each_with_index.map do |username, i|
+      {
+        url: "https://api.github.com/teams/#{i}",
+        name: username,
+        id: i
+      }
+    end
+  end
+end

data/teachers_pet.gemspec

@@ -20,12 +20,16 @@ Gem::Specification.new do |s|
 
   s.required_ruby_version = '>= 1.9.3'
 
-  s.add_dependency 'highline', '~> 1.6.21'
+  s.add_dependency 'activesupport', '~> 4.0'
   s.add_dependency 'octokit', '~> 3.1.0'
+  s.add_dependency 'require_all', '~> 1.3.2'
+  s.add_dependency 'thor', '~> 0.19.1'
 
   s.add_development_dependency 'bundler', '~> 1.5'
   s.add_development_dependency 'guard-rspec', '~> 4.2'
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec', '~> 2.14'
+  s.add_development_dependency 'rspec', '~> 3.0'
+  # https://github.com/colszowka/simplecov/issues/281
+  s.add_development_dependency 'simplecov', '~> 0.7.1'
   s.add_development_dependency 'webmock', '~> 1.17'
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: teachers_pet
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - John Britton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-16 00:00:00.000000000 Z
+date: 2014-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: highline
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.21
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.21
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,34 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.1.0
+- !ruby/object:Gem::Dependency
+  name: require_all
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.3.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.3.2
+- !ruby/object:Gem::Dependency
+  name: thor
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.19.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.19.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +114,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -111,12 +153,7 @@ dependencies:
 description: 
 email: public@johndbritton.com
 executables:
-- clone_repos
-- create_repos
-- create_teams
-- fork_collab
-- open_issue
-- push_files
+- teachers_pet
 extensions: []
 extra_rdoc_files: []
 files:
@@ -129,30 +166,44 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- bin/clone_repos
-- bin/create_repos
-- bin/create_teams
-- bin/fork_collab
-- bin/open_issue
-- bin/push_files
+- bin/teachers_pet
 - lib/teachers_pet.rb
+- lib/teachers_pet/actions/add_to_team.rb
 - lib/teachers_pet/actions/base.rb
 - lib/teachers_pet/actions/clone_repos.rb
 - lib/teachers_pet/actions/create_repos.rb
-- lib/teachers_pet/actions/create_teams.rb
+- lib/teachers_pet/actions/create_student_teams.rb
 - lib/teachers_pet/actions/fork_collab.rb
 - lib/teachers_pet/actions/open_issue.rb
 - lib/teachers_pet/actions/push_files.rb
+- lib/teachers_pet/cli.rb
+- lib/teachers_pet/client_decorator.rb
+- lib/teachers_pet/commands/add_to_team.rb
+- lib/teachers_pet/commands/clone_repos.rb
+- lib/teachers_pet/commands/create_repos.rb
+- lib/teachers_pet/commands/create_student_teams.rb
+- lib/teachers_pet/commands/fork_collab.rb
+- lib/teachers_pet/commands/open_issue.rb
+- lib/teachers_pet/commands/push_files.rb
 - lib/teachers_pet/configuration.rb
 - lib/teachers_pet/version.rb
-- spec/actions/clone_repos_spec.rb
-- spec/actions/create_repos_spec.rb
-- spec/actions/create_teams_spec.rb
-- spec/actions/open_issue_spec.rb
+- spec/actions/base_spec.rb
+- spec/cli_spec.rb
+- spec/commands/add_to_team_spec.rb
+- spec/commands/clone_repos_spec.rb
+- spec/commands/create_repos_spec.rb
+- spec/commands/create_student_teams_spec.rb
+- spec/commands/fork_collab_spec.rb
+- spec/commands/open_issue_spec.rb
+- spec/commands/push_files_spec.rb
+- spec/fixtures/empty
 - spec/fixtures/instructors
 - spec/fixtures/issue.md
 - spec/fixtures/students
+- spec/fixtures/teams
 - spec/spec_helper.rb
+- spec/support/command_helpers.rb
+- spec/support/common_helpers.rb
 - teachers_pet.gemspec
 homepage: http://github.com/education/teachers_pet
 licenses:
@@ -174,16 +225,25 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Command line tools to help teachers use GitHub in their classrooms
 test_files:
-- spec/actions/clone_repos_spec.rb
-- spec/actions/create_repos_spec.rb
-- spec/actions/create_teams_spec.rb
-- spec/actions/open_issue_spec.rb
+- spec/actions/base_spec.rb
+- spec/cli_spec.rb
+- spec/commands/add_to_team_spec.rb
+- spec/commands/clone_repos_spec.rb
+- spec/commands/create_repos_spec.rb
+- spec/commands/create_student_teams_spec.rb
+- spec/commands/fork_collab_spec.rb
+- spec/commands/open_issue_spec.rb
+- spec/commands/push_files_spec.rb
+- spec/fixtures/empty
 - spec/fixtures/instructors
 - spec/fixtures/issue.md
 - spec/fixtures/students
+- spec/fixtures/teams
 - spec/spec_helper.rb
+- spec/support/command_helpers.rb
+- spec/support/common_helpers.rb