tdc 0.3.6 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afd309b8d6f641f50856a6ab71c6557dceba91c43e97c6d23a54f526cc954570
-  data.tar.gz: c730e903a12d47f4a8dc452a212ae9f38f75a4d2b61a74dd72237e69f0005d47
+  metadata.gz: a574acff7829e69b0f0921e3057ed00ccbf149aa6bc23e77585de0c4372183af
+  data.tar.gz: b8242f2461ab9eab727e3aca43de8b7ad4f31b45435ce67a4e8cd868893263d4
 SHA512:
-  metadata.gz: f699b62e54e48f3b42bb06215a8e783ca15797265292e988f70f4cbc82191aa55174ccfbcdf1bb50b58ccb1323716272d7d958283b49eac45dbb1c948208f616
-  data.tar.gz: 7496da7a34c508a1b132a5232f1c061eded18b8b5057192728be98b3faae095b3c3e1dd377b2563fde95f897861bcedb932bf867c8f20c4e3f09621af18cf52d
+  metadata.gz: 5bfe223f7dbbe91f3b92e0d6582d0964a5a1f309190a3f787dde1c6c7132678f2c3f1d0c0faf442231a6c1462ee43941dd1b03460dd0d5f5135612998df0a59b
+  data.tar.gz: 056c5002c9fbc2cd94ec5a9de9a06d229a271867a915a486abc316c245499ae8c3f069ef8a1bfb14c10d895b9e2af3b5a5035b8af086c5d3187a3bf7592829a5

data/.rubocop.yml

@@ -2,39 +2,19 @@ require:
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.5
+  NewCops: enable
+  TargetRubyVersion: 2.6
 
   Exclude:
     - 'bin/**/*'
 
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 
 # Rubocop and I cannot agree.
 Layout/MultilineMethodCallBraceLayout:
   Enabled: false
 
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-
-Lint/DuplicateElsifCondition:
-  Enabled: true
-
-Lint/MixedRegexpCaptureTypes:
-  Enabled: true
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
 Metrics/BlockLength:
   Enabled: false
 
@@ -68,15 +48,6 @@ RSpec/MultipleExpectations:
 RSpec/SubjectStub:
   Enabled: false
 
-Style/AccessorGrouping:
-  Enabled: true
-
-Style/ArrayCoercion:
-  Enabled: true
-
-Style/BisectedAttrAccessor:
-  Enabled: true
-
 Style/BlockDelimiters:
   Enabled: true
   EnforcedStyle: line_count_based
@@ -84,37 +55,16 @@ Style/BlockDelimiters:
     - 'let'
     - 'subject'
 
-Style/CaseLikeIf:
-  Enabled: true
-
 Style/Documentation:
   Enabled: false
 
 Style/EmptyMethod:
   EnforcedStyle: expanded
 
-Style/ExponentialNotation:
-  Enabled: true
-
 # We can ignore this small performance improvement.
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/HashAsLastArrayItem:
-  Enabled: true
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashLikeCase:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
-
 # We like to use the hash rocket in rake files.
 Style/HashSyntax:
   Exclude:
@@ -124,21 +74,6 @@ Style/HashSyntax:
 Style/MutableConstant:
   Enabled: false
 
-Style/RedundantAssignment:
-  Enabled: true
-
-Style/RedundantFetchBlock:
-  Enabled: true
-
-Style/RedundantFileExtensionInRequire:
-  Enabled: true
-
-Style/RedundantRegexpCharacterClass:
-  Enabled: true
-
-Style/RedundantRegexpEscape:
-  Enabled: true
-
 # No need to mention StandardError.
 Style/RescueStandardError:
   EnforcedStyle: implicit

data/CHANGELOG.md

@@ -6,6 +6,39 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.4.0] - 2020-08-14
+
+#### New Features
+
+- Drop requirement that an empty test data definition file must be provided 
+
+## [0.3.9] - 2020-08-12
+
+#### Breaking Changes
+
+- Collapse `ConfigurableGenerator` into `StandardGenerator`
+
+## [0.3.8] - 2020-08-11
+
+#### New Features
+
+- Multiple subclass instances of `ExtendedAttributes::InterpreterBase` may be registered
+- A default extended attribute interpreter recognizes `_atx`, `_datex`, or `_onx` date/time attributes
+
+#### Breaking Changes
+
+- Rename `AtxContextFactory` to `ExtendedAttributes::InterpreterRegistry`
+
+## [0.3.7] - 2020-08-10
+
+#### New Features
+
+- Register a context with the `AtxContextFactory`
+
+## [0.3.6.1] - 2020-08-10
+
+- Add the `AtxContextFactory` abstraction
+
 ## [0.3.6] - 2020-08-06
 
 #### Breaking Changes

data/README.md

@@ -13,3 +13,5 @@ During generation the test data catalog will be represented by ```CatalogEntries
 **Data Definition DSL**
 
 ```DefinitionResolvable``` and ```DefinitionSourcable``` provide a DSL that you may use in your generators to work more easily with a ```DataDefinition```.
+
+By registering a class instance that inherits from ```ExtendedAttributes::InterpreterBase``` with the ```ExtendedAttributes::InterpreterRegistry``` you may extend the DSL that is used to interpret attribute values. 

data/lib/tdc.rb

@@ -7,10 +7,21 @@ require "active_support/core_ext"
 
 require "tdc/version"
 
-# Errors
+# Definition Resolvers
+require "tdc/definition_resolvers"
+require "tdc/definition_resolvers/definition_resolver"
+require "tdc/definition_resolvers/tag_resolver"
+
+# Tdc Errors
 require "tdc/fatal_error"
 require "tdc/missing_override_error"
 
+# Extended Attributes
+require "tdc/extended_attributes"
+require "tdc/extended_attributes/interpreter_base"
+require "tdc/extended_attributes/default_interpreter"
+require "tdc/extended_attributes/interpreter_registry"
+
 # Data Definition Hierarchy
 require "tdc/data_definition"
 require "tdc/data_definition_file_reader"
@@ -19,25 +30,17 @@ require "tdc/with_indifferent_access_decorator"
 
 # Generators
 require "tdc/generators"
-require "tdc/generators/generation_context"
-
-# Current Catalog
 require "tdc/generators/catalog_entries"
+require "tdc/generators/generation_context"
 
-# Concerns
+# Generator Concerns
 require "tdc/generators/definition_resolvable"
 require "tdc/generators/definition_sourcable"
 
 # Generator Hierarchy
 require "tdc/generators/generator_base"
-require "tdc/generators/configurable_generator"
 require "tdc/generators/standard_generator"
 
-# Definition Resolvers
-require "tdc/definition_resolvers"
-require "tdc/definition_resolvers/definition_resolver"
-require "tdc/definition_resolvers/tag_resolver"
-
 #
 # A framework for building a Test Data Catalog
 #

data/lib/tdc/data_definition_file_reader.rb

@@ -6,6 +6,8 @@ module Tdc
     EMPTY_DEFINITIONS = []
 
     def initialize(catalog_root_directory)
+      super()
+
       @catalog_root_directory = catalog_root_directory
     end
 
@@ -27,7 +29,7 @@ module Tdc
       if File.exist?(definitions_file)
         load_yaml(definitions_file) || EMPTY_DEFINITIONS
       else
-        missing_data_definition(definitions_file)
+        EMPTY_DEFINITIONS
       end
     end
 
@@ -43,11 +45,5 @@ module Tdc
     def expand_erb(definitions_file)
       ERB.new(File.read(definitions_file)).result
     end
-
-    def missing_data_definition(definitions_file)
-      return EMPTY_DEFINITIONS if ENV.key?("TDC_IGNORE_MISSING_TEST_DATA_DEFINITION_ERROR")
-
-      raise Tdc::FatalError, "Missing test definitions file: '#{definitions_file}'"
-    end
   end
 end

data/lib/tdc/definition_resolvers/tag_resolver.rb

@@ -8,6 +8,8 @@ module Tdc
       attr_reader :key, :source
 
       def initialize(key:, source:)
+        super()
+
         @key = key
         @source = source
       end

data/lib/tdc/extended_attributes.rb

@@ -0,0 +1,7 @@
+module Tdc
+  #
+  # Namespace to host extended attributes.
+  #
+  module ExtendedAttributes
+  end
+end

data/lib/tdc/extended_attributes/default_interpreter.rb

@@ -0,0 +1,31 @@
+module Tdc
+  module ExtendedAttributes
+    class DefaultInterpreter < Tdc::ExtendedAttributes::InterpreterBase
+      def interpret(instance_definition)
+        extended_attribute_definitions = keep_extended_attributes(instance_definition)
+
+        extended_attribute_definitions.each do |k, v|
+          # Remove the original extended attribute.
+          instance_definition.delete(k)
+
+          # Add a standard attribute.
+          instance_definition[convert_to_standard_attribute(k)] = extended_attribute_context.instance_eval(v)
+        end
+      end
+
+      concerning :HookMethods do
+        def convert_to_standard_attribute(k) # rubocop:disable Naming/MethodParameterName
+          k.delete_suffix("x")
+        end
+
+        def extended_attribute_context
+          Time.zone
+        end
+
+        def keep_extended_attributes(instance_definition)
+          instance_definition.select { |k, _v| /_(at|date|on)x$/ =~ k }
+        end
+      end
+    end
+  end
+end

data/lib/tdc/extended_attributes/interpreter_base.rb

@@ -0,0 +1,9 @@
+module Tdc
+  module ExtendedAttributes
+    class InterpreterBase
+      def interpret(_instance_definition)
+        raise Tdc::MissingOverrideError, "Implement the 'keep_extended_attributes' method"
+      end
+    end
+  end
+end

data/lib/tdc/extended_attributes/interpreter_registry.rb

@@ -0,0 +1,32 @@
+module Tdc
+  module ExtendedAttributes
+    #
+    # Knows the class instances that interpret extended attribute values.
+    #
+    class InterpreterRegistry
+      include Singleton
+
+      def self.register(interpreter:)
+        instance.register_interpreter(interpreter)
+      end
+
+      def initialize
+        @interpreters = []
+      end
+
+      def interpreters
+        @interpreters << Tdc::ExtendedAttributes::DefaultInterpreter.new if @interpreters.empty?
+
+        @interpreters
+      end
+
+      def register_interpreter(interpreter)
+        raise Tdc::FatalError, <<~MSG unless interpreter.is_a?(Tdc::ExtendedAttributes::InterpreterBase)
+          Cannot register an interpreter unless it inherits from Tdc::ExtendedAttributes::InterpreterBase
+        MSG
+
+        @interpreters << interpreter
+      end
+    end
+  end
+end

data/lib/tdc/generators/definition_sourcable.rb

@@ -38,7 +38,7 @@ module Tdc
         definition_source&.key?(key) ? definition_source.fetch(key) : super
       end
 
-      def respond_to_missing?(method, include_all = false)
+      def respond_to_missing?(method, include_all = false) # rubocop:disable Style/OptionalBooleanParameter
         key = transform_method_to_definition_source_key(method)
 
         definition_source&.key?(key) ? true : super

data/lib/tdc/generators/standard_generator.rb

@@ -1,11 +1,15 @@
 module Tdc
   module Generators
     #
-    # Abstract class for defining generators that define a collection of model instances.
+    # Knows how to provide a configurable instance definition.
     #
-    # See also SingularGenerator.
-    #
-    class StandardGenerator < Tdc::Generators::ConfigurableGenerator
+    class StandardGenerator < Tdc::Generators::GeneratorBase
+      include Tdc::Generators::DefinitionSourcable
+
+      attr_reader :instance_definition
+
+      source_definition_from :instance_definition
+
       def generate
         CatalogEntries.new.tap do |catalog_entries|
           instance_definitions.each do |instance_definition|
@@ -21,6 +25,43 @@ module Tdc
           end
         end
       end
+
+      def run_resolvers_and_generate_instance
+        run_extended_attribute_interpreters(instance_definition)
+        run_definition_resolvers(instance_definition)
+
+        generate_instance
+      end
+
+      #
+      # Hook method: subclasses are expected to define how to generate a model instance.
+      #
+      def generate_instance
+        raise Tdc::MissingOverrideError, "Implement the 'generate_instance' method"
+      end
+
+      #
+      # Hook method: subclasses may include the DefinitionResolvable concern to override.
+      #
+      def run_definition_resolvers(_instance_definition)
+        # Do nothing
+      end
+
+      private
+
+      def configure_instance_definition(instance_definition)
+        @instance_definition = instance_definition
+
+        configure_definition_source(instance_definition)
+      end
+
+      def run_extended_attribute_interpreters(instance_definition)
+        interpreters.each { |interpreter| interpreter.interpret(instance_definition) }
+      end
+
+      def interpreters
+        Tdc::ExtendedAttributes::InterpreterRegistry.instance.interpreters
+      end
     end
   end
 end

data/lib/tdc/in_memory_data_definition.rb

@@ -4,6 +4,8 @@ module Tdc
   #
   class InMemoryDataDefinition < Tdc::DataDefinition
     def initialize(path_elements_data = {})
+      super()
+
       @store = path_elements_data
     end
 

data/lib/tdc/version.rb

@@ -1,3 +1,3 @@
 module Tdc
-  VERSION = "0.3.6"
+  VERSION = "0.4.0"
 end

data/tdc.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "rake", ">= 12.1", "< 13.1"
   spec.add_development_dependency "rspec", ">= 3.9", "< 4.0"
-  spec.add_development_dependency "rubocop", "~> 0.88"
+  spec.add_development_dependency "rubocop", "~> 0.89"
   spec.add_development_dependency "rubocop-rspec", "~> 1.42"
   spec.add_development_dependency "simplecov", "~> 0.17"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tdc
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.4.0
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-07 00:00:00.000000000 Z
+date: 2020-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -70,14 +70,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '0.89'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '0.89'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -131,10 +131,13 @@ files:
 - lib/tdc/definition_resolvers.rb
 - lib/tdc/definition_resolvers/definition_resolver.rb
 - lib/tdc/definition_resolvers/tag_resolver.rb
+- lib/tdc/extended_attributes.rb
+- lib/tdc/extended_attributes/default_interpreter.rb
+- lib/tdc/extended_attributes/interpreter_base.rb
+- lib/tdc/extended_attributes/interpreter_registry.rb
 - lib/tdc/fatal_error.rb
 - lib/tdc/generators.rb
 - lib/tdc/generators/catalog_entries.rb
-- lib/tdc/generators/configurable_generator.rb
 - lib/tdc/generators/definition_resolvable.rb
 - lib/tdc/generators/definition_sourcable.rb
 - lib/tdc/generators/generation_context.rb

data/lib/tdc/generators/configurable_generator.rb

@@ -1,60 +0,0 @@
-module Tdc
-  module Generators
-    #
-    # Knows how to provide a configurable instance definition.
-    #
-    # Shared implementation between the StandardGenerator and the SingularGenerator abstract classes.
-    #
-    class ConfigurableGenerator < Tdc::Generators::GeneratorBase
-      include Tdc::Generators::DefinitionSourcable
-
-      attr_reader :instance_definition
-
-      source_definition_from :instance_definition
-
-      def run_resolvers_and_generate_instance
-        run_atx_resolvers(instance_definition)
-        run_definition_resolvers(instance_definition)
-
-        generate_instance
-      end
-
-      #
-      # Hook method: subclasses are expected to define how to generate a model instance.
-      #
-      def generate_instance
-        raise Tdc::MissingOverrideError, "Implement the 'generate_instance' method"
-      end
-
-      #
-      # Hook method: subclasses may include the DefinitionResolvable concern to override.
-      #
-      def run_definition_resolvers(_instance_definition)
-        # Do nothing
-      end
-
-      private
-
-      def configure_instance_definition(instance_definition)
-        @instance_definition = instance_definition
-
-        configure_definition_source(instance_definition)
-      end
-
-      def run_atx_resolvers(instance_definition)
-        atx_definitions = instance_definition.select { |k, _v| /_atx$/ =~ k }
-
-        # ARM (2020-08-04): Move all the way out so that all generators use the same atx_context.
-        atx_context = Time.zone
-
-        atx_definitions.each do |k, v|
-          # Remove the original _atx attribute.
-          instance_definition.delete(k)
-
-          # Add a standard _at attribute.
-          instance_definition[k.delete_suffix("x")] = atx_context.instance_eval(v)
-        end
-      end
-    end
-  end
-end