tdberlintest 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f39df2ad661a6a2bb40058c77f25808c0da01d6c
-  data.tar.gz: f5d2dca0f07d4325c06ff5f3dde405d4b7df4b83
+  metadata.gz: 92f9629f4887cbf8347a601dbf16cc4a34b56211
+  data.tar.gz: 4ced00e799e479a752b884ad021c732b8e778df8
 SHA512:
-  metadata.gz: e22269e0be51c14e3249b729f8b6625fe07f6970079866c1c1a29cd7377d66a901f876f0e47355e99ad1588c8dd8467842a5ed2c8f835859f9877eaacb15b417
-  data.tar.gz: 9b8ebb789920f00685e9d5f4667666c078a4126bc4f9258ace9e8e42e74df8a353f06e8543096b07d248d9750c519eb8ee369da90bb5c2f13bb006c5ce1efc04
+  metadata.gz: 717c72f8803a62b273bfcd71db7664cd9f50c41b4e29a5b4243a7744db90866acaad15fe793adca7ff64f7e757d3ee71fab60c191a3090648761d34b3c22e5d9
+  data.tar.gz: e32da15401fc3bb2e279b8fc6a04fe827be6971d35bbd3628f82480572a7d43796ff0c28ea839e42e48150ae70833ef35d40a04da18a6603583a184e544a00cd

data/README.md

@@ -1,6 +1,4 @@
-# TdberlinTest
-
-TODO: Write a gem description
+# td-berlin.com Test Solution Proposal
 
 ## Installation
 
@@ -20,12 +18,33 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+Create any ruby file, e.g. test.rb and add this line at the beginning:
+ ```ruby
+ require 'tdberlintest'
+ ```
+
+Now run
+    ruby test.rb
+You will see this:
+
+    Commands:
+        test.rb help [COMMAND]  # Describe available commands or one specific command
+        test.rb task1           # execute task1 of test. specify input yaml file. e.g.: ruby test.rb task1 -i langs.yaml
+        test.rb task2           # execute task2 of test. specify input yaml file. e.g.: ruby test.rb task2 -i langs.yaml
+
+If you want to read the task1 requirements, type:
+    test.rb help task1
+
+So in order to execute any of the two tasks, you will need to specify a yaml file.
+So you could go ahead and could create e.g. the yaml file 'langs.yaml' with this content:
+
+    ---
+    - langs: [ruby, scheme, haskell]
+
+So if you now run the command:
+
+    ruby test.rb task1 -i pathtoyamlfile/langs.yaml
 
-## Contributing
+you should see the result after a few seconds.
 
-1. Fork it ( https://github.com/[my-github-username]/tdberlintest/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
+Same steps for task2!

data/lib/stackoverflow_api_fetcher.rb

@@ -7,6 +7,8 @@ module TdBerlinTest
   class StackexchangeApiFetcher
     DefaultQueryURI = "https://api.stackexchange.com/2.2/tags"
 
+    attr_accessor :language_data, :result
+
     def initialize(yaml_file)
       @language_data = parse_yaml_file(yaml_file)
     end
@@ -23,7 +25,8 @@ module TdBerlinTest
         result_hash[language] = tag_usage_count
       end
 
-      output_result(result_hash)
+      @result = sort_result_by_tag_usage_count(result_hash)
+      output_result(@result)
     end
 
     def fetch_stackoverflow(language)
@@ -41,12 +44,12 @@ module TdBerlinTest
       end
     end
 
-    def sort_result(hash)
-      hash.sort_by { |language, tag_usage_count| tag_usage_count }.reverse
+    def sort_result_by_tag_usage_count(hash)
+      temp = hash.sort_by { |language, tag_usage_count| tag_usage_count }.reverse.to_h
     end
 
     def output_result(hash)
-      ap sort_result(hash).to_h, :indent => -2
+      ap @result, :indent => -2
     end
   end
 end

data/lib/tdberlintest/version.rb

@@ -1,3 +1,3 @@
 module TdBerlinTest
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/lib/tdberlintest.rb

@@ -8,7 +8,7 @@ require_relative 'stackoverflow_api_fetcher'
 module TdBerlinTest
   class TestManager < Thor
 
-    desc 'task1', 'execute task1 of test. specify input yaml file. e.g.: ./test.rb task1 -i langs.yaml'
+    desc 'task1', 'execute task1 of test. specify input yaml file. e.g.: ruby test.rb task1 -i langs.yaml'
     long_desc <<-LONGDESC
     Query the Wolfram Alpha API and parse the output.
 
@@ -35,7 +35,7 @@ module TdBerlinTest
       wolfram_api_fetcher.run
     end
 
-    desc 'task2', 'execute task2 of test. specify input yaml file. e.g.: ./test.rb task2 -i langs.yaml'
+    desc 'task2', 'execute task2 of test. specify input yaml file. e.g.: ruby test.rb task2 -i langs.yaml'
     long_desc <<-LONGDESC
     Query the Stackexchange API and parse the output.
 

data/lib/wolfram_api_fetcher.rb

@@ -6,6 +6,7 @@ module TdBerlinTest
   class WolframApiFetcher
     WOLFRAM_APP_ID = 'Q6LH5Y-3JA7L335LL'
 
+    attr_accessor :language_data, :result
 
     def initialize(yaml_file)
       @language_data = parse_yaml_file(yaml_file)

data/spec/fixtures/langs.yaml

@@ -0,0 +1,2 @@
+---
+- langs: [ruby, scheme, haskell]

data/spec/fixtures/test_json.rb

@@ -0,0 +1,9 @@
+test_json = '{
+  "items":[
+    {"has_synonyms":true,"is_moderator_only":false,"is_required":false,"count":190401,"name":"ruby-on-rails"},
+    {"has_synonyms":false,"is_moderator_only":false,"is_required":false,"count":123770,"name":"ruby"}
+  ],
+  "has_more":true,
+  "quota_max":300,
+  "quota_remaining":225
+}'

data/{lib/tests/test_helper.rb → spec/spec_helper.rb}

@@ -4,7 +4,7 @@ require 'yaml'
 
 describe WolframApiFetcher do
   before :each do
-
+    # @book = Book.new 'Title', 'Author', :category
   end
 
   it '' do

data/spec/stackoverflow_api_fetcher_spec.rb

@@ -0,0 +1,62 @@
+require_relative '../lib/stackoverflow_api_fetcher'
+# require_relative 'fixtures/test_json'
+require 'open-uri'
+require 'json'
+
+describe TdBerlinTest::StackexchangeApiFetcher do
+  before(:each) do
+    $stackoverflow_api_fetcher = TdBerlinTest::StackexchangeApiFetcher.new 'fixtures/langs.yaml'
+  end
+
+  describe '.run' do
+    it 'should exist' do
+      expect($stackoverflow_api_fetcher).to respond_to(:run)
+    end
+  end
+
+  describe '.run' do
+    it 'give the correct result for the test data' do
+      $stackoverflow_api_fetcher.run
+      expect($stackoverflow_api_fetcher.result['ruby']).to be > 100000
+    end
+  end
+
+  describe '.parse_yaml_file' do
+    it 'should parse the sample yaml file correctly' do
+      expect($stackoverflow_api_fetcher).to respond_to(:parse_yaml_file)
+      expect($stackoverflow_api_fetcher.language_data[0].keys[0]).to eq 'langs'
+    end
+  end
+
+  describe '.fetch_stackoverflow' do
+    it 'should return a xml response for ruby as input language' do
+      xml_response = JSON.parse($stackoverflow_api_fetcher.fetch_stackoverflow('ruby'))
+      expect(xml_response.keys.include?('items')).to be_truthy
+    end
+  end
+
+  # TODO: move the content of test_json out into fixture
+  describe '.get_tag_usage_count_from_json' do
+    it 'should return a number greater than 100000' do
+      test_json = '{
+        "items":[
+          {"has_synonyms":true,"is_moderator_only":false,"is_required":false,"count":190401,"name":"ruby-on-rails"},
+          {"has_synonyms":false,"is_moderator_only":false,"is_required":false,"count":123770,"name":"ruby"}
+        ],
+        "has_more":true,
+        "quota_max":300,
+        "quota_remaining":225
+      }'
+
+      ruby_tag_count = $stackoverflow_api_fetcher.get_tag_usage_count_from_json(test_json, 'ruby')
+      expect(ruby_tag_count).to be > 100000
+    end
+  end
+
+  describe '.sort_result_by_tag_usage_count' do
+    it 'should sort the items of an input hash by value of items' do
+      result_hash = $stackoverflow_api_fetcher.sort_result_by_tag_usage_count({'a' => 3, 'b' => 5})
+      expect(result_hash).to eq({'b' => 5, 'a' => 3})
+    end
+  end
+end

data/spec/tdberlintest_spec.rb

@@ -0,0 +1,20 @@
+#!/usr/bin/env ruby
+
+require 'TdBerlinTest/TestManager'
+
+module TdBerlinTest
+  class TestManager < Thor
+
+    def task1
+      wolfram_api_fetcher = TdBerlinTest::WolframApiFetcher.new options[:input]
+      wolfram_api_fetcher.run
+    end
+
+    def task2
+      stackexchange_api_fetcher = TdBerlinTest::StackexchangeApiFetcher.new options[:input]
+      stackexchange_api_fetcher.run
+    end
+  end
+end
+
+TdBerlinTest::TestManager.start(ARGV)

data/spec/wolfram_api_fetcher_spec.rb

@@ -0,0 +1,30 @@
+require_relative '../lib/wolfram_api_fetcher'
+require 'open-uri'
+require 'json'
+
+describe TdBerlinTest::WolframApiFetcher do
+  before(:each) do
+    $wolfram_api_fetcher = TdBerlinTest::WolframApiFetcher.new 'fixtures/langs.yaml'
+  end
+
+  describe '.run' do
+    it 'should exist' do
+      expect($wolfram_api_fetcher).to respond_to(:run)
+    end
+  end
+
+  # a rough integration test to make sure we get a result
+  describe '.run' do
+    it 'give the correct result for the test data' do
+      $wolfram_api_fetcher.run
+      expect($wolfram_api_fetcher.result_array.empty?).to_not be_truthy
+    end
+  end
+
+  describe '.parse_yaml_file' do
+    it 'should parse the sample yaml file correctly' do
+      expect($wolfram_api_fetcher).to respond_to(:parse_yaml_file)
+      expect($wolfram_api_fetcher.language_data[0].keys[0]).to eq 'langs'
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tdberlintest
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Phil Stahlschmidt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-18 00:00:00.000000000 Z
+date: 2015-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -130,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -138,10 +139,14 @@ files:
 - lib/stackoverflow_api_fetcher.rb
 - lib/tdberlintest.rb
 - lib/tdberlintest/version.rb
-- lib/tests/test_helper.rb
-- lib/tests/wolfram_api_fetcher_spec.rb
 - lib/wolfram_api_fetcher.rb
-- tdberlintest-0.0.5.gem
+- spec/fixtures/langs.yaml
+- spec/fixtures/test_json.rb
+- spec/spec_helper.rb
+- spec/stackoverflow_api_fetcher_spec.rb
+- spec/tdberlintest_spec.rb
+- spec/wolfram_api_fetcher_spec.rb
+- tdberlintest-0.0.6.gem
 - tdberlintest.gemspec
 homepage: http://www.td-berlin.com
 licenses:
@@ -167,4 +172,10 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: td-berlin.com test solution.
-test_files: []
+test_files:
+- spec/fixtures/langs.yaml
+- spec/fixtures/test_json.rb
+- spec/spec_helper.rb
+- spec/stackoverflow_api_fetcher_spec.rb
+- spec/tdberlintest_spec.rb
+- spec/wolfram_api_fetcher_spec.rb

data/lib/tests/wolfram_api_fetcher_spec.rb

@@ -1,8 +0,0 @@
-require_relative '../wolfram_api_fetcher'
-
-describe wolfram_api_fetcher, '#score' do
-  it 'is just a placeholder' do
-    wolfram_api_fetcher = TdBerlinTest::WolframApiFetcher.new 'langs.yaml'
-    expect(wolfram_api_fetcher.score).to eq(0)
-  end
-end