td 0.13.2 → 0.14.0

data/spec/file_reader/parsing_reader_spec.rb

@@ -13,20 +13,20 @@ describe 'FileReader parsing readers' do
 
   shared_examples_for 'forward basics' do
     it 'forward returns one data' do
-      reader.forward.should == dataset[0]
+      expect(reader.forward).to eq(dataset[0])
     end
 
     it 'feeds all dataset' do
       begin
         i = 0
         while line = reader.forward
-          line.should == dataset[i]
+          expect(line).to eq(dataset[i])
           i += 1
         end
       rescue RSpec::Expectations::ExpectationNotMetError => e
           fail
       rescue => e
-        io.eof?.should be_true
+        expect(io.eof?).to be_truthy
       end
     end
   end
@@ -46,7 +46,7 @@ describe 'FileReader parsing readers' do
 
     it 'initialize' do
       reader = FileReader::MessagePackParsingReader.new(io, error, {})
-      reader.should_not be_nil
+      expect(reader).not_to be_nil
     end
 
     context 'after initialization' do
@@ -102,7 +102,7 @@ describe 'FileReader parsing readers' do
 
       it "initialize #{format}" do
         reader = FileReader::SeparatedValueParsingReader.new(io, error, opts)
-        reader.should_not be_nil
+        expect(reader).not_to be_nil
       end
 
       context "after #{format} initialization" do

data/spec/file_reader/shared_context.rb

@@ -3,7 +3,7 @@ require 'rspec'
 shared_context 'error_proc' do
   let :error do
     Proc.new { |reason, data|
-      reason.should match(error_pattern)
+      expect(reason).to match(error_pattern)
     }
   end
 end

data/spec/file_reader_spec.rb

@@ -12,10 +12,20 @@ describe FileReader do
   describe 'initialize' do
     subject { FileReader.new }
 
-    its(:parser_class) { should be_nil }
-    its(:opts) { should be_empty }
+    describe '#parser_class' do
+      subject { super().parser_class }
+      it { is_expected.to be_nil }
+    end
+
+    describe '#opts' do
+      subject { super().opts }
+      it { is_expected.to be_empty }
+    end
     [:delimiter_expr, :null_expr, :true_expr, :false_expr].each { |key|
-      its(:default_opts) { should have_key(key); }
+      describe '#default_opts' do
+        subject { super().default_opts }
+        it { is_expected.to have_key(key); }
+      end
     }
   end
 
@@ -26,36 +36,36 @@ describe FileReader do
   describe 'set_format_template' do
     it 'can set csv' do
       reader.set_format_template('csv')
-      reader.instance_variable_get(:@format).should == 'text'
-      reader.opts.should include(:delimiter_expr => /,/)
+      expect(reader.instance_variable_get(:@format)).to eq('text')
+      expect(reader.opts).to include(:delimiter_expr => /,/)
     end
 
     it 'can set tsv' do
       reader.set_format_template('tsv')
-      reader.instance_variable_get(:@format).should == 'text'
-      reader.opts.should include(:delimiter_expr => /\t/)
+      expect(reader.instance_variable_get(:@format)).to eq('text')
+      expect(reader.opts).to include(:delimiter_expr => /\t/)
     end
 
     it 'can set apache' do
       reader.set_format_template('apache')
-      reader.instance_variable_get(:@format).should == 'apache'
-      reader.opts.should include(:time_column => 'time')
+      expect(reader.instance_variable_get(:@format)).to eq('apache')
+      expect(reader.opts).to include(:time_column => 'time')
     end
 
     it 'can set syslog' do
       reader.set_format_template('syslog')
-      reader.instance_variable_get(:@format).should == 'syslog'
-      reader.opts.should include(:time_column => 'time')
+      expect(reader.instance_variable_get(:@format)).to eq('syslog')
+      expect(reader.opts).to include(:time_column => 'time')
     end
 
     it 'can set msgpack' do
       reader.set_format_template('msgpack')
-      reader.instance_variable_get(:@format).should == 'msgpack'
+      expect(reader.instance_variable_get(:@format)).to eq('msgpack')
     end
 
     it 'can set json' do
       reader.set_format_template('json')
-      reader.instance_variable_get(:@format).should == 'json'
+      expect(reader.instance_variable_get(:@format)).to eq('json')
     end
 
     it 'raises when set unknown format' do
@@ -77,7 +87,7 @@ describe FileReader do
       ['-f', '--format'].each { |opt|
         ['csv', 'tsv', 'apache', 'syslog', 'msgpack', 'json'].each { |format|
           it "#{opt} option with #{format}" do
-            reader.should_receive(:set_format_template).with(format)
+            expect(reader).to receive(:set_format_template).with(format)
             parse_opt([opt, format]) { }
           end
         }
@@ -89,7 +99,7 @@ describe FileReader do
         it "#{opt} option" do
           columns = 'A,B,C'
           parse_opt([opt, columns]) {
-            reader.opts.should include(:column_names => columns.split(','))
+            expect(reader.opts).to include(:column_names => columns.split(','))
           }
         end
       }
@@ -99,7 +109,7 @@ describe FileReader do
       ['-H', '--column-header'].each { |opt|
         it "#{opt} option" do
           parse_opt([opt]) {
-            reader.opts.should include(:column_header => true)
+            expect(reader.opts).to include(:column_header => true)
           }
         end
       }
@@ -110,7 +120,7 @@ describe FileReader do
         it "#{opt} option" do
           pattern = '!'
           parse_opt([opt, pattern]) {
-            reader.opts.should include(:delimiter_expr => Regexp.new(pattern))
+            expect(reader.opts).to include(:delimiter_expr => Regexp.new(pattern))
           }
         end
       }
@@ -120,7 +130,7 @@ describe FileReader do
       it "--null REGEX option" do
         pattern = 'null'
         parse_opt(['--null', pattern]) {
-          reader.opts.should include(:null_expr => Regexp.new(pattern))
+          expect(reader.opts).to include(:null_expr => Regexp.new(pattern))
         }
       end
     end
@@ -129,7 +139,7 @@ describe FileReader do
       it "--true REGEX option" do
         pattern = 'true'
         parse_opt(['--true', pattern]) {
-          reader.opts.should include(:true_expr => Regexp.new(pattern))
+          expect(reader.opts).to include(:true_expr => Regexp.new(pattern))
         }
       end
     end
@@ -138,7 +148,7 @@ describe FileReader do
       it "--false REGEX option" do
         pattern = 'false'
         parse_opt(['--false', pattern]) {
-          reader.opts.should include(:false_expr => Regexp.new(pattern))
+          expect(reader.opts).to include(:false_expr => Regexp.new(pattern))
         }
       end
     end
@@ -147,7 +157,7 @@ describe FileReader do
       ['-S', '--all-string'].each { |opt|
         it "#{opt} option" do
           parse_opt([opt]) {
-            reader.opts.should include(:all_string => true)
+            expect(reader.opts).to include(:all_string => true)
           }
         end
       }
@@ -158,7 +168,7 @@ describe FileReader do
         it "#{opt} option" do
           name = 'created_at'
           parse_opt([opt, name]) {
-            reader.opts.should include(:time_column => name)
+            expect(reader.opts).to include(:time_column => name)
           }
         end
       }
@@ -169,7 +179,7 @@ describe FileReader do
         it "#{opt} option" do
           format = '%Y'
           parse_opt([opt, format]) {
-            reader.opts.should include(:time_format => format)
+            expect(reader.opts).to include(:time_format => format)
           }
         end
       }
@@ -180,7 +190,7 @@ describe FileReader do
         it "--time-value option with #{value_type}" do
           time = Time.now
           parse_opt(['--time-value', converter.call(time)]) {
-            reader.opts.should include(:time_value => time.to_i)
+            expect(reader.opts).to include(:time_value => time.to_i)
           }
         end
       }
@@ -191,7 +201,7 @@ describe FileReader do
         it "#{opt} option" do
           enc = 'utf-8'
           parse_opt([opt, enc]) {
-            reader.opts.should include(:encoding => enc)
+            expect(reader.opts).to include(:encoding => enc)
           }
         end
       }
@@ -202,7 +212,7 @@ describe FileReader do
         it "#{opt} option" do
           format = 'gzip'
           parse_opt([opt, format]) {
-            reader.opts.should include(:compress => format)
+            expect(reader.opts).to include(:compress => format)
           }
         end
       }
@@ -212,7 +222,7 @@ describe FileReader do
   describe 'compose_factory' do
     it 'returns Proc object' do
       factory = reader.compose_factory
-      factory.should be_an_instance_of(Proc)
+      expect(factory).to be_an_instance_of(Proc)
     end
 
     # other specs in parse spec
@@ -254,7 +264,7 @@ describe FileReader do
         parse_opt(%W(-f #{format} --time-value #{@time}) + (args || [])) {
           i = 0
           reader.parse(io, error) { |record|
-            record.should == dataset[i].merge('time' => @time)
+            expect(record).to eq(dataset[i].merge('time' => @time))
             i += 1
           }
         }
@@ -266,7 +276,7 @@ describe FileReader do
           reader.parse(io, error) { |record|
             time = record[time_column]
             time = Time.parse(time).to_i if time.is_a?(String)
-            record.should == dataset[i].merge('time' => time)
+            expect(record).to eq(dataset[i].merge('time' => time))
             i += 1
           }
         }

data/spec/td/command/connector_spec.rb

@@ -43,7 +43,7 @@ module TreasureData::Command
         let(:out_file) { Tempfile.new('out.yml').tap{|f| f.close } }
 
         before do
-          command.stub(:get_client).and_return(client)
+          allow(command).to receive(:get_client).and_return(client)
         end
 
         let(:config) {
@@ -58,11 +58,11 @@ module TreasureData::Command
         include_context 'quiet_out'
 
         before do
-          command.stub(:prepare_bulkload_job_config).and_return(config)
+          allow(command).to receive(:prepare_bulkload_job_config).and_return(config)
         end
 
         it 'guess_plugins passed td-client' do
-          client.should_receive(:bulk_load_guess).with({config: expect_config}).and_return({})
+          expect(client).to receive(:bulk_load_guess).with({config: expect_config}).and_return({})
 
           command.connector_guess(option)
         end
@@ -82,7 +82,7 @@ module TreasureData::Command
         }
 
         before do
-            command.stub(:get_client).and_return(client)
+            allow(command).to receive(:get_client).and_return(client)
             command.connector_guess(option)
         end
 
@@ -118,7 +118,7 @@ module TreasureData::Command
 
       before do
         client = double(:client, bulk_load_preview: preview_result)
-        command.stub(:get_client).and_return(client)
+        allow(command).to receive(:get_client).and_return(client)
       end
 
       it 'should include too_long_column_name without truncated' do
@@ -141,8 +141,8 @@ module TreasureData::Command
 
         before do
           client = double(:client, bulk_load_issue: 1234)
-          command.stub(:get_client).and_return(client)
-          command.stub(:create_database_and_table_if_not_exist)
+          allow(command).to receive(:get_client).and_return(client)
+          allow(command).to receive(:create_database_and_table_if_not_exist)
         end
 
         it 'should include too_long_column_name without truncated' do
@@ -154,8 +154,8 @@ module TreasureData::Command
         let(:client) { double(:client, bulk_load_issue: 1234) }
 
         before do
-          command.stub(:get_client).and_return(client)
-          client.stub(:database)
+          allow(command).to receive(:get_client).and_return(client)
+          allow(client).to receive(:database)
         end
 
         context 'set auto crate table option' do
@@ -164,7 +164,7 @@ module TreasureData::Command
           }
 
           it 'call create_database_and_table_if_not_exist' do
-            command.should_receive(:create_database_and_table_if_not_exist)
+            expect(command).to receive(:create_database_and_table_if_not_exist)
 
             subject
           end
@@ -176,7 +176,7 @@ module TreasureData::Command
           }
 
           it 'call create_database_and_table_if_not_exist' do
-            command.should_not_receive(:create_database_and_table_if_not_exist)
+            expect(command).not_to receive(:create_database_and_table_if_not_exist)
 
             subject
           end
@@ -191,8 +191,8 @@ module TreasureData::Command
       let(:job_name) { 'job_1' }
 
       before do
-        command.stub(:get_client).and_return(client)
-        client.stub(:database)
+        allow(command).to receive(:get_client).and_return(client)
+        allow(client).to receive(:database)
       end
 
       context 'with scheduled_time' do
@@ -202,7 +202,7 @@ module TreasureData::Command
         }
 
         it 'client call with unix time' do
-          client.should_receive(:bulk_load_run).with(job_name, scheduled_time.to_i).and_return(123)
+          expect(client).to receive(:bulk_load_run).with(job_name, scheduled_time.to_i).and_return(123)
 
           command.connector_run(option)
         end
@@ -215,8 +215,8 @@ module TreasureData::Command
         let(:current_time) { Time.now }
 
         it 'client call with unix time' do
-          client.should_receive(:bulk_load_run).with(job_name, current_time.to_i).and_return(123)
-          command.stub(:current_time).and_return(current_time.to_i)
+          expect(client).to receive(:bulk_load_run).with(job_name, current_time.to_i).and_return(123)
+          allow(command).to receive(:current_time).and_return(current_time.to_i)
 
           command.connector_run(option)
         end
@@ -235,8 +235,8 @@ module TreasureData::Command
 
       before do
         client = double(:client)
-        client.stub(:bulk_load_history).with(name).and_return(history)
-        command.stub(:get_client).and_return(client)
+        allow(client).to receive(:bulk_load_history).with(name).and_return(history)
+        allow(command).to receive(:get_client).and_return(client)
       end
 
       context 'history is empty' do
@@ -308,7 +308,7 @@ module TreasureData::Command
       }
 
       before do
-        command.stub(:get_client).and_return(client)
+        allow(command).to receive(:get_client).and_return(client)
         command.connector_list(option)
       end
 
@@ -341,8 +341,8 @@ module TreasureData::Command
       }
 
       before do
-        command.stub(:get_table)
-        command.stub(:get_client).and_return(client)
+        allow(command).to receive(:get_table)
+        allow(command).to receive(:get_client).and_return(client)
         command.connector_create(option)
       end
 

data/spec/td/command/export_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+require 'td/command/common'
+require 'td/command/list'
+require 'td/command/export'
+
+module TreasureData::Command
+  describe 'export commands' do
+    let(:command) {
+      Class.new { include TreasureData::Command }.new
+    }
+    let(:stdout_io) { StringIO.new }
+    let(:stderr_io) { StringIO.new }
+
+    around do |example|
+      stdout = $stdout.dup
+      stderr = $stderr.dup
+
+      begin
+        $stdout = stdout_io
+        $stderr = stderr_io
+
+        example.run
+      ensure
+        $stdout = stdout
+        $stderr = stderr
+      end
+    end
+
+    describe '#table_export' do
+      let(:option) {
+        List::CommandParser.new("table:export", ["db_name", "table_name"], [], nil, option_list, true)
+      }
+      let(:option_with_encryption) {
+        ops = option_list
+        ops.push "-e"
+        ops.push encryption
+        List::CommandParser.new("table:export", ["db_name", "table_name"], [], nil, ops, true)
+      }
+      let(:option_with_wrong_encryption) {
+        ops = option_list
+        ops.push "-e"
+        ops.push wrong_encryption
+        List::CommandParser.new("table:export", ["db_name", "table_name"], [], nil, ops, true)
+      }
+      let(:option_list) { [database, table, "-b", bucket, "-p", path, "-k", key, "-s", pass, "-F", format] }
+      let(:database) { 'database' }
+      let(:table)    { 'table' }
+      let(:bucket)    { 'bucket' }
+      let(:path)    { 'path' }
+      let(:key)    { 'key' }
+      let(:pass)    { 'pass' }
+      let(:format)    { 'tsv.gz' }
+      let(:encryption)    { 's3' }
+      let(:wrong_encryption)    { 's3s3' }
+      let(:job_id)    { 111 }
+
+      before do
+        client = double(:client)
+        job = double(:job, job_id: job_id)
+        allow(client).to receive(:export).and_return(job)
+        table = double(:table)
+
+        allow(command).to receive(:get_client).and_return(client)
+        allow(command).to receive(:get_table).and_return(table)
+      end
+
+      it 'export table without encryption' do
+        expect {
+          command.table_export(option)
+        }.to_not raise_exception
+      end
+
+      it 'export table with encryption' do
+        expect {
+          command.table_export(option_with_encryption)
+        }.to_not raise_exception
+      end
+
+      it 'fail to export table with wrong encryption' do
+        expect {
+          command.table_export(option_with_wrong_encryption)
+        }.to raise_exception
+      end
+    end
+  end
+end