tco_client_core 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 988aa36ca352a04d8301597ea64143f36ce78971
-  data.tar.gz: 7dd34b6afb2fd308003a9a0322ac4a2e44219f17
+  metadata.gz: c13303b1d63c373df6e28f468fb5a844b39bd997
+  data.tar.gz: 9d5d5f9107c31f0794e264c3c4f58fc6b0f8fb42
 SHA512:
-  metadata.gz: a03da0c76691340140a2dd11d774c83a91f89c1f415f88369b2b6faf453324f46e978ff55ec4776d04aab7d2321fa29ca1030db06b2429fdc8b3bcad834e78f6
-  data.tar.gz: 2605a74f0b59bb4e3de9236f24c697aac30098fdb954a64a5c29c8bc72c505f7b95e0da399848e2f0dbee830eeb578df5cb85b23b2bfd872a0c8018c485028d9
+  metadata.gz: 3c76fedbae3fae6f654de6382ca6b91ad80cd3b60766ac181e914a7a22333ad5f1b4e4c3cf234b49d3967c2707b222923b6298f6c95991d84d7e66019ecf7948
+  data.tar.gz: 1384d6962243cdadfc84b777b9caa7e20321d0f7961f9770e13482b5f0d5a4b7a7fa19e54a7ee047df639ef6b958f199b2cd49e8b95d1cc55ce6f846c2859b88

data/lib/tco_client_core.rb

@@ -1,7 +1,8 @@
 require "ostruct"
 require "tco_client_core/version"
-require "tco_client_core/base_request"
+require "tco_client_core/request"
 require "tco_client_core/response"
+require "tco_client_core/model"
 
 module TcoClientCore
   class Error < StandardError; end

data/lib/tco_client_core/model.rb

@@ -0,0 +1,19 @@
+require "active_model"
+
+class TcoClientCore::Model
+  include ActiveModel::Model
+
+  def self.new_with_errors attributes, errors
+    model = new attributes
+    errors.each do |key, messages|
+      messages.each do |message|
+        model.errors.add(key.to_sym, message)
+      end
+    end
+    model
+  end
+
+  def valid?
+    !errors.any?
+  end
+end

data/lib/tco_client_core/{base_request.rb → request.rb}

@@ -3,7 +3,7 @@ require "rest_client"
 require "base64"
 
 module TcoClientCore
-  class BaseRequest
+  class Request
     def self.base_uri
       TcoClientCore.config.base_uri
     end
@@ -14,7 +14,7 @@ module TcoClientCore
     end
 
     def self.request(endpoint, method, payload={})
-      raise "Base URI not set" if base_uri.nil?
+      raise "TcoClientCore::Request Base URI not set" if base_uri.nil?
       params = {
         method: method,
         url: "#{base_uri}/#{endpoint}",

data/lib/tco_client_core/response.rb

@@ -9,7 +9,7 @@ module TcoClientCore
     def initialize(raw)
       @raw = raw
       @response = JSON.parse(raw)
-      raise ArgumentError, "TcoClientCore::Response: response hash required" unless @response.is_a? Hash
+      raise ArgumentError, "TcoClientCore::Response response hash required" unless @response.is_a? Hash
       @response.keys.each do |key|
         next if key == "errors"
         define_singleton_method(key) { @response[key] }
@@ -17,7 +17,7 @@ module TcoClientCore
     end
 
     def errors?
-      @response.key?("errors")
+      errors.any?
     end
 
     def errors

data/lib/tco_client_core/version.rb

@@ -1,3 +1,3 @@
 module TcoClientCore
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/model_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+describe TcoClientCore::Model do
+  class TestModel < TcoClientCore::Model
+    attr_accessor :property
+  end
+
+  describe ".new_with_errors" do
+    it "adds the errors to the model" do
+      subject = TestModel.new_with_errors({ property: "value" }, { property: ["can't be value"] })
+      expect(subject.errors).not_to be_empty
+      expect(subject).not_to be_valid
+    end
+  end
+
+  describe "#valid?" do
+    it "returns true when no errors are present" do
+      subject = TestModel.new(property: "value")
+      expect(subject).to be_valid
+    end
+  end
+end

data/spec/{base_request_spec.rb → request_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe TcoClientCore::BaseRequest do
+describe TcoClientCore::Request do
   before do
     allow(TcoClientCore.config).to receive(:base_uri) { "base_uri" }
     allow(TcoClientCore.config).to receive(:vendor_id) { "vendor_id" }
@@ -9,7 +9,7 @@ describe TcoClientCore::BaseRequest do
 
   describe '.authorization' do
     it 'Base64 encodes the vendor id and api key and prepends "Basic "' do
-      expect(TcoClientCore::BaseRequest.authorization).to eq("Basic #{Base64::encode64("#{TcoClientCore.config.vendor_id}:#{TcoClientCore.config.api_key}")}")
+      expect(TcoClientCore::Request.authorization).to eq("Basic #{Base64::encode64("#{TcoClientCore.config.vendor_id}:#{TcoClientCore.config.api_key}")}")
     end
   end
 
@@ -18,7 +18,7 @@ describe TcoClientCore::BaseRequest do
       allow(TcoClientCore.config).to receive(:base_uri) { nil }
       expect {
         subject.request("test", :get)
-      }.to raise_error("Base URI not set")
+      }.to raise_error("TcoClientCore::Request Base URI not set")
     end
 
     it "makes a rest request with the given endpoint, including the authorization" do
@@ -30,7 +30,7 @@ describe TcoClientCore::BaseRequest do
         headers: {
           accept: :json,
           content_type: 'application/json',
-          authorization: TcoClientCore::BaseRequest.authorization
+          authorization: TcoClientCore::Request.authorization
         }
       }).and_return double(execute: "{}")
       subject.request("test", :get)
@@ -45,7 +45,7 @@ describe TcoClientCore::BaseRequest do
         headers: {
           accept: :json,
           content_type: "application/json",
-          authorization: TcoClientCore::BaseRequest.authorization
+          authorization: TcoClientCore::Request.authorization
         },
         payload: payload_data.to_json
       }).and_return double(execute: "{}")
@@ -54,36 +54,36 @@ describe TcoClientCore::BaseRequest do
 
     it "returns a response" do
       allow_any_instance_of(RestClient::Request).to receive(:execute).and_return({ "test" => "result" }.to_json)
-      response = TcoClientCore::BaseRequest.request("test", :get)
+      response = TcoClientCore::Request.request("test", :get)
       expect(response).to be_kind_of(TcoClientCore::Response)
     end
   end
 
   describe ".get" do
     it "makes a get request" do
-      expect(TcoClientCore::BaseRequest).to receive(:request).with("test", :get, {})
-      TcoClientCore::BaseRequest.get("test")
+      expect(TcoClientCore::Request).to receive(:request).with("test", :get, {})
+      TcoClientCore::Request.get("test")
     end
   end
 
   describe ".post" do
     it "makes a post request" do
-      expect(TcoClientCore::BaseRequest).to receive(:request).with("test", :post, {})
-      TcoClientCore::BaseRequest.post("test")
+      expect(TcoClientCore::Request).to receive(:request).with("test", :post, {})
+      TcoClientCore::Request.post("test")
     end
   end
 
   describe ".patch" do
     it "makes a patch request" do
-      expect(TcoClientCore::BaseRequest).to receive(:request).with("test", :patch, {})
-      TcoClientCore::BaseRequest.patch("test")
+      expect(TcoClientCore::Request).to receive(:request).with("test", :patch, {})
+      TcoClientCore::Request.patch("test")
     end
   end
 
   describe ".delete" do
     it "makes a delete request" do
-      expect(TcoClientCore::BaseRequest).to receive(:request).with("test", :delete, {})
-      TcoClientCore::BaseRequest.delete("test")
+      expect(TcoClientCore::Request).to receive(:request).with("test", :delete, {})
+      TcoClientCore::Request.delete("test")
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tco_client_core
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - 2CO Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-20 00:00:00.000000000 Z
+date: 2015-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -228,10 +228,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/tco_client_core.rb
-- lib/tco_client_core/base_request.rb
+- lib/tco_client_core/model.rb
+- lib/tco_client_core/request.rb
 - lib/tco_client_core/response.rb
 - lib/tco_client_core/version.rb
-- spec/base_request_spec.rb
+- spec/model_spec.rb
+- spec/request_spec.rb
 - spec/response_spec.rb
 - spec/spec_helper.rb
 - spec/tco_base_api_spec.rb
@@ -260,7 +262,8 @@ signing_key:
 specification_version: 4
 summary: Gem to handle communication with the 2CO API
 test_files:
-- spec/base_request_spec.rb
+- spec/model_spec.rb
+- spec/request_spec.rb
 - spec/response_spec.rb
 - spec/spec_helper.rb
 - spec/tco_base_api_spec.rb