tcell_agent 2.0.0 → 2.2.1

data/spec/lib/tcell_agent/{cmdi_spec.rb → instrumentation/cmdi_spec.rb}

@@ -147,5 +147,55 @@ module TCellAgent
         end
       end
     end
+    describe '.parse_command_from_open' do
+      context 'with empty parameters' do
+        it 'should not return a command' do
+          cmd = TCellAgent::Cmdi.parse_command_from_open
+          expect(cmd).to eq('')
+        end
+      end
+      context 'with empty array' do
+        it 'should not return a command' do
+          args = []
+          cmd = TCellAgent::Cmdi.parse_command_from_open(*args)
+          expect(cmd).to eq('')
+        end
+      end
+      context 'with a string command' do
+        context 'with an empty string' do
+          it 'should return an empty string' do
+            cmd = TCellAgent::Cmdi.parse_command_from_open('')
+            expect(cmd).to eq('')
+          end
+        end
+        context 'with an empty command' do
+          it 'should return an empty string' do
+            cmd = TCellAgent::Cmdi.parse_command_from_open('|')
+            expect(cmd).to eq('')
+          end
+        end
+        context 'with a non-empty command' do
+          it 'should parse the command properly' do
+            cmd = TCellAgent::Cmdi.parse_command_from_open('|echo')
+            expect(cmd).to eq('echo')
+
+            cmd = TCellAgent::Cmdi.parse_command_from_open('|ls -l /tmp')
+            expect(cmd).to eq('ls -l /tmp')
+          end
+        end
+      end
+      context 'with a filename argument' do
+        it 'should not return a command' do
+          cmd = TCellAgent::Cmdi.parse_command_from_open('/tmp')
+          expect(cmd).to eq('')
+        end
+      end
+      context 'with a non-string first argument' do
+        it 'should return an empty string' do
+          cmd = TCellAgent::Cmdi.parse_command_from_open({})
+          expect(cmd).to eq('')
+        end
+      end
+    end
   end
 end

data/spec/lib/tcell_agent/instrumentation/lfi/io_lfi_spec.rb

@@ -42,6 +42,7 @@ describe 'IO' do
             TCellAgent::PolicyTypes::LFI
           ).and_return(@local_files_policy)
           expect(@local_files_policy).to receive(:block_file_access?).and_return(false)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -75,6 +76,7 @@ describe 'IO' do
             TCellAgent::PolicyTypes::LFI
           ).and_return(@local_files_policy)
           expect(@local_files_policy).to receive(:block_file_access?).and_return(true)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -254,6 +256,7 @@ describe 'IO' do
           ).and_return(@local_files_policy)
 
           expect(@local_files_policy).to receive(:block_file_access?).and_return(false)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -288,6 +291,7 @@ describe 'IO' do
           ).and_return(@local_files_policy)
 
           expect(@local_files_policy).to receive(:block_file_access?).and_return(true)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -338,6 +342,7 @@ describe 'IO' do
           ).and_return(@local_files_policy)
 
           expect(@local_files_policy).to receive(:block_file_access?).and_return(false)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -366,6 +371,7 @@ describe 'IO' do
           ).and_return(@local_files_policy)
 
           expect(@local_files_policy).to receive(:block_file_access?).and_return(true)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 

data/spec/lib/tcell_agent/instrumentation/lfi/kernel_lfi_spec.rb

@@ -2,6 +2,7 @@
 # rubocop:disable Lint/UselessAssignment
 require 'spec_helper'
 require 'securerandom'
+require 'pathname'
 
 describe 'Kernel' do
   before do
@@ -15,6 +16,7 @@ describe 'Kernel' do
 
   before(:all) do
     @new_file_name = '/tmp/' + SecureRandom.uuid
+    @new_pathname = Pathname.new(@new_file_name)
   end
   describe '#open and ::open' do
     context 'empty path' do
@@ -39,13 +41,14 @@ describe 'Kernel' do
         end.to raise_error(Errno::ENOENT)
       end
     end
-    context 'with a filename not blocked for read/write' do
+    context 'with a non-existent file, with filename not blocked for read/write' do
       before do |test|
         unless test.metadata[:skip_before]
           expect(TCellAgent).to receive(:policy).with(
             TCellAgent::PolicyTypes::LFI
           ).and_return(@local_files_policy, @local_files_policy)
           expect(@local_files_policy).to receive(:block_file_access?).and_return(false, false)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -56,7 +59,18 @@ describe 'Kernel' do
         result = open('|echo test').read
         expect(result).to eq "test\n"
       end
-      context 'with a nonexistent filename with mode w' do
+      context 'with a pathname filename with mode w' do
+        it 'should create the file' do
+          Kernel.open(@new_pathname, 'w')
+          expect(File.exist?(@new_pathname)).to be_truthy
+          File.delete(@new_pathname)
+
+          open(@new_pathname, 'w')
+          expect(File.exist?(@new_pathname)).to be_truthy
+          File.delete(@new_pathname)
+        end
+      end
+      context 'with a filename with mode w' do
         it 'should create the file' do
           Kernel.open(@new_file_name, 'w')
           expect(File.exist?(@new_file_name)).to be_truthy
@@ -90,13 +104,14 @@ describe 'Kernel' do
         end
       end
     end
-    context 'with a filename blocked for read/write' do
+    context 'with a non-existent file, with filename blocked for read/write' do
       before do |test|
         unless test.metadata[:skip_before]
           expect(TCellAgent).to receive(:policy).with(
             TCellAgent::PolicyTypes::LFI
           ).and_return(@local_files_policy, @local_files_policy)
           expect(@local_files_policy).to receive(:block_file_access?).and_return(true, true)
+          expect(TCellAgent::Cmdi).not_to receive(:parse_command_from_open)
         end
       end
 
@@ -107,7 +122,7 @@ describe 'Kernel' do
         result = open('|echo test').read
         expect(result).to eq "test\n"
       end
-      context 'with a nonexistent filename with mode w' do
+      context 'with a filename with mode w' do
         it 'should raise an error' do
           expect do
             Kernel.open(@new_file_name, 'w')

data/spec/lib/tcell_agent/instrumentation/lfi_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module TCellAgent
   module Instrumentation
     module Lfi
-      describe 'extract path and mode' do
+      describe '.extract_path_mode' do
         context 'with path' do
           it 'should extract the path correctly' do
             args = '/path-to-file'
@@ -34,51 +34,91 @@ module TCellAgent
               args = '/path-to-file', 'r'
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Read')
+
+              args = '/path-to-file', { :mode => 'r' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Read')
             end
             it 'should return Write for mode w' do
               args = '/path-to-file', 'w'
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Write')
+
+              args = '/path-to-file', { :mode => 'w' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Write')
             end
             it 'should return Write for mode a' do
               args = '/path-to-file', 'a'
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Write')
+
+              args = '/path-to-file', { :mode => 'a' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Write')
             end
             it 'should return ReadWrite for mode r+' do
               args = '/path-to-file', 'r+'
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('ReadWrite')
+
+              args = '/path-to-file', { :mode => 'r+' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('ReadWrite')
             end
             it 'should return ReadWrite for mode w+' do
               args = '/path-to-file', 'w+'
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('ReadWrite')
+
+              args = '/path-to-file', { :mode => 'w+' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('ReadWrite')
             end
             it 'should return ReadWrite for mode a+' do
               args = '/path-to-file', 'a+'
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('ReadWrite')
+
+              args = '/path-to-file', { :mode => 'a+' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('ReadWrite')
             end
             it 'should return Read for mode ::File::RDONLY (0)' do
               args = '/path-to-file', ::File::RDONLY
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Read')
+
+              args = '/path-to-file', { :mode => ::File::RDONLY }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Read')
             end
             it 'should return Write for mode ::File::WRONLY (1)' do
               args = '/path-to-file', ::File::WRONLY
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Write')
+
+              args = '/path-to-file', { :mode => ::File::WRONLY }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Write')
             end
             it 'should return ReadWrite for mode ::File::RDWR (2)' do
               args = '/path-to-file', ::File::RDWR
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('ReadWrite')
+
+              args = '/path-to-file', { :mode => ::File::RDWR }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('ReadWrite')
             end
             it 'should return Write for mode ::File::CREAT | ::File::EXCL | ::File::WRONLY (2561)' do
               args = '/path-to-file', ::File::CREAT | ::File::EXCL | ::File::WRONLY
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Write')
+
+              args = '/path-to-file', { :mode => ::File::CREAT | ::File::EXCL | ::File::WRONLY }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Write')
             end
           end
           context 'with an invalid mode' do
@@ -87,11 +127,16 @@ module TCellAgent
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Read')
             end
-            it 'should return Read when mode is a hash' do
+            it 'should return Read when mode is an empty hash' do
               args = '/path-to-file', {}
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
               expect(mode).to eq('Read')
             end
+            it 'should return Read when mode is a hash without a :mode key' do
+              args = '/path-to-file', { :placeholder => 'testing' }
+              _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)
+              expect(mode).to eq('Read')
+            end
             it 'should return Read when mode is an array' do
               args = '/path-to-file', []
               _path, mode = TCellAgent::Instrumentation::Lfi.extract_path_mode(*args)

data/spec/lib/tcell_agent/rust/agent_config_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+module TCellAgent
+  module Rust
+    describe AgentConfig do
+      context 'with initializers set' do
+        before do
+          TCellAgent.configure do |config|
+            config.app_id = 'initializer_app_id_set'
+            config.api_key = 'initializer_api_key_set'
+            config.enabled_instrumentations = { 'authlogic' => false, :devise => false, 'doorkeeper' => false }
+            config.hmac_key = config.app_id
+          end
+        end
+        it 'should return the correct values' do
+          config = AgentConfig.new(TCellAgent.initializer_configuration)
+
+          expect(config['agent_type']).to eq 'Ruby'
+          expect(config['overrides']['disabled_instrumentation']).to contain_exactly('authlogic', 'devise', 'doorkeeper')
+          expect(config['overrides']['applications'][0][:api_key]).to eq 'initializer_api_key_set'
+          expect(config['overrides']['applications'][0][:app_id]).to eq 'initializer_app_id_set'
+          expect(config['overrides']['applications'][0][:api_key]).to eq 'initializer_api_key_set'
+        end
+      end
+    end
+  end
+end

data/spec/lib/tcell_agent/settings_reporter_spec.rb

@@ -14,7 +14,6 @@ module TCellAgent
                              :reverse_proxy => true,
                              :reverse_proxy_ip_address_header => nil,
                              :log_filename => 'log-filename',
-                             :config_filename => 'config-filename',
                              :agent_log_dir => 'agent-log-dir',
                              :agent_home_dir => 'agent-home-dir',
                              :agent_home_owner => nil,
@@ -57,78 +56,6 @@ module TCellAgent
           'value' => 'true'
         }
       )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'allow_payloads',
-          'value' => 'true'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'reverse_proxy',
-          'value' => 'true'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'config_filename',
-          'value' => 'config-filename'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'logging_directory',
-          'value' => 'agent-log-dir'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'agent_home_directory',
-          'value' => 'agent-home-dir'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'logging_enabled',
-          'value' => 'true'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'logging_level',
-          'value' => 'INFO'
-        }
-      )
-      expect(TCellAgent).to receive(:send_event).with(
-        {
-          'event_type' => 'app_config_setting',
-          'package' => 'tcell',
-          'section' => 'config',
-          'name' => 'reverse_proxy_ip_address_header',
-          'value' => ''
-        }
-      )
 
       TCellAgent.report_settings
     end

data/spec/spec_helper.rb

@@ -20,3 +20,9 @@ end
 
 require 'tcell_agent/agent'
 require 'tcell_agent/rails/routes'
+
+TCellAgent.configuration.enabled = true
+TCellAgent.configuration.instrument = true
+TCellAgent.configuration.enable_intercept_requests = true
+TCellAgent.configuration.disabled_instrumentation = []
+TCellAgent.thread_agent.instrument_built_ins

data/spec/support/builders.rb

@@ -1,12 +1,11 @@
 require 'spec_helper'
+require 'tcell_agent/config_initializer'
+
 module TCellAgent
   module Tests
     class ConfigurationBuilder
       def initialize
-        @configuration = TCellAgent::Configuration.new
-        @configuration.config_filename = 'tcell_agent.config'
-        @configuration.demomode = false
-        @configuration.enable_event_manager = false
+        @configuration = TCellAgent::ConfigInitializer.new
         @configuration.fetch_policies_from_tcell = false
         @configuration.max_csp_header_bytes = nil
         @configuration.app_id = 'TestAppId-AppId'
@@ -18,11 +17,12 @@ module TCellAgent
         @configuration.allow_payloads = true
         @configuration.js_agent_api_base_url = @configuration.tcell_api_url
         @configuration.js_agent_url = 'https://jsagent.tcell.io/tcellagent.min.js'
-        @configuration.cache_folder = nil
         @configuration.agent_log_dir = 'tcell/logs'
-        @configuration.logging_options = { 'enabled' => false }
+        @configuration.logging_options = { :enabled => false }
         @configuration.host_identifier = 'python-test-suite'
         @configuration.reverse_proxy_ip_address_header = 'X-Forwarded-For'
+        @configuration.enable_intercept_requests = true
+        @configuration.enabled = true
       end
 
       def update_attribute(attribute, setting)