tcell_agent 1.1.12 → 2.0.0

data/spec/lib/tcell_agent/config/unknown_options_spec.rb

@@ -6,8 +6,6 @@ module TCellAgent
       describe '.get_unknown_options' do
         context 'with an unknown tcell environment variable set' do
           it 'should return a message about the unknown variable' do
-            orig_allow_uap = ENV.fetch('TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS', nil)
-            orig_allow_uafp = ENV.fetch('TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS', nil)
             orig_allow_ap = ENV.fetch('TCELL_AGENT_ALLOW_PAYLOADS', nil)
             orig_demomode = ENV.fetch('TCELL_DEMOMODE', nil)
             orig_agent_home = ENV.fetch('TCELL_AGENT_HOME', nil)
@@ -22,8 +20,6 @@ module TCellAgent
             orig_password_hmac_key = ENV.fetch('TCELL_PASSWORD_HMAC_KEY', nil)
 
             ENV['TCELL_HACK'] = 'hack the system'
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'] = 'valid'
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'] = 'valid'
             ENV['TCELL_AGENT_ALLOW_PAYLOADS'] = 'valid'
             ENV['TCELL_DEMOMODE'] = 'valid'
             ENV['TCELL_AGENT_HOME'] = 'valid'
@@ -40,17 +36,7 @@ module TCellAgent
             messages = Validate.get_unknown_options(nil)
 
             ENV.delete 'TCELL_HACK'
-            if orig_allow_uap
-              ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'] = orig_allow_uap
-            else
-              ENV.delete 'TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'
-            end
 
-            if orig_allow_uafp
-              ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'] = orig_allow_uafp
-            else
-              ENV.delete 'TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'
-            end
             if orig_allow_ap
               ENV['TCELL_AGENT_ALLOW_PAYLOADS'] = orig_allow_ap
             else
@@ -150,8 +136,6 @@ module TCellAgent
                   'js_agent_url' => 'js agent url',
                   'max_csp_header_bytes' => 512,
                   'event_batch_size_limit' => 50,
-                  'allow_unencrypted_appsensor_payloads' => true,
-                  'allow_unencrypted_appfirewall_payloads' => true,
                   'allow_payloads' => true,
                   'data_exposure' => {
                     'data_ex_level' => 'boo',
@@ -164,12 +148,10 @@ module TCellAgent
                   'disable_all' => false,
                   'enabled' => true,
                   'enable_event_manager' => true,
-                  'enable_event_consumer' => true,
                   'enable_policy_polling' => true,
                   'enable_instrumentation' => true,
                   'enable_intercept_requests' => true,
                   'instrument_for_events' => true,
-                  'agent_home_owner' => true,
                   'enabled_instrumentations' => {
                     'enabled_instrumentations_level' => 'blah',
                     'doorkeeper' => true,

data/spec/lib/tcell_agent/configuration_spec.rb

@@ -7,9 +7,6 @@ module TCellAgent
         it 'should set cache file, config, and log file to defaults' do
           configuration = Configuration.new
 
-          expect(configuration.cache_filename_with_app_id).to match(
-            %r{/tcell/cache/tcell_agent.cache}
-          )
           expect(configuration.log_filename).to eq(
             File.join(Dir.getwd, 'tcell/logs/tcell_agent.log')
           )
@@ -27,9 +24,6 @@ module TCellAgent
 
           configuration = Configuration.new
 
-          expect(configuration.cache_filename_with_app_id).to match(
-            %r{spec_tcell_home/cache/tcell_agent.cache}
-          )
           expect(configuration.log_filename).to eq(
             'spec_tcell_home/logs/tcell_agent.log'
           )
@@ -51,9 +45,6 @@ module TCellAgent
 
           configuration = Configuration.new
 
-          expect(configuration.cache_filename_with_app_id).to match(
-            %r{spec_tcell_home/cache/tcell_agent.cache}
-          )
           expect(configuration.log_filename).to eq(
             'spec_tcell_log_dir/tcell_agent.log'
           )
@@ -78,9 +69,6 @@ module TCellAgent
 
           configuration = Configuration.new
 
-          expect(configuration.cache_filename_with_app_id).to match(
-            %r{spec_tcell_home/cache/tcell_agent.cache}
-          )
           expect(configuration.log_filename).to eq(
             'spec_tcell_log_dir/tcell_agent.log'
           )
@@ -178,61 +166,9 @@ module TCellAgent
 
     describe '#allow_payloads' do
       context 'setting it via config' do
-        context 'using allow_unencrypted_appsensor_payloads' do
-          it 'should be false' do
-            allow_unencrypted_appfirewall_payloads_enabled = double(
-              'no_data_ex',
-              :read => {
-                :version => 1,
-                :applications => [
-                  :app_id => 'app_id',
-                  :api_key => 'api_key',
-                  :allow_unencrypted_appsensor_payloads => false
-                ]
-              }.to_json
-            )
-            expect(File).to receive(:file?).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(true)
-            expect(File).to receive(:open).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(allow_unencrypted_appfirewall_payloads_enabled)
-
-            configuration = Configuration.new
-
-            expect(configuration.allow_payloads).to eq(false)
-          end
-        end
-
-        context 'using allow_unencrypted_appfirewall_payloads' do
-          it 'should be false' do
-            allow_unencrypted_appfirewall_payloads_enabled = double(
-              'no_data_ex',
-              :read => {
-                :version => 1,
-                :applications => [
-                  :app_id => 'app_id',
-                  :api_key => 'api_key',
-                  :allow_unencrypted_appfirewall_payloads => false
-                ]
-              }.to_json
-            )
-            expect(File).to receive(:file?).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(true)
-            expect(File).to receive(:open).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(allow_unencrypted_appfirewall_payloads_enabled)
-
-            configuration = Configuration.new
-
-            expect(configuration.allow_payloads).to eq(false)
-          end
-        end
-
         context 'using allow_payloads' do
           it 'should be false' do
-            allow_unencrypted_appfirewall_payloads_enabled = double(
+            allow_payloads_enabled = double(
               'no_data_ex',
               :read => {
                 :version => 1,
@@ -248,7 +184,7 @@ module TCellAgent
             ).and_return(true)
             expect(File).to receive(:open).with(
               File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(allow_unencrypted_appfirewall_payloads_enabled)
+            ).and_return(allow_payloads_enabled)
 
             configuration = Configuration.new
 
@@ -258,89 +194,19 @@ module TCellAgent
       end
 
       context 'setting it via env var' do
-        context 'TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS overrides config file' do
-          it 'should be false' do
-            old_allow_unencrypted_appsensor_payloads = ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS']
-
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'] = 'false'
-
-            allow_unencrypted_appfirewall_payloads_enabled = double(
-              'no_data_ex',
-              :read => {
-                :version => 1,
-                :applications => [
-                  :app_id => 'app_id',
-                  :api_key => 'api_key',
-                  :allow_unencrypted_appsensor_payloads => true
-                ]
-              }.to_json
-            )
-            expect(File).to receive(:file?).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(true)
-            expect(File).to receive(:open).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(allow_unencrypted_appfirewall_payloads_enabled)
-
-            configuration = Configuration.new
-
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'] = old_allow_unencrypted_appsensor_payloads
-
-            expect(configuration.allow_payloads).to eq(false)
-          end
-        end
-
-        context 'TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS overrides config file' do
-          it 'should be false' do
-            old_allow_unencrypted_appfirewall_payloads = ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS']
-
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'] = 'false'
-
-            allow_unencrypted_appfirewall_payloads_enabled = double(
-              'no_data_ex',
-              :read => {
-                :version => 1,
-                :applications => [
-                  :app_id => 'app_id',
-                  :api_key => 'api_key',
-                  :allow_unencrypted_appfirewall_payloads => true
-                ]
-              }.to_json
-            )
-            expect(File).to receive(:file?).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(true)
-            expect(File).to receive(:open).with(
-              File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(allow_unencrypted_appfirewall_payloads_enabled)
-
-            configuration = Configuration.new
-
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'] = old_allow_unencrypted_appfirewall_payloads
-
-            expect(configuration.allow_payloads).to eq(false)
-          end
-        end
-
         context 'TCELL_AGENT_ALLOW_PAYLOADS overrides everything else' do
           it 'should be false' do
-            old_allow_unencrypted_appsensor_payloads = ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS']
-            old_allow_unencrypted_appfirewall_payloads = ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS']
             old_tcell_agent_allow_payloads = ENV['TCELL_AGENT_ALLOW_PAYLOADS']
 
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'] = 'true'
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'] = 'true'
             ENV['TCELL_AGENT_ALLOW_PAYLOADS'] = 'false'
 
-            allow_unencrypted_appfirewall_payloads_enabled = double(
+            allow_payloads_enabled = double(
               'no_data_ex',
               :read => {
                 :version => 1,
                 :applications => [
                   :app_id => 'app_id',
                   :api_key => 'api_key',
-                  :allow_unencrypted_appsensor_payloads => true,
-                  :allow_unencrypted_appfirewall_payloads => true,
                   :allow_payloads => true
                 ]
               }.to_json
@@ -350,12 +216,10 @@ module TCellAgent
             ).and_return(true)
             expect(File).to receive(:open).with(
               File.join(Dir.getwd, 'config/tcell_agent.config')
-            ).and_return(allow_unencrypted_appfirewall_payloads_enabled)
+            ).and_return(allow_payloads_enabled)
 
             configuration = Configuration.new
 
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPSENSOR_PAYLOADS'] = old_allow_unencrypted_appsensor_payloads
-            ENV['TCELL_AGENT_ALLOW_UNENCRYPTED_APPFIREWALL_PAYLOADS'] = old_allow_unencrypted_appfirewall_payloads
             ENV['TCELL_AGENT_ALLOW_PAYLOADS'] = old_tcell_agent_allow_payloads
 
             expect(configuration.allow_payloads).to eq(false)

data/spec/lib/tcell_agent/hooks/login_fraud_spec.rb

@@ -26,56 +26,30 @@ module TCellAgent
 
   describe 'manually requiring auth hooks' do
     before(:all) do
-      require 'tcell_agent/hooks/login_fraud'
+      load 'lib/tcell_agent/hooks/login_fraud.rb'
+      load 'spec/support/force_logger_mocking.rb'
     end
 
     describe 'Using generic interface' do
       context 'with a login failure' do
         context 'with login_failed_enabled set to true' do
           it 'should report the login failure' do
-            login_fraud = double('login_fraud', :enabled => true, :login_failed_enabled => true)
-
-            expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
-              login_fraud
-            )
-            expect(TCellAgent).to receive(:send_event).with(
-              {
-                'event_type' => 'login',
-                'header_keys' => %w[USER_AGENT X_FORWARDED_FOR],
-                'user_agent' => 'user_agent',
-                'referrer' => 'http://tcell.tcell.io/?utm_campaign=',
-                'remote_addr' => '1.1.1.1',
-                'user_id' => 'user_id',
-                'document_uri' => 'http://tcell.tcell.io/login?param_name=',
-                'session' => '48c0ce7961d8d5d4bd57bd77976b3d38',
-                'event_name' => 'login-failure'
-              }
-            )
-
+            login_fraud = double('login_fraud', :login_failed_enabled => true)
             status = Hooks::V1::Login::LOGIN_FAILURE
             header_keys = %w[HTTP_USER_AGENT HTTP_X_FORWARDED_FOR]
             document_uri = 'http://tcell.tcell.io/login?param_name=param_value'
             referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
 
-            Hooks::V1::Login.register_login_event(
-              status, 'session_id', 'user_agent', referrer, '1.1.1.1', header_keys, 'user_id', document_uri
-            )
-          end
-        end
-
-        context 'with login_failed_enabled set to false' do
-          it 'should NOT report the login failure' do
-            login_fraud = double('login_fraud', :enabled => true, :login_failed_enabled => false)
-
-            expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
-              login_fraud
+            expect(TCellAgent).to receive(:policy).with(
+              TCellAgent::PolicyTypes::LOGINFRAUD
+            ).and_return(login_fraud)
+            expect(login_fraud).to receive(:report_login_failure).with(
+              'user_id',
+              nil,
+              header_keys,
+              nil,
+              anything
             )
-            expect(TCellAgent).to_not receive(:send_event)
-
-            status = Hooks::V1::Login::LOGIN_FAILURE
-            header_keys = %w[HTTP_USER_AGENT HTTP_X_FORWARDED_FOR]
-            document_uri = 'http://tcell.tcell.io/login?param_name=param_value'
-            referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
 
             Hooks::V1::Login.register_login_event(
               status, 'session_id', 'user_agent', referrer, '1.1.1.1', header_keys, 'user_id', document_uri
@@ -87,49 +61,20 @@ module TCellAgent
       context 'with a login success' do
         context 'with login_success_enabled set to true' do
           it 'should report the login success' do
-            login_fraud = double('login_fraud', :enabled => true, :login_success_enabled => true)
-
-            expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
-              login_fraud
-            )
-            expect(TCellAgent).to receive(:send_event).with(
-              {
-                'event_type' => 'login',
-                'header_keys' => %w[USER_AGENT X_FORWARDED_FOR],
-                'user_agent' => 'user_agent',
-                'referrer' => 'http://tcell.tcell.io/?utm_campaign=',
-                'remote_addr' => '1.1.1.1',
-                'user_id' => 'user_id',
-                'document_uri' => 'http://tcell.tcell.io/login?param_name=',
-                'session' => '48c0ce7961d8d5d4bd57bd77976b3d38',
-                'event_name' => 'login-success'
-              }
-            )
-
+            login_fraud = double('login_fraud', :login_success_enabled => true)
             status = Hooks::V1::Login::LOGIN_SUCCESS
             header_keys = %w[HTTP_USER_AGENT HTTP_X_FORWARDED_FOR]
             document_uri = 'http://tcell.tcell.io/login?param_name=param_value'
             referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
 
-            Hooks::V1::Login.register_login_event(
-              status, 'session_id', 'user_agent', referrer, '1.1.1.1', header_keys, 'user_id', document_uri
-            )
-          end
-        end
-
-        context 'with login_success_enabled set to false' do
-          it 'should NOT report the login success' do
-            login_fraud = double('login_fraud', :enabled => true, :login_success_enabled => false)
-
             expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
               login_fraud
             )
-            expect(TCellAgent).to_not receive(:send_event)
-
-            status = Hooks::V1::Login::LOGIN_SUCCESS
-            header_keys = %w[HTTP_USER_AGENT HTTP_X_FORWARDED_FOR]
-            document_uri = 'http://tcell.tcell.io/login?param_name=param_value'
-            referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
+            expect(login_fraud).to receive(:report_login_success).with(
+              'user_id',
+              header_keys,
+              anything
+            )
 
             Hooks::V1::Login.register_login_event(
               status, 'session_id', 'user_agent', referrer, '1.1.1.1', header_keys, 'user_id', document_uri
@@ -140,15 +85,17 @@ module TCellAgent
 
       context 'with an unknown status' do
         it 'should log the error' do
-          login_fraud = double('login_fraud', :enabled => true)
+          login_fraud = double('login_fraud')
           logger = double('logger')
 
-          expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
-            login_fraud
-          )
+          expect(TCellAgent).to receive(:policy).with(
+            TCellAgent::PolicyTypes::LOGINFRAUD
+          ).and_return(login_fraud)
           expect(TCellAgent).to_not receive(:send_event)
-          expect(TCellAgent).to receive(:logger).and_return(logger)
-          expect(logger).to receive(:error).with('Unkown login status: mumbo-jumbo')
+          expect(TCellAgent::Hooks::LoginFraud).to receive(:get_logger).and_return(logger)
+          expect(logger).to receive(:error).with(
+            'Unkown login status: mumbo-jumbo'
+          )
 
           status = 'mumbo-jumbo'
           header_keys = %w[HTTP_USER_AGENT HTTP_X_FORWARDED_FOR]
@@ -166,12 +113,12 @@ module TCellAgent
       context 'with a login failure' do
         context 'with login_failed_enabled set to true' do
           it 'should report the login failure' do
-            login_fraud = double('login_fraud', :enabled => true, :login_failed_enabled => true)
+            login_fraud = double('login_fraud', :login_failed_enabled => true)
             rails_request = double('rails_request')
             tcell_data = TCellAgent::Instrumentation::TCellData.new
             tcell_data.user_agent = 'user_agent'
             tcell_data.referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
-            tcell_data.ip_address = '1.1.1.1'
+            tcell_data.remote_address = '1.1.1.1'
             tcell_data.path = 'http://tcell.tcell.io/login?param_name=param_value'
             tcell_data.hmac_session_id = TCellAgent::SensorEvents::Util.hmac('session_id')
             request_env = {
@@ -185,18 +132,12 @@ module TCellAgent
             )
             expect(rails_request).to receive(:env).and_return(request_env)
             expect(rails_request).to receive(:env).and_return(request_env)
-            expect(TCellAgent).to receive(:send_event).with(
-              {
-                'event_type' => 'login',
-                'header_keys' => %w[USER_AGENT X_FORWARDED_FOR],
-                'user_agent' => 'user_agent',
-                'referrer' => 'http://tcell.tcell.io/?utm_campaign=',
-                'remote_addr' => '1.1.1.1',
-                'user_id' => 'user_id',
-                'document_uri' => 'http://tcell.tcell.io/login?param_name=',
-                'session' => '48c0ce7961d8d5d4bd57bd77976b3d38',
-                'event_name' => 'login-failure'
-              }
+            expect(login_fraud).to receive(:report_login_failure).with(
+              'user_id',
+              nil,
+              request_env,
+              nil,
+              anything
             )
 
             status = Hooks::V1::Login::LOGIN_FAILURE
@@ -206,48 +147,17 @@ module TCellAgent
             )
           end
         end
-
-        context 'with login_failed_enabled set to false' do
-          it 'should NOT report the login failure' do
-            login_fraud = double('login_fraud', :enabled => true, :login_failed_enabled => false)
-            rails_request = double('rails_request')
-            tcell_data = TCellAgent::Instrumentation::TCellData.new
-            tcell_data.user_agent = 'user_agent'
-            tcell_data.referrer = 'http://tcell.tcell.io/?utm_campaign='
-            tcell_data.ip_address = '1.1.1.1'
-            tcell_data.path = 'http://tcell.tcell.io/login?param_name=param_value'
-            tcell_data.hmac_session_id = TCellAgent::SensorEvents::Util.hmac('session_id')
-            request_env = {
-              TCellAgent::Instrumentation::TCELL_ID => tcell_data,
-              'HTTP_USER_AGENT' => true,
-              'HTTP_X_FORWARDED_FOR' => true
-            }
-
-            expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
-              login_fraud
-            )
-            expect(rails_request).to receive(:env).and_return(request_env)
-            expect(rails_request).to receive(:env).and_return(request_env)
-            expect(TCellAgent).to_not receive(:send_event)
-
-            status = Hooks::V1::Login::LOGIN_FAILURE
-
-            Hooks::V1::Frameworks::Rails::Login.register_login_event(
-              status, rails_request, 'user_id'
-            )
-          end
-        end
       end
 
       context 'with a login success' do
         context 'with login_success_enabled set to true' do
           it 'should report the login success' do
-            login_fraud = double('login_fraud', :enabled => true, :login_success_enabled => true)
+            login_fraud = double('login_fraud', :login_success_enabled => true)
             rails_request = double('rails_request')
             tcell_data = TCellAgent::Instrumentation::TCellData.new
             tcell_data.user_agent = 'user_agent'
             tcell_data.referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
-            tcell_data.ip_address = '1.1.1.1'
+            tcell_data.remote_address = '1.1.1.1'
             tcell_data.path = 'http://tcell.tcell.io/login?param_name=param_value'
             tcell_data.hmac_session_id = TCellAgent::SensorEvents::Util.hmac('session_id')
             request_env = {
@@ -261,18 +171,10 @@ module TCellAgent
             )
             expect(rails_request).to receive(:env).and_return(request_env)
             expect(rails_request).to receive(:env).and_return(request_env)
-            expect(TCellAgent).to receive(:send_event).with(
-              {
-                'event_type' => 'login',
-                'header_keys' => %w[USER_AGENT X_FORWARDED_FOR],
-                'user_agent' => 'user_agent',
-                'referrer' => 'http://tcell.tcell.io/?utm_campaign=',
-                'remote_addr' => '1.1.1.1',
-                'user_id' => 'user_id',
-                'document_uri' => 'http://tcell.tcell.io/login?param_name=',
-                'session' => '48c0ce7961d8d5d4bd57bd77976b3d38',
-                'event_name' => 'login-success'
-              }
+            expect(login_fraud).to receive(:report_login_success).with(
+              'user_id',
+              request_env,
+              anything
             )
 
             status = Hooks::V1::Login::LOGIN_SUCCESS
@@ -282,48 +184,17 @@ module TCellAgent
             )
           end
         end
-
-        context 'with login_success_enabled set to false' do
-          it 'should NOT report the login success' do
-            login_fraud = double('login_fraud', :enabled => true, :login_success_enabled => false)
-            rails_request = double('rails_request')
-            tcell_data = TCellAgent::Instrumentation::TCellData.new
-            tcell_data.user_agent = 'user_agent'
-            tcell_data.referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
-            tcell_data.ip_address = '1.1.1.1'
-            tcell_data.path = 'http://tcell.tcell.io/login?param_name=param_value'
-            tcell_data.hmac_session_id = TCellAgent::SensorEvents::Util.hmac('session_id')
-            request_env = {
-              TCellAgent::Instrumentation::TCELL_ID => tcell_data,
-              'HTTP_USER_AGENT' => true,
-              'HTTP_X_FORWARDED_FOR' => true
-            }
-
-            expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::LOGINFRAUD).and_return(
-              login_fraud
-            )
-            expect(rails_request).to receive(:env).and_return(request_env)
-            expect(rails_request).to receive(:env).and_return(request_env)
-            expect(TCellAgent).to_not receive(:send_event)
-
-            status = Hooks::V1::Login::LOGIN_SUCCESS
-
-            Hooks::V1::Frameworks::Rails::Login.register_login_event(
-              status, rails_request, 'user_id'
-            )
-          end
-        end
       end
 
       context 'with an unknown status' do
         it 'should log the error' do
-          login_fraud = double('login_fraud', :enabled => true, :login_failed_enabled => true)
+          login_fraud = double('login_fraud', :login_failed_enabled => true)
           logger = double('logger')
           rails_request = double('rails_request')
           tcell_data = TCellAgent::Instrumentation::TCellData.new
           tcell_data.user_agent = 'user_agent'
           tcell_data.referrer = 'http://tcell.tcell.io/?utm_campaign=some-source'
-          tcell_data.ip_address = '1.1.1.1'
+          tcell_data.remote_address = '1.1.1.1'
           tcell_data.path = 'http://tcell.tcell.io/login?param_name=param_value'
           tcell_data.hmac_session_id = TCellAgent::SensorEvents::Util.hmac('session_id')
           request_env = {
@@ -338,8 +209,10 @@ module TCellAgent
           expect(rails_request).to receive(:env).and_return(request_env)
           expect(rails_request).to receive(:env).and_return(request_env)
           expect(TCellAgent).to_not receive(:send_event)
-          expect(TCellAgent).to receive(:logger).and_return(logger)
-          expect(logger).to receive(:error).with('Unkown login status: mumbo-jumbo')
+          expect(TCellAgent::Hooks::LoginFraud).to receive(:get_logger).and_return(logger)
+          expect(logger).to receive(:error).with(
+            'Unkown login status: mumbo-jumbo'
+          )
 
           status = 'mumbo-jumbo'