tbd 3.1.1 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be8e76fa83e37a27c674adaeddee2cbf022d8b9e543f75e46ab62b4f1d2087c1
-  data.tar.gz: 6699f65f798c2e615660c6e65f6df926a4baa9af0cb1f040fc2075b10100a4dc
+  metadata.gz: 7a5a9002ff406325bc226c157ed29ffc22ccb60ac46b9c6bf29358f04aa9d6a3
+  data.tar.gz: 60b0a52d46be3a91a2119cb5d3875826e7b278ca9ce78a230e9575263dbb4c89
 SHA512:
-  metadata.gz: cc594dc6093c99f18aa9b30e17c7efb10a011118d7dd4996c9798dabe9c9f84f2a47ca5250f0dfbc45467cfdf8f545bb08f4473b8ebdbbeb2ff197ff475fea45
-  data.tar.gz: '099e13541b55a471309ba59dd212114ecb0e55839cb59b6b05bc971f0a5c4aa42e74f5bdd27dc7f61b5512f379cc0245be9038a23e3fb766a19a14349243a252'
+  metadata.gz: df24c1565b802fd84c8f067d78662adf23d5fb2059145b6b22da98b8c06f70b49283ef7f28613e91c1258e3c7b865d17e81df93c2340aec431483597d8ddb847
+  data.tar.gz: 34ea2406564f08b36a54987ab08fd5d2cb24e49bfb02640169278f1138f65f36ac2c9279abb7e8be83e1c2aec4cca639b8735ab13f54f0470fe0a8470977be86

data/.github/workflows/pull_request.yml

@@ -70,3 +70,19 @@ jobs:
         docker exec -t test bundle update
         docker exec -t test bundle exec rake
         docker kill test
+  test_351x:
+    runs-on: ubuntu-22.04
+    steps:
+    - name: Check out repository
+      uses: actions/checkout@v2
+    - name: Run Tests
+      run: |
+        echo $(pwd)
+        echo $(ls)
+        docker pull nrel/openstudio:3.5.1
+        docker run --name test --rm -d -t -v $(pwd):/work -w /work nrel/openstudio:3.5.1
+        docker exec -t test pwd
+        docker exec -t test ls
+        docker exec -t test bundle update
+        docker exec -t test bundle exec rake
+        docker kill test

data/LICENSE.md

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020-2022 Denis Bourgeois & Dan Macumber
+Copyright (c) 2020-2023 Denis Bourgeois & Dan Macumber
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -32,9 +32,7 @@ TBD is systematically tested against updated OpenStudio versions (since v3.0.0).
 
 ### Windows Installation
 
-Install Ruby using the [RubyInstaller](https://rubyinstaller.org/downloads/archives/) for [Ruby 2.7.2 (x64)](https://github.com/oneclick/rubyinstaller2/releases/tag/RubyInstaller-2.7.2-1/rubyinstaller-2.7.2-1-x64.exe).
-
-From the command line, check that the ruby installation returns the correct Ruby version:
+Either install Ruby using the [RubyInstaller](https://rubyinstaller.org/downloads/archives/) for [Ruby 2.7.2 (x64)](https://github.com/oneclick/rubyinstaller2/releases/tag/RubyInstaller-2.7.2-1/rubyinstaller-2.7.2-1-x64.exe), or preferably under [WSL2](https://gist.github.com/brgix/0d968d8f32c41f13300dc6769414df79). Run the following steps if going down the _RubyInstaller_ route. From the command line, check that the ruby installation returns the correct Ruby version:
 ```
 ruby -v
 ```
@@ -57,9 +55,6 @@ Verify your OpenStudio and Ruby configuration:
 ruby -e "require 'openstudio'" -e "puts OpenStudio::Model::Model.new"
 ```
 
-`git clone` the TBD repo, then run basic tests to ensure the measure operates properly (see end of this README).
-
-
 ### MacOS Installation
 
 MacOS already comes with Ruby, but likely not the right Ruby version for the desired OpenStudio measure development [environment](https://github.com/NREL/OpenStudio/wiki/OpenStudio-SDK-Version-Compatibility-Matrix). Instructions here show how to install Ruby v2.7.2 alongside MacOS's own Ruby version. Although no longer officially supported, instructions for an OpenStudio v2.9.1 setup is described [here](https://github.com/rd2/tbd/blob/master/v291_MacOS.md).
@@ -117,8 +112,9 @@ cd ~/Documents/sandbox340
 ruby -e "require 'openstudio'" -e "puts OpenStudio::Model::Model.new"
 ```
 
-Install the latest version of _git_ (e.g. through Homebrew), then ```git clone``` the TBD repo, e.g. under "sandbox340". Run the basic tests below to ensure the measure operates as expected.
+## Clone TBD
 
+Once done with either the Windows or MacOS setup, install the latest version of _git_ (e.g. through Homebrew), then ```git clone``` the TBD repo, e.g. under "sandbox340". Run the basic tests below to ensure the measure operates as expected.
 
 ## Complete list of test commands
 

data/Rakefile

@@ -2,28 +2,29 @@ require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec) do |t|
-    t.rspec_opts = '--exclude-pattern \'spec/**/*suite_spec.rb\''
+  t.rspec_opts = "--exclude-pattern \'spec/**/*suite_spec.rb\'"
 end
 
 task default: :spec
 
 desc "Update Library Files"
 task :libraries do
-  puts "Updating Library Files"
+  # puts "Updating Library Files"
 
   require "fileutils"
 
   libs  = ["topolys", "osut", "oslg", "tbd"]
   files = {}
-
+  
   $:.each do |path|
     libs.each do |l|
       next unless path.include?(l)
+
       files[l] = Dir.glob(File.join(path, "#{l}/*.rb"))
       files[l].delete_if { |f| f.include?("version.rb") }  unless l == "topolys"
-      puts "#{l} lib files:"
-      files[l].each { |lf| puts "... #{lf}" }
-      puts
+      # puts "#{l} lib files:"
+      # files[l].each { |lf| puts "... #{lf}" }
+      # puts
     end
   end
 
@@ -38,7 +39,7 @@ end
 
 desc "Update Measure"
 task measure: [:libraries] do
-  puts "Updating Measure"
+  # puts "Updating Measure"
 
   require "openstudio"
   require "open3"

data/lib/measures/tbd/LICENSE.md

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020-2022 Denis Bourgeois & Dan Macumber
+Copyright (c) 2020-2023 Denis Bourgeois & Dan Macumber
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/lib/measures/tbd/README.md

@@ -27,6 +27,14 @@ For EnergyPlus simulations, leave CHECKED. For iterative exploration with Apply
 **Required:** false,
 **Model Dependent:** false
 
+### Proximity tolerance (m)
+Proximity tolerance (e.g. 0.100 m) between subsurface edges, e.g. between near-adjacent window jambs.
+**Name:** sub_tol,
+**Type:** Double,
+**Units:** ,
+**Required:** false,
+**Model Dependent:** false
+
 ### Load 'tbd.json'
 Loads existing 'tbd.json' file (under '/files'), may override 'default thermal bridge' set.
 **Name:** load_tbd_json,

data/lib/measures/tbd/measure.rb

@@ -1,6 +1,6 @@
 # MIT License
 #
-# Copyright (c) 2020-2022 Denis Bourgeois & Dan Macumber
+# Copyright (c) 2020-2023 Denis Bourgeois & Dan Macumber
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -48,6 +48,15 @@ class TBDMeasure < OpenStudio::Measure::ModelMeasure
     alter.setDefaultValue(true)
     args << alter
 
+    arg = "sub_tol"
+    dsc = "Proximity tolerance (e.g. 0.100 m) between subsurface edges, e.g. " \
+          "between near-adjacent window jambs."
+    sub_tol = OpenStudio::Measure::OSArgument.makeDoubleArgument(arg, false)
+    sub_tol.setDisplayName("Proximity tolerance (m)")
+    sub_tol.setDescription(dsc)
+    sub_tol.setDefaultValue(TBD::TOL)
+    args << sub_tol
+
     arg = "load_tbd_json"
     dsc = "Loads existing 'tbd.json' file (under '/files'), may override "     \
           "'default thermal bridge' set."
@@ -225,6 +234,7 @@ class TBDMeasure < OpenStudio::Measure::ModelMeasure
 
     argh                 = {}
     argh[:alter        ] = runner.getBoolArgumentValue("alter_model",      args)
+    argh[:sub_tol      ] = runner.getDoubleArgumentValue("sub_tol",        args)
     argh[:load_tbd     ] = runner.getBoolArgumentValue("load_tbd_json",    args)
     argh[:option       ] = runner.getStringArgumentValue("option",         args)
     argh[:write_tbd    ] = runner.getBoolArgumentValue("write_tbd_json",   args)
@@ -286,6 +296,38 @@ class TBDMeasure < OpenStudio::Measure::ModelMeasure
       end
     end
 
+    # Pre-validate ground-facing constructions for KIVA.
+    if argh[:kiva_force] || argh[:gen_kiva]
+      kva = true
+
+      mdl.getSurfaces.each do |s|
+        id = s.nameString
+        construction = s.construction
+        next unless s.isGroundSurface
+
+        if construction.empty?
+          runner.registerError("Invalid construction for KIVA (#{id})")
+          kva = false if kva
+        else
+          construction = construction.get.to_LayeredConstruction
+
+          if construction.empty?
+            runner.registerError("KIVA requires layered constructions (#{id})")
+            kva = false if kva
+          else
+            construction = construction.get
+
+            unless TBD.standardOpaqueLayers?(construction)
+              runner.registerError("KIVA requires standard materials (#{id})")
+              kva = false if kva
+            end
+          end
+        end
+      end
+
+      return false unless kva
+    end
+
     # Process all ground-facing surfaces as foundation-facing.
     if argh[:kiva_force]
       argh[:gen_kiva] = true
@@ -313,7 +355,7 @@ class TBDMeasure < OpenStudio::Measure::ModelMeasure
 
     argh[:version ]  = model.getVersion.versionIdentifier
     tbd              = TBD.process(model, argh)
-    argh[:io      ]  = tbd[:io]
+    argh[:io      ]  = tbd[:io      ]
     argh[:surfaces]  = tbd[:surfaces]
     setpoints        = TBD.heatingTemperatureSetpoints?(model)
     setpoints        = TBD.coolingTemperatureSetpoints?(model) || setpoints

data/lib/measures/tbd/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>tbd_measure</name>
   <uid>8890787b-8c25-4dc8-8641-b6be1b6c2357</uid>
-  <version_id>59363fb9-ebff-4985-834a-911020830cf1</version_id>
-  <version_modified>20221213T122330Z</version_modified>
+  <version_id>2fc42e1d-2010-44ae-9837-6390512c41d4</version_id>
+  <version_modified>20230214T105829Z</version_modified>
   <xml_checksum>99772807</xml_checksum>
   <class_name>TBDMeasure</class_name>
   <display_name>Thermal Bridging and Derating - TBD</display_name>
@@ -30,6 +30,15 @@
         </choice>
       </choices>
     </argument>
+    <argument>
+      <name>sub_tol</name>
+      <display_name>Proximity tolerance (m)</display_name>
+      <description>Proximity tolerance (e.g. 0.100 m) between subsurface edges, e.g. between near-adjacent window jambs.</description>
+      <type>Double</type>
+      <required>false</required>
+      <model_dependent>false</model_dependent>
+      <default_value>0.01</default_value>
+    </argument>
     <argument>
       <name>load_tbd_json</name>
       <display_name>Load 'tbd.json'</display_name>
@@ -373,12 +382,6 @@
       <usage_type>doc</usage_type>
       <checksum>32D70693</checksum>
     </file>
-    <file>
-      <filename>LICENSE.md</filename>
-      <filetype>md</filetype>
-      <usage_type>license</usage_type>
-      <checksum>CB393A2B</checksum>
-    </file>
     <file>
       <filename>geometry.rb</filename>
       <filetype>rb</filetype>
@@ -386,34 +389,28 @@
       <checksum>D80E9AE6</checksum>
     </file>
     <file>
-      <filename>model.rb</filename>
-      <filetype>rb</filetype>
-      <usage_type>resource</usage_type>
-      <checksum>57ED37BF</checksum>
-    </file>
-    <file>
-      <filename>version.rb</filename>
-      <filetype>rb</filetype>
-      <usage_type>resource</usage_type>
-      <checksum>05CC939E</checksum>
+      <filename>LICENSE.md</filename>
+      <filetype>md</filetype>
+      <usage_type>license</usage_type>
+      <checksum>A91E64A0</checksum>
     </file>
     <file>
       <filename>oslog.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>6F3C0E99</checksum>
+      <checksum>E97617E3</checksum>
     </file>
     <file>
       <filename>tbd.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>3776D81D</checksum>
+      <checksum>A4E8433C</checksum>
     </file>
     <file>
       <filename>utils.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>54F57409</checksum>
+      <checksum>283C976C</checksum>
     </file>
     <file>
       <version>
@@ -424,37 +421,49 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>3EE587D6</checksum>
+      <checksum>44B11139</checksum>
     </file>
     <file>
       <filename>tbd_tests.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>6ED9AF88</checksum>
+      <checksum>58ED6635</checksum>
+    </file>
+    <file>
+      <filename>geo.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>resource</usage_type>
+      <checksum>F447D8CE</checksum>
     </file>
     <file>
       <filename>README.md</filename>
       <filetype>md</filetype>
       <usage_type>readme</usage_type>
-      <checksum>36FA11E3</checksum>
+      <checksum>B836C43A</checksum>
     </file>
     <file>
-      <filename>geo.rb</filename>
+      <filename>ua.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>D999D942</checksum>
+      <checksum>19193778</checksum>
     </file>
     <file>
       <filename>psi.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>4C4C35F9</checksum>
+      <checksum>1045EF38</checksum>
     </file>
     <file>
-      <filename>ua.rb</filename>
+      <filename>model.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>resource</usage_type>
+      <checksum>8E9A76C7</checksum>
+    </file>
+    <file>
+      <filename>version.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>3438C6A8</checksum>
+      <checksum>A3BB982A</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/tbd/resources/geo.rb

@@ -1,6 +1,6 @@
 # MIT License
 #
-# Copyright (c) 2020-2022 Denis Bourgeois & Dan Macumber
+# Copyright (c) 2020-2023 Denis Bourgeois & Dan Macumber
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -22,24 +22,27 @@
 
 module TBD
   ##
-  # Check for matching Topolys vertex pairs between edges (within TOL).
+  # Check for matching Topolys vertex pairs between edges.
   #
   # @param e1 [Hash] first edge
   # @param e2 [Hash] second edge
+  # @param tol [Float] user-set tolerance (> TOL) in m
   #
   # @return [Bool] true if edges share vertex pairs
   # @return [Bool] false if invalid input
-  def matches?(e1 = {}, e2 = {})
+  def matches?(e1 = {}, e2 = {}, tol = TOL)
     mth = "TBD::#{__callee__}"
     cl  = Topolys::Point3D
     a   = false
 
     return mismatch("e1", e1, Hash, mth, DBG, a)        unless e1.is_a?(Hash)
     return mismatch("e2", e2, Hash, mth, DBG, a)        unless e2.is_a?(Hash)
+
     return hashkey("e1", e1, :v0, mth, DBG, a)          unless e1.key?(:v0)
     return hashkey("e1", e1, :v1, mth, DBG, a)          unless e1.key?(:v1)
     return hashkey("e2", e2, :v0, mth, DBG, a)          unless e2.key?(:v0)
     return hashkey("e2", e2, :v1, mth, DBG, a)          unless e2.key?(:v1)
+
     return mismatch("e1 :v0", e1[:v0], cl, mth, DBG, a) unless e1[:v0].is_a?(cl)
     return mismatch("e1 :v1", e1[:v1], cl, mth, DBG, a) unless e1[:v1].is_a?(cl)
     return mismatch("e2 :v0", e2[:v0], cl, mth, DBG, a) unless e2[:v0].is_a?(cl)
@@ -51,26 +54,29 @@ module TBD
     return zero("e1", mth, DBG, a) if e1_vector.magnitude < TOL
     return zero("e2", mth, DBG, a) if e2_vector.magnitude < TOL
 
+    return mismatch("e1", e1, Hash, mth, DBG, a)       unless tol.is_a?(Numeric)
+    return zero("tol", mth, DBG, a)                        if tol < TOL
+
     return true if
     (
       (
-        ( (e1[:v0].x - e2[:v0].x).abs < TOL &&
-          (e1[:v0].y - e2[:v0].y).abs < TOL &&
-          (e1[:v0].z - e2[:v0].z).abs < TOL
+        ( (e1[:v0].x - e2[:v0].x).abs < tol &&
+          (e1[:v0].y - e2[:v0].y).abs < tol &&
+          (e1[:v0].z - e2[:v0].z).abs < tol
         ) ||
-        ( (e1[:v0].x - e2[:v1].x).abs < TOL &&
-          (e1[:v0].y - e2[:v1].y).abs < TOL &&
-          (e1[:v0].z - e2[:v1].z).abs < TOL
+        ( (e1[:v0].x - e2[:v1].x).abs < tol &&
+          (e1[:v0].y - e2[:v1].y).abs < tol &&
+          (e1[:v0].z - e2[:v1].z).abs < tol
         )
       ) &&
       (
-        ( (e1[:v1].x - e2[:v0].x).abs < TOL &&
-          (e1[:v1].y - e2[:v0].y).abs < TOL &&
-          (e1[:v1].z - e2[:v0].z).abs < TOL
+        ( (e1[:v1].x - e2[:v0].x).abs < tol &&
+          (e1[:v1].y - e2[:v0].y).abs < tol &&
+          (e1[:v1].z - e2[:v0].z).abs < tol
         ) ||
-        ( (e1[:v1].x - e2[:v1].x).abs < TOL &&
-          (e1[:v1].y - e2[:v1].y).abs < TOL &&
-          (e1[:v1].z - e2[:v1].z).abs < TOL
+        ( (e1[:v1].x - e2[:v1].x).abs < tol &&
+          (e1[:v1].y - e2[:v1].y).abs < tol &&
+          (e1[:v1].z - e2[:v1].z).abs < tol
         )
       )
     )
@@ -354,6 +360,7 @@ module TBD
       next                                                          unless valid
       vec      = s.vertices
       area     = s.grossArea
+      mult     = s.multiplier
       typ      = s.subSurfaceType.downcase
       type     = :skylight
       type     = :window       if typ.include?("window" )
@@ -442,6 +449,7 @@ module TBD
               n:        n,
               gross:    s.grossArea,
               area:     area,
+              mult:     mult,
               type:     type,
               u:        u,
               unhinged: unhinged }
@@ -478,7 +486,9 @@ module TBD
     end
 
     subarea = 0
-    subs.values.each { |sub| subarea += sub[:area] }
+
+    subs.values.each { |sub| subarea += sub[:area] * sub[:mult] }
+
     surf[:net] = surf[:gross] - subarea
 
     # Tranform final Point 3D sets, and store.
@@ -604,6 +614,36 @@ module TBD
     return mismatch("floors", floors, cl2, mth, DBG, a) unless floors.is_a?(cl2)
     return mismatch("edges", edges, cl2, mth, DBG, a)   unless edges.is_a?(cl2)
 
+    kva = true
+
+    # Pre-validate foundation-facing constructions.
+    model.getSurfaces.each do |s|
+      id = s.nameString
+      construction = s.construction
+      next unless s.outsideBoundaryCondition.downcase == "foundation"
+
+      if construction.empty?
+        log(ERR, "Invalid construction for KIVA (see #{id})")
+        kva = false if kva
+      else
+        construction = construction.get.to_LayeredConstruction
+
+        if construction.empty?
+          log(ERR, "KIVA requires layered constructions (see #{id})")
+          kva = false if kva
+        else
+          construction = construction.get
+
+          unless standardOpaqueLayers?(construction)
+            log(ERR, "KIVA requires standard materials (see #{id})")
+            kva = false if kva
+          end
+        end
+      end
+    end
+
+    return a unless kva
+
     # Strictly relying on Kiva's total exposed perimeter approach.
     arg = "TotalExposedPerimeter"
     kiva = true

data/lib/measures/tbd/resources/model.rb

@@ -1,9 +1,3 @@
-begin
-  require "topolys/version"
-rescue LoadError
-  require File.join(File.dirname(__FILE__), 'version.rb')
-end
-
 require 'json'
 require 'securerandom'
 require 'set'

data/lib/measures/tbd/resources/oslog.rb

@@ -1,6 +1,6 @@
 # BSD 3-Clause License
 #
-# Copyright (c) 2022, Denis Bourgeois
+# Copyright (c) 2022-2023, Denis Bourgeois
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -127,6 +127,7 @@ module OSlg
   # @return [String] "DEBUG", "INFO", "WARN", "ERROR" or "FATAL"
   def tag(level)
     return @@tag[level] if level >= DEBUG && level <= FATAL
+
     ""
   end
 
@@ -138,6 +139,7 @@ module OSlg
   # @return [String] preset OSlg message
   def msg(status)
     return @@msg[status] if status >= DEBUG && status <= FATAL
+
     ""
   end
 
@@ -163,6 +165,7 @@ module OSlg
       @@logs << {level: level, message: message}
       @@status = level if level > @@status
     end
+
     @@status
   end
 
@@ -194,10 +197,11 @@ module OSlg
     mth = mth[0...60] + " ..." if mth.length > 60
     return res if mth.empty?
 
-    msg  = "Invalid '#{id}' "
+    msg = "Invalid '#{id}' "
     msg += "arg ##{ord} " if ord > 0
     msg += "(#{mth})"
     log(lvl, msg) if lvl >= DEBUG && lvl <= FATAL
+
     res
   end
 
@@ -232,6 +236,7 @@ module OSlg
 
     msg = "'#{id}' #{obj.class}? expecting #{cl} (#{mth})"
     log(lvl, msg) if lvl >= DEBUG && lvl <= FATAL
+
     res
   end
 
@@ -264,8 +269,9 @@ module OSlg
     mth = mth[0...60] + " ..." if mth.length > 60
     return res if mth.empty?
 
-    msg  = "Missing '#{key}' key in '#{id}' Hash (#{mth})"
+    msg = "Missing '#{key}' key in '#{id}' Hash (#{mth})"
     log(lvl, msg) if lvl >= DEBUG && lvl <= FATAL
+
     res
   end
 
@@ -294,8 +300,9 @@ module OSlg
     mth = mth[0...60] + " ..." if mth.length > 60
     return res if mth.empty?
 
-    msg  = "Empty '#{id}' (#{mth})"
+    msg = "Empty '#{id}' (#{mth})"
     log(lvl, msg) if lvl >= DEBUG && lvl <= FATAL
+
     res
   end
 
@@ -325,8 +332,9 @@ module OSlg
     mth = mth[0...60] + " ..." if mth.length > 60
     return res if mth.empty?
 
-    msg  = "Zero '#{id}' (#{mth})"
+    msg = "Zero '#{id}' (#{mth})"
     log(lvl, msg) if lvl >= DEBUG && lvl <= FATAL
+
     res
   end
 
@@ -355,9 +363,10 @@ module OSlg
 
     mth = mth[0...60] + " ..." if mth.length > 60
     return res if mth.empty?
-    
-    msg  = "Negative '#{id}' (#{mth})"
+
+    msg = "Negative '#{id}' (#{mth})"
     log(lvl, msg) if lvl >= DEBUG && lvl <= FATAL
+
     res
   end
 
@@ -368,6 +377,7 @@ module OSlg
   def clean!
     @@status = 0
     @@logs   = []
+
     @@level
   end